Grant Likely wrote:
>
> Hi Richard. Please do another spin of this patch. I don't have any
> particular problem with the changes, but it needs to be in a more
> granular form so I can review it properly.
I will post an update today.
In the future, if you are "quasi responsible for everything X
> Morton;
> dbrown...@users.sourceforge.net; John Linn
> Subject: Re: [spi-devel-general] [PATCH v4] xilinx_spi: Splitted into
> generic, of and platform
> driver, added support for DS570
>
> On Tue, Nov 10, 2009 at 9:19 AM, Richard Röjfors
> wrote:
> > Grant Likely wrote:
> >
Grant Likely wrote:
> Oops, I replied to the original version, but missed the subsequent
> versions. Looks like some of my comments still apply though.
> Overall, the patch changes too many things all at once. You should
> look at splitting it up. At the very least the io accessor changes
> shou
On Tue, Nov 10, 2009 at 9:19 AM, Richard Röjfors
wrote:
> Grant Likely wrote:
>> Oops, I replied to the original version, but missed the subsequent
>> versions. Looks like some of my comments still apply though.
>> Overall, the patch changes too many things all at once. You should
>> look at spl
t; Cc: spi-devel-gene...@lists.sourceforge.net; Andrew Morton;
> dbrown...@users.sourceforge.net; John
> Linn; linuxppc-...@ozlabs.org
> Subject: Re: [spi-devel-general] [PATCH v4] xilinx_spi: Splitted into
> generic, of and platform
> driver, added support for DS570
>
> Oops, I r
Oops, I replied to the original version, but missed the subsequent
versions. Looks like some of my comments still apply though.
Overall, the patch changes too many things all at once. You should
look at splitting it up. At the very least the io accessor changes
should be done in a separate patch
