Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-14 Thread Sachin Sant
> On 13-Mar-2020, at 5:05 PM, Vlastimil Babka wrote: > > On 3/13/20 12:12 PM, Srikar Dronamraju wrote: >> * Michael Ellerman [2020-03-13 21:48:06]: >> >>> Sachin Sant writes: > The patch below might work. Sachin can you test this? I tried faking up > a system with a memoryless node

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-13 Thread Vlastimil Babka
On 3/13/20 12:12 PM, Srikar Dronamraju wrote: > * Michael Ellerman [2020-03-13 21:48:06]: > >> Sachin Sant writes: >> >> The patch below might work. Sachin can you test this? I tried faking up >> >> a system with a memoryless node zero but couldn't get it to even start >> >> booting. >> >> >>

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-13 Thread Srikar Dronamraju
* Michael Ellerman [2020-03-13 21:48:06]: > Sachin Sant writes: > >> The patch below might work. Sachin can you test this? I tried faking up > >> a system with a memoryless node zero but couldn't get it to even start > >> booting. > >> > > The patch did not help. The kernel crashed during > >

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-13 Thread Michael Ellerman
Sachin Sant writes: >> The patch below might work. Sachin can you test this? I tried faking up >> a system with a memoryless node zero but couldn't get it to even start >> booting. >> > The patch did not help. The kernel crashed during > the boot with the same call trace. > > BUG_ON() introduced

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-12 Thread Sachin Sant
> The patch below might work. Sachin can you test this? I tried faking up > a system with a memoryless node zero but couldn't get it to even start > booting. > The patch did not help. The kernel crashed during the boot with the same call trace. BUG_ON() introduced with the patch was not

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-12 Thread Michael Ellerman
Michal Hocko writes: > On Thu 27-02-20 19:26:54, Michal Hocko wrote: >> [Cc ppc maintainers] > [...] >> Please have a look at >> http://lkml.kernel.org/r/52ef4673-7292-4c4c-b459-af583951b...@linux.vnet.ibm.com >> for the boot log with the debugging patch which tracks set_numa_mem. >> This seems

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-03-10 Thread Michal Hocko
On Thu 27-02-20 19:26:54, Michal Hocko wrote: > [Cc ppc maintainers] [...] > Please have a look at > http://lkml.kernel.org/r/52ef4673-7292-4c4c-b459-af583951b...@linux.vnet.ibm.com > for the boot log with the debugging patch which tracks set_numa_mem. > This seems to lead to a crash in the slab

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-27 Thread Michal Hocko
[Cc ppc maintainers] On Thu 27-02-20 17:16:41, Vlastimil Babka wrote: > On 2/27/20 5:00 PM, Sachin Sant wrote: > > > > > >> On 27-Feb-2020, at 5:42 PM, Michal Hocko wrote: > >> > >> A very good hint indeed. I would do this > >> diff --git a/include/linux/topology.h b/include/linux/topology.h >

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-27 Thread Vlastimil Babka
On 2/27/20 5:00 PM, Sachin Sant wrote: > > >> On 27-Feb-2020, at 5:42 PM, Michal Hocko wrote: >> >> A very good hint indeed. I would do this >> diff --git a/include/linux/topology.h b/include/linux/topology.h >> index eb2fe6edd73c..d9f1b6737e4d 100644 >> --- a/include/linux/topology.h >> +++

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-27 Thread Sachin Sant
> On 27-Feb-2020, at 5:42 PM, Michal Hocko wrote: > > A very good hint indeed. I would do this > diff --git a/include/linux/topology.h b/include/linux/topology.h > index eb2fe6edd73c..d9f1b6737e4d 100644 > --- a/include/linux/topology.h > +++ b/include/linux/topology.h > @@ -137,6 +137,8 @@

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-27 Thread Michal Hocko
On Wed 26-02-20 23:29:24, Vlastimil Babka wrote: > On 2/26/20 10:45 PM, Vlastimil Babka wrote: > > > > > > if (node == NUMA_NO_NODE) > > page = alloc_pages(flags, order); > > else > > page = __alloc_pages_node(node, flags, order); > > > > So yeah looks like SLUB's kmalloc_node() is

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-27 Thread Michal Hocko
On Wed 26-02-20 22:45:52, Vlastimil Babka wrote: > On 2/26/20 7:41 PM, Michal Hocko wrote: > > On Wed 26-02-20 18:25:28, Cristopher Lameter wrote: > >> On Mon, 24 Feb 2020, Michal Hocko wrote: > >> > >>> Hmm, nasty. Is there any reason why kmalloc_node behaves differently > >>> from the page

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Vlastimil Babka
On 2/26/20 10:45 PM, Vlastimil Babka wrote: > > > if (node == NUMA_NO_NODE) > page = alloc_pages(flags, order); > else > page = __alloc_pages_node(node, flags, order); > > So yeah looks like SLUB's kmalloc_node() is supposed to behave like the > page allocator's __alloc_pages_node() and

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Vlastimil Babka
On 2/26/20 7:41 PM, Michal Hocko wrote: > On Wed 26-02-20 18:25:28, Cristopher Lameter wrote: >> On Mon, 24 Feb 2020, Michal Hocko wrote: >> >>> Hmm, nasty. Is there any reason why kmalloc_node behaves differently >>> from the page allocator? >> >> The page allocator will do the same thing if you

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Michal Hocko
On Wed 26-02-20 12:31:56, David Rientjes wrote: > On Wed, 26 Feb 2020, Michal Hocko wrote: > > > On Wed 26-02-20 18:44:13, Cristopher Lameter wrote: > > > On Wed, 26 Feb 2020, Michal Hocko wrote: > > > > > > > Besides that kmalloc_node shouldn't really have an implicit GFP_THISNODE > > > >

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Michal Hocko
On Wed 26-02-20 18:44:13, Cristopher Lameter wrote: > On Wed, 26 Feb 2020, Michal Hocko wrote: > > > Besides that kmalloc_node shouldn't really have an implicit GFP_THISNODE > > semantic right? At least I do not see anything like that documented > > anywhere. > > Kmalloc_node does not support

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Christopher Lameter
On Wed, 26 Feb 2020, Michal Hocko wrote: > Besides that kmalloc_node shouldn't really have an implicit GFP_THISNODE > semantic right? At least I do not see anything like that documented > anywhere. Kmalloc_node does not support memory policies etc. Only kmalloc does. kmalloc_node is mostly used

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Michal Hocko
On Wed 26-02-20 18:25:28, Cristopher Lameter wrote: > On Mon, 24 Feb 2020, Michal Hocko wrote: > > > Hmm, nasty. Is there any reason why kmalloc_node behaves differently > > from the page allocator? > > The page allocator will do the same thing if you pass GFP_THISNODE and > insist on allocating

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-26 Thread Christopher Lameter
On Mon, 24 Feb 2020, Michal Hocko wrote: > Hmm, nasty. Is there any reason why kmalloc_node behaves differently > from the page allocator? The page allocator will do the same thing if you pass GFP_THISNODE and insist on allocating memory from a node that does not exist. > > > A short summary.

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-24 Thread Michal Hocko
On Sat 22-02-20 03:38:11, Cristopher Lameter wrote: > On Tue, 18 Feb 2020, Michal Hocko wrote: > > > Anyway, I do not think it is expected that kmalloc_node just blows up > > on those nodes. The page allocator simply falls back to the closest > > node. Something for kmalloc maintainers I believe.

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-21 Thread Christopher Lameter
On Tue, 18 Feb 2020, Michal Hocko wrote: > Anyway, I do not think it is expected that kmalloc_node just blows up > on those nodes. The page allocator simply falls back to the closest > node. Something for kmalloc maintainers I believe. That is the case for an unconstrained allocation.

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Michal Hocko
On Tue 18-02-20 20:41:12, Sachin Sant wrote: > > >> Yes, I can recreate the same problem with the patch applied on top of > >> 5.6.0-rc2. > > > > And just to make sure. This was with > > http://lkml.kernel.org/r/fff0e636-4c36-ed10-281c-8cdb0687c...@virtuozzo.com > > right? > > > Yes, the same

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Sachin Sant
>> Yes, I can recreate the same problem with the patch applied on top of >> 5.6.0-rc2. > > And just to make sure. This was with > http://lkml.kernel.org/r/fff0e636-4c36-ed10-281c-8cdb0687c...@virtuozzo.com > right? > Yes, the same patch. > If yes, is it possible that the specific node is

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Michal Hocko
On Tue 18-02-20 19:30:33, Sachin Sant wrote: > > > > On 18-Feb-2020, at 5:25 PM, Michal Hocko wrote: > > > > On Tue 18-02-20 17:10:47, Sachin Sant wrote: > >> > could you please test your boot with original patch from here: > > https://patchwork.kernel.org/patch/11360007/ >

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Michal Hocko
On Tue 18-02-20 17:10:47, Sachin Sant wrote: > > >> could you please test your boot with original patch from here: > >> > >> https://patchwork.kernel.org/patch/11360007/ > > > > After you tried the above patch instead of the problem patch, > > do one more test and apply the below on current

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Kirill Tkhai
On 18.02.2020 14:38, Sachin Sant wrote: > > >> On 18-Feb-2020, at 4:20 PM, Kirill Tkhai wrote: >> >> Hi, Sachin, >> >> On 18.02.2020 13:45, Sachin Sant wrote: >>> >>> commit a75056fc1e7c >>> mm/memcontrol.c: allocate shrinker_map on appropriate NUMA node >>> >>> I can boot the kernel

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Sachin Sant
>> could you please test your boot with original patch from here: >> >> https://patchwork.kernel.org/patch/11360007/ > > After you tried the above patch instead of the problem patch, > do one more test and apply the below on current linux-next. > Please, say which of the patches makes your

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Sachin Sant
> On 18-Feb-2020, at 4:20 PM, Kirill Tkhai wrote: > > Hi, Sachin, > > On 18.02.2020 13:45, Sachin Sant wrote: >> >> commit a75056fc1e7c >> mm/memcontrol.c: allocate shrinker_map on appropriate NUMA node >> >> I can boot the kernel successfully if the patch is reverted. > > > could you

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Kirill Tkhai
On 18.02.2020 14:01, Kirill Tkhai wrote: > On 18.02.2020 13:50, Kirill Tkhai wrote: >> Hi, Sachin, >> >> On 18.02.2020 13:45, Sachin Sant wrote: >>> Todays next fails to boot on a POWER9 PowerVM logical partition >>> with following trace: >>> >>> [8.767660] random: systemd: uninitialized

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Kirill Tkhai
Hi, Sachin, On 18.02.2020 13:45, Sachin Sant wrote: > Todays next fails to boot on a POWER9 PowerVM logical partition > with following trace: > > [8.767660] random: systemd: uninitialized urandom read (16 bytes read) > [8.768629] BUG: Kernel NULL pointer dereference on read at 0x73b0

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-18 Thread Kirill Tkhai
On 18.02.2020 13:50, Kirill Tkhai wrote: > Hi, Sachin, > > On 18.02.2020 13:45, Sachin Sant wrote: >> Todays next fails to boot on a POWER9 PowerVM logical partition >> with following trace: >> >> [8.767660] random: systemd: uninitialized urandom read (16 bytes read) >> [8.768629] BUG: