Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Michael Neuling
> > > 3: > > > /* Emulate H_SET_DABR/X on P8 for the sake of compat mode > > > guests */ > > > rlwimi r5, r4, 5, DAWRX_DR | DAWRX_DW > > > c010b03c: 74 2e 85 50 rlwimi r5,r4,5,25,26 > > > rlwimi r5, r4, 2, DAWRX_WT > > > c010b040: f6 16

Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Suraj Jitindar Singh
On Thu, 2019-06-13 at 10:16 +1000, Michael Neuling wrote: > On Wed, 2019-06-12 at 09:43 +0200, Cédric Le Goater wrote: > > On 12/06/2019 09:22, Michael Neuling wrote: > > > In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 > > > option") I screwed up some assembler and corrupted a

Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Michael Neuling
On Wed, 2019-06-12 at 09:43 +0200, Cédric Le Goater wrote: > On 12/06/2019 09:22, Michael Neuling wrote: > > In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 > > option") I screwed up some assembler and corrupted a pointer in > > r3. This resulted in crashes like the below from

Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Christophe Leroy
Le 12/06/2019 à 11:23, Paul Mackerras a écrit : On Wed, Jun 12, 2019 at 09:42:52AM +0200, Christophe Leroy wrote: Le 12/06/2019 à 09:22, Michael Neuling a écrit : In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option") I screwed up some assembler and corrupted a pointer

Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Paul Mackerras
On Wed, Jun 12, 2019 at 09:42:52AM +0200, Christophe Leroy wrote: > > > Le 12/06/2019 à 09:22, Michael Neuling a écrit : > >In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 > >option") I screwed up some assembler and corrupted a pointer in > >r3. This resulted in crashes like the

Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Cédric Le Goater
On 12/06/2019 09:22, Michael Neuling wrote: > In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 > option") I screwed up some assembler and corrupted a pointer in > r3. This resulted in crashes like the below from Cédric: > > [ 44.374746] BUG: Kernel NULL pointer dereference at

Re: [PATCH] KVM: PPC: Book3S HV: Fix r3 corruption in h_set_dabr()

2019-06-12 Thread Christophe Leroy
Le 12/06/2019 à 09:22, Michael Neuling a écrit : In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option") I screwed up some assembler and corrupted a pointer in r3. This resulted in crashes like the below from Cédric: Iaw Documentation/process/submitting-patches.rst: