Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-11 Thread Guilherme G. Piccoli
On 11/11/2016 05:12 PM, Benjamin Herrenschmidt wrote: > On Fri, 2016-11-11 at 16:32 +, Mark Rutland wrote: >> On Fri, Nov 11, 2016 at 08:30:43AM +1100, Benjamin Herrenschmidt >> wrote: >>> >>> On Wed, 2016-11-09 at 19:04 +, Mark Rutland wrote: If we don't have an

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-11 Thread Benjamin Herrenschmidt
On Fri, 2016-11-11 at 16:32 +, Mark Rutland wrote: > On Fri, Nov 11, 2016 at 08:30:43AM +1100, Benjamin Herrenschmidt > wrote: > > > > On Wed, 2016-11-09 at 19:04 +, Mark Rutland wrote: > > > > > > > > > If we don't have an interrupt-map on a PCI controller, why don't > > > we > > >

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-11 Thread Mark Rutland
On Fri, Nov 11, 2016 at 08:30:43AM +1100, Benjamin Herrenschmidt wrote: > On Wed, 2016-11-09 at 19:04 +, Mark Rutland wrote: > > > > If we don't have an interrupt-map on a PCI controller, why don't we > > instead log a message regarding that being missing, and give up > > early? > > Why ?

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-10 Thread Benjamin Herrenschmidt
On Wed, 2016-11-09 at 19:04 +, Mark Rutland wrote: > > > If we don't have an interrupt-map on a PCI controller, why don't we > instead log a message regarding that being missing, and give up > early? Why ? It's legit to not support LSIs. > That sounds like a more generically useful error

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-10 Thread Benjamin Herrenschmidt
On Wed, 2016-11-09 at 12:05 -0200, Guilherme G. Piccoli wrote: > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index 393fea8..1ad6882 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -275,7 +275,10 @@ int of_irq_parse_raw(const __be32 *addr, struct > of_phandle_args *out_irq) >  

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-09 Thread Mark Rutland
On Wed, Nov 09, 2016 at 12:05:08PM -0200, Guilherme G. Piccoli wrote: > On PowerPC machines some PCI slots might not have Level-triggered > interrupts capability (also know as Level Signaled Interrupts - LSI), > leading of_irq_parse_pci() to complain by presenting error messages > on the kernel

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-09 Thread Guilherme G. Piccoli
On 11/09/2016 04:05 PM, Rob Herring wrote: > On Wed, Nov 9, 2016 at 8:05 AM, Guilherme G. Piccoli > wrote: >> On PowerPC machines some PCI slots might not have Level-triggered >> interrupts capability (also know as Level Signaled Interrupts - LSI), >> leading

Re: [PATCH] of/irq: improve error message on irq discovery process failure

2016-11-09 Thread Rob Herring
On Wed, Nov 9, 2016 at 8:05 AM, Guilherme G. Piccoli wrote: > On PowerPC machines some PCI slots might not have Level-triggered > interrupts capability (also know as Level Signaled Interrupts - LSI), > leading of_irq_parse_pci() to complain by presenting error