Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Wed, 2017-10-18 at 14:18 +1100, Michael Ellerman wrote: > Mimi Zohar writes: > > On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote: > >> On Tue, 17 Oct 2017, Dan Carpenter wrote: > >> > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > >> > > On Tue,

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Wed, Oct 18, 2017 at 09:09:48AM -0700, James Bottomley wrote: > On Wed, 2017-10-18 at 18:10 +0300, Jarkko Sakkinen wrote: > > On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote: > > > > > > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > > > > > > > > > > >

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Wed, 2017-10-18 at 18:10 +0300, Jarkko Sakkinen wrote: > On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote: > > > > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > > > > > > > > > > > > Fixes is only for bug fixes.  These don't fix any bugs. > > > > > >

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote: > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > > > Fixes is only for bug fixes.  These don't fix any bugs. > > > > How do you distinguish these in questionable source code > > from other error categories or

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, Oct 17, 2017 at 12:44:34PM +0300, Dan Carpenter wrote: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > > > > > A minor complaint: all

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Mon, Oct 16, 2017 at 10:44:18PM +0200, SF Markus Elfring wrote: > > A minor complaint: all commits are missing "Fixes:" tag. > > * Do you require it to be added to the commit messages? I don't require it. It's part of the development process:

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

Mimi Zohar writes: > On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote: >> On Tue, 17 Oct 2017, Dan Carpenter wrote: >> > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: >> > > On Tue, 17 Oct 2017, Dan Carpenter wrote: >> > > > On Mon, Oct 16, 2017 at

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, 2017-10-17 at 08:57 -0700, James Bottomley wrote: > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > > > Fixes is only for bug fixes.  These don't fix any bugs. > > > > How do you distinguish these in questionable source code > > from other error categories or software

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

>>> Fixes is only for bug fixes.  These don't fix any bugs. >> >> How do you distinguish these in questionable source code >> from other error categories or software weaknesses? > > A style change is one that doesn't change the effect of the execution. This can occasionally be fine, can't it?

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote: > > > > Fixes is only for bug fixes.  These don't fix any bugs. > > How do you distinguish these in questionable source code > from other error categories or software weaknesses? A style change is one that doesn't change the effect of

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

Dan Carpenter writes: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: >> >> >> On Tue, 17 Oct 2017, Dan Carpenter wrote: >> >> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: >> > > >> > > A minor complaint: all commits are missing

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

Hi Julia, On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote: > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > > > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300,

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, 17 Oct 2017, Dan Carpenter wrote: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > > > > > A minor complaint: all commits are missing

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > > > A minor complaint: all commits are missing "Fixes:" tag. > > > > > > > Fixes is only for bug fixes.

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

> Fixes is only for bug fixes. These don't fix any bugs. How do you distinguish these in questionable source code from other error categories or software weaknesses? Regards, Markus

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Tue, 17 Oct 2017, Dan Carpenter wrote: > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > A minor complaint: all commits are missing "Fixes:" tag. > > > > Fixes is only for bug fixes. These don't fix any bugs. 0-day seems to put Fixes for everything. Should they be

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > A minor complaint: all commits are missing "Fixes:" tag. > Fixes is only for bug fixes. These don't fix any bugs. regards, dan carpenter

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

>> A minor complaint: all commits are missing "Fixes:" tag. > > None of these patches fix anything. It depends on the view which you prefer. > All are trivial changes without much of any impact. I find that they improve the affected software another bit. Other adjustments can be more

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Mon, 2017-10-16 at 21:35 +0300, Jarkko Sakkinen wrote: > A minor complaint: all commits are missing "Fixes:" tag. None of these patches fix anything. All are trivial changes without much of any impact.

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

> A minor complaint: all commits are missing "Fixes:" tag. * Do you require it to be added to the commit messages? * Would you like to get a finer patch granularity then? * Do you find any more information missing? Regards, Markus

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Mon, Oct 16, 2017 at 09:31:39PM +0300, Jarkko Sakkinen wrote: > On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 16 Oct 2017 19:12:34 +0200 > > > > A few update suggestions were taken into account > >

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 16 Oct 2017 19:12:34 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (4): > Delete an error