Manish Ahuja writes:
If Mike and Paul are okay, then I will leave this bit as is and fix all
other issues and comments.
Well, part of the problem is the semantic dissonance caused by having
a static variable called global. Please change the name
phyp_dump_global to phyp_dump_vars or
On 10/03/2008, Michael Ellerman [EMAIL PROTECTED] wrote:
On Thu, 2008-02-28 at 18:24 -0600, Manish Ahuja wrote:
+
+/* Global, used to communicate data between early boot and late boot */
+static struct phyp_dump phyp_dump_global;
+struct phyp_dump *phyp_dump_info = phyp_dump_global;
If Mike and Paul are okay, then I will leave this bit as is and fix all
other issues and comments.
Thanks,
Manish
Linas Vepstas wrote:
On 10/03/2008, Michael Ellerman [EMAIL PROTECTED] wrote:
On Thu, 2008-02-28 at 18:24 -0600, Manish Ahuja wrote:
+
+/* Global, used to communicate
Manish Ahuja writes:
+#else /* CONFIG_PHYP_DUMP */
+int early_init_dt_scan_phyp_dump(unsigned long node,
+ const char *uname, int depth, void *data) { return 0; }
This shouldn't be in the header file. Either put it in prom.c (and
make it return 1 so the of_scan_flat_dt call
On Tue, 2008-03-11 at 17:12 +1100, Paul Mackerras wrote:
Manish Ahuja writes:
+#else /* CONFIG_PHYP_DUMP */
+int early_init_dt_scan_phyp_dump(unsigned long node,
+ const char *uname, int depth, void *data) { return 0; }
This shouldn't be in the header file. Either put it in
On Wed, 2008-03-12 at 11:13 +1100, Michael Ellerman wrote:
On Tue, 2008-03-11 at 17:12 +1100, Paul Mackerras wrote:
Manish Ahuja writes:
+#else /* CONFIG_PHYP_DUMP */
+int early_init_dt_scan_phyp_dump(unsigned long node,
+ const char *uname, int depth, void *data) { return
On Thu, 2008-02-28 at 18:24 -0600, Manish Ahuja wrote:
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
On Thu, Feb 14, 2008 at 02:46:21PM +1100, Tony Breeds wrote:
Hi Manish,
Sorry for the minor nits but this should be:
---
* Linas Vepstas, Manish Ahuja 2008
* Copyright 2008 IBM Corp.
---
You can optionally use the '??' symbol after word 'Copyright' but you
shouldn't use '(c)'
Olof,
I will run it through checkpatch before resubmitting.
Thanks,
Manish
Olof Johansson wrote:
On Thu, Feb 14, 2008 at 02:46:21PM +1100, Tony Breeds wrote:
Hi Manish,
Sorry for the minor nits but this should be:
---
* Linas Vepstas, Manish Ahuja 2008
* Copyright 2008 IBM
On Tue, Feb 12, 2008 at 01:08:25AM -0600, Manish Ahuja wrote:
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL
On Tue, 2008-02-12 at 01:08 -0600, Manish Ahuja wrote:
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Sorry,
I think i sent the wrong patch file, it shouldn't have my printk statement in
there. Let me re-send
the correct file and let me test it once more to make sure it does the right
thing.
-Manish
Paul Mackerras wrote:
Manish Ahuja writes:
Initial patch for reserving memory in early
Manish Ahuja writes:
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
[snip]
+static void __init reserve_crashed_mem(void)
+{
+ unsigned long base,
Reposted this one. I got the email id wrong in this one.
Sorry about that.
Manish
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
14 matches
Mail list logo
