On Tue, 6 Apr 2010 09:12:38 pm Anton Blanchard wrote:
The patch below changes things to call tty_kref_put once for every
hvc_close call, and with that my machine boots fine.
Thanks, applied.
Cheers,
Rusty.
___
Linuxppc-dev mailing list
Hi,
Looking at the commit e74d098c66543d0731de62eb747ccd5b636a6f4c,
i see that for every tty_kref_get() there is a corresponding
tty_kref_put() except maybe for the one in the following patch snippet
spin_lock_irqsave(hp-lock, flags);
/* Check and then increment for
On (Tue) Apr 06 2010 [21:42:38], Anton Blanchard wrote:
Hi,
Looking at the commit e74d098c66543d0731de62eb747ccd5b636a6f4c,
i see that for every tty_kref_get() there is a corresponding
tty_kref_put() except maybe for the one in the following patch snippet
Anton Blanchard wrote:
The patch below changes things to call tty_kref_put once for every
hvc_close call, and with that my machine boots fine.
Signed-off-by: Anton Blanchard an...@samba.org
---
Works for me. Thanks Anton.
Regards
-Sachin
diff --git a/drivers/char/hvc_console.c
I don't claim to understand the tty layer, but it seems like hvc_open and
hvc_close should be balanced in their kref reference counting.
They should yes.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
Amit Shah wrote:
On (Sun) Mar 21 2010 [10:07:25], Amit Shah wrote:
On (Sun) Mar 21 2010 [08:04:39], Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where
On (Fri) Mar 26 2010 [14:43:56], Sachin Sant wrote:
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Hi Amit,
I too ran into this issue as reported by Anton. Unfortunately in my
case the following suggested
Hi Amit,
On Fri, 26 Mar 2010 15:28:21 +0530 Amit Shah amit.s...@redhat.com wrote:
On (Fri) Mar 26 2010 [14:43:56], Sachin Sant wrote:
I too ran into this issue as reported by Anton. Unfortunately in my
case the following suggested patch does not help boot the powerpc
box successfully.
Amit Shah wrote:
On (Fri) Mar 26 2010 [14:43:56], Sachin Sant wrote:
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Hi Amit,
I too ran into this issue as reported by Anton. Unfortunately in my
case the
mount: can't find /root/proc in /etc/fstab or /etc/mtab
/sbin/smart_agetty: can not determine 'console' speed
OK, this gets even murkier. I don't know why taking a few krefs modifies
hvc_console behaviour to such an extent.
Can you see if the agetty is getting a hangup or open
On (Fri) Mar 26 2010 [17:12:22], Sachin Sant wrote:
Amit Shah wrote:
On (Fri) Mar 26 2010 [14:43:56], Sachin Sant wrote:
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Hi Amit,
I too ran into this
On (Fri) Mar 26 2010 [11:52:33], Alan Cox wrote:
mount: can't find /root/proc in /etc/fstab or /etc/mtab
/sbin/smart_agetty: can not determine 'console' speed
OK, this gets even murkier. I don't know why taking a few krefs modifies
hvc_console behaviour to such an extent.
Hi,
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Looks good, tests OK on my POWER5 box. Thanks!
Tested-by: Anton Blanchard an...@samba.org
diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
On (Fri) Mar 26 2010 [10:30:31], Anton Blanchard wrote:
Hi,
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Looks good, tests OK on my POWER5 box. Thanks!
Tested-by: Anton Blanchard an...@samba.org
On Sun, 2010-03-21 at 08:04 +1100, Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is the first user of
On (Wed) Mar 24 2010 [21:45:44], Benjamin Herrenschmidt wrote:
On Sun, 2010-03-21 at 08:04 +1100, Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is
On Sun, 21 Mar 2010 08:04:39 +1100
Benjamin Herrenschmidt b...@kernel.crashing.org wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is
On (Sun) Mar 21 2010 [10:07:25], Amit Shah wrote:
On (Sun) Mar 21 2010 [08:04:39], Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked. The
On (Wed) Mar 24 2010 [11:37:21], Alan Cox wrote:
On Sun, 21 Mar 2010 08:04:39 +1100
Benjamin Herrenschmidt b...@kernel.crashing.org wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is the first user of hvc_remove().
This causes hangs during boot on pseries machines. Haven't had
On (Sun) Mar 21 2010 [08:04:39], Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is the first user of
21 matches
Mail list logo
