Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

2008-03-11 Thread Paul Mackerras
Manish Ahuja writes: -static void -release_memory_range(unsigned long start_pfn, unsigned long nr_pages) +static +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages) This change looks rather pointless. If you have to change it, I'd prefer: static void

Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

2008-02-12 Thread Stephen Rothwell
Hi Manish, On Tue, 12 Feb 2008 01:18:22 -0600 Manish Ahuja [EMAIL PROTECTED] wrote: -static void -release_memory_range(unsigned long start_pfn, unsigned long nr_pages) +static +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages) Cosmetic changes like this should