Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 15:33:37 Rafael J. Wysocki wrote: > > > > Note the check on !CPU_THERMAL rather than !THERMAL in my patch, that > > part was correct. I think the line should be > > > > depends on !CPU_THERMAL || THERMAL > > > > as some other drivers do. I must have copied the

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-29 Thread Rafael J. Wysocki
On Mon, Feb 29, 2016 at 11:05 AM, Arnd Bergmann wrote: > On Friday 26 February 2016 18:41:06 Li Yang wrote: >> >> > >> >> > It would be perfect if this it true. But I tried with the following >> >> > change, it just makes QORIQ_CPUFREQ non-selectable if THERMAL=m. >> >> > >> >> >

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-29 Thread Arnd Bergmann
On Friday 26 February 2016 18:41:06 Li Yang wrote: > >> > > >> > It would be perfect if this it true. But I tried with the following > >> > change, it just makes QORIQ_CPUFREQ non-selectable if THERMAL=m. > >> > > >> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > >> > index

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Li Yang
On Fri, Feb 26, 2016 at 6:08 PM, Scott Wood wrote: > On Fri, 2016-02-26 at 18:04 -0600, Li Yang wrote: >> On Fri, Feb 26, 2016 at 5:31 PM, Li Yang wrote: >> > On Fri, Feb 26, 2016 at 5:16 PM, Arnd Bergmann wrote: >> > > On Friday 26

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Scott Wood
On Fri, 2016-02-26 at 18:04 -0600, Li Yang wrote: > On Fri, Feb 26, 2016 at 5:31 PM, Li Yang wrote: > > On Fri, Feb 26, 2016 at 5:16 PM, Arnd Bergmann wrote: > > > On Friday 26 February 2016 17:07:09 Li Yang wrote: > > > > > > > > I don't have a perfect

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Li Yang
On Fri, Feb 26, 2016 at 5:31 PM, Li Yang wrote: > On Fri, Feb 26, 2016 at 5:16 PM, Arnd Bergmann wrote: >> On Friday 26 February 2016 17:07:09 Li Yang wrote: >>> >>> I don't have a perfect solution either. But I think this is still >>> better than making

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Li Yang
On Fri, Feb 26, 2016 at 5:16 PM, Arnd Bergmann wrote: > On Friday 26 February 2016 17:07:09 Li Yang wrote: >> >> I don't have a perfect solution either. But I think this is still >> better than making cpufreq not usable. The cpufreq driver will print >> out an error message if

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Arnd Bergmann
On Friday 26 February 2016 17:07:09 Li Yang wrote: > > I don't have a perfect solution either. But I think this is still > better than making cpufreq not usable. The cpufreq driver will print > out an error message if thermal is not reachable. Maybe this can > relief the confusion a little

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Li Yang
On Fri, Feb 26, 2016 at 2:20 PM, Arnd Bergmann wrote: > On Friday 26 February 2016 12:04:59 Li Yang wrote: >> On Fri, Dec 18, 2015 at 4:32 PM, Arnd Bergmann wrote: >> > On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote: >> >> On Thursday, November 26,

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Arnd Bergmann
On Friday 26 February 2016 12:04:59 Li Yang wrote: > On Fri, Dec 18, 2015 at 4:32 PM, Arnd Bergmann wrote: > > On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote: > >> On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: > >> > Register the qoriq cpufreq driver

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2016-02-26 Thread Li Yang
On Fri, Dec 18, 2015 at 4:32 PM, Arnd Bergmann wrote: > On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote: >> On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: >> > Register the qoriq cpufreq driver as a cooling device, based on the >> > thermal device tree

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2015-12-18 Thread Arnd Bergmann
On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote: > On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: > > Register the qoriq cpufreq driver as a cooling device, based on the > > thermal device tree framework. When temperature crosses the passive trip > > point cpufreq is

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2015-12-14 Thread Rafael J. Wysocki
On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: > Register the qoriq cpufreq driver as a cooling device, based on the > thermal device tree framework. When temperature crosses the passive trip > point cpufreq is used to throttle CPUs. > > Signed-off-by: Jia Hongtao