Le 26/07/2023 à 17:02, Herve Codina a écrit :
> Introduce the qmc_chan_setup_tsa* functions to setup entries related
> to the given channel.
> Use them during QMC channels setup.
>
> Signed-off-by: Herve Codina
Reviewed-by: Christophe Leroy
> ---
> drivers/soc/fsl/qe/qmc.c | 161
On Tue, 1 Aug 2023 11:36:43 +0200
Andrew Lunn wrote:
> > +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
> > +{
> > + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
> > +}
> > +
>
> Please don't use inline in .c files. Let the compiler decide.
>
>
> +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
> +{
> + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
> +}
> +
Please don't use inline in .c files. Let the compiler decide.
Andrew
