Re: [PATCH v3 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros

2020-04-23 Thread Ravi Bangoria
Hi Christophe,   max_len = DAWR_MAX_LEN;   /* DAWR region can't cross 512 bytes boundary */ -    if ((start_addr >> 9) != (end_addr >> 9)) +    if ((start_addr >> 9) != ((end_addr - 1) >> 9)) What about: if (ALIGN(start_addr, SZ_512M) != ALIGN(end - 1, SZ_512M))

Re: [PATCH v3 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros

2020-04-13 Thread Christophe Leroy
Le 14/04/2020 à 05:16, Ravi Bangoria a écrit : Currently we calculate hw aligned start and end addresses manually. Replace them with builtin ALIGN_DOWN() and ALIGN() macros. Suggested-by: Christophe Leroy Signed-off-by: Ravi Bangoria --- arch/powerpc/include/asm/hw_breakpoint.h | 5