Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-05 Thread Rasmus Villemoes
On 05/11/2019 07.16, Qiang Zhao wrote: > > I tested your v3 patches on ls1043ardb which is arm64 for fsl_ucc_hdlc, it > can work, > Only it will put a compile warning, I also made a patch to fix it. > I can send a patch to remove PPC32 dependency when I send my patch to support > ARM64. > Or I

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-05 Thread Li Yang
On Tue, Nov 5, 2019 at 4:47 PM Rasmus Villemoes wrote: > > On 04/11/2019 21.56, Li Yang wrote: > > >> No, this patch cannot be dropped. Please see the kbuild complaints for > >> v2,23/23 about use of IS_ERR_VALUE on not-sizeof(long) entities. I see > >> kbuild has complained about the same thing

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-05 Thread Rasmus Villemoes
On 04/11/2019 21.56, Li Yang wrote: >> No, this patch cannot be dropped. Please see the kbuild complaints for >> v2,23/23 about use of IS_ERR_VALUE on not-sizeof(long) entities. I see >> kbuild has complained about the same thing for v3 since apparently the >> same thing appears in ucc_slow.c. So

RE: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-04 Thread Qiang Zhao
ernel.org; Scott Wood ; > net...@vger.kernel.org > Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend > on PPC32 > > On 01/11/2019 23.31, Leo Li wrote: > > > > > >> -Original Message- > >> From: Christophe Leroy > >>

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-04 Thread Li Yang
moes ; Qiang Zhao > >> ; Leo Li > >> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; > >> linux-ker...@vger.kernel.org; Scott Wood ; > >> net...@vger.kernel.org > >> Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly > &g

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-04 Thread Rasmus Villemoes
adead.org; >> linux-ker...@vger.kernel.org; Scott Wood ; >> net...@vger.kernel.org >> Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly >> depend on PPC32 >> >> >> >> Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit : >>> Cur

RE: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-01 Thread Leo Li
; net...@vger.kernel.org > Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly > depend on PPC32 > > > > Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit : > > Currently, FSL_UCC_HDLC depends on QUICC_ENGINE, which in turn > depends > > on PPC32.

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-01 Thread Christophe Leroy
Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit : Currently, FSL_UCC_HDLC depends on QUICC_ENGINE, which in turn depends on PPC32. As preparation for removing the latter and thus allowing the core QE code to be built for other architectures, make FSL_UCC_HDLC explicitly depend on PPC32. Is