Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue, Feb 02, 2016 at 04:46:27PM +0300, Denis Kirjanov wrote: > > + > > +#ifdef CONFIG_LIVEPATCH > > +static inline int klp_check_compiler_support(void) > > +{ > > +#if !defined(_CALL_ELF) || _CALL_ELF != 2 || > > !defined(CC_USING_MPROFILE_KERNEL) > > + return 1; > > +#endif > > + return 0;

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue, 2 Feb 2016, Petr Mladek wrote: > Note that TOC is not set only when the problematic functions are > compiled with --mprofile-kernel. I still see the TOC stuff when > compiling only with -pg. I don't see how this wouldn't be a gcc bug. No matter whether it's plain profiling call (-pg)

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue 2016-02-02 16:45:23, Torsten Duwe wrote: > On Tue, Feb 02, 2016 at 01:12:24PM +0100, Petr Mladek wrote: > > > > Hmm, the size of the offset is not a constant. In particular, leaf > > functions do not set TOC before the mcount location. > > To be slightly more precise, a leaf function that

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue 2016-01-26 13:48:53, Petr Mladek wrote: > On Tue 2016-01-26 11:50:25, Miroslav Benes wrote: > > > > [ added Petr to CC list ] > > > > On Mon, 25 Jan 2016, Torsten Duwe wrote: > > > > > * create the appropriate files+functions > > > arch/powerpc/include/asm/livepatch.h > > >

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On 1/25/16, Torsten Duwe wrote: > * create the appropriate files+functions > arch/powerpc/include/asm/livepatch.h > klp_check_compiler_support, > klp_arch_set_pc > arch/powerpc/kernel/livepatch.c with a stub for > klp_write_module_reloc > This is

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue, Feb 02, 2016 at 01:12:24PM +0100, Petr Mladek wrote: > > Hmm, the size of the offset is not a constant. In particular, leaf > functions do not set TOC before the mcount location. To be slightly more precise, a leaf function that additionally uses no global data. No global function calls,

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

[ added Petr to CC list ] On Mon, 25 Jan 2016, Torsten Duwe wrote: > * create the appropriate files+functions > arch/powerpc/include/asm/livepatch.h > klp_check_compiler_support, > klp_arch_set_pc > arch/powerpc/kernel/livepatch.c with a stub for >

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue, Jan 26, 2016 at 01:48:53PM +0100, Petr Mladek wrote: > On Tue 2016-01-26 11:50:25, Miroslav Benes wrote: > > > > We still need Petr's patch from [1] to make livepatch work, right? Could > > you, please, add it to this patch set to make it self-sufficient? It's Petr's patch, I don't want

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue, Jan 26, 2016 at 11:50:25AM +0100, Miroslav Benes wrote: > > + */ > > +int klp_write_module_reloc(struct module *mod, unsigned long type, > > + unsigned long loc, unsigned long value) > > +{ > > + /* This requires infrastructure changes; we need the loadinfos. */ > >

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

[ Jessica added to CC list so she is aware that there are plans to implement livepatch on ppc64le ] On Tue, 26 Jan 2016, Torsten Duwe wrote: > On Tue, Jan 26, 2016 at 11:50:25AM +0100, Miroslav Benes wrote: > > > + */ > > > +int klp_write_module_reloc(struct module *mod, unsigned long type, >

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

On Tue 2016-01-26 11:50:25, Miroslav Benes wrote: > > [ added Petr to CC list ] > > On Mon, 25 Jan 2016, Torsten Duwe wrote: > > > * create the appropriate files+functions > > arch/powerpc/include/asm/livepatch.h > > klp_check_compiler_support, > > klp_arch_set_pc > >