On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote:
> Maybe a standard #define WATCHDOG_NAME
> .identity = WATCHGOD_NAME
I don't really see that the indrection via the #define would buy us
anything?
___
Linuxppc-dev mailing list
Linuxppc-dev@
On Tue, 2010-01-19 at 22:16 +, Mark Brown wrote:
> On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote:
> > Maybe a standard #define WATCHDOG_NAME
> > .identity = WATCHGOD_NAME
>
> I don't really see that the indrection via the #define would buy us
> anything?
Maybe not, just a sugge
Hi Alan,
> > please comment on following patch.
>
> Why move them out - why not just make them const ?
There's 2 options:
1) we only make them const now. And we move them out later when we do the
conversion to the generic watchdog api (which means that we will rip out the
code for the open, re
On Tue, 19 Jan 2010 22:17:59 +0100
Wim Van Sebroeck wrote:
> Hi All,
>
> please comment on following patch.
Why move them out - why not just make them const ?
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinf
On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
> -static struct watchdog_info at32_wdt_info = {
> +static const struct watchdog_info at32_wdt_info = {
It'd be good to use a consistent structure name:
static const struct watchdog_info ident = {
etc...
}
$ grep -Poh "struct\s*w
On Tue, Jan 19, 2010 at 16:42, Joe Perches wrote:
> On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
>> -static struct watchdog_info at32_wdt_info = {
>> +static const struct watchdog_info at32_wdt_info = {
>
> It'd be good to use a consistent structure name:
>
> static const struct watch
