Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-24 Thread Yosry Ahmed
On Mon, Jan 22, 2024 at 12:49 PM Yosry Ahmed wrote: > > On Sun, Jan 21, 2024 at 11:42 PM Christoph Hellwig wrote: > > > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > > Well, better compression ratios for one :) > > > > > > I think a long time ago there were complaints that zs

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-22 Thread Yosry Ahmed
On Sun, Jan 21, 2024 at 11:42 PM Christoph Hellwig wrote: > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > Well, better compression ratios for one :) > > > > I think a long time ago there were complaints that zsmalloc had higher > > latency than zbud/z3fold, but since then a lo

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-21 Thread Christoph Hellwig
On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > Well, better compression ratios for one :) > > I think a long time ago there were complaints that zsmalloc had higher > latency than zbud/z3fold, but since then a lot of things have changed > (including nice compaction optimization fro

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-16 Thread Chris Down
Vitaly Wool writes: Existing users, if any, should voice their objections. Otherwise, we can remove z3fold in a few releases. At this point I NACK this patch. We're about to submit an allocator which is clearly better that z3fold and is faster that zsmalloc in most cases and that submission wil

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-16 Thread Chris Down
Yosry Ahmed writes: The z3fold compressed pages allocator is not widely used, most users use zsmalloc. The only disadvantage of zsmalloc in comparison is the dependency on MMU, and zbud is a more common option for !MMU as it was the default zswap allocator for a long time. In hopes of having a s

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-16 Thread Yosry Ahmed
On Tue, Jan 16, 2024 at 7:39 AM Christoph Hellwig wrote: > > On Fri, Jan 12, 2024 at 04:38:30PM -0800, Nhat Pham wrote: > > > > > > I thought deprecating z3fold is the low hanging fruit. Then, once we > > > can sort out the MMU dependency in zsmalloc, we can go after zbud as > > > well. > > > > Ma

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-16 Thread Christoph Hellwig
On Fri, Jan 12, 2024 at 04:38:30PM -0800, Nhat Pham wrote: > > > > I thought deprecating z3fold is the low hanging fruit. Then, once we > > can sort out the MMU dependency in zsmalloc, we can go after zbud as > > well. > > Makes sense to me. Should we do the same thing to zbud? We probably > have

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-15 Thread Vitaly Wool
On Fri, Jan 12, 2024 at 8:31 PM Yosry Ahmed wrote: > > The z3fold compressed pages allocator is not widely used, most users use > zsmalloc. The only disadvantage of zsmalloc in comparison is the > dependency on MMU, and zbud is a more common option for !MMU as it was > the default zswap allocator

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-15 Thread Sergey Senozhatsky
On (24/01/15 08:47), Yosry Ahmed wrote: > > At this point I NACK this patch. We're about to submit an allocator > > which is clearly better that z3fold and is faster that zsmalloc in > > most cases and that submission will mark z3fold as deprecated. But for > > now this move is premature. > > I thi

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-15 Thread Nhat Pham
On Mon, Jan 15, 2024 at 4:27 AM Vitaly Wool wrote: > > On Fri, Jan 12, 2024 at 8:31 PM Yosry Ahmed wrote: > > > > The z3fold compressed pages allocator is not widely used, most users use > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > dependency on MMU, and zbud is a more

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-15 Thread Yosry Ahmed
On Mon, Jan 15, 2024 at 4:27 AM Vitaly Wool wrote: > > On Fri, Jan 12, 2024 at 8:31 PM Yosry Ahmed wrote: > > > > The z3fold compressed pages allocator is not widely used, most users use > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > dependency on MMU, and zbud is a more

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-14 Thread Yosry Ahmed
On Sun, Jan 14, 2024 at 2:42 PM Nhat Pham wrote: > > On Sun, Jan 14, 2024 at 10:49 AM Yosry Ahmed wrote: > > > > On Fri, Jan 12, 2024 at 4:38 PM Nhat Pham wrote: > > > > > > On Fri, Jan 12, 2024 at 3:37 PM Yosry Ahmed wrote: > > > > > > > > On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > >

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-14 Thread Nhat Pham
On Sun, Jan 14, 2024 at 10:49 AM Yosry Ahmed wrote: > > On Fri, Jan 12, 2024 at 4:38 PM Nhat Pham wrote: > > > > On Fri, Jan 12, 2024 at 3:37 PM Yosry Ahmed wrote: > > > > > > On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > > > > > > > > On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed > > >

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-14 Thread Yosry Ahmed
On Fri, Jan 12, 2024 at 4:38 PM Nhat Pham wrote: > > On Fri, Jan 12, 2024 at 3:37 PM Yosry Ahmed wrote: > > > > On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > > > > > > On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed > > > wrote: > > > > > > > > The z3fold compressed pages allocator is not w

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-12 Thread Nhat Pham
On Fri, Jan 12, 2024 at 3:37 PM Yosry Ahmed wrote: > > On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > > > > On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed wrote: > > > > > > The z3fold compressed pages allocator is not widely used, most users use > > > zsmalloc. The only disadvantage of zsmal

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-12 Thread Yosry Ahmed
On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > > On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed wrote: > > > > The z3fold compressed pages allocator is not widely used, most users use > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > dependency on MMU, and zbud is a more

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-12 Thread Nhat Pham
On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed wrote: > > The z3fold compressed pages allocator is not widely used, most users use > zsmalloc. The only disadvantage of zsmalloc in comparison is the > dependency on MMU, and zbud is a more common option for !MMU as it was > the default zswap allocator

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-12 Thread Nhat Pham
On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed wrote: > > The z3fold compressed pages allocator is not widely used, most users use > zsmalloc. The only disadvantage of zsmalloc in comparison is the > dependency on MMU, and zbud is a more common option for !MMU as it was > the default zswap allocator