Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-02 Thread Wolfgang Grandegger
Hi Kumar, Kumar Gala wrote: On Apr 1, 2009, at 8:10 AM, Wolfgang Grandegger wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-02 Thread Kumar Gala
On Apr 2, 2009, at 1:38 AM, Wolfgang Grandegger wrote: Socrates is a new board and it has no problem using an up-to-date version of U-Boot. The socrates.dts file in your next tree already has the device_type = soc removed. We need to add fsl,soc to the compatible property and update

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-02 Thread Wolfgang Grandegger
Kumar Gala wrote: On Apr 2, 2009, at 1:38 AM, Wolfgang Grandegger wrote: Socrates is a new board and it has no problem using an up-to-date version of U-Boot. The socrates.dts file in your next tree already has the device_type = soc removed. We need to add fsl,soc to the compatible

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-02 Thread Kumar Gala
On Apr 2, 2009, at 1:50 PM, Wolfgang Grandegger wrote: [PATCH] powerpc/85xx: Re-add the device_type soc to socrates.dts The device_type soc is still required for MPC85xx boards. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- arch/powerpc/boot/dts/socrates.dts |1 + 1 file

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] + soc8...@e000 { + #address-cells = 1; + #size-cells = 1; + device_type = soc; Drop device_type here too. Grrr, I just realized that removing the

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] +       soc8...@e000 { +               #address-cells = 1; +               #size-cells = 1; +              

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Wolfgang Grandegger
Grant Likely wrote: On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] + soc8...@e000 { + #address-cells = 1; + #size-cells = 1; +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Kumar Gala
On Apr 1, 2009, at 8:10 AM, Wolfgang Grandegger wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] + soc8...@e000 { +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: + soc8...@e000 { + #address-cells = 1; + #size-cells = 1; +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: +       soc8...@e000 { +      

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 7:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Anton Vorontsov
On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] +       soc8...@e000 { +               #address-cells = 1; +               #size-cells = 1; +               device_type = soc; Drop device_type here too. Grrr, I just realized that removing the devices type soc has

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 9:54 AM, Anton Vorontsov avoront...@ru.mvista.com wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] +       soc8...@e000 { +               #address-cells = 1; +               #size-cells = 1; +               device_type = soc; Drop

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. OK. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: + soc8...@e000 { + #address-cells = 1; + #size-cells = 1; +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
David Gibson wrote: On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote: [snip] [snip[ +disp...@2,0 { +compatible = fujitsu,lime; This compat string looks slightly worryingly non-specific. The node is for the Lime graphic controller from

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
Hi Kumar, Kumar Gala wrote: On Mar 19, 2009, at 10:26 AM, Wolfgang Grandegger wrote: +m...@24520 { +#address-cells = 1; +#size-cells = 0; +compatible = fsl,gianfar-mdio; +reg = 0x24520 0x20; + +phy0: ethernet-...@0 {

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-20 Thread Wolfgang Grandegger
David Gibson wrote: On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote: This patch adds support for the socrates board based on the MPC8544. Supported are Ethernet, serial console, I2C, I2C-based RTC and temperature sensors, NOR and NAND flash, PCI, USB, CAN and Lime display

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-19 Thread David Gibson
On Thu, Mar 19, 2009 at 04:26:44PM +0100, Wolfgang Grandegger wrote: This patch adds support for the socrates board based on the MPC8544. Supported are Ethernet, serial console, I2C, I2C-based RTC and temperature sensors, NOR and NAND flash, PCI, USB, CAN and Lime display controller. The

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-19 Thread Kumar Gala
On Mar 19, 2009, at 10:26 AM, Wolfgang Grandegger wrote: + m...@24520 { + #address-cells = 1; + #size-cells = 0; + compatible = fsl,gianfar-mdio; + reg = 0x24520 0x20; + +

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-19 Thread Grant Likely
I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: +       soc8...@e000 { +               #address-cells = 1; +               #size-cells = 1; +               device_type = soc; Drop