Re: [PATCH 09/22] [v2] arch: fix asm-offsets.c building with -Wmissing-prototypes

2023-11-08 Thread Sam Ravnborg
On Wed, Nov 08, 2023 at 01:58:30PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When -Wmissing-prototypes is enabled, the some asm-offsets.c files fail > to build, even when this warning is disabled in the Makefile for normal > files: > > arch/sparc/kernel/asm-offs

[PATCH 09/22] [v2] arch: fix asm-offsets.c building with -Wmissing-prototypes

2023-11-08 Thread Arnd Bergmann
From: Arnd Bergmann When -Wmissing-prototypes is enabled, the some asm-offsets.c files fail to build, even when this warning is disabled in the Makefile for normal files: arch/sparc/kernel/asm-offsets.c:22:5: error: no previous prototype for 'sparc32_foo' [-Werror=missing-protot

Re: [PATCH] powerpc/asm: Remove unused symbols in asm-offsets.c

2021-03-15 Thread Christophe Leroy
Le 02/06/2016 à 00:56, Rashmica Gupta a écrit : --- GPR15, GPR16, GPR17, GPR18, GPR19, GPR20, GPR21, GPR22, GPR23, GPR24, GPR25, GPR26, GPR27, GPR28, GPR29 and GPR30: Added in commit a4bcbe6a41ad ("powerpc: Remove old compile time disabled syscall tracing code") and were never used. --- GPR1

Re: [2/3] powerpc/asm: Define STACK_OFFSET macro in asm-offsets.c

2017-02-15 Thread Michael Ellerman
On Thu, 2016-06-02 at 04:29:47 UTC, Rashmica Gupta wrote: > There are quite a few entries in asm-offests.c look like this: > DEFINE(REG, STACK_FRAME_OVERHEAD+offsetof(struct pt_regs, reg)); > > So define a local MACRO to clean this up: > STACK_OFFSET(sym, val) DEFINE(sym, STACK_FRAME_OVERHEAD + \

Re: [1/3] powerpc/asm: Use OFFSET macro in asm-offsets.c

2017-02-15 Thread Michael Ellerman
On Thu, 2016-06-02 at 04:29:46 UTC, Rashmica Gupta wrote: > A lot of entries in asm-offests.c look like this: > DEFINE(TI_FLAGS, offsetof(struct thread_info, flags)); > > But there is a common macro, OFFSET, which makes this cleaner: > OFFSET(TI_flags, thread_info, flags), so use this. > > Signed

Re: powerpc/asm: Remove unused symbols in asm-offsets.c

2016-06-20 Thread Michael Ellerman
On Wed, 2016-01-06 at 22:56:47 UTC, Rashmica Gupta wrote: > THREAD_DSCR: Added in commit efcac6589a27 ("powerpc: Per process DSCR + ... > > Signed-off-by: Rashmica Gupta Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/aac6a91fea93e6bdd7ac20365d cheers

[PATCH 3/3] powerpc/asm: Add STACK_INT_OFFSET macro in asm-offsets.c

2016-06-01 Thread Rashmica Gupta
)) Signed-off-by: Rashmica Gupta --- arch/powerpc/kernel/asm-offsets.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c index 3dbd3bd016ba..5efe5e297256 100644 --- a/arch/powerpc

[PATCH 2/3] powerpc/asm: Define STACK_OFFSET macro in asm-offsets.c

2016-06-01 Thread Rashmica Gupta
: Rashmica Gupta --- arch/powerpc/kernel/asm-offsets.c | 61 --- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c index 345a351909c5..3dbd3bd016ba 100644 --- a/arch/powerpc/kernel/asm

[PATCH 1/3] powerpc/asm: Use OFFSET macro in asm-offsets.c

2016-06-01 Thread Rashmica Gupta
A lot of entries in asm-offests.c look like this: DEFINE(TI_FLAGS, offsetof(struct thread_info, flags)); But there is a common macro, OFFSET, which makes this cleaner: OFFSET(TI_flags, thread_info, flags), so use this. Signed-off-by: Rashmica Gupta --- arch/powerpc/kernel/asm-offsets.c | 685

[PATCH] powerpc/asm: Remove unused symbols in asm-offsets.c

2016-06-01 Thread Rashmica Gupta
removed in commit 401d1f029beb ("[PATCH] syscall entry/exit revamp") CLONE_VM: Added in commit 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.") and currently unused. --- CLONE_UNTRACED: Added in commit 14cf11af6cf6 ("powerpc: Merge enough to sta

[PATCH 18/27] Add Book3s_64 offsets to asm-offsets.c

2009-10-30 Thread Alexander Graf
We need to access some VCPU fields from assembly code. In order to get the proper offsets, we have to define them in asm-offsets.c. Signed-off-by: Alexander Graf --- arch/powerpc/kernel/asm-offsets.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-11 Thread Geert Uytterhoeven
On Fri, 8 Feb 2008, Simon Holm Th�gersen wrote: > fre, 08 02 2008 kl. 12:06 -0600, skrev Paul Jackson: > > Linus wrote: > > > Please, when mentioning hex numbers, also do the one-liner shortlog. > > > ... > > > without _requiring_ people to be git users to get the gist of the > > > matter, ok? > >

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Simon Holm Thøgersen
fre, 08 02 2008 kl. 12:06 -0600, skrev Paul Jackson: > Linus wrote: > > Please, when mentioning hex numbers, also do the one-liner shortlog. > > ... > > without _requiring_ people to be git users to get the gist of the > > matter, ok? > > > Thanks for sticking up for us git-challenged contribut

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Paul Jackson
Thanks, Olof and Harvey. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h= Just what I was looking for. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.940.

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Harvey Harrison
On Fri, 2008-02-08 at 12:06 -0600, Paul Jackson wrote: > Linus wrote: > > Please, when mentioning hex numbers, also do the one-liner shortlog. > > ... > > without _requiring_ people to be git users to get the gist of the > > matter, ok? > > > Thanks for sticking up for us git-challenged contribu

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Olof Johansson
On Fri, Feb 08, 2008 at 12:21:54PM -0600, Olof Johansson wrote: > On Fri, Feb 08, 2008 at 12:06:23PM -0600, Paul Jackson wrote: > > Linus wrote: > > > Please, when mentioning hex numbers, also do the one-liner shortlog. > > > ... > > > without _requiring_ people to be git users to get the gist of t

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Olof Johansson
On Fri, Feb 08, 2008 at 12:06:23PM -0600, Paul Jackson wrote: > Linus wrote: > > Please, when mentioning hex numbers, also do the one-liner shortlog. > > ... > > without _requiring_ people to be git users to get the gist of the > > matter, ok? > > > Thanks for sticking up for us git-challenged c

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Paul Jackson
Linus wrote: > Please, when mentioning hex numbers, also do the one-liner shortlog. > ... > without _requiring_ people to be git users to get the gist of the > matter, ok? Thanks for sticking up for us git-challenged contributors. Can anyone point me at instructions providing the shortest path

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-07 Thread Linus Torvalds
On Fri, 8 Feb 2008, Paul Mackerras wrote: > > From: Tony Breeds <[EMAIL PROTECTED]> > > Commit ad7f71674ad7c3c4467e48f6ab9e85516dae2720 corrected the clock > .. Please, when mentioning hex numbers, also do the one-liner shortlog. I realize that in gitk (or even just with two terminal windows o

[PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-07 Thread Paul Mackerras
t; --- Linus, I'm sending you this as a patch since it touches generic code. Please apply, since mainline is broken for powerpc users who are using gcc-4.0 or earlier. diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c index e6e4928..4b749c4 100644 --- a/

Re: asm-offsets.c

2008-02-07 Thread Sean MacLennan
Benjamin Herrenschmidt wrote: > On Wed, 2008-02-06 at 23:43 -0500, Sean MacLennan wrote: > >> I just did a git pull of Josh's tree, and >> arch/powerpc/kernel/asm-offsets.c does not compile. I have only been >> glossing over the linuxppc-dev emails, so forgive m

Re: asm-offsets.c

2008-02-07 Thread Christoph Hellwig
On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: > I just did a git pull of Josh's tree, and > arch/powerpc/kernel/asm-offsets.c does not compile. I have only been > glossing over the linuxppc-dev emails, so forgive me if this already > came up. > > It l

Re: asm-offsets.c

2008-02-07 Thread Benjamin Herrenschmidt
On Wed, 2008-02-06 at 23:43 -0500, Sean MacLennan wrote: > I just did a git pull of Josh's tree, and > arch/powerpc/kernel/asm-offsets.c does not compile. I have only been > glossing over the linuxppc-dev emails, so forgive me if this already > came up. > > It looks

Re: asm-offsets.c

2008-02-06 Thread Sean MacLennan
Nathan Lynch wrote: > CLOCK_REALTIME_RES is defined in include/asm/asm-offsets.h, which is > generated from asm-offsets.c as part of the build. > > Your config builds fine here, so please post the actual error that you > are seeing during the build? > Mine is off one lin

Re: asm-offsets.c

2008-02-06 Thread Nathan Lynch
; > >>>> I just did a git pull of Josh's tree, and > >>>> arch/powerpc/kernel/asm-offsets.c does not compile. I have only been > >>>> glossing over the linuxppc-dev emails, so forgive me if this already > >>>> came up. > &g

Re: asm-offsets.c

2008-02-06 Thread Nathan Lynch
Christoph Hellwig wrote: > On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: > > I just did a git pull of Josh's tree, and > > arch/powerpc/kernel/asm-offsets.c does not compile. I have only been > > glossing over the linuxppc-dev emails, so forgive me if

Re: asm-offsets.c

2008-02-06 Thread Sean MacLennan
Christoph Hellwig wrote: > On Thu, Feb 07, 2008 at 12:49:34AM -0600, Nathan Lynch wrote: > >> Christoph Hellwig wrote: >> >>> On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: >>> >>>> I just did a git pull of Josh

Re: asm-offsets.c

2008-02-06 Thread Christoph Hellwig
On Thu, Feb 07, 2008 at 12:49:34AM -0600, Nathan Lynch wrote: > Christoph Hellwig wrote: > > On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: > > > I just did a git pull of Josh's tree, and > > > arch/powerpc/kernel/asm-offsets.c does not compile.

Re: asm-offsets.c

2008-02-06 Thread Sean MacLennan
Tony Breeds wrote: > Yeah it's needed, so this patch isn;t the best solution. I'll fix this > ASAP. > Great! Thanks a lot. Cheers, Sean ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: asm-offsets.c

2008-02-06 Thread Tony Breeds
On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: > I just did a git pull of Josh's tree, and > arch/powerpc/kernel/asm-offsets.c does not compile. I have only been > glossing over the linuxppc-dev emails, so forgive me if this already > came up. Hmm very so

Re: asm-offsets.c

2008-02-06 Thread Christoph Hellwig
On Wed, Feb 06, 2008 at 11:43:41PM -0500, Sean MacLennan wrote: > I just did a git pull of Josh's tree, and > arch/powerpc/kernel/asm-offsets.c does not compile. I have only been > glossing over the linuxppc-dev emails, so forgive me if this already > came up. I have the

asm-offsets.c

2008-02-06 Thread Sean MacLennan
I just did a git pull of Josh's tree, and arch/powerpc/kernel/asm-offsets.c does not compile. I have only been glossing over the linuxppc-dev emails, so forgive me if this already came up. It looks like, at least for the Warp, CLOCK_REALTIME_RES is not defined so asm-offsets.c gets an