On 08/01/2017 12:55 AM, Michael Ellerman wrote:
> Jens Axboe writes:
> ...
>>
>> Can you try the below fix? Should be more palatable than the previous
>> one. Brian, maybe you can take a look at the IRQ issue mentioned above?
>
> Given the patch from Brian fixed the lockdep
Jens Axboe writes:
...
>
> Can you try the below fix? Should be more palatable than the previous
> one. Brian, maybe you can take a look at the IRQ issue mentioned above?
Given the patch from Brian fixed the lockdep warning, do you still want
me to try and test this one?
cheers
Michael Ellerman writes:
> Brian King writes:
>
>> On 07/28/2017 10:17 AM, Brian J King wrote:
>>> Jens Axboe wrote on 07/28/2017 09:25:48 AM:
>>>
Can you try the below fix? Should be more palatable than the previous
Brian King writes:
> On 07/28/2017 10:17 AM, Brian J King wrote:
>> Jens Axboe wrote on 07/28/2017 09:25:48 AM:
>>
>>> Can you try the below fix? Should be more palatable than the previous
>>> one. Brian, maybe you can take a look at the IRQ issue
Jens Axboe wrote on 07/28/2017 09:25:48 AM:
> Can you try the below fix? Should be more palatable than the previous
> one. Brian, maybe you can take a look at the IRQ issue mentioned above?
Working on an ipr change to address the IRQ issue.
-Brian
On 07/28/2017 10:17 AM, Brian J King wrote:
> Jens Axboe wrote on 07/28/2017 09:25:48 AM:
>
>> Can you try the below fix? Should be more palatable than the previous
>> one. Brian, maybe you can take a look at the IRQ issue mentioned above?
Michael,
Does this address the issue
On 07/28/2017 09:13 AM, Bart Van Assche wrote:
> On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote:
>> On 07/28/2017 12:19 AM, Michael Ellerman wrote:
>>> OK, so the resolution is "fix it in IPR" ?
>>
>> I'll leave that to the SCSI crew. But at least one bug is in IPR, if you
>> look at the call
On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote:
> On 07/28/2017 12:19 AM, Michael Ellerman wrote:
> > OK, so the resolution is "fix it in IPR" ?
>
> I'll leave that to the SCSI crew. But at least one bug is in IPR, if you
> look at the call trace:
>
> - timer function triggers, runs
On 07/28/2017 12:19 AM, Michael Ellerman wrote:
> Jens Axboe writes:
>> On 07/27/2017 08:47 AM, Bart Van Assche wrote:
>>> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote:
The bug looks like SCSI running the queue inline from IRQ
context, that's not a good idea.
>
Jens Axboe writes:
> On 07/27/2017 08:47 AM, Bart Van Assche wrote:
>> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote:
>>> The bug looks like SCSI running the queue inline from IRQ
>>> context, that's not a good idea.
...
>>
>> scsi_run_queue() works fine if no scheduler is
On 07/27/2017 08:47 AM, Bart Van Assche wrote:
> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote:
>> The bug looks like SCSI running the queue inline from IRQ
>> context, that's not a good idea. Can you confirm the below works for
>> you?
>>
>>
>> diff --git a/drivers/scsi/scsi_lib.c
On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote:
> The bug looks like SCSI running the queue inline from IRQ
> context, that's not a good idea. Can you confirm the below works for
> you?
>
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index f6097b89d5d3..78740ebf966c
On 07/26/2017 11:10 PM, Michael Ellerman wrote:
> Hi Jens,
>
> I'm seeing the lockdep warning below on shutdown on a Power8 machine
> using IPR.
>
> If I'm reading it right it looks like the spin_lock() (non-irq) in
> blk_mq_sched_insert_request() is the immediate cause.
All the users of
Hi Jens,
I'm seeing the lockdep warning below on shutdown on a Power8 machine
using IPR.
If I'm reading it right it looks like the spin_lock() (non-irq) in
blk_mq_sched_insert_request() is the immediate cause.
Looking at blk_mq_requeue_work() (the caller), it is doing
spin_lock_irqsave(). So is
14 matches
Mail list logo