On Wed, Aug 27, 2008 at 09:49:44AM +0200, Wolfram Sang wrote:
> On Sat, Aug 23, 2008 at 10:57:21AM +0200, Arnd Bergmann wrote:
>
> > On Saturday 23 August 2008, Kevin Diggs wrote:
> > > WARNING: externs should be avoided in .c files
> > > #1137: FILE: powerpc/kernel/cpu/pll_if.c:369:
> > > +
On Sat, Aug 23, 2008 at 10:57:21AM +0200, Arnd Bergmann wrote:
> On Saturday 23 August 2008, Kevin Diggs wrote:
> > WARNING: externs should be avoided in .c files
> > #1137: FILE: powerpc/kernel/cpu/pll_if.c:369:
> > + __asm__ __volatile__ (
> >
> > ??? I don't know what this is?
> >
> > T
Kevin Diggs <[EMAIL PROTECTED]> wrote:
> The entire block is:
>
> __asm__ __volatile__ (
> "addi %0,%3,-1\n"
> "andc %1,%3,%0\n"
> "cntlzw %1,%1\n"
> "subfic %1,%1,31\n"
> "cntlzw %0,%2\n":
> "=r"(cntlz), "=
On Saturday 23 August 2008, Kevin Diggs wrote:
> WARNING: externs should be avoided in .c files
> #1137: FILE: powerpc/kernel/cpu/pll_if.c:369:
> + __asm__ __volatile__ (
>
> ??? I don't know what this is?
>
> The entire block is:
>
> __asm__ __volatile__ (
> "addi
On Fri, 22 Aug 2008 17:21:44 -0700
"Kevin Diggs" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Can I ignore these checkpatch errors:
>
> ERROR: do not initialise statics to 0 or NULL
> #829: FILE: powerpc/kernel/cpu/pll_if.c:61:
> +static unsigned int override_bus_clock = 0;
>
> ERROR: do not initialise
Hi,
Can I ignore these checkpatch errors:
ERROR: do not initialise statics to 0 or NULL
#829: FILE: powerpc/kernel/cpu/pll_if.c:61:
+static unsigned int override_bus_clock = 0;
ERROR: do not initialise externals to 0 or NULL
#1281: FILE: powerpc/kernel/cpu/pll_if.c:513:
+int rval = 0;
Someone
