Re: ethtool occationally fails to communicate with with ucc_geth

2013-02-06 Thread Lennart Sorensen
On Wed, Feb 06, 2013 at 09:08:32PM +, Ben Hutchings wrote: > This seems to be a workaround for a bug in phylib: phy_state_machine() > calls netif_carrier_on() before adjust_link(), so the TX scheduler can > start immediately even though the MAC has not been configured. > > A better workaround

Re: ethtool occationally fails to communicate with with ucc_geth

2013-02-06 Thread Ben Hutchings
On Wed, 2013-02-06 at 15:05 -0500, Lennart Sorensen wrote: > We are occationally seeing ethtool fail to communicate with ucc_geth. > I think I have tracked down why it happens, but I don't see a good way > to fix it. > > When the phy state changes, adjust_link() checks if the state has changed > a

ethtool occationally fails to communicate with with ucc_geth

2013-02-06 Thread Lennart Sorensen
We are occationally seeing ethtool fail to communicate with ucc_geth. I think I have tracked down why it happens, but I don't see a good way to fix it. When the phy state changes, adjust_link() checks if the state has changed and if the link is up. If it is it does: if (new_state