Re: hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-05 Thread Michael Ellerman
On Wed, 2016-02-03 at 09:55:17 UTC, Ravi Bangoria wrote: > At a time of destroying hw_breakpoint event, kernel ends up with Oops. > Here is the sample output from 4.5.0-rc6 kernel. I merged the revised version, as discussed with peterz. https://git.kernel.org/powerpc/c/fb822e6076d972691c5dd33431

Re: hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-04 Thread Michael Ellerman
On Thu, 2016-03-03 at 11:20 +0100, Peter Zijlstra wrote: > On Thu, Mar 03, 2016 at 08:23:38PM +1100, Michael Ellerman wrote: > > On Wed, 2016-03-02 at 12:59 +0100, Peter Zijlstra wrote: > > Indeed, but if there's a preemption point in between setting and using > that state, the ctx->task pointer

Re: hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-03 Thread Peter Zijlstra
On Thu, Mar 03, 2016 at 08:23:38PM +1100, Michael Ellerman wrote: > On Wed, 2016-03-02 at 12:59 +0100, Peter Zijlstra wrote: > > > On Wed, Mar 02, 2016 at 10:53:24PM +1100, Michael Ellerman wrote: > > > > Peterz, acme, do you guys want to take this? Or should I? > > > > I'm not too happy its

Re: hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-03 Thread Michael Ellerman
On Wed, 2016-03-02 at 12:59 +0100, Peter Zijlstra wrote: > On Wed, Mar 02, 2016 at 10:53:24PM +1100, Michael Ellerman wrote: > > Peterz, acme, do you guys want to take this? Or should I? > > I'm not too happy its touching event->ctx at all. It really should not > be doing that. Hmm OK. It's

Re: hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-02 Thread Peter Zijlstra
On Wed, Mar 02, 2016 at 10:53:24PM +1100, Michael Ellerman wrote: > Peterz, acme, do you guys want to take this? Or should I? I'm not too happy its touching event->ctx at all. It really should not be doing that. ___ Linuxppc-dev mailing list

Re: hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-02 Thread Michael Ellerman
Hi Ravi, On Wed, 2016-02-03 at 09:55:17 UTC, Ravi Bangoria wrote: > At a time of destroying hw_breakpoint event, kernel ends up with Oops. > Here is the sample output from 4.5.0-rc6 kernel. It's nice to trim the oops a bit, the time stamps aren't useful. And the full GPRs is probably not useful

Re: [PATCH] hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-02 Thread Peter Zijlstra
On Wed, Mar 02, 2016 at 03:25:17PM +0530, Ravi Bangoria wrote: > At a time of destroying hw_breakpoint event, kernel ends up with Oops. > Here is the sample output from 4.5.0-rc6 kernel. > Call chain: > > hw_breakpoint_event_init() > bp->destroy = bp_perf_event_destroy; > > do_exit() >

[PATCH] hw_breakpoint: Fix Oops at destroying hw_breakpoint event on powerpc

2016-03-02 Thread Ravi Bangoria
At a time of destroying hw_breakpoint event, kernel ends up with Oops. Here is the sample output from 4.5.0-rc6 kernel. [ 450.708568] Unable to handle kernel paging request for data at address 0x0c07 [ 450.708684] Faulting instruction address: 0xc00291d0 [ 450.708750] Oops: