Re: linux-next bad Kconfig for drivers/hid

2011-12-15 Thread Jiri Kosina
On Mon, 12 Dec 2011, Tony Breeds wrote: On Mon, Dec 12, 2011 at 12:21:16AM +0100, Jiri Kosina wrote: On Thu, 8 Dec 2011, Jeremy Fitzhardinge wrote: Hm. How about making it depends on HID POWER_SUPPLY? I think that would needlessly disable it if HID is also modular, but I'm not

Re: linux-next bad Kconfig for drivers/hid

2011-12-15 Thread Randy Dunlap
On 12/15/2011 02:08 AM, Jiri Kosina wrote: On Mon, 12 Dec 2011, Tony Breeds wrote: On Mon, Dec 12, 2011 at 12:21:16AM +0100, Jiri Kosina wrote: On Thu, 8 Dec 2011, Jeremy Fitzhardinge wrote: Hm. How about making it depends on HID POWER_SUPPLY? I think that would needlessly disable it if

Re: linux-next bad Kconfig for drivers/hid

2011-12-15 Thread Tony Breeds
On Thu, Dec 15, 2011 at 11:08:08AM +0100, Jiri Kosina wrote: Tony, have you actually tested this one to work in the configuration you have been seeing it to fail? I don't seem to be able to find any use of '==' in other Kconfig files (and never used it myself), so I'd like to have

Re: linux-next bad Kconfig for drivers/hid

2011-12-11 Thread Jiri Kosina
On Thu, 8 Dec 2011, Jeremy Fitzhardinge wrote: Commit 4f5ca836bef3 (HID: hid-input: add support for HID devices reporting Battery Strength) went into linux-next on Dec 1st since then a ppc6xx_defconfig has been failing with: --- drivers/built-in.o: In function

Re: linux-next bad Kconfig for drivers/hid

2011-12-11 Thread Tony Breeds
On Mon, Dec 12, 2011 at 12:21:16AM +0100, Jiri Kosina wrote: On Thu, 8 Dec 2011, Jeremy Fitzhardinge wrote: Hm. How about making it depends on HID POWER_SUPPLY? I think that would needlessly disable it if HID is also modular, but I'm not sure how to fix that. depends on HID

Re: linux-next bad Kconfig for drivers/hid

2011-12-09 Thread Randy Dunlap
On Thu, December 8, 2011 9:33 pm, Jeremy Fitzhardinge wrote: On 12/08/2011 05:27 PM, Tony Breeds wrote: Commit 4f5ca836bef3 (HID: hid-input: add support for HID devices reporting Battery Strength) went into linux-next on Dec 1st since then a ppc6xx_defconfig has been failing with: ---

linux-next bad Kconfig for drivers/hid

2011-12-08 Thread Tony Breeds
Commit 4f5ca836bef3 (HID: hid-input: add support for HID devices reporting Battery Strength) went into linux-next on Dec 1st since then a ppc6xx_defconfig has been failing with: --- drivers/built-in.o: In function `hidinput_cleanup_battery': /scratch/tony/working/drivers/hid/hid-input.c:351:

Re: linux-next bad Kconfig for drivers/hid

2011-12-08 Thread Jeremy Fitzhardinge
On 12/08/2011 05:27 PM, Tony Breeds wrote: Commit 4f5ca836bef3 (HID: hid-input: add support for HID devices reporting Battery Strength) went into linux-next on Dec 1st since then a ppc6xx_defconfig has been failing with: --- drivers/built-in.o: In function `hidinput_cleanup_battery':