Re: ppc_set_hwdebug vs ptrace_set_debugreg

2011-01-02 Thread K.Prasad
On Thu, Dec 16, 2010 at 06:07:47PM +0100, Andreas Schwab wrote: K.Prasad pra...@linux.vnet.ibm.com writes: How about the revised patch below? It is only compile-tested; have you got a quick test case that I can run? It crashes the kernel when running the watch-vfork test. Andreas.

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2011-01-02 Thread Andreas Schwab
K.Prasad pra...@linux.vnet.ibm.com writes: The watch-vfork test actually fails on my system (4 unexpected failures) It should pass all four tests. If gdb cannot even set a watchpoint it cannot trigger the crash, of course. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-12-16 Thread Andreas Schwab
K.Prasad pra...@linux.vnet.ibm.com writes: How about the revised patch below? It is only compile-tested; have you got a quick test case that I can run? It crashes the kernel when running the watch-vfork test. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-12-14 Thread K.Prasad
On Mon, Dec 13, 2010 at 08:05:36PM +0100, Andreas Schwab wrote: K.Prasad pra...@linux.vnet.ibm.com writes: +#ifdef CONFIG_HAVE_HW_BREAKPOINT + /* Create a new breakpoint request if one doesn't exist already */ + hw_breakpoint_init(attr); + attr.bp_addr = bp_info-addr

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-12-14 Thread Andreas Schwab
K.Prasad pra...@linux.vnet.ibm.com writes: How about the revised patch below? It is only compile-tested; have you got a quick test case that I can run? Try the watchpoint tests in gdb. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-12-13 Thread K.Prasad
On Wed, Dec 01, 2010 at 10:07:58AM +0530, K.Prasad wrote: On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andreas Schwab wrote: K.Prasad pra...@linux.vnet.ibm.com writes: Although ppc_set_hwdebug() can set DABR through set_dabr() in arch/powerpc/kernel/process.c, it is good to have it

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-12-13 Thread Andreas Schwab
K.Prasad pra...@linux.vnet.ibm.com writes: +#ifdef CONFIG_HAVE_HW_BREAKPOINT + /* Create a new breakpoint request if one doesn't exist already */ + hw_breakpoint_init(attr); + attr.bp_addr = bp_info-addr ~HW_BREAKPOINT_ALIGN; + arch_bp_generic_fields(bp_info-addr +

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-11-30 Thread K.Prasad
On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andreas Schwab wrote: K.Prasad pra...@linux.vnet.ibm.com writes: Although ppc_set_hwdebug() can set DABR through set_dabr() in arch/powerpc/kernel/process.c, it is good to have it converted to use register_user_hw_breakpoint(). What do you mean

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-11-29 Thread Andreas Schwab
K.Prasad pra...@linux.vnet.ibm.com writes: Although ppc_set_hwdebug() can set DABR through set_dabr() in arch/powerpc/kernel/process.c, it is good to have it converted to use register_user_hw_breakpoint(). What do you mean with good to have? It doesn't work without it unless I disable

Re: ppc_set_hwdebug vs ptrace_set_debugreg

2010-11-28 Thread K.Prasad
On Sat, Nov 27, 2010 at 08:36:30PM +0100, Andreas Schwab wrote: Why does ptrace_set_debugreg call register_user_hw_breakpoint, but ppc_set_hwdebug doesn't? Shouldn't ppc_set_hwdebug set the DABR_DATA_(READ|WRITE|TRANSLATION) bits in the dabr? Andreas. The hw-breakpoint interfaces were

ppc_set_hwdebug vs ptrace_set_debugreg

2010-11-27 Thread Andreas Schwab
Why does ptrace_set_debugreg call register_user_hw_breakpoint, but ppc_set_hwdebug doesn't? Shouldn't ppc_set_hwdebug set the DABR_DATA_(READ|WRITE|TRANSLATION) bits in the dabr? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B