Re: remove a few uses of ->queuedata

2020-05-13 Thread Dan Williams
On Tue, May 12, 2020 at 1:08 AM Christoph Hellwig wrote: > > On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > > which are all used in the I/O submission path (generic_make_request / > > > generic_make_request_checks). This is mostly a prep cleanup patch to > > > also remove the

Re: remove a few uses of ->queuedata

2020-05-12 Thread Christoph Hellwig
On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > which are all used in the I/O submission path (generic_make_request / > > generic_make_request_checks). This is mostly a prep cleanup patch to > > also remove the pointless queue argument from ->make_request - then > > ->queue is

Re: remove a few uses of ->queuedata

2020-05-09 Thread Dan Williams
On Sat, May 9, 2020 at 1:24 AM Christoph Hellwig wrote: > > On Fri, May 08, 2020 at 11:04:45AM -0700, Dan Williams wrote: > > On Fri, May 8, 2020 at 9:16 AM Christoph Hellwig wrote: > > > > > > Hi all, > > > > > > various bio based drivers use queue->queuedata despite already having > > > set up

Re: remove a few uses of ->queuedata

2020-05-09 Thread Christoph Hellwig
On Sat, May 09, 2020 at 06:13:21AM +0800, Ming Lei wrote: > On Fri, May 08, 2020 at 06:15:02PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > various bio based drivers use queue->queuedata despite already having > > set up disk->private_data, which can be used just as easily. This > >

Re: remove a few uses of ->queuedata

2020-05-09 Thread Christoph Hellwig
On Fri, May 08, 2020 at 11:04:45AM -0700, Dan Williams wrote: > On Fri, May 8, 2020 at 9:16 AM Christoph Hellwig wrote: > > > > Hi all, > > > > various bio based drivers use queue->queuedata despite already having > > set up disk->private_data, which can be used just as easily. This > > series

Re: remove a few uses of ->queuedata

2020-05-08 Thread Ming Lei
On Fri, May 08, 2020 at 06:15:02PM +0200, Christoph Hellwig wrote: > Hi all, > > various bio based drivers use queue->queuedata despite already having > set up disk->private_data, which can be used just as easily. This > series cleans them up to only use a single private data pointer. > >

Re: remove a few uses of ->queuedata

2020-05-08 Thread Dan Williams
On Fri, May 8, 2020 at 9:16 AM Christoph Hellwig wrote: > > Hi all, > > various bio based drivers use queue->queuedata despite already having > set up disk->private_data, which can be used just as easily. This > series cleans them up to only use a single private data pointer. ...but isn't the

remove a few uses of ->queuedata

2020-05-08 Thread Christoph Hellwig
Hi all, various bio based drivers use queue->queuedata despite already having set up disk->private_data, which can be used just as easily. This series cleans them up to only use a single private data pointer. blk-mq based drivers that have code pathes that can't easily get at the gendisk are