Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-18 Thread Kumar Gala
On Jul 17, 2007, at 10:30 PM, Segher Boessenkool wrote: A: They haven't been posted yet. Q: How do we know Segher has new patches? He sent it to me to test, and I told him it worked... And I sent it to the list hours later, over a week ago. Can someone send a ozlabs linuxppc list link

Re: [PATCH 01/61] Use strcasecmp() rather than strncasecmp() when determining device node compatibility.

2007-07-18 Thread Stephen Rothwell
On Tue, 17 Jul 2007 20:31:37 -0500 Scott Wood [EMAIL PROTECTED] wrote: The current code assumes foo-bar must always be compatible with a node compatible with foo, which breaks device trees where this is not so. This should (at least partly) wait for the OF consolidation patches (coming

Re: [PATCH 07/61] bootwrapper: Set timebase_period_ns from dt_fixup_cpu_clocks.

2007-07-18 Thread Stephen Rothwell
On Tue, 17 Jul 2007 20:33:04 -0500 Scott Wood [EMAIL PROTECTED] wrote: void dt_fixup_cpu_clocks(u32 cpu, u32 tb, u32 bus) { + extern unsigned long timebase_period_ns; Why isn't this declared in a header file somewhere? -- Cheers, Stephen Rothwell[EMAIL PROTECTED]

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-18 Thread pradeep singh
On 7/18/07, Andy Fleming [EMAIL PROTECTED] wrote: phy_read() returns a negative number if there's an error, but the error-checking code in the Vitesse driver's config_intr function triggers if phy_read() returns non-zero. Correct that. Signed-off-by: Andy Fleming [EMAIL PROTECTED] --- I

[PATCH 2/2] fix showing xmon help

2007-07-18 Thread Ishizaki Kou
In some configuration, xmon help string is larger than xmon_printf buffer. We need not to use printf. This patch adds xmon_puts and change to use it to show help string. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] --- This patch depends on [PATCH 1/2]. Index:

[PATCH 1/2] Make xmon_write accept a const buffer

2007-07-18 Thread Ishizaki Kou
Because xmon_write doesn't change the buffer, we should add 'const' qualifier to the argument which points it. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] --- Index: linux-powerpc-git/arch/powerpc/xmon/start.c === ---

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Vitaly Bordug
Overall looks good, though mentioned mutually exclusive SoC devices adding some pain and extra code having relevant parts removed but not covered (see below). I think it makes sense to work ontop of this code to address known quirks/issues though, hence will cover this. yet, there are little

Re: [PATCH 51/61] cpm_uart: Be an of_platform device when using arch/powerpc.

2007-07-18 Thread Vitaly Bordug
On Tue, 17 Jul 2007 20:36:06 -0500 Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it has been removed, and the serial driver now talks to the device tree directly. The non-CONFIG_PPC_MERGE code can do away once CPM platforms are dropped from

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 18 July 2007, Kumar Gala wrote: M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] We get the following compile error if CONFIG_BLOCK isn't enabled: CC arch/powerpc/kernel/setup_32.o In file included from arch/powerpc/kernel/setup_32.c:14:

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-18 Thread Segher Boessenkool
A: They haven't been posted yet. Q: How do we know Segher has new patches? He sent it to me to test, and I told him it worked... And I sent it to the list hours later, over a week ago. Can someone send a ozlabs linuxppc list link or patchworks to the new patch.

Re: [PATCH 38/61] cpm2: Update device trees.

2007-07-18 Thread Vitaly Bordug
On Tue, 17 Jul 2007 20:35:50 -0500 Scott Wood wrote: + fsl,cpm-uart; reg = 11a00 20 8000 100; - current-speed = 1c200; Hmm, how is it supposed to work without speed? I was testing my u-boot OF

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic (IPv6)

2007-07-18 Thread Jan-Bernd Themann
Hi, I suggest we keep the interface open for IPv6 support by adding an additional parameter but first just get IPv4 support only into the kernel. IPv6 support can then incrementially be added. Would that be ok? On Sunday 15 July 2007 11:40, David Miller wrote: From: Christoph Hellwig [EMAIL

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-18 Thread Segher Boessenkool
Yes, I shouldn't say defaulted -- a unit interrupt specifier simply has no unit address part, in an interrupt domain that doesn't correspond to a normal bus. But saying it like this is a little bit inexact, and it uses more words. which is why I tend to prefer having it explicitely in the

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-18 Thread Segher Boessenkool
See above. Besides, as I said, default values are crap. And no, it's not obvious which nodes define a physical address space or not, at least not for a generic parser. The obvious way (which indeed isn't what the suggested algorithm does -- but the suggested algorithm doesn't do

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 18 July 2007, Kumar Gala wrote: M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] We get the following compile error if CONFIG_BLOCK isn't enabled: CC arch/powerpc/kernel/setup_32.o In file

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 7:07 AM, Segher Boessenkool wrote: A: They haven't been posted yet. Q: How do we know Segher has new patches? He sent it to me to test, and I told him it worked... And I sent it to the list hours later, over a week ago. Can someone send a ozlabs linuxppc list link

Re: [PATCH] PPC: Prevent direct inclusion of asm/rwsem.h.

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 8:36 AM, Robert P. J. Day wrote: Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Can you provide some commit description as to why we are doing this? - k --- not compile-tested, so if there's a flaw here somewhere, feel free to tweak it. arch/ppc/syslib/ocp.c

Re: [PATCH 28/61] Add cpm2_set_pin().

2007-07-18 Thread Kumar Gala
On Jul 17, 2007, at 8:35 PM, Scott Wood wrote: This provides a generic way for board code to set up CPM pins, rather than directly poking magic values into registers. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- arch/powerpc/sysdev/cpm2_common.c | 28

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jan Engelhardt
On Jul 16 2007 18:15, Geert Uytterhoeven wrote: Add a Disk Storage Driver for the PS3: - Implemented as a block device driver with a dynamic major - Disk names (and partitions) are of the format ps3d%c(%u) - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Geert Uytterhoeven
On Wed, 18 Jul 2007, Jan Engelhardt wrote: On Jul 16 2007 18:15, Geert Uytterhoeven wrote: Add a Disk Storage Driver for the PS3: - Implemented as a block device driver with a dynamic major - Disk names (and partitions) are of the format ps3d%c(%u) - Uses software scatter-gather with a

Re: [PATCH 2/2] fix showing xmon help

2007-07-18 Thread Milton Miller
On Wed Jul 18 19:26:40 EST 2007, Ishizaki Kou wrote: In some configuration, xmon help string is larger than xmon_printf buffer. We need not to use printf. This patch adds xmon_puts and change to use it to show help string. [Since I'm requesting changes I'll suggest a new change log.] In some

Re: [PATCH 22/61] Rename mpc82xx_ads to mpc8272ads.

2007-07-18 Thread Scott Wood
Mark Zhan wrote: Scott, It seems the old name mpc82xx ads is still used in your code. It will be nice that your file name match your code name, you know, less confusion. See patch 24. AIUI, it's generally preferred when moving large chunks of code to first have a patch that just moves it,

Re: PS3 Storage Driver O_DIRECT issue

2007-07-18 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Olaf Hering wrote: This driver (or the generic PS3 code) has appearently problems with O_DIRECT. glibc aborts parted because the malloc metadata get corrupted. While it is reproducible, the place where it crashes changes with every version of the debug attempt. I dont

Re: [PATCH 01/61] Use strcasecmp() rather than strncasecmp() when determining device node compatibility.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: Can these patches be broken into logical clumps? Probably... I just wanted to get them out there quickly as there've been numerous people lately inquiring about 82xx support and posting patches. Would be easier to review and obviously the fs_enet patches need to go via

Re: [PATCH] Add StorCenter DTS first draft.

2007-07-18 Thread Segher Boessenkool
+ compatible = storcenter; Needs a manufacturer name in there. Right. Will use: compatible = iomega,storcenter Okido. + PowerPC,603e { /* Really 8241 */ So say PowerPC,[EMAIL PROTECTED], or PowerPC,[EMAIL PROTECTED] (or whatever the CPU core in

Re: [PATCH 06/61] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: On Jul 17, 2007, at 8:33 PM, Scott Wood wrote: On arch/ppc, Soft_emulate_8xx was used when full math emulation was turned off to emulate a minimal subset of floating point load/store instructions, to avoid needing a soft-float toolchain. This function is called, but not

[PATCH 19/61] 8xx: Fix CONFIG_PIN_TLB.

2007-07-18 Thread Scott Wood
1. Only map 512K of the IMMR, rather than 8M, to avoid conflicting with the default ioremap region. 2. The wrong register was being loaded into SPRN_MD_RPN. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- Apparently I missed sending this one yesterday... arch/powerpc/kernel/head_8xx.S |8

Re: [PATCH 30/61] fsl_soc: Update the way get_brgfreq() finds things in the device tree.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts b/arch/powerpc/ boot/dts/mpc8272ads.dts index 4d09dca..16a77f4 100644 --- a/arch/powerpc/boot/dts/mpc8272ads.dts +++ b/arch/powerpc/boot/dts/mpc8272ads.dts @@ -119,12 +119,11 @@ #address-cells = 1;

Re: [PATCH 32/61] mpc82xx: Move PQ2 restart and halt functions out of mpc8272-specific code.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: Kill pq2_halt, if this is all it does just dont set ppc_md.halt() and get the generic behavior which is the same. OK. diff --git a/include/asm-ppc/immap_cpm2.h b/include/asm-ppc/ immap_cpm2.h index 3c23d9c..8795bcc 100644 --- a/include/asm-ppc/immap_cpm2.h +++

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: -#ifdef CONFIG_SERIAL_CPM_SMC1 - clrbits32(bcsr_io, BCSR1_RS232EN_1); - clrbits32(cp-cp_simode, 0xe000 17);/* brg1 */ - tmpval8 = in_8((cp-cp_smc[0].smc_smcm)) | (SMCM_RX | SMCM_TX); - out_8((cp-cp_smc[0].smc_smcm), tmpval8); -

Re: [PATCH 38/61] cpm2: Update device trees.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: On Tue, 17 Jul 2007 20:35:50 -0500 Scott Wood wrote: + fsl,cpm-uart; reg = 11a00 20 8000 100; - current-speed = 1c200; Hmm, how is it supposed to work without speed? I

Re: [PATCH 09/61] bootwrapper: Add dt_is_compatible().

2007-07-18 Thread Scott Wood
Milton Miller wrote: + for (pos = 0; pos + compat_len len; pos++) { + if (!strcmp(buf + pos, compat)) + return 1; + + while (buf[pos] pos + compat_len len) + pos++; This is buggy: if you are searching for

Re: [PATCH 28/61] Add cpm2_set_pin().

2007-07-18 Thread Scott Wood
Kumar Gala wrote: On Jul 17, 2007, at 8:35 PM, Scott Wood wrote: + +struct cpm2_ioports { +u32dir, par, sor, odr, dat; __be32? OK. +u32res[3]; +}; + +void cpm2_set_pin(int port, int pin, int flags) Can we make the function take a pointer to the port directly? I'd

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: On Wed, 18 Jul 2007 11:40:07 -0500 Scott Wood wrote: The CPM reset should take care of that. IIRC we had CPM reset prior, and it didn't help, making all those stuff added. You previously only did the CPM reset when CONFIG_UCODE_PATH was enabled. I saw the same

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-18 Thread Andy Fleming
On Jul 18, 2007, at 02:00, pradeep singh wrote: On 7/18/07, Andy Fleming [EMAIL PROTECTED] wrote: - if (err) + if (err 0) return err; but would that mean, if phy_read returns 0 it is a success? Yes. phy_read() returns a 32-bit value.

[PATCH] make powerpc pci compile again

2007-07-18 Thread Johannes Berg
Looks like we got a new declaration in the generic header... This fixes compile but I don't know whether it's correct. --- arch/powerpc/kernel/pci-common.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) --- linux-2.6-git.orig/arch/powerpc/kernel/pci-common.c 2007-07-17

Re: [PATCH 06/61] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 11:22 AM, Scott Wood wrote: Kumar Gala wrote: On Jul 17, 2007, at 8:33 PM, Scott Wood wrote: On arch/ppc, Soft_emulate_8xx was used when full math emulation was turned off to emulate a minimal subset of floating point load/store instructions, to avoid needing a

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Vitaly Bordug
On Wed, 18 Jul 2007 11:40:07 -0500 Scott Wood wrote: Vitaly Bordug wrote: -#ifdef CONFIG_SERIAL_CPM_SMC1 - clrbits32(bcsr_io, BCSR1_RS232EN_1); - clrbits32(cp-cp_simode, 0xe000 17);/* brg1 */ - tmpval8 = in_8((cp-cp_smc[0].smc_smcm)) | (SMCM_RX | SMCM_TX); -

Re: [PATCH 52/61] cpm_uart: Issue STOP_TX command before initializing console.

2007-07-18 Thread Vitaly Bordug
On Wed, 18 Jul 2007 11:35:58 -0500 Scott Wood wrote: Vitaly Bordug wrote: + cpm_line_cr_cmd(pinfo, CPM_CR_STOP_TX); + I am recalling exactly the contrary patch that removes stuff to get the non-console UARTs work. Let's better revalidate this once other pieces will be in before

Re: [PATCH 46/61] mpc885ads: Rework initialization.

2007-07-18 Thread Scott Wood
Vitaly Bordug wrote: The conflict is in register space, not pins -- why would the smc1 pins matter? ok, I may have confused this with something else. Possibly the conflict between FEC2 and SMC2 (which is still done via kconfig option)? -Scott ___

Re: [PATCH 06/61] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: I don't see any reason to break people that might not have updated their toolchains. Full math emulation is still an option... There is no reason for us to drop a feature like this w/o some additional warning. ...as is arch/ppc, whose remaining life expectancy can

Re: [PATCH 53/61] 82xx: Set NOT_COHERENT_CACHE on 8272 with PCI.

2007-07-18 Thread Scott Wood
Kumar Gala wrote: On Jul 17, 2007, at 10:28 PM, David Gibson wrote: Hrm... I for one would be a lot more comfortable with this patch if you had a theoretical explanation for why it's necessary, in addition to the seems to fix things. Sure, so would I; I just wanted to point out the issue, and

Re: [patch 14/14] Bamboo zImage wrapper

2007-07-18 Thread Josh Boyer
On Wed, 2007-07-18 at 12:51 -0500, Josh Boyer wrote: Is there some reason they should not all be merged into this one platform file? they meaning what? I can understand wanting the dcr fixups as a library, but lets wait to do the file splits until there are actually users. Its also

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 July 2007, Kumar Gala wrote: On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 18 July 2007, Kumar Gala wrote: M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] We get the following compile error if CONFIG_BLOCK isn't enabled:

[PATCH] fix future firmware feature fixups function failure

2007-07-18 Thread Michael Neuling
Move firmware feature initialisation from pSeries_init_early to the earlier pSeries_probe_hypertas so they are initialised before firmware feature fixups are applied. Currently firmware feature sections are only used for iSeries which initialises the these features much earlier. This is a bug in

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic (IPv6)

2007-07-18 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Wed, 18 Jul 2007 15:00:59 +0200 Hi, I suggest we keep the interface open for IPv6 support by adding an additional parameter but first just get IPv4 support only into the kernel. IPv6 support can then incrementially be added. Would that be

Re: [PATCH 1/4] ibmveth: Enable TCP checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: This patchset enables TCP checksum offload support for IPV4 on ibmveth. This completely eliminates the generation and checking of the checksum for packets that are completely virtual and never touch a physical network. A simple TCP_STREAM netperf run on a virtual network

Re: [PATCH 4/4] ibmveth: Add ethtool driver stats hooks

2007-07-18 Thread Jeff Garzik
Brian King wrote: Add ethtool hooks to ibmveth to retrieve driver statistics. ACK patches 3-4 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] eHEA: Fix bonding support

2007-07-18 Thread Jeff Garzik
Thomas Klein wrote: The driver didn't allow an interface's MAC address to be modified if the respective interface wasn't setup - a failing Hcall was the result. Thus bonding wasn't usable. The fix moves the failing Hcall which was registering a MAC address for the reception of BC packets in

Re: [PATCH] fix future firmware feature fixups function failure

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Michael Neuling wrote: Move firmware feature initialisation from pSeries_init_early to the earlier pSeries_probe_hypertas so they are initialised before firmware feature fixups are applied. Currently firmware feature sections are only used for iSeries which

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:40 +0200 Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] Add a Disk Storage Driver for the PS3: Your patchset significantly hits powerpc, scsi and block. So who gets to merge this? Jens? James? Paul? Me, I guess ;) -

[PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:41 +0200 Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] Add a BD/DVD/CD-ROM Storage Driver for the PS3: - Implemented as a SCSI device driver - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor

Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-18 Thread Arnd Bergmann
On Wednesday 18 July 2007, Scott Wood wrote: +static struct cpm_pin mpc8272ads_pins[] = { +   /* SCC1 */ +   {3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY}, +   {3, 31, CPM_PIN_INPUT | CPM_PIN_PRIMARY}, + +   /* SCC4 */ +   {3, 21, CPM_PIN_OUTPUT | CPM_PIN_PRIMARY}, +  

Re: [PATCH 37/61] cpm2: Rework 8272ads initialization, and eliminate init_fcc_ioports().

2007-07-18 Thread Arnd Bergmann
On Thursday 19 July 2007, Arnd Bergmann wrote: I guess you considered moving such tables into the device tree at some point, which doesn't seem that difficult at all to an ignorant reviewer like me. What's the reasoning for putting it into the platform code after all? Ok, I think I found

Re: [PATCH 17/61] bootwrapper: Add 8xx support.

2007-07-18 Thread David Gibson
On Wed, Jul 18, 2007 at 11:13:05AM -0500, Scott Wood wrote: David Gibson wrote: On Tue, Jul 17, 2007 at 08:33:18PM -0500, Scott Wood wrote: [snip] diff --git a/arch/powerpc/boot/cuboot-8xx.c b/arch/powerpc/boot/cuboot-8xx.c new file mode 100644 index 000..35476a0 --- /dev/null +++

Re: [PATCH 2/15] boot: record header bytes in gunzip_start

2007-07-18 Thread David Gibson
On Tue, Jul 10, 2007 at 05:08:05PM -0500, Milton Miller wrote: Record the number of header bytes skipped in the total bytes read field. This is needed for the initramfs parsing code to find the end of the zip file. Signed-off-by: Milton Miller [EMAIL PROTECTED] Ok... I assume you've

Re: [PATCH 3/15] boot: simplfy gunzip_finish

2007-07-18 Thread David Gibson
On Tue, Jul 10, 2007 at 05:08:32PM -0500, Milton Miller wrote: Call gunzip_partial to calculate the remaining length and copy the data to the user buffer. This makes it shorter and reduces duplication. Signed-off-by: Milton Miller [EMAIL PROTECTED] Hrm... I guess this is sufficient.

Re: [PATCH] fix future firmware feature fixups function failure

2007-07-18 Thread Michael Neuling
On Wednesday 18 July 2007, Michael Neuling wrote: Move firmware feature initialisation from pSeries_init_early to the earlier pSeries_probe_hypertas so they are initialised before firmware feature fixups are applied. =20 Currently firmware feature sections are only used for iSeries which

Re: [PATCH 3/15] boot: simplfy gunzip_finish

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 9:39 PM, David Gibson wrote: On Tue, Jul 10, 2007 at 05:08:32PM -0500, Milton Miller wrote: Call gunzip_partial to calculate the remaining length and copy the data to the user buffer. This makes it shorter and reduces duplication. Signed-off-by: Milton Miller [EMAIL

Re: [PATCH 3/15] boot: simplfy gunzip_finish

2007-07-18 Thread David Gibson
On Wed, Jul 18, 2007 at 11:01:37PM -0500, Milton Miller wrote: On Jul 18, 2007, at 9:39 PM, David Gibson wrote: On Tue, Jul 10, 2007 at 05:08:32PM -0500, Milton Miller wrote: Call gunzip_partial to calculate the remaining length and copy the data to the user buffer. This makes it

Re: [PATCH 02/11] dtc: move declaration of yyerror

2007-07-18 Thread David Gibson
On Sat, Jul 07, 2007 at 01:18:47AM -0500, Milton Miller wrote: yyerror() is used by both dtc-parser.y and dtc-lexer.l, so move the declaration to srcpos.h. Signed-off-by: Milton Miller [EMAIL PROTECTED] --- eliminates implicit declaration warning. Eck. This wasn't necessary: that part of

Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 1:56 PM, Scott Wood wrote: Milton Miller wrote: In-Reply-To: [EMAIL PROTECTED] On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote: 1. ft_create_node was returning the internal pointer rather than a phandle. 2. ft_find_device_rel was treating lookups relative to root as an

Re: [PATCH 2/2] fix showing xmon help

2007-07-18 Thread Milton Miller
On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote: Milton Miller [EMAIL PROTECTED] writes: case '?': - printf(help_string); + xmon_puts(help_string); break; nonstdio.h #defines printf to xmon_printf.