Re: [PATCH v15 01/10] USB/ppc4xx: Add Synopsys DesignWare HS USB OTG Register definitions

2011-10-21 Thread Olof Johansson
On Fri, Oct 14, 2011 at 03:08:39PM -0700, tma...@apm.com wrote: > diff --git a/drivers/usb/dwc/regs.h b/drivers/usb/dwc/regs.h > new file mode 100644 > index 000..d3694f3 > --- /dev/null > +++ b/drivers/usb/dwc/regs.h > +#define DWC_GCTL_BSESSION_VALID_RW(reg, x) \ > + (((reg) & (~((u32)

Re: [PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver

2011-10-21 Thread Olof Johansson
On Fri, Oct 14, 2011 at 03:08:34PM -0700, tma...@apm.com wrote: > From: Tirumala Marri Overall this driver seems to be based on the IP vendor driver? It looks like a completely flexible driver that implements all possible combinations of everything. And as a result, it's huge, and it's got a lot

Re: [PATCH v15 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-10-21 Thread Olof Johansson
Hi, Some hit-and-run comments below. -Olof On Fri, Oct 14, 2011 at 03:08:49PM -0700, tma...@apm.com wrote: > diff --git a/drivers/usb/dwc/cil.h b/drivers/usb/dwc/cil.h > new file mode 100644 > index 000..8c29678 > --- /dev/null > +++ b/drivers/usb/dwc/cil.h > @@ -0,0 +1,1174 @@ > +/* > + *

Re: [PATCH v15 04/10] USB/ppc4xx: Add Synopsys DWC OTG HCD function

2011-10-21 Thread Olof Johansson
Some more hit-and-run comments. On Fri, Oct 14, 2011 at 03:08:53PM -0700, tma...@apm.com wrote: > +static int dwc_otg_hcd_disconnect_cb(void *_p) > +{ > + u32 intr; > + struct dwc_hcd *hcd = hcd_to_dwc_otg_hcd(_p); > + struct core_if *core_if = hcd->core_if; > + > + /* Set status f

Re: [PATCH] powerpc/fsl_msi: add support for "msi-address-64" property

2011-10-21 Thread Tabi Timur-B04825
On Fri, Oct 14, 2011 at 9:15 AM, Kumar Gala wrote: >> .../devicetree/bindings/powerpc/fsl/msi-pic.txt    |   42 >> >> arch/powerpc/sysdev/fsl_msi.c                      |   20 +++--- >> arch/powerpc/sysdev/fsl_msi.h                      |    3 +- >> 3 files changed, 57 i

RE: [PATCH 3/5][v2] fsl-rio: Add two ports and rapidio message units support

2011-10-21 Thread Liu Gang-B34182
Hi, Alex, Thanks for your comments, please find my replies inlines. -Original Message- From: Bounine, Alexandre [mailto:alexandre.boun...@idt.com] Sent: Thursday, October 20, 2011 3:54 AM To: Kumar Gala; linuxppc-...@ozlabs.org Cc: Andrew Morton; Liu Gang-B34182; linux-ker...@vger.kernel