Re: next/mmotm unbootable on G5: irqdomain

2012-07-22 Thread Benjamin Herrenschmidt
On Sat, 2012-07-21 at 19:47 -0700, Hugh Dickins wrote: I have to revert the patch below from mmotm 2012-07-20-16-30 or next-20120720 in order to boot on the PowerPC G5: otherwise it freezes before switching to the framebuffer console - but I'm not certain where because that initial console

Re: next/mmotm unbootable on G5: irqdomain

2012-07-22 Thread Hugh Dickins
On Sun, 22 Jul 2012, Benjamin Herrenschmidt wrote: On Sat, 2012-07-21 at 19:47 -0700, Hugh Dickins wrote: I have to revert the patch below from mmotm 2012-07-20-16-30 or next-20120720 in order to boot on the PowerPC G5: otherwise it freezes before switching to the framebuffer console - but

Re: [PATCH] powerpc: SMT priority (PPR) save and restore

2012-07-22 Thread Michael Neuling
Haren Myneni ha...@linux.vnet.ibm.com wrote: On Mon, 2012-07-16 at 13:41 +1000, Michael Neuling wrote: Heaven Myneni ha...@linux.vnet.ibm.com wrote: powerpc: SMT priority (PPR) save and restore snip Can you break this patch into a few parts that are easier to review than one giant

Re: [PATCH] powerpc: SMT priority (PPR) save and restore

2012-07-22 Thread Michael Neuling
Can you break this patch into a few parts that are easier to review than one giant patch. Start by adding the PPR ftr bits, then the extra space in the paca, then the new macros, then use the new infrastructure. I'm sure you can get 5 or so patches which will be much easier to

Re: [PATCH -V3 06/11] arch/powerpc: Make KERN_VIRT_SIZE not dependend on PGTABLE_RANGE

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:36PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com As we keep increasing PGTABLE_RANGE we need not increase the virual map area for kernel. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Reviewed-by:

Re: [PATCH -V3 10/11] arch/powerpc: Use 32bit array for slb cache

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:40PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With larger vsid we need to track more bits of ESID in slb cache for slb invalidate. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Minor comment

Re: [PATCH -V3 04/11] arch/powerpc: Rename va to vpn

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:34PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Rename the variable to better reflect the values. No functional change in this patch. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com I think you missed

Re: [PATCH -V3 02/11] arch/powerpc: Simplify hpte_decode

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:32PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch simplify hpte_decode for easy switching of virtual address to virtual page number in the later patch Signed-off-by: Aneesh Kumar K.V

Re: [PATCH -V3 01/11] arch/powerpc: Use hpt_va to compute virtual address

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:31PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Don't open code the same Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Reviewed-by: Paul Mackerras pau...@samba.org

Re: [PATCH -V3 09/11] arch/powerpc: Use 50 bits of VSID in slbmte

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:39PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Increase the number of valid VSID bits in slbmte instruction. We will use the new bits when we increase valid VSID bits. Signed-off-by: Aneesh Kumar K.V

Re: [PATCH -V3 07/11] arch/powerpc: Increase the slice range to 64TB

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:37PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch makes the high psizes mask as an unsigned char array so that we can have more than 16TB. Currently we support upto 64TB Some comments inline... @@ -804,16

Re: [PATCH -V3 03/11] arch/powerpc: Convert virtual address to vpn

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:33PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch convert different functions to take virtual page number instead of virtual address. Virtual page number is virtual address shifted right by VPN_SHIFT (12) bits.

Re: [PATCH -V3 11/11] arch/powerpc: Add 64TB support

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:41PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Increase max addressable range to 64TB. This is not tested on real hardware yet. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com ---

Re: [PATCH -V3 08/11] arch/powerpc: Make some of the PGTABLE_RANGE dependency explicit

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:38PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com slice array size and slice mask size depend on PGTABLE_RANGE. We can't directly include pgtable.h in these header because there is a circular dependency. So add compile

Re: [PATCH -V3 05/11] arch/powerpc: remove masking top 16 bit of va in tlb invalidate

2012-07-22 Thread Paul Mackerras
On Mon, Jul 09, 2012 at 06:43:35PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com ISA doc doesn't talk about this. As per ISA doc for a 4K page tlbie RB RS The Abbreviated Virtual Address (AVA) field in register RB must contain bits 14:65

Re: [PATCH -V3 05/11] arch/powerpc: remove masking top 16 bit of va in tlb invalidate

2012-07-22 Thread Benjamin Herrenschmidt
On Mon, 2012-07-23 at 09:56 +1000, Paul Mackerras wrote: That indicate we should not mask the top 16 bits. So remove the same. Older versions of the architecture (2.02 and earler) require the masking, so we can't just unconditionally remove it, since that would potentially break POWER5 and

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-22 Thread Rob Herring
On 07/18/2012 11:04 AM, Scott Wood wrote: On 07/17/2012 09:38 PM, Rob Herring wrote: On 07/17/2012 08:11 PM, Scott Wood wrote: Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 (of: match by compatible property first) breaks the gianfar ethernet driver found on various Freescale PPC chips.

Re: next/mmotm unbootable on G5: irqdomain

2012-07-22 Thread Benjamin Herrenschmidt
On Sat, 2012-07-21 at 19:47 -0700, Hugh Dickins wrote: I have to revert the patch below from mmotm 2012-07-20-16-30 or next-20120720 in order to boot on the PowerPC G5: otherwise it freezes before switching to the framebuffer console - but I'm not certain where because that initial console

[PATCH] powerpc: Update g5_defconfig

2012-07-22 Thread Benjamin Herrenschmidt
This updates the g5 defconfig to include nouveau instead of nvidiafb (which works much better nowadays, in fact the latter crashes on modern distros), and to set CONFIG_VT_HW_CONSOLE_BINDING without which takeover from the firmware offb by nouveau doesn't work properly (and leads to unexplained

Re: [PATCH -V3 05/11] arch/powerpc: remove masking top 16 bit of va in tlb invalidate

2012-07-22 Thread Paul Mackerras
On Mon, Jul 23, 2012 at 11:22:08AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-23 at 09:56 +1000, Paul Mackerras wrote: That indicate we should not mask the top 16 bits. So remove the same. Older versions of the architecture (2.02 and earler) require the masking, so we can't

[git pull] Please pull powerpc.git next branch

2012-07-22 Thread Benjamin Herrenschmidt
Hi Linus ! Here's the powerpc batch for 3.6 merge window. Notable highlights: - iommu improvements from Anton removing the per-iommu global lock in favor of dividing the DMA space into pools, each with its own lock, and hashed on the CPU number. Along with making the locking more fine grained,

Re: [PATCH -V3 02/11] arch/powerpc: Simplify hpte_decode

2012-07-22 Thread Aneesh Kumar K.V
Paul Mackerras pau...@samba.org writes: On Mon, Jul 09, 2012 at 06:43:32PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch simplify hpte_decode for easy switching of virtual address to virtual page number in the later patch Signed-off-by:

Re: [PATCH -V3 03/11] arch/powerpc: Convert virtual address to vpn

2012-07-22 Thread Aneesh Kumar K.V
Paul Mackerras pau...@samba.org writes: On Mon, Jul 09, 2012 at 06:43:33PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch convert different functions to take virtual page number instead of virtual address. Virtual page number is virtual