Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
Hi Bhushan, I'll revise some as you suggest. Just a few replies here. On Mon, Aug 19, 2013 at 12:38:11PM +0800, Bhushan Bharat-R65777 wrote: We here suppose the reset bit would be cleared -- The software reset will last 8 cycles. from RM, so if this happened to be a failure, the whole

RE: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Bhushan Bharat-R65777
-Original Message- From: Chen Guangyu-B42378 Sent: Monday, August 19, 2013 11:55 AM To: Bhushan Bharat-R65777 Cc: broo...@kernel.org; l...@metafoo.de; p.za...@pengutronix.de; s.ha...@pengutronix.de; mark.rutl...@arm.com; devicet...@vger.kernel.org; alsa- de...@alsa-project.org;

Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 02:31:47PM +0800, Bhushan Bharat-R65777 wrote: We here suppose the reset bit would be cleared -- The software reset will last 8 cycles. from RM, so if this happened to be a failure, the whole IP module won't be normally working as well. Also add a

[PATCH v7 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-19 Thread Nicolin Chen
Changelog: v6-v7: * Removed extra comma in array. * Revised some comments. * Added some dev_err(). * Check the return value of soft reset. * Use bitrev8() instead of extra reverse_bits(). * Use cache_bypass as default for regmap. v5-v6: * Sorted out rxtx clk source in DT binding. * Use

[PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 56 + sound/soc/fsl/Kconfig

[PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 +

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 09:35:21AM +0100, Nicolin Chen wrote: This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com ---

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 09:35:22AM +0100, Nicolin Chen wrote: This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com ---

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
Hi Mark, Thank you for the commenst. I'll Fix them in v8. Here are some remaining question: On Mon, Aug 19, 2013 at 10:18:09AM +0100, Mark Rutland wrote: +Required properties: + + - compatible : Compatible list, contains fsl,chip-spdif. What are valid values for chip? The

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mark Rutland
On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: Also I would make this option required. Use a dummy clock for mux inputs that are grounded for a

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
Hi, On Mon, Aug 19, 2013 at 10:24:58AM +0100, Mark Rutland wrote: Is this used semantically, or is it a completely arbitrary string? In either case I don't see why the compatible string doesn't give the driver enough to have a sensible value. I'm confused as to why we need this. The phrase

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 10:34:24AM +0100, Nicolin Chen wrote: Hi Mark, Thank you for the commenst. I'll Fix them in v8. Here are some remaining question: On Mon, Aug 19, 2013 at 10:18:09AM +0100, Mark Rutland wrote: +Required properties: + + - compatible : Compatible

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 10:50:43AM +0100, Nicolin Chen wrote: Hi, On Mon, Aug 19, 2013 at 10:24:58AM +0100, Mark Rutland wrote: Is this used semantically, or is it a completely arbitrary string? In either case I don't see why the compatible string doesn't give the driver enough to have

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-19 Thread Sudeep KarkadaNagesha
On 16/08/13 23:13, Benjamin Herrenschmidt wrote: On Fri, 2013-08-16 at 18:39 +0100, Sudeep KarkadaNagesha wrote: +static bool __of_find_n_match_cpu_property(struct device_node *cpun, + const char *prop_name, int cpu, unsigned int *thread) +{ + const __be32 *cell;

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote: I see, so 'Compatible list, must contains fsl,imx35-spdif' would be okay? While that needs to be mentioned, other values which might be present (e.g. fsl,imx6q-spdif) must be mentioned, or we can't rely on them if we want to use

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-19 Thread Deepthi Dharwar
Hi Dongsheng, On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: I think we should move the states and handle function to arch/power/platform* The states and handle function is belong to backend driver, not for this, different platform have different state. Different platforms to make

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-19 Thread Mark Rutland
On Sat, Aug 17, 2013 at 11:09:36PM +0100, Benjamin Herrenschmidt wrote: On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: I wonder how would this handle uniprocessor ARM (pre-v7) cores, for which the updated bindings[1] define #address-cells = 0 and so no reg property. [1] -

Re: [RFC PATCH v2 4/4] of: move of_get_cpu_node implementation to DT core library

2013-08-19 Thread Sudeep KarkadaNagesha
On 16/08/13 23:14, Benjamin Herrenschmidt wrote: On Fri, 2013-08-16 at 18:39 +0100, Sudeep KarkadaNagesha wrote: +#ifdef CONFIG_PPC + /* Check for historical ibm,ppc-interrupt-server#s property +* for thread ids on PowerPC. If it doesn't exist fallback to +

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: At least they are separate drivers as I mentioned in the commit comments. I'm not sure that the boundary of Linux drivers should necessarily determine the way we carve up the description of IP blocks, though presumably it's a

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Philipp Zabel
Am Montag, den 19.08.2013, 11:01 +0100 schrieb Mark Rutland: On Mon, Aug 19, 2013 at 10:50:43AM +0100, Nicolin Chen wrote: Hi, On Mon, Aug 19, 2013 at 10:24:58AM +0100, Mark Rutland wrote: Is this used semantically, or is it a completely arbitrary string? In either case I don't see

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Brown
On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: On Mon, Aug 19, 2013 at 10:50:43AM +0100, Nicolin Chen wrote: The phrase user-visible is being used in many current docs, I don't dare to change it unless a sage gives me a suggestion. I can see that there is entrenched usage,

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 11:13:04AM +0100, Nicolin Chen wrote: On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote: I see, so 'Compatible list, must contains fsl,imx35-spdif' would be okay? While that needs to be mentioned, other values which might be present (e.g.

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 11:21:06AM +0100, Nicolin Chen wrote: On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: At least they are separate drivers as I mentioned in the commit comments. I'm not sure that the boundary of Linux drivers should necessarily determine the way we

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Rutland
On Mon, Aug 19, 2013 at 11:52:01AM +0100, Mark Brown wrote: On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: On Mon, Aug 19, 2013 at 10:50:43AM +0100, Nicolin Chen wrote: The phrase user-visible is being used in many current docs, I don't dare to change it unless a sage

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 12:13:49PM +0100, Mark Rutland wrote: + rxtx0-7 Clock source list for tx and rx clock. + This clock list should be identical to + the source list connecting to the spdif +

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Brown
On Mon, Aug 19, 2013 at 12:31:21PM +0100, Mark Rutland wrote: On Mon, Aug 19, 2013 at 11:52:01AM +0100, Mark Brown wrote: This is intended to allow userspace to distinguish between systems that are electrically identical but physically distinct, for example when multiple systems are

Re: [PATCH] powerpc: add the missing required isync for the coherent icache flush

2013-08-19 Thread Kevin Hao
On Mon, Aug 19, 2013 at 01:37:17PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2013-08-19 at 13:36 +1000, Benjamin Herrenschmidt wrote: The semantic of this function is to make data executable. Even if the implementation has a snooping icache, it *still* needs to make sure prefetched

[PATCH v8 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-19 Thread Nicolin Chen
Changelog: v7-v8: * Revised DT binding doc. * Revised dev_err() error msg. * Check return value of clk_set_rate(). v6-v7: * Removed extra comma in array. * Revised some comments. * Added some dev_err(). * Check the return value of soft reset. * Use bitrev8() instead of extra

[PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 +

[PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 54 + sound/soc/fsl/Kconfig

[PATCH v4 0/7] net: use platform_{get,set}_drvdata()

2013-08-19 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with pdev-dev, so we can directly pass a struct platform_device. changelog v4: remove modify about happy_meal_pci_probe happy_meal_pci_remove changelog v3:

[PATCH v4 2/7] net: ucc_geth: use platform_{get,set}_drvdata()

2013-08-19 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with ofdev-dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/net/ethernet/freescale/ucc_geth.c |3

[PATCH][RFC] pci: fsl: rework PCIe driver compatible with Layerscape

2013-08-19 Thread Minghuan Lian
The Freescale's Layerscape series processors will use ARM cores. The LS1's PCIe controllers is the same as T4240's. So it's better the PCIe controller driver can support PowerPC and ARM simultaneously. This patch is for this purpose. It derives the common functions from

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Sascha Hauer
Hi Nicolas, Some misc other comments inline. On Mon, Aug 19, 2013 at 08:08:48PM +0800, Nicolin Chen wrote: This patch implements a device-tree-only CPU DAI driver for Freescale + +struct fsl_spdif_priv { + struct spdif_mixer_control fsl_spdif_control; + struct snd_soc_dai_driver

Re: [PATCH] powerpc: add the missing required isync for the coherent icache flush

2013-08-19 Thread Benjamin Herrenschmidt
On Mon, 2013-08-19 at 19:50 +0800, Kevin Hao wrote: On Mon, Aug 19, 2013 at 01:37:17PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2013-08-19 at 13:36 +1000, Benjamin Herrenschmidt wrote: The semantic of this function is to make data executable. Even if the implementation has a

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-19 Thread Rob Herring
On 08/19/2013 05:19 AM, Mark Rutland wrote: On Sat, Aug 17, 2013 at 11:09:36PM +0100, Benjamin Herrenschmidt wrote: On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: I wonder how would this handle uniprocessor ARM (pre-v7) cores, for which the updated bindings[1] define #address-cells =

Re: [RFC PATCH v2 4/4] of: move of_get_cpu_node implementation to DT core library

2013-08-19 Thread Rob Herring
On 08/16/2013 12:39 PM, Sudeep KarkadaNagesha wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com This patch moves the generalized implementation of of_get_cpu_node from PowerPC to DT core library, thereby adding support for retrieving cpu node for a given logical cpu index on

[PATCH] i2c: powermac: fix return path on error

2013-08-19 Thread Wolfram Sang
We want to bail out immediately if i2c_add_adapter failed and not try to register child nodes with a nilled adapter structure. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-powermac.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child nodes in the core instead of doing this manually in each driver.

Re: [RFC PATCH v2 4/4] of: move of_get_cpu_node implementation to DT core library

2013-08-19 Thread Sudeep KarkadaNagesha
On 19/08/13 14:11, Rob Herring wrote: On 08/16/2013 12:39 PM, Sudeep KarkadaNagesha wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com This patch moves the generalized implementation of of_get_cpu_node from PowerPC to DT core library, thereby adding support for retrieving cpu

Re: [PATCH 1/8] powerpc/pseries: fix creation of loop in device node property list

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: The update_dt_prop helper function fails to set the IN/OUT parameter prop to NULL after a complete property has been parsed from the work area returned by the ibm,update-properties rtas function. This results in the property list of the device node

Re: [PATCH 2/8] powerpc/pseries: fix over writing of rtas return code in update_dt_node

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: The rc variable is initially used to store the return code from the ibm,update-properties rtas call which returns 0 or 1 on success. A return code of 1 indicates that ibm,update-properties must be called again for the node. However, the rc variable

Re: [PATCH 3/8] powerpc/pseries: pack update_props_workarea to map correctly to rtas buffer header

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: The work area buffer returned by the ibm,update-properties rtas call contains 20 bytes of header information prior to the property value descriptor data. Currently update_dt_node tries to advance over this header using sizeof(upwa). The

Re: [PATCH 4/8] powerpc/pseries: fix parsing of initial node path in update_dt_node

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: On the first call to ibm,update-properties for a node the first property returned is the full node path. Currently this is not parsed correctly by the update_dt_node function. Commit 2e9b7b0 attempted to fix this, but was incorrect as it made a

Re: [PATCH 5/8] powerpc/pseries: do all node initialization in dlpar_parse_cc_node

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: Currently the OF_DYNAMIC and kref initialization for a node happens in dlpar_attach_node. However, a node passed to dlpar_attach_node may be a tree containing child nodes, and no initialization traversal is done on the tree. Since the children

Re: [PATCH 6/8] powerpc/pseries: make dlpar_configure_connector parent node aware

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: Currently the device nodes created in the device subtree returned by a call to dlpar_configure_connector are all named in the root node. This is because the the node name in the work area returned by ibm,configure-connector rtas call only contains

Re: [PATCH 7/8] powerpc/pseries: add mising of_node_put in delete_dt_node

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: The node to be detached is retrieved via its phandle by a call to of_find_node_by_phandle which increments the ref count. We need a matching call to of_node_put to decrement the ref count and ensure the node is actually freed. Signed-off-by:

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-19 Thread Sudeep KarkadaNagesha
On 19/08/13 14:02, Rob Herring wrote: On 08/19/2013 05:19 AM, Mark Rutland wrote: On Sat, Aug 17, 2013 at 11:09:36PM +0100, Benjamin Herrenschmidt wrote: On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: I wonder how would this handle uniprocessor ARM (pre-v7) cores, for which the

Re: [PATCH 8/8] powerpc/pseries: child nodes are not detached by dlpar_detach_node

2013-08-19 Thread Nathan Fontenot
On 08/15/2013 12:23 AM, Tyrel Datwyler wrote: Calls to dlpar_detach_node do not iterate over child nodes detaching them as well. By iterating and detaching the child nodes we ensure that they have the OF_DETACHED flag set and that their reference counts are decremented such that the node will

Re: [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places

2013-08-19 Thread Toshi Kani
On Sat, 2013-08-17 at 16:15 -0700, Greg KH wrote: On Sat, Aug 17, 2013 at 01:46:57PM -0600, Toshi Kani wrote: lock_device_hotplug() serializes CPU Memory online/offline and hotplug operations. However, this lock is not held in the debug interfaces below that initiate CPU online/offline

Re: [PATCH 0/4] Unify CPU hotplug lock interface

2013-08-19 Thread Toshi Kani
On Sun, 2013-08-18 at 03:02 +0200, Rafael J. Wysocki wrote: On Saturday, August 17, 2013 01:46:55 PM Toshi Kani wrote: lock_device_hotplug() was recently introduced to serialize CPU Memory online/offline and hotplug operations, along with sysfs online interface restructure (commit

Re: [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()

2013-08-19 Thread Nathan Fontenot
On 08/17/2013 02:46 PM, Toshi Kani wrote: cpu_hotplug_driver_lock() serializes CPU online/offline operations when ARCH_CPU_PROBE_RELEASE is set. This lock interface is no longer necessary with the following reason: - lock_device_hotplug() now protects CPU online/offline operations,

Re: [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()

2013-08-19 Thread Toshi Kani
On Mon, 2013-08-19 at 10:20 -0500, Nathan Fontenot wrote: On 08/17/2013 02:46 PM, Toshi Kani wrote: cpu_hotplug_driver_lock() serializes CPU online/offline operations when ARCH_CPU_PROBE_RELEASE is set. This lock interface is no longer necessary with the following reason: -

Re: [RFC PATCH v2 00/11] Add (de)compression support to pstore

2013-08-19 Thread Tony Luck
On Sat, Aug 17, 2013 at 11:32 AM, Kees Cook keesc...@chromium.org wrote: Yeah, this is great. While I haven't tested it myself yet, the code seems to be in good shape. I acked the ram piece separately, but consider the entire series: Reviewed-by: Kees Cook keesc...@chromium.org Applied.

[PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child nodes in the core instead of doing this manually in each driver.

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-19 Thread Scott Wood
On Mon, 2013-08-19 at 15:48 +0530, Deepthi Dharwar wrote: Hi Dongsheng, On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: I think we should move the states and handle function to arch/power/platform* The states and handle function is belong to backend driver, not for this,

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
However this patch fails to apply onto either v3.11-rc4 or v3.11-rc6: Argh, did not drop the MPC patch before rebasing :( So either pick the patch i2c: powermac: fix return path on error before, pull the branch [1], or force me to resend ;) Thanks! [1]

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Felipe Balbi
On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child

Re: Critical Interrupt Input

2013-08-19 Thread Benjamin Herrenschmidt
On Mon, 2013-08-19 at 12:00 -0700, Henry Bausley wrote: Support does appear to be present but there is a problem returning back to user space I suspect. Probably a problem with TLB misses vs. crit interrupts. A critical interrupt can re-enter a TLB miss. I can see two potential issues

Re: Critical Interrupt Input

2013-08-19 Thread Denis Kirjanov
The easy thing is to start to experimenting with scratch/preserve registers :) On 8/20/13, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2013-08-19 at 12:00 -0700, Henry Bausley wrote: Support does appear to be present but there is a problem returning back to user space I

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 09:46:04PM +0200, Thierry Reding wrote: On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: [...] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [...] +#if IS_ENABLED(CONFIG_OF) +static void of_i2c_register_devices(struct i2c_adapter *adap)

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Stephen Warren
On 08/19/2013 06:08 AM, Nicolin Chen wrote: This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.txt

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Stephen Warren
On 08/19/2013 06:08 AM, Nicolin Chen wrote: This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Rob Herring
On 08/19/2013 12:59 PM, Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child nodes in the core

[PATCH] sata: fsl: save irqs while coalescing

2013-08-19 Thread Anthony Foiani
-failure-lockdep-splat-possibly-related-tp75162.html Same patch successfully tested with 3.9.7. linux-next compiled but not tested on hardware. This patch is based off linux-next tag next-20130819 (which is commit 66a01bae29d11916c09f9f5a937cafe7d402e4a5 ) Signed-off-by: Anthony Foiani anthony.foi

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Sylwester Nawrocki
On 08/19/2013 07:59 PM, Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child nodes in the core

Re: Critical Interrupt Input

2013-08-19 Thread Henry Bausley
Support does appear to be present but there is a problem returning back to user space I suspect. What fails is it causes Linux user space programs to get Segmentation errors. Issuing a simple ls causes a segmentation fault sometimes. The shell gets terminated and you cannot log back in.

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Thierry Reding
On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: [...] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [...] +#if IS_ENABLED(CONFIG_OF) +static void of_i2c_register_devices(struct i2c_adapter *adap) +{ [...] +} [...] +#endif /* CONFIG_OF */ Isn't this missing the

Re: [PATCH] i2c: move of helpers into the core

2013-08-19 Thread Rafael J. Wysocki
On Monday, August 19, 2013 03:19:18 PM Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child

Re: [PATCH] i2c: move of helpers into the core

2013-08-19 Thread Stephen Warren
On 08/19/2013 05:04 PM, Rafael J. Wysocki wrote: On Monday, August 19, 2013 03:19:18 PM Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and

Re: Pull request: scottwood/linux.git next

2013-08-19 Thread Scott Wood
On Thu, 2013-08-15 at 07:01 +1000, Benjamin Herrenschmidt wrote: On Wed, 2013-08-14 at 12:02 -0500, Scott Wood wrote: On Wed, 2013-08-14 at 14:18 +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-08-08 at 17:45 -0500, Scott Wood wrote: powerpc/e500: Update compilation flags with

Re: Pull request: scottwood/linux.git next

2013-08-19 Thread Benjamin Herrenschmidt
On Mon, 2013-08-19 at 17:56 -0500, Scott Wood wrote: If we use the generic CPU target then mftb won't get turned into mfspr (I assume this is what you meant by tricky asm). Does mfspr work everywhere, including from userspace? Or do we need to patch? What about 403GCX which seems to need

Re: Pull request: scottwood/linux.git next

2013-08-19 Thread Josh Boyer
On Mon, Aug 19, 2013 at 7:47 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2013-08-19 at 17:56 -0500, Scott Wood wrote: If we use the generic CPU target then mftb won't get turned into mfspr (I assume this is what you meant by tricky asm). Does mfspr work everywhere,

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mike Turquette
Quoting Mark Rutland (2013-08-19 02:35:43) On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: Also I would make this option required. Use a dummy clock for

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Brown
On Mon, Aug 19, 2013 at 03:39:26PM -0600, Stephen Warren wrote: On 08/19/2013 06:08 AM, Nicolin Chen wrote: This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. diff --git

Re: [PATCH] sata: fsl: save irqs while coalescing

2013-08-19 Thread Scott Wood
On Mon, 2013-08-19 at 12:15 -0600, Anthony Foiani wrote: diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 19720a0..851bd3f 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -293,6 +293,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host,

Re: [PATCH 1/2] powerpc/85xx: add hardware automatically enter altivec idle state

2013-08-19 Thread Scott Wood
On Sun, 2013-08-18 at 21:53 -0500, Wang Dongsheng-B40534 wrote: Thanks for your feedback. -Original Message- From: Wood Scott-B07421 Sent: Saturday, August 17, 2013 12:51 AM To: Kumar Gala Cc: Wang Dongsheng-B40534; linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/2]

Re: [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100.

2013-08-19 Thread Scott Wood
On Mon, 2013-08-19 at 07:58 +1100, Stephen N Chivers wrote: The serial console setup in 'legacy_serial' does not support reg-shift or reg-offset properties and so a preferred_console is not added by it. The DTS file for the board does specify the register shift so that 'of_serial' will

Re: Pull request: scottwood/linux.git next

2013-08-19 Thread Benjamin Herrenschmidt
On Mon, 2013-08-19 at 19:49 -0400, Josh Boyer wrote: I think mfspr works everywhere we care about but I might be mistaken :-) I don't think anybody have tried booting a 403 in a long time. I would be surprised if it still worked. I think I have one buried somewhere in my garage. I'm

Re: [PATCH 1/3 V4] mmc:core: parse voltage from device-tree

2013-08-19 Thread Zhang Haijun
Hi, Anton and all I had update this patchset. Is there any change need? If so let me know. Thanks. On 08/12/2013 09:39 AM, Haijun Zhang wrote: Add function to support get voltage from device-tree. If there are voltage-range specified in device-tree node, this function will parse it and return

[PATCH] sata: fsl: save irqs while coalescing

2013-08-19 Thread Anthony Foiani
tag next-20130819 (which is commit 66a01bae29d11916c09f9f5a937cafe7d402e4a5 ) Signed-off-by: Anthony Foiani anthony.foi...@gmail.com --- drivers/ata/sata_fsl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 19720a0

Re: [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100.

2013-08-19 Thread Stephen N Chivers
Scott Wood scottw...@freescale.com wrote on 08/09/2013 11:35:20 AM: From: Scott Wood scottw...@freescale.com To: Stephen N Chivers schiv...@csc.com.au Cc: b...@kernel.crashing.org, pau...@samba.org, Chris Proctor cproc...@csc.com.au, linuxppc-dev@lists.ozlabs.org Date: 08/09/2013 11:36 AM

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
Thank you Sascha, I'll revise them all in v9 On Mon, Aug 19, 2013 at 02:34:49PM +0200, Sascha Hauer wrote: Hi Nicolas, Some misc other comments inline. On Mon, Aug 19, 2013 at 08:08:48PM +0800, Nicolin Chen wrote: This patch implements a device-tree-only CPU DAI driver for Freescale +

BUG_ON and gcc don't mix

2013-08-19 Thread Anton Blanchard
Hi, I noticed our BUG_ON macros were taking a large number of instructions. I've built a testcase to analyse it: #if defined(ASMBUG) #define BUG_ON(x) do { \ __asm__ __volatile__(tdnei %0,0\n : : r ((long)(x))); \ } while (0) #elif defined(BUILTIN) #define BUG_ON(x) do { \

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
On Mon, Aug 19, 2013 at 03:35:58PM -0600, Stephen Warren wrote: + core The core clock of spdif controller + rxtx0-7 Clock source list for tx and rx clock. + This clock list should be identical to + the source list connecting to the spdif

[PATCH v2] Correct Memory Hotplug for Power

2013-08-19 Thread Nathan Fontenot
Memory hotplug on Power is currently broken, these two patches correct the issues needed to get memory hotplug working again. This update marks memory resources that are added at boot time are also marked as busy. It sounds a bit counter intuitive but the core mm code will not free memory

[PATCH v2 1/2] Mark Memory Resources as busy

2013-08-19 Thread Nathan Fontenot
Memory I/O resources need to be marked as busy or else we cannot remove them when doing memory hot remove. Signed-off-by: Nathan Fontenot nf...@linux.vnet.ibm.com --- arch/powerpc/mm/mem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/arch/powerpc/mm/mem.c

[PATCH v2 2/2] Register bootmem pages

2013-08-19 Thread Nathan Fontenot
Previous commit 46723bfa540... introduced a new config option HAVE_BOOTMEM_INFO_NODE that ended up breaking memory hot-remove for ppc when sparse vmemmap is not defined. This patch defines HAVE_BOOTMEM_INFO_NODE for ppc and adds the call to register_page_bootmem_info_node. Without this we get a

Re: [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100.

2013-08-19 Thread Stephen N Chivers
Scott Wood scottw...@freescale.com wrote on 08/20/2013 10:44:31 AM: From: Scott Wood scottw...@freescale.com To: Stephen N Chivers schiv...@csc.com.au Cc: Chris Proctor cproc...@csc.com.au, Kumar Gala ga...@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, pau...@samba.org Date:

[PATCH v9 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-19 Thread Nicolin Chen
Changelog: v8-v9: * Use bool instead of atomic_t. * Use clk_prepare_enable() instead. * Dropped dumpregs(). * Dropped unnecessary clk_round_rate(). * Dropped unused clock source enum. * Revised dev_err() message. v7-v8: * Revised DT binding doc. * Revised dev_err() error msg. * Check

[PATCH v9 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only CPU DAI driver for Freescale S/PDIF controller that supports stereo playback and record feature. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/fsl,spdif.txt| 54 + sound/soc/fsl/Kconfig

[PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen b42...@freescale.com --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 +

Re: BUG_ON and gcc don't mix

2013-08-19 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 12:37 +1000, Anton Blanchard wrote: 0: 00 00 23 a1 lhz r9,0(r3) 4: 01 00 60 38 li r3,1 8: 20 00 a9 0c twlgei r9,32 c: 20 00 80 4e blr Nice! I remember chasing this down before and the issue is we need the address of the

Re: BUG_ON and gcc don't mix

2013-08-19 Thread Alan Modra
On Tue, Aug 20, 2013 at 12:37:50PM +1000, Anton Blanchard wrote: address of the trap instruction for our bug exception table. Maybe we need a gcc builtin in which we can get a label on the trap instruction. Would that be possible? Not your actual _EMIT_BUG_ENTRY, but something like this ought

Re: BUG_ON and gcc don't mix

2013-08-19 Thread Alan Modra
On Tue, Aug 20, 2013 at 02:02:11PM +0930, Alan Modra wrote: On Tue, Aug 20, 2013 at 12:37:50PM +1000, Anton Blanchard wrote: address of the trap instruction for our bug exception table. Maybe we need a gcc builtin in which we can get a label on the trap instruction. Would that be possible?

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Shawn Guo
On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote: I guess it's better to drop the 'imx6q-spdif' here? That depends: * If the two IP blocks are identical, only the imx35-spdif name is necessary, and we can forget about fsl,imx6q-spdif. * If fsl,imx6q-spdif is a strict