RE: [PATCH v2 08/25] powerpc/8xx: Map IMMR area with 512k page at a fixed address

From: Scott Wood > Sent: 24 September 2015 21:14 > > Isn't this a more general problem? > > > > If there are multiple remap requests for the same physical page > > shouldn't the kernel be just increasing a reference count somewhere > > and returning address in the same virtual page? > > This

Re: [PATCH v3 19/32] cxlflash: Correct usage of scsi_host_put()

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 28/32] cxlflash: Fix to avoid state change collision

On 09/24/2015 02:42 PM, Matthew R. Ochs wrote: > diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c > index ab11ee6..325ba31 100644 > --- a/drivers/scsi/cxlflash/main.c > +++ b/drivers/scsi/cxlflash/main.c > @@ -496,6 +496,7 @@ static int cxlflash_queuecommand(struct

Re: [PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

On 09/24/2015 02:44 PM, Matthew R. Ochs wrote: > @@ -1293,8 +1291,8 @@ static int cxlflash_disk_attach(struct scsi_device > *sdev, > > int fd = -1; > > - /* On first attach set fileops */ > - if (atomic_read(>num_user_contexts) == 0) > + /* On very first attach set fileops for

Re: [RFC v2 3/7] powerpc: atomic: Implement atomic{,64}_{add,sub}_return_* variants

On Wed, Sep 23, 2015 at 08:07:55AM +0800, Boqun Feng wrote: > On Tue, Sep 22, 2015 at 08:25:40AM -0700, Paul E. McKenney wrote: > > On Tue, Sep 22, 2015 at 07:37:04AM +0800, Boqun Feng wrote: > > > On Tue, Sep 22, 2015 at 07:26:56AM +0800, Boqun Feng wrote: > > > > On Mon, Sep 21, 2015 at

Re: [PATCH v3 20/32] cxlflash: Fix to prevent workq from accessing freed memory

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 5/5] cpufreq: qoriq: Don't look at clock implementation details

On Fri, 2015-09-25 at 23:42 +0200, Rafael J. Wysocki wrote: > On Tuesday, September 22, 2015 12:46:54 PM Viresh Kumar wrote: > > On 19-09-15, 23:29, Scott Wood wrote: > > > Get the CPU clock's potential parent clocks from the clock interface > > > itself, rather than manually parsing the clocks

Re: [PATCH v3 5/5] cpufreq: qoriq: Don't look at clock implementation details

On Tuesday, September 22, 2015 12:46:54 PM Viresh Kumar wrote: > On 19-09-15, 23:29, Scott Wood wrote: > > Get the CPU clock's potential parent clocks from the clock interface > > itself, rather than manually parsing the clocks property to find a > > phandle, looking at the clock-names property of

Re: [PATCH v3 13/32] cxlflash: Fix to avoid stall while waiting on TMF

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a): > > > On 23 September 2015 19:50:52 GMT+10:00, Michal Marek > wrote: >> On 2015-09-23 07:40, Michael Ellerman wrote: >>> +else ifneq ($(wildcard >> arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG)),) >>> @$(kecho) "*** Default

Re: [PATCH v3 30/32] cxlflash: Fix to double the delay each time

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 5/5] cpufreq: qoriq: Don't look at clock implementation details

On Friday, September 25, 2015 04:17:07 PM Scott Wood wrote: > On Fri, 2015-09-25 at 23:42 +0200, Rafael J. Wysocki wrote: > > On Tuesday, September 22, 2015 12:46:54 PM Viresh Kumar wrote: > > > On 19-09-15, 23:29, Scott Wood wrote: > > > > Get the CPU clock's potential parent clocks from the

Re: [PATCH v3 32/32] cxlflash: Correct trace string

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v3 2/8] dpaa_eth: add support for DPAA Ethernet

From: Madalin Bucur Date: Thu, 24 Sep 2015 18:00:13 +0300 > +#define DPA_NAPI_WEIGHT 64 This is just the default, so simply use "NAPI_POLL_WEIGHT" rather than defining your own macro unnecessarily for this. > +static int dpa_eth_priv_stop(struct

Re: [PATCH v2 08/25] powerpc/8xx: Map IMMR area with 512k page at a fixed address

On Fri, 2015-09-25 at 14:46 +, David Laight wrote: > From: Scott Wood > > Sent: 24 September 2015 21:14 > > > Isn't this a more general problem? > > > > > > If there are multiple remap requests for the same physical page > > > shouldn't the kernel be just increasing a reference count

Re: [PATCH v3 08/32] cxlflash: Fix to avoid CXL services during EEH

> On Sep 24, 2015, at 8:23 PM, Brian King wrote: > On 09/24/2015 02:38 PM, Matthew R. Ochs wrote: >> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c >> index 3e3ccf1..6e85c77 100644 >> --- a/drivers/scsi/cxlflash/main.c >> +++

Re: [V5, 2/6] fsl/fman: Add FMan support

On Mon, Sep 21, 2015 at 02:52:34PM +0300, Igal.Liberman wrote: > diff --git a/drivers/net/ethernet/freescale/fman/fman.c > b/drivers/net/ethernet/freescale/fman/fman.c > new file mode 100644 > index 000..924685f > --- /dev/null > +++ b/drivers/net/ethernet/freescale/fman/fman.c > @@ -0,0

[PATCH v4 00/32] cxlflash: Miscellaneous bug fixes and corrections

This patch set contains various fixes and corrections for issues that were found during test and code review. The series is based upon the code upstreamed in 4.3 and is intended for the rc phase. The entire set is bisectable. Please reference the changelog below for details on what has been

[PATCH v4 05/32] cxlflash: Fix data corruption when vLUN used over multiple cards

If the same virtual LUN is accessed over multiple cards, only accesses made over the first card will be valid. Accesses made over the second card will go to the wrong LUN causing data corruption. This is because the global LUN's mode word was being used to determine whether the LUN table for that

[PATCH v4 08/32] cxlflash: Fix to avoid CXL services during EEH

During an EEH freeze event, certain CXL services should not be called until after the hardware reset has taken place. Doing so can result in unnecessary failures and possibly cause other ill effects by triggering hardware accesses. This translates to a requirement to quiesce all threads that may

[PATCH v4 11/32] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Suggested-by: Shane Seymour Signed-off-by: Matthew R. Ochs

[PATCH v4 19/32] cxlflash: Correct usage of scsi_host_put()

Currently, scsi_host_put() is being called prematurely in the remove path and is missing entirely in an error cleanup path. The former can lead to memory being freed too early with subsequent access potentially corrupting data whilst the former would result in a memory leak. Move the usage on

[PATCH v4 13/32] cxlflash: Fix to avoid stall while waiting on TMF

Borrowing the TMF waitq's spinlock causes a stall condition when waiting for the TMF to complete. To remedy, introduce our own spin lock to serialize TMF and use the appropriate wait services. Also add a timeout while waiting for a TMF completion. When a TMF times out, report back a failure such

Re: [PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

> On Sep 25, 2015, at 4:23 PM, Brian King wrote: > On 09/24/2015 02:44 PM, Matthew R. Ochs wrote: >> @@ -1293,8 +1291,8 @@ static int cxlflash_disk_attach(struct scsi_device >> *sdev, >> >> int fd = -1; >> >> -/* On first attach set fileops */ >> -if

[PATCH v4 01/32] cxlflash: Fix to avoid invalid port_sel value

From: Manoj Kumar If two concurrent MANAGE_LUN ioctls are issued with the same WWID parameter, it would result in an incorrect value of port_sel. This is because port_sel is modified without any locks being held. If the first caller stalls after the return from

[PATCH v4 06/32] cxlflash: Fix to avoid sizeof(bool)

Using sizeof(bool) is considered poor form for various reasons and sparse warns us of that. Correct by changing type from bool to u8. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v4 07/32] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v4 04/32] cxlflash: Fix potential oops following LUN removal

When a LUN is removed, the sdev that is associated with the LUN remains intact until its reference count drops to 0. In order to prevent an sdev from being removed while a context is still associated with it, obtain an additional reference per-context for each LUN attached to the context. This

[PATCH v4 09/32] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N.

[PATCH v4 14/32] cxlflash: Fix location of setting resid

The resid is incorrectly set which can lead to unnecessary retry attempts by the stack. This is due to resid _always_ being set using a value returned from the adapter. Instead, the value should only be interpreted and set when in an underrun scenario. Signed-off-by: Matthew R. Ochs

[PATCH v4 12/32] cxlflash: Fix to avoid spamming the kernel log

During run-time the driver can be very chatty and spam the system kernel log. Various print statements can be limited and/or moved to development-only mode. Additionally, numerous prints can be converted to trace the corresponding device. The following changes were made: - pr_debug to pr_devel

[PATCH v4 18/32] cxlflash: Fix AFU version access/storage and add check

The AFU version is stored as a non-terminated string of bytes within a 64-bit little-endian register. Presently the value is read directly (no MMIO accessor) and is stored in a buffer that is not big enough to contain a NULL terminator. Additionally the version obtained is not evaluated against a

[PATCH v4 22/32] cxlflash: Remove unnecessary scsi_block_requests

The host reset handler is called with I/O already blocked, thus there is no need to explicitly block and unblock I/O in the handler. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v4 21/32] cxlflash: Correct behavior in device reset handler following EEH

When the device reset handler is entered while a reset operation is taking place, the handler exits without actually sending a reset (TMF) to the targeted device. This behavior is incorrect as the device is not reset. Further complicating matters is the fact that a success is returned even when

Re: [PATCH v3 28/32] cxlflash: Fix to avoid state change collision

> On Sep 25, 2015, at 4:10 PM, Brian King wrote: > On 09/24/2015 02:42 PM, Matthew R. Ochs wrote: >> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c >> index ab11ee6..325ba31 100644 >> --- a/drivers/scsi/cxlflash/main.c >> +++

[PATCH v4 03/32] cxlflash: Fix read capacity timeout

From: Manoj Kumar The timeout value for read capacity is too small. Certain devices may take longer to respond and thus the command may prematurely timeout. Additionally the literal used for the timeout is stale. Update the timeout to 30 seconds (matches the value used in

[PATCH v4 02/32] cxlflash: Replace magic numbers with literals

From: Manoj Kumar Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs

[PATCH v4 10/32] cxlflash: Make functions static

Found during code inspection, that the following functions are not being used outside of the file where they are defined. Make them static. int cxlflash_send_cmd(struct afu *, struct afu_cmd *); void cxlflash_wait_resp(struct afu *, struct afu_cmd *); int cxlflash_afu_reset(struct cxlflash_cfg

[PATCH v4 15/32] cxlflash: Fix host link up event handling

Following a link up event, the LUNs available to the host may have changed. Without rescanning the host, the LUN topology is unknown to the user. In such a state, the user would be unable to locate provisioned resources. To remedy, the host should be rescanned after a link up event.

[PATCH v4 17/32] cxlflash: Remove dual port online dependency

At present, both ports must be online for the device to configure properly. Remove this dependency and the unnecessary internal LUN override logic as well. Additionally, as a refactoring measure, change the return code variable name to match that used throughout the driver. Signed-off-by: Matthew

[PATCH v4 16/32] cxlflash: Fix async interrupt bypass logic

A bug was introduced earlier in the development cycle when cleaning up logic statements. Instead of skipping bits that are not set, set bits are skipped, causing async interrupts to not be handled correctly. To fix, simply add back in the proper evaluation for an unset bit. Signed-off-by:

[PATCH v4 20/32] cxlflash: Fix to prevent workq from accessing freed memory

The workq can process work in parallel with a remove event, leading to a condition where the workq handler can access freed memory. To remedy, the workq should be terminated prior to freeing memory. Move the termination call earlier in remove and use cancel_work_sync() instead of flush_work() as

[PATCH v4 24/32] cxlflash: Fix MMIO and endianness errors

Sparse uncovered several errors with MMIO operations (accessing directly) and handling endianness. These can cause issues when running in different environments. Introduce __iomem and proper endianness tags/swaps where appropriate to make driver sparse clean. Signed-off-by: Matthew R. Ochs

[PATCH v4 26/32] cxlflash: Correct spelling, grammar, and alignment mistakes

There are several spelling and grammar mistakes throughout the driver. Additionally there are a handful of places where there are extra lines and unnecessary variables/statements. These are a nuisance and pollute the driver. Fix spelling and grammar issues. Update some comments for clarity and

[PATCH v4 25/32] cxlflash: Fix to prevent EEH recovery failure

The process_sense() routine can perform a read capacity which can take some time to complete. If an EEH occurs while waiting on the read capacity, the EEH handler is unable to obtain the context's mutex in order to put the context in an error state. The EEH handler will sit and wait until the

[PATCH v4 23/32] cxlflash: Fix function prolog parameters and return codes

Several function prologs have incorrect parameter names and return code descriptions. This can lead to confusion when reviewing the source and creates inaccurate documentation. To remedy, update the function prologs to properly reflect parameter names and return codes. Signed-off-by: Matthew R.

[PATCH v4 29/32] cxlflash: Fix to double the delay each time

From: Manoj Kumar The operator used to double the delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl Signed-off-by: Matthew R. Ochs

[PATCH v4 31/32] cxlflash: Correct trace string

The trace following the failure of alloc_mem() incorrectly identifies which function failed. This can lead to misdiagnosing a failure. Fix the string to correctly indicate that alloc_mem() failed. Reported-by: Brian King Signed-off-by: Matthew R. Ochs

[PATCH v4 27/32] cxlflash: Fix to prevent stale AFU RRQ

Following an adapter reset, the AFU RRQ that resides in host memory holds stale data. This can lead to a condition where the RRQ interrupt handler tries to process stale entries and/or endlessly loops due to an out of sync generation bit. To fix, the AFU RRQ in host memory needs to be cleared

[PATCH v4 28/32] MAINTAINERS: Add cxlflash driver

Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan --- MAINTAINERS | 9 +

[PATCH v4 30/32] cxlflash: Fix to avoid corrupting adapter fops

The fops owned by the adapter can be corrupted in certain scenarios, opening a window where certain fops are temporarily NULLed before being reset to their proper value. This can potentially lead software to make incorrect decisions, leaving the user with the inability to function as intended. An

[PATCH v4 32/32] cxlflash: Fix to avoid potential deadlock on EEH

Ioctl threads that use scsi_execute() can run for an excessive amount of time due to the fact that they have lengthy timeouts and retry logic built in. Under normal operation this is not an issue. However, once EEH enters the picture, a long execution time coupled with the possibility that a

Re: [RFC v2 3/7] powerpc: atomic: Implement atomic{,64}_{add,sub}_return_* variants

On Fri, Sep 25, 2015 at 02:29:04PM -0700, Paul E. McKenney wrote: > On Wed, Sep 23, 2015 at 08:07:55AM +0800, Boqun Feng wrote: > > On Tue, Sep 22, 2015 at 08:25:40AM -0700, Paul E. McKenney wrote: > > > On Tue, Sep 22, 2015 at 07:37:04AM +0800, Boqun Feng wrote: > > > > On Tue, Sep 22, 2015 at

[PATCH v8 2/4] perf,kvm/{x86,s390}: Remove const from kvm_events_tp

This patch removes the "const" qualifier from kvm_events_tp declaration to account for the fact that powerpc will need to update this variable dynamically depending on the machine type. Signed-off-by: Hemant Kumar --- tools/perf/arch/s390/util/kvm-stat.c | 2 +-

[PATCH v8 4/4] perf,kvm/powerpc: Add support for HCALL reasons

Powerpc provides hcall events that also provides insights into guest behaviour. Enhance perf kvm stat to record and analyze hcall events. - To trace hcall events : perf kvm stat record - To show the results : perf kvm stat report --event=hcall The result shows the number of hypervisor

[PATCH v8 1/4] perf, kvm/{x86, s390}: Remove dependency on uapi/kvm_perf.h

Its better to remove the dependency on uapi/kvm_perf.h to allow dynamic discovery of kvm events (if its needed). To do this, some extern variables have been introduced with which we can keep the generic functions generic. Signed-off-by: Hemant Kumar --- Changes since

[PATCH v8 3/4] perf,kvm/powerpc: Port perf kvm stat to powerpc

perf kvm can be used to analyze guest exit reasons. This support already exists in x86. Hence, porting it to powerpc. - To trace KVM events : perf kvm stat record If many guests are running, we can track for a specific guest by using --pid as in : perf kvm stat record --pid - To see the

RE: [PATCH V3] thermal: qoriq: Add thermal management support

> -Original Message- > From: Wood Scott-B07421 > Sent: Friday, September 25, 2015 1:12 PM > To: Jia Hongtao-B38951 > Cc: edubez...@gmail.com; linux...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH V3] thermal: qoriq: Add thermal management support > > On Thu,

Re: [PATCH v2 1/2] powerpc/selftest: Add gettimeofday() benchmark

On Friday 25 September 2015 14:01:39 Michael Neuling wrote: > This adds a benchmark directory to the powerpc selftests and adds a > gettimeofday() benchmark to it. > > Suggested-by: Michael Ellerman > Signed-off-by: Michael Neuling > Any reason for

Re: [PATCH] powerpc/eeh: Avoid to handle EEH on a passed Child PE

On Wed, Sep 23, 2015 at 09:07:41AM +1000, Gavin Shan wrote: >On Tue, Sep 22, 2015 at 12:43:03PM +0800, Wei Yang wrote: >>On Mon, Sep 21, 2015 at 09:49:45PM +1000, Gavin Shan wrote: >>>On Mon, Sep 21, 2015 at 05:29:48PM +0800, Wei Yang wrote: Current EEH infrastructure would avoid to handle EEH

[GIT PULL] Please pull powerpc/linux.git powerpc-4.3-3 tag

Hi Linus, Please pull two powerpc fixes for 4.3: The following changes since commit 1f93e4a96c9109378204c147b3eec0d0e8100fde: Linux 4.3-rc2 (2015-09-20 14:32:34 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git

Re: [PATCH v2 1/2] powerpc/selftest: Add gettimeofday() benchmark

On 9/25/15, Gabriel Paubert wrote: > On Fri, Sep 25, 2015 at 12:28:30PM +0300, Denis Kirjanov wrote: >> On 9/25/15, Arnd Bergmann wrote: >> > On Friday 25 September 2015 14:01:39 Michael Neuling wrote: >> >> This adds a benchmark directory to the powerpc selftests

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

From: Florian Fainelli Date: Thu, 24 Sep 2015 18:39:56 -0700 > On 24/09/15 12:17, Russell King - ARM Linux wrote: >> Hi, >> >> The third version of this series fixes the build error which David >> identified, and drops the broken changes for the Cavium Thunger BGX >>

Re: [PATCH v2 1/2] powerpc/selftest: Add gettimeofday() benchmark

On 9/25/15, Arnd Bergmann wrote: > On Friday 25 September 2015 14:01:39 Michael Neuling wrote: >> This adds a benchmark directory to the powerpc selftests and adds a >> gettimeofday() benchmark to it. >> >> Suggested-by: Michael Ellerman >> Signed-off-by:

Re: [PATCH v2 1/2] powerpc/selftest: Add gettimeofday() benchmark

On Fri, Sep 25, 2015 at 12:28:30PM +0300, Denis Kirjanov wrote: > On 9/25/15, Arnd Bergmann wrote: > > On Friday 25 September 2015 14:01:39 Michael Neuling wrote: > >> This adds a benchmark directory to the powerpc selftests and adds a > >> gettimeofday() benchmark to it. > >> > >>