Re: [PATCH v2 3/6] cxlflash: Removed driver date print

2015-12-14 Thread Andrew Donnellan
On 15/12/15 08:06, Uma Krishnan wrote: Having a date for the driver requires it to be updated quite often. Removing the date which is not necessary. Also made use of the existing symbol to print the driver name. Signed-off-by: Uma Krishnan Reviewed-by: Andrew

Re: [PATCH v2 4/6] cxlflash: Fix to resolve cmd leak after host reset

2015-12-14 Thread Andrew Donnellan
On 15/12/15 08:07, Uma Krishnan wrote: From: Manoj Kumar After a few iterations of resetting the card, either during EEH recovery, or a host_reset the following is seen in the logs. cxlflash 0008:00: cxlflash_queuecommand: could not get a free command At every reset

Re: [RFC] powerpc: Enable UBSAN support

2015-12-14 Thread Andrew Donnellan
On 10/12/15 11:42, Daniel Axtens wrote: This hooks up UBSAN support for PowerPC. So far it's found some interesting cases where we don't properly sanitise input to shifts, including one in our futex handling. Nothing critical, but interesting and worth fixing. CC: Andrey Ryabinin

[PATCH] p1010rdb:update dts for pcie interrupt-map

2015-12-14 Thread Zhao Qiang
p1010rdb use the irq[4:5] for inta and intb to pcie, it is active-high, so set it. Signed-off-by: Zhao Qiang --- arch/powerpc/boot/dts/fsl/p1010rdb.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/powerpc/boot/dts/fsl/p1010rdb.dtsi

Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree

2015-12-14 Thread Rafael J. Wysocki
On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: > Register the qoriq cpufreq driver as a cooling device, based on the > thermal device tree framework. When temperature crosses the passive trip > point cpufreq is used to throttle CPUs. > > Signed-off-by: Jia Hongtao

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

2015-12-14 Thread Matthew R. Ochs
Acked-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 6/6] cxlflash: Enable device id for future IBM CXL adapter

2015-12-14 Thread Andrew Donnellan
On 15/12/15 08:07, Uma Krishnan wrote: From: Manoj Kumar This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. If you do a V3 - this could be better worded in the imperative mood as: "Add a new device ID (0x0600) for a

Re: [v2] platforms/powernv: Add support for Nvlink NPUs

2015-12-14 Thread Alistair Popple
Thanks for the review Michael. I'll do a respin to address the comments below. On Mon, 14 Dec 2015 20:26:27 Michael Ellerman wrote: > Hi Alistair, > > Just a few nitty things ... > > On Tue, 2015-10-11 at 02:28:11 UTC, Alistair Popple wrote: > > NV-Link is a high speed interconnect that is used

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Denis Kirjanov
On 12/14/15, Michael Ellerman wrote: > On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote: >> On Tue, 08 Dec 2015 08:02:15 +1100 >> Benjamin Herrenschmidt wrote: >> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: >> > > > +

[PATCH] perf: bpf: Fix build breakage due to libbpf

2015-12-14 Thread Naveen N. Rao
perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including tools/perf/config/Makefile.arch for the proper $ARCH macro.

[PATCH v2] tools lib bpf: Support libbpf on PowerPC

2015-12-14 Thread Wang Nan
Support basic PowerPC compiling. Checks BPF syscall number, turn off libbpf building on platform doesn't support sys_bpf instead of blocking compiling. Reported-by: Naveen N. Rao Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo

Re: powerpc: Fix DSCR inheritance over fork()

2015-12-14 Thread Michael Ellerman
On Wed, 2015-09-12 at 09:11:47 UTC, Anton Blanchard wrote: > Two DSCR tests have a hack in them: > > /* >* XXX: Force a context switch out so that DSCR >* current value is copied into the thread struct >* which is required for the child to inherit the >*

Re: [v2] powerpc: Call restore_sprs() before _switch()

2015-12-14 Thread Michael Ellerman
On Thu, 2015-10-12 at 09:44:39 UTC, Anton Blanchard wrote: > commit 152d523e6307 ("powerpc: Create context switch helpers save_sprs() > and restore_sprs()") moved the restore of SPRs after the call to _switch(). > > There is an issue with this approach - new tasks do not return through >

Re: [PATCH] perf: bpf: Fix build breakage due to libbpf

2015-12-14 Thread Wangnan (F)
Hi Naveen, On 2015/12/14 18:50, Naveen N. Rao wrote: perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including

Re: powernv/opal-irqchip: Fix double endian conversion

2015-12-14 Thread Michael Ellerman
On Mon, 2015-07-12 at 00:28:28 UTC, Alistair Popple wrote: > The OPAL event calls return a mask of events that are active in big > endian format. This is checked when unmasking the events in the > irqchip by comparison with a cached value. The cached value was stored > in big endian format but

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Michael Ellerman
On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote: > On Tue, 08 Dec 2015 08:02:15 +1100 > Benjamin Herrenschmidt wrote: > > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: > > > > + TP_CONDITION(cpu_online(smp_processor_id())), > > > > + > > > >

Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable

2015-12-14 Thread Daniel Thompson
On 11/12/15 23:21, Russell King - ARM Linux wrote: As I explained when I did that work, the vast majority of ARM platforms are unable to trigger anything like a NMI - the FIQ is something that's generally a property of the secure monitor, and is not accessible to Linux. However, there are

Re: cxl: Set endianess of kernel contexts

2015-12-14 Thread Michael Ellerman
On Mon, 2015-07-12 at 13:34:40 UTC, Frederic Barrat wrote: > A process element (defined in CAIA) keeps track of the endianess of > contexts through the Little Endian (LE) bit of the State Register. It > is currently set for user contexts, but was somehow forgotten for > kernel contexts, so this

Re: [v2] platforms/powernv: Add support for Nvlink NPUs

2015-12-14 Thread Michael Ellerman
Hi Alistair, Just a few nitty things ... On Tue, 2015-10-11 at 02:28:11 UTC, Alistair Popple wrote: > NV-Link is a high speed interconnect that is used in conjunction with Is it NV-Link or NVLink? > a PCI-E connection to create an interface between CPU and GPU that > provides very high data

Re: [v2] Revert "powerpc/eeh: Don't unfreeze PHB PE after reset"

2015-12-14 Thread Michael Ellerman
On Tue, 2015-08-12 at 05:59:25 UTC, Andrew Donnellan wrote: > This reverts commit 527d10ef3a315d3cb9dc098dacd61889a6c26439. > > The reverted commit breaks cxlflash devices following an EEH reset (and > possibly other cxl devices, however this has not been tested). ... > > In the meantime, revert

Re: sbc8641: drop bogus PHY IRQ entries from DTS file

2015-12-14 Thread Michael Ellerman
On Tue, 2015-08-12 at 22:44:02 UTC, Paul Gortmaker wrote: > This file was originally cloned off of the MPC8641D-HPCN reference > platform, which actually had a PHY IRQ line connected. However > this board does not. The bogus entry was largely inert and went > undetected until commit

[PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf

2015-12-14 Thread Wang Nan
From: "Naveen N. Rao" perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including

[PATCH v3 1/3] perf tools: Fix PowerPC native building

2015-12-14 Thread Wang Nan
Checks BPF syscall number, turn off libbpf building on platform doesn't correctly support sys_bpf instead of blocking compiling. Reported-by: Naveen N. Rao Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa

Re: [PATCH] powerpc: Enable UBSAN support

2015-12-14 Thread Michael Ellerman
Hi Daniel, Great work thanks for getting this going. On Tue, 2015-12-15 at 14:46 +1100, Daniel Axtens wrote: > This hooks up UBSAN support for PowerPC. > > So far it's found some interesting cases where we don't properly sanitise > input to shifts, including one in our futex handling. It's

Re: linux-next: manual merge of the akpm-current tree with the powerpc tree

2015-12-14 Thread Stephen Rothwell
Hi Andrew, On Tue, 15 Dec 2015 16:53:42 +1100 Stephen Rothwell wrote: > > diff --git a/arch/powerpc/include/asm/book3s/64/hash.h > b/arch/powerpc/include/asm/book3s/64/hash.h > index 8b929e531758..4e69d9a273ed 100644 > --- a/arch/powerpc/include/asm/book3s/64/hash.h >

[PATCH] tools lib bpf: Support libbpf on PowerPC

2015-12-14 Thread Wang Nan
Support basic PowerPC compiling. Checks BPF syscall number, turn off libbpf building on platform doesn't support sys_bpf instead of blocking compiling. Reported-by: Naveen N. Rao Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo

Re: [PATCH] perf: bpf: Fix build breakage due to libbpf

2015-12-14 Thread Naveen N. Rao
On 2015/12/14 07:53PM, Wang Nan wrote: > Hi Naveen, > > On 2015/12/14 18:50, Naveen N. Rao wrote: > >perf build is currently (v4.4-rc5) broken on powerpc: > > > >bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > >your arch. > > # error __NR_bpf not defined. libbpf does

Re: [PATCH v2] tools lib bpf: Support libbpf on PowerPC

2015-12-14 Thread Naveen N. Rao
On 2015/12/14 11:57AM, Wang Nan wrote: > Support basic PowerPC compiling. > > Checks BPF syscall number, turn off libbpf building on platform doesn't > support sys_bpf instead of blocking compiling. > > Reported-by: Naveen N. Rao > Signed-off-by: Wang Nan

[PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf

2015-12-14 Thread Wang Nan
Hi Naveen, Now I know your problem is in native building and the reason is missing proper $(ARCH). I think other than that there's another problem in libbpf's building: if your problem is unable to compile libbpf, feature checker should find it and set NO_LIBBPF=1 for perf, so perf building

[PATCH] powerpc: Remove broken GregorianDay()

2015-12-14 Thread Daniel Axtens
GregorianDay() is supposed to calculate the day of the week (tm->tm_wday) for a given day/month/year. In that calcuation it indexed into an array called MonthOffset using tm->tm_mon-1. However tm_mon is zero-based, not one-based, so this is off-by-one. It also means that every January,

[PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up

2015-12-14 Thread Martin Roth
The patch fixes FCC port lock-up, which occurs as a result of a bug during underrun/collision handling. Within the tx_startup() function in mac-fcc.c, the address of last BD is not calculated correctly. As a result of wrong calculation of the last BD address, the next transmitted BD may be set to

[PATCH] powerpc: Enable UBSAN support

2015-12-14 Thread Daniel Axtens
This hooks up UBSAN support for PowerPC. So far it's found some interesting cases where we don't properly sanitise input to shifts, including one in our futex handling. It's also found an out of bounds read in an array. Nothing critical, but worth fixing. Tested-by: Andrew Donnellan

[PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts

2015-12-14 Thread Wang Nan
After this patch other directories can use this architecture detector without directly including it from perf's directory. Libbpf would utilize it to get proper $(ARCH) so it can receive correct uapi include directory. Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo

Re: [PATCH] powerpc: Enable UBSAN support

2015-12-14 Thread Daniel Axtens
Michael Ellerman writes: > Hi Daniel, > > Great work thanks for getting this going. > > Have you tried running with KVM? > > I'm wondering if we should be excluding some of the KVM code that runs in > real mode, eg: > > arch/powerpc/kvm/book3s_hv_rm_mmu.c >

Re: [PATCH] powerpc: Enable UBSAN support

2015-12-14 Thread Daniel Axtens
>> Have you tried running with KVM? OK, I ran a UBSAN kvm guest on a UBSAN host and I ran trinity inside the guest. It all appears to work as usual. I really don't have the knowledge to determine what we should exclude, but I'm very very happy to respin with a greater list of excludes if you

linux-next: manual merge of the akpm-current tree with the powerpc tree

2015-12-14 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got conflicts in: arch/powerpc/include/asm/nohash/64/pgtable.h arch/powerpc/mm/pgtable_64.c between various commits from the powerpc tree and commits: e56ebae0dd4c ("powerpc, thp: remove infrastructure for handling splitting

Re: [PATCH 4/6] cxlflash: Fix to resolve cmd leak after host reset

2015-12-14 Thread Matthew R. Ochs
Acked-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/6] cxlflash: Resolve oops in wait_port_offline

2015-12-14 Thread Matthew R. Ochs
Acked-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

2015-12-14 Thread Manoj Kumar
On 12/13/2015 9:47 PM, Andrew Donnellan wrote: On 11/12/15 09:54, Uma Krishnan wrote: From: Manoj Kumar This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. No card specific programming has been added. These card

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

2015-12-14 Thread Matthew R. Ochs
Acked-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

2015-12-14 Thread Matthew R. Ochs
Acked-by: Matthew R. Ochs ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cpufreq: powernv: Redesign the presentation of throttle notification

2015-12-14 Thread Paul Clarke
On 12/13/2015 12:17 PM, Shilpasri G Bhat wrote: Replace the throttling event console messages to perf trace event "power:powernv_throttle" and throttle counter stats which are exported in sysfs. The newly added sysfs files are as follows: 1)/sys/devices/system/node/node0/throttle_frequencies

[PATCH v2 2/2] ./drmgr -c cpu -a -r gives the following warning:

2015-12-14 Thread Denis Kirjanov
[ 2327.035563] RCU used illegally from offline CPU! rcu_scheduler_active = 1, debug_locks = 1 [ 2327.035564] no locks held by swapper/12/0. [ 2327.035565] stack backtrace: [ 2327.035567] CPU: 12 PID: 0 Comm: swapper/12 Tainted: G S 4.3.0-rc3-00060-g353169a #5 [ 2327.035568] Call Trace: [

[PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Denis Kirjanov
./drmgr -c cpu -a -r gives the following warning: [ 2327.035563] RCU used illegally from offline CPU! rcu_scheduler_active = 1, debug_locks = 1 [ 2327.035564] no locks held by swapper/12/0. [ 2327.035565] stack backtrace: [ 2327.035567] CPU: 12 PID: 0 Comm: swapper/12 Tainted: G S

[PATCH v2 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-12-14 Thread Denis Kirjanov
TRACE_EVENT_FN can't be used in some circumstances like invoking trace functions from offlined CPU due to RCU usage. This patch adds the TRACE_EVENT_FN_COND macro to make such trace points conditional. Signed-off-by: Denis Kirjanov --- include/linux/tracepoint.h | 4

Re: [PATCH v2 2/2] ./drmgr -c cpu -a -r gives the following warning:

2015-12-14 Thread Denis Kirjanov
On 12/14/15, Denis Kirjanov wrote: > [ 2327.035563] > RCU used illegally from offline CPU! > rcu_scheduler_active = 1, debug_locks = 1 > [ 2327.035564] no locks held by swapper/12/0. > [ 2327.035565] > stack backtrace: > [ 2327.035567] CPU: 12 PID: 0 Comm: swapper/12

[PATCH v3 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-12-14 Thread Denis Kirjanov
TRACE_EVENT_FN can't be used in some circumstances like invoking trace functions from offlined CPU due to RCU usage. This patch adds the TRACE_EVENT_FN_COND macro to make such trace points conditional. Signed-off-by: Denis Kirjanov --- include/linux/tracepoint.h | 4

Re: powerpc: Call check_if_tm_restore_required() in enable_kernel_*()

2015-12-14 Thread Michael Ellerman
On Thu, 2015-10-12 at 09:04:05 UTC, Anton Blanchard wrote: > Commit a0e72cf12b1a ("powerpc: Create msr_check_and_{set,clear}()") > removed a call to check_if_tm_restore_required() in the > enable_kernel_*() functions. Add them back in. > > Fixes: a0e72cf12b1a ("powerpc: Create

Re: [V6,01/35] powerpc/mm: move pte headers to book3s directory

2015-12-14 Thread Michael Ellerman
On Tue, 2015-01-12 at 03:36:26 UTC, "Aneesh Kumar K.V" wrote: > Acked-by: Scott Wood > Signed-off-by: Aneesh Kumar K.V Entire series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/26b6a3d9bb48f8b4624a6228 cheers

Re: powerpc/mm: Fix infinite loop in hash fault with 4K page size

2015-12-14 Thread Michael Ellerman
On Sat, 2015-28-11 at 17:09:33 UTC, "Aneesh Kumar K.V" wrote: > This is the same bug we fixed as part of > 09567e7fd44291bfc08accfdd67ad8f467842332 > ("powerpc/mm: Check paca psize is up to date for huge mappings"). Please > check that for details. The difference here is that faults were >

Re: [PATCH 3/6] cxlflash: Updated date of the driver

2015-12-14 Thread Uma Krishnan
On 12/10/2015 6:35 PM, Daniel Axtens wrote: Hi Uma, It looks like CXLFLASH_DRIVER_DATE is only used once, on init, and it's just printed. Is it necessary? It looks like having it will require sending a patch to update it quite often. Hi Daniel, Valid point. I will pull this out from the

Re: [PATCH net-next v2] Driver for IBM System i/p VNIC protocol

2015-12-14 Thread Thomas Falcon
On 12/11/2015 06:53 PM, David Miller wrote: > From: Thomas Falcon > Date: Tue, 8 Dec 2015 11:52:19 -0600 > >> +static long h_reg_sub_crq(unsigned long unit_address, unsigned long token, >> + unsigned long length, unsigned long *number, >> +

[POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection

2015-12-14 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 14 Dec 2015 23:01:32 +0100 A status check was performed by the fsl_get_immr() function even if it was known already that a system setting did not fit to the expectations. This implementation detail could be improved by an adjustment

Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection

2015-12-14 Thread Scott Wood
On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 14 Dec 2015 23:01:32 +0100 > > A status check was performed by the fsl_get_immr() function even if it > was known already that a system setting did not fit to the

[PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

2015-12-14 Thread Uma Krishnan
This patch set contains miscellaneous fixes and adds support for a future IBM CXL adapter. This series is intended for 4.5 and is bisectable. Please reference the changelog below for details on what has been altered from previous versions of this patch set. v2 Changes: - Incorporate comments from

[PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

2015-12-14 Thread Uma Krishnan
This patch set contains miscellaneous fixes and adds support for a future IBM CXL adapter. This series is intended for 4.5 and is bisectable. Please reference the changelog below for details on what has been altered from previous versions of this patch set. v2 Changes: - Incorporate comments from

[PATCH v2 5/6] cxlflash: Resolve oops in wait_port_offline

2015-12-14 Thread Uma Krishnan
From: Manoj Kumar If an async error interrupt is generated, and the error requires the FC link to be reset, it cannot be performed in the interrupt context. So a work element is scheduled to complete the link reset in a process context. If either an EEH event or an

[PATCH v2 6/6] cxlflash: Enable device id for future IBM CXL adapter

2015-12-14 Thread Uma Krishnan
From: Manoj Kumar This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. As per the design, the Accelerator Function Unit (AFU) for this new IBM CXL Flash Adapter retains the same host interface as the previous generation.

[PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

2015-12-14 Thread Uma Krishnan
This patch set contains miscellaneous fixes and adds support for a future IBM CXL adapter. This series is intended for 4.5 and is bisectable. Please reference the changelog below for details on what has been altered from previous versions of this patch set. v2 Changes: - Incorporate comments from

[PATCH v2 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

2015-12-14 Thread Uma Krishnan
From: Manoj Kumar The original fix to escalate a 'login timed out' error to a LINK_RESET was only made for one of the two ports on the card. This fix resolves the same issue for the second port (port 1). Signed-off-by: Manoj N. Kumar

[PATCH v2 2/6] cxlflash: Fix to avoid virtual LUN failover failure

2015-12-14 Thread Uma Krishnan
From: "Matthew R. Ochs" Applications which use virtual LUN's that are backed by a physical LUN over both adapter ports may experience an I/O failure in the event of a link loss (e.g. cable pull). Virtual LUNs may be accessed through one or both ports of the adapter.

[PATCH v2 4/6] cxlflash: Fix to resolve cmd leak after host reset

2015-12-14 Thread Uma Krishnan
From: Manoj Kumar After a few iterations of resetting the card, either during EEH recovery, or a host_reset the following is seen in the logs. cxlflash 0008:00: cxlflash_queuecommand: could not get a free command At every reset of the card, the commands that are

[PATCH v2 3/6] cxlflash: Removed driver date print

2015-12-14 Thread Uma Krishnan
Having a date for the driver requires it to be updated quite often. Removing the date which is not necessary. Also made use of the existing symbol to print the driver name. Signed-off-by: Uma Krishnan --- drivers/scsi/cxlflash/main.c | 3 +--