Re: [PATCH 04/17] mm: pass the vmem_altmap to arch_add_memory and __add_pages

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > We can just pass this on instead of having to do a radix tree lookup > without proper locking 2 levels into the callchain. > > Signed-off-by: Christoph Hellwig Yeah, the lookup of vmem_altmap is too magical

[PATCH] SB600 for the Nemo board has non-zero devices on non-root bus

On 04 December 2017 at 12:40PM, Darren Stevens wrote: > Hello Bjorn > > Firstly sorry for not being able to join in this discussion, I have been > moving house and only got my X1000 set up again yesterday.. > > On 30/11/2017, Bjorn Helgaas wrote: >> I *think* something like the patch below should

Re: [PATCH 01/17] memremap: provide stubs for vmem_altmap_offset and vmem_altmap_free

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > Currently all calls to those functions are eliminated by the compiler when > CONFIG_ZONE_DEVICE is not set, but this soon won't be the case. > > Signed-off-by: Christoph Hellwig Looks good, Reviewed-by: Dan

Re: [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level

On 12/13/17 5:18 PM, Nicolin Chen wrote: Additionally, in order to fix/work-around hardware bugs and design flaws, the driver made a lot of compromise so now its program flow looks very complicated and it's getting hard to maintain or update. So I am going to clean up the driver on both coding

Re: [PATCH 03/17] mm: don't export __add_pages

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > This function isn't used by any modules, and is only to be called > from core MM code. This includes the calls for the add_pages wrapper > that might be inlined. > > Signed-off-by: Christoph Hellwig Looks

Re: [PATCH 06/17] mm: pass the vmem_altmap to arch_remove_memory and __remove_pages

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > We can just pass this on instead of having to do a radix tree lookup > without proper locking 2 levels into the callchain. > > Signed-off-by: Christoph Hellwig wip I assume that "wip" is a typo? Otherwise,

Re: [PATCH 07/17] mm: pass the vmem_altmap to vmemmap_free

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > We can just pass this on instead of having to do a radix tree lookup > without proper locking a few levels into the callchain. > > Signed-off-by: Christoph Hellwig Now I remember why I went with the radix

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

Hi, I am outside so can't use mutt. Sorry for that. This comment is going to be replaced in the 2nd set anyway because the whole function will be replaced. And please point out all comments that you think I need to rework. I am totally fine to do that. I don't think every single one is bad. And

Re: [PATCH 05/17] mm: pass the vmem_altmap to vmemmap_populate

[ cc Michal ] On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > We can just pass this on instead of having to do a radix tree lookup > without proper locking a few levels into the callchain. > > Signed-off-by: Christoph Hellwig I know Michal has concerns

Re: [PATCH 08/17] mm: pass the vmem_altmap to memmap_init_zone

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > Pass the vmem_altmap two levels down instead of needing a lookup. > > Signed-off-by: Christoph Hellwig Given the fact that HMM and now P2P are attracted to devm_memremap_pages() I think this churn is worth it.

Re: [PATCH 10/17] mm: merge vmem_altmap_alloc into altmap_alloc_block_buf

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > There is no clear separation between the two, so merge them. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe Looks good, Reviewed-by: Dan Williams

Re: [PATCH 09/17] mm: split altmap memory map allocation from normal case

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > No functional changes, just untangling the call chain. I'd also mention that creating more helper functions in the altmap_ namespace helps document why altmap is passed all around the hotplug code. > > Signed-off-by:

Re: [PATCH 02/17] mm: don't export arch_add_memory

On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > Only x86_64 and sh export this symbol, and it is not used by any > modular code. > > Signed-off-by: Christoph Hellwig Looks good, Reviewed-by: Dan Williams

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/13/17 5:18 PM, Nicolin Chen wrote: -* We are running on a SoC which does not support online SSI -* reconfiguration, so we have to enable all necessary flags at once -* even if we do not use them later (capture and playback configuration) +* Online

Re: [PATCH] Fix parse_args cycle limit check.

On 12/15/2017 01:41 PM, Michal Suchanek wrote: > Actually args are supposed to be renamed to next so both and args hold the > previous argument so both can be passed to the callback. This additionla patch additional > should fix up

[PATCH] SB600 for the Nemo board has non-zero devices on non-root bus

On 09 December 2017 at 7:03PM, Christian Zigotzky wrote: > On 08 December 2017 at 12:59PM, Michael Ellerman wrote: > > > >> Darren's idea of doing it at the same time you tweak the SB600 "relax > >> pci-e" bit is ideal because then the two pieces are obviously > >> connected and it wouldn't

[PATCH v4 2/2] powernv/kdump: Fix cases where the kdump kernel can get HMI's

Certain HMI's such as malfunction error propagate through all threads/core on the system. If a thread was offline prior to us crashing the system and jumping to the kdump kernel, bad things happen when it wakes up due to an HMI in the kdump kernel. There are several possible ways to solve this

Re: [PATCH v4 2/2] powernv/kdump: Fix cases where the kdump kernel can get HMI's

On Fri, 15 Dec 2017 19:14:55 +1100 Balbir Singh wrote: > Certain HMI's such as malfunction error propagate through > all threads/core on the system. If a thread was offline > prior to us crashing the system and jumping to the kdump > kernel, bad things happen when it wakes

Re: [PATCH v4 1/2] powerpc/crash: Remove the test for cpu_online in the IPI callback

On Fri, 15 Dec 2017 19:14:54 +1100 Balbir Singh wrote: > Our check was extra cautious, we've audited crash_send_ipi > and it sends an IPI only to online CPU's. Removal of this > check should have not functional impact on crash kdump. > Reviewed-by: Nicholas Piggin

[PATCH v4 1/2] powerpc/crash: Remove the test for cpu_online in the IPI callback

Our check was extra cautious, we've audited crash_send_ipi and it sends an IPI only to online CPU's. Removal of this check should have not functional impact on crash kdump. Signed-off-by: Balbir Singh --- arch/powerpc/kernel/crash.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH 03/17] mm: don't export __add_pages

This function isn't used by any modules, and is only to be called from core MM code. This includes the calls for the add_pages wrapper that might be inlined. Signed-off-by: Christoph Hellwig --- mm/memory_hotplug.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 07/17] mm: pass the vmem_altmap to vmemmap_free

We can just pass this on instead of having to do a radix tree lookup without proper locking a few levels into the callchain. Signed-off-by: Christoph Hellwig --- arch/arm64/mm/mmu.c| 3 +- arch/ia64/mm/discontig.c | 3 +- arch/powerpc/mm/init_64.c | 5 ++--

[PATCH 08/17] mm: pass the vmem_altmap to memmap_init_zone

Pass the vmem_altmap two levels down instead of needing a lookup. Signed-off-by: Christoph Hellwig --- arch/ia64/mm/init.c| 9 + include/linux/memory_hotplug.h | 2 +- include/linux/mm.h | 4 ++-- kernel/memremap.c | 2 +- mm/hmm.c

[PATCH 13/17] memremap: remove to_vmem_altmap

All callers are gone now. Signed-off-by: Christoph Hellwig --- include/linux/memremap.h | 9 - kernel/memremap.c| 26 -- 2 files changed, 35 deletions(-) diff --git a/include/linux/memremap.h b/include/linux/memremap.h index

[PATCH v4 1/2] powerpc/powernv: Enable tunneled operations

P9 supports PCI tunneled operations (atomics and as_notify). This patch adds support for tunneled operations on powernv, with a new API, to be called by device drivers: pnv_pci_get_tunnel_ind() Tell driver the 16-bit ASN indication used by kernel. pnv_pci_set_tunnel_bar() Tell kernel the

[PATCH 02/17] mm: don't export arch_add_memory

Only x86_64 and sh export this symbol, and it is not used by any modular code. Signed-off-by: Christoph Hellwig --- arch/sh/mm/init.c | 1 - arch/x86/mm/init_64.c | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c index

[PATCH 01/17] memremap: provide stubs for vmem_altmap_offset and vmem_altmap_free

Currently all calls to those functions are eliminated by the compiler when CONFIG_ZONE_DEVICE is not set, but this soon won't be the case. Signed-off-by: Christoph Hellwig --- include/linux/memremap.h | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff

[PATCH 06/17] mm: pass the vmem_altmap to arch_remove_memory and __remove_pages

We can just pass this on instead of having to do a radix tree lookup without proper locking 2 levels into the callchain. Signed-off-by: Christoph Hellwig wip --- arch/ia64/mm/init.c| 4 ++-- arch/powerpc/mm/mem.c | 6 ++ arch/s390/mm/init.c| 2 +-

[PATCH 12/17] mm: optimize dev_pagemap reference counting around get_dev_pagemap

Change the calling convention so that get_dev_pagemap always consumes the previous reference instead of doing this using an explicit earlier call to put_dev_pagemap in the callers. The callers will still need to put the final reference after finishing the loop over the pages. Signed-off-by:

[PATCH 04/17] mm: pass the vmem_altmap to arch_add_memory and __add_pages

We can just pass this on instead of having to do a radix tree lookup without proper locking 2 levels into the callchain. Signed-off-by: Christoph Hellwig --- arch/ia64/mm/init.c| 5 +++-- arch/powerpc/mm/mem.c | 5 +++-- arch/s390/mm/init.c| 5

[PATCH v4 2/2] cxl: read PHB indications from the device tree

Configure the P9 XSL_DSNCTL register with PHB indications found in the device tree, or else use legacy hard-coded values. Signed-off-by: Philippe Bergheaud --- Changelog: v2: New patch. Use the new device tree property "ibm,phb-indications". v3: No change. v4: No

revamp vmem_altmap / dev_pagemap handling V2

Hi all, this series started with two patches from Logan that now are in the middle of the series to kill the memremap-internal pgmap structure and to redo the dev_memreamp_pages interface to be better suitable for future PCI P2P uses. I reviewed them and noticed that there isn't really any good

[PATCH 05/17] mm: pass the vmem_altmap to vmemmap_populate

We can just pass this on instead of having to do a radix tree lookup without proper locking a few levels into the callchain. Signed-off-by: Christoph Hellwig --- arch/arm64/mm/mmu.c| 6 -- arch/ia64/mm/discontig.c | 3 ++- arch/powerpc/mm/init_64.c | 7

[PATCH 10/17] mm: merge vmem_altmap_alloc into altmap_alloc_block_buf

There is no clear separation between the two, so merge them. Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe --- mm/sparse-vmemmap.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-) diff --git

[PATCH 09/17] mm: split altmap memory map allocation from normal case

No functional changes, just untangling the call chain. Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe --- arch/powerpc/mm/init_64.c | 5 - arch/x86/mm/init_64.c | 5 - include/linux/mm.h| 9 ++--- mm/sparse-vmemmap.c

[PATCH 11/17] mm: move get_dev_pagemap out of line

This is a pretty big function, which should be out of line in general, and a no-op stub if CONFIG_ZONE_DEVICЕ is not set. Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe --- include/linux/memremap.h | 39 ---

Re: [PATCH] On ppc64le we HAVE_RELIABLE_STACKTRACE

On Tue, 12 Dec 2017 08:05:01 -0600 Josh Poimboeuf wrote: > On Tue, Dec 12, 2017 at 12:39:12PM +0100, Torsten Duwe wrote: > > Hi all, > > > > The "Power Architecture 64-Bit ELF V2 ABI" says in section 2.3.2.3: > > > > [...] There are several rules that must be adhered to in

Re: [mainline] rcu stalls on CPU when unbinding mpt3sas driver

On 12/12/2017 11:38 AM, Abdul Haleem wrote: > Hi, > > Off late we are seeing cpu stalls messages while mpt3sas driver unbind > on powerpc machine for both mainline and linux-next kernels > > Machine Type: Power 8 Bare-metal > Kernel version: 4.15.0-rc2 > config: attached. > test: driver unbind >

[PATCH 15/17] memremap: drop private struct page_map

From: Logan Gunthorpe 'struct page_map' is a private structure of 'struct dev_pagemap' but the latter replicates all the same fields as the former so there isn't much value in it. Thus drop it in favour of a completely public struct. This is a clean up in preperation for a

[PATCH 16/17] memremap: change devm_memremap_pages interface to use struct dev_pagemap

From: Logan Gunthorpe This new interface is similar to how struct device (and many others) work. The caller initializes a 'struct dev_pagemap' as required and calls 'devm_memremap_pages'. This allows the pagemap structure to be embedded in another structure and thus

[PATCH] Fix parse_args cycle limit check.

Actually args are supposed to be renamed to next so both and args hold the previous argument so both can be passed to the callback. This additionla patch should fix up the rename. --- kernel/params.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH] Optimize final quote removal.

This is additional patch that avoids the memmove when processing the quote on the end of the parameter. --- lib/cmdline.c | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/cmdline.c b/lib/cmdline.c index c5335a79a177..b1d8a0dc60fc

[PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages

__radix_tree_insert already checks for duplicates and returns -EEXIST in that case, so remove the duplicate (and racy) duplicates check. Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe --- kernel/memremap.c | 11 --- 1 file changed, 11

[PATCH 17/17] memremap: merge find_dev_pagemap into get_dev_pagemap

There is only one caller of the trivial function find_dev_pagemap left, so just merge it into the caller. Signed-off-by: Christoph Hellwig --- kernel/memremap.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/kernel/memremap.c b/kernel/memremap.c index

Mac Mini G4 defconfig ?

Hi there, Does anyone has working defconfig for a Mac Mini G4 ? Here is what I tried: $ cat ./arch/powerpc/configs/g4_defconfig CONFIG_PPC_FPU=y CONFIG_ALTIVEC=y $ make ARCH=powerpc g4_defconfig $ make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- V=1 set -e; : ' CHK

Re: [PATCH v9 2/8] boot/param: add pointer to current and next argument to unknown parameter callback

Hello, On Wed, 15 Nov 2017 20:47:14 +0530 Hari Bathini wrote: > From: Michal Suchanek > > Add pointer to current and next argument to make parameter processing > more robust. This can make parameter processing easier and less error > prone in

Re: [PATCH v9 1/8] lib/cmdline.c: remove quotes symmetrically

On Wed, 15 Nov 2017 20:46:56 +0530 Hari Bathini wrote: > From: Michal Suchanek > > Remove quotes from argument value only if there is qoute on both > sides. > > Signed-off-by: Michal Suchanek > --- > lib/cmdline.c | 10

Re: Mac Mini G4 defconfig ?

On Fri, Dec 15, 2017 at 8:50 PM, Mathieu Malaterre wrote: > Hi there, > > Does anyone has working defconfig for a Mac Mini G4 ? > > Here is what I tried: > > $ cat ./arch/powerpc/configs/g4_defconfig > CONFIG_PPC_FPU=y > CONFIG_ALTIVEC=y > $ make ARCH=powerpc g4_defconfig > $

Re: Mac Mini G4 defconfig ?

On Fri, Dec 15, 2017 at 9:52 PM, Mathieu Malaterre wrote: > On Fri, Dec 15, 2017 at 8:50 PM, Mathieu Malaterre wrote: >> Hi there, >> >> Does anyone has working defconfig for a Mac Mini G4 ? >> >> Here is what I tried: >> >> $ cat

Re: [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus

On Fri, Dec 15, 2017 at 09:04:51AM +0100, Christian Zigotzky wrote: > On 09 December 2017 at 7:03PM, Christian Zigotzky wrote: > > On 08 December 2017 at 12:59PM, Michael Ellerman wrote: > > > > > >> Darren's idea of doing it at the same time you tweak the SB600 "relax > > >> pci-e" bit is ideal

[PATCH] PCI: Add #defines for Completion Timeout Disable feature

From: Bjorn Helgaas Add #defines for the Completion Timeout Disable feature and use them. No functional change intended. Signed-off-by: Bjorn Helgaas --- arch/powerpc/platforms/powernv/eeh-powernv.c |6 +++--- include/uapi/linux/pci_regs.h