Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Tue, Mar 27, 2018 at 10:59:40AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2018-03-26 at 16:50 -0600, Jason Gunthorpe wrote: > > On Tue, Mar 27, 2018 at 09:36:11AM +1100, Benjamin Herrenschmidt wrote: > > > On Mon, 2018-03-26 at 16:27 -0600, Jason Gunthorpe wrote: > > > > > Otherwise almost

[PATCH v3 4/8] KVM: PPC: Book3S HV: Return error from h_set_mode(SET_DAWR) on POWER9

2018-03-26 Thread Michael Neuling
Return H_P2 on a h_set_mode(SET_DAWR) on POWER9 where the DAWR is disabled. Current Linux guests ignore this error, so they will silently not get the DAWR (sigh). The same error code is being used by POWERVM in this case. Signed-off-by: Michael Neuling ---

Re: [PATCH] powerpc, pkey: make protection key 0 less special

2018-03-26 Thread Ram Pai
On Mon, Mar 26, 2018 at 04:31:41PM -0700, Ram Pai wrote: > Applications need the ability to associate an address-range with some > key and latter revert to its initial default key. Pkey-0 comes close to > providing this function but falls short, because the current > implementation disallows

[PATCH] powerpc: do not allow userspace to modify execute-only pkey

2018-03-26 Thread Ram Pai
When mprotect(,PROT_EXEC) is called, the kernel allocates a execute-only pkey and associates the pkey with the given address space. The permission of this key should not be modifiable from userspace. However a bug in the current implementation lets the permissions on the key modifiable from

[PATCH v3 1/8] powerpc: Add ppc_breakpoint_available()

2018-03-26 Thread Michael Neuling
Add ppc_breakpoint_available() to determine if a breakpoint is available currently via the DAWR or DABR. Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/debug.h | 1 + arch/powerpc/kernel/process.c| 12 2 files changed, 13 insertions(+) diff

Re: linux-next: manual merge of the powerpc tree with the powerpc-fixes tree

2018-03-26 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the powerpc tree got a conflict in: > > arch/powerpc/include/asm/cputable.h > arch/powerpc/kernel/dt_cpu_ftrs.c > > between commit: > > a5d4b5891c2f ("powerpc/mm: Fixup tlbie vs store ordering issue

[PATCH] powerpc/mm: Fix thread_pkey_regs_init()

2018-03-26 Thread Ram Pai
thread_pkey_regs_init() initializes the pkey related registers instead of initializing the fields in the task structures. Fortunately those key related registers are re-set to zero when the task gets scheduled on the cpu. However its good to fix this glaringly visible error. cc: Michael Ellermen

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Linus Torvalds
On Mon, Mar 26, 2018 at 4:37 PM, John Paul Adrian Glaubitz wrote: > > What about a tarball with a minimal Debian x32 chroot? Then you can > install interesting packages you would like to test yourself. That probably works fine. Linus

Re: [PATCH] powerpc/mm: Fix thread_pkey_regs_init()

2018-03-26 Thread Balbir Singh
On Tue, Mar 27, 2018 at 1:36 PM, Ram Pai wrote: > thread_pkey_regs_init() initializes the pkey related registers > instead of initializing the fields in the task structures. Fortunately > those key related registers are re-set to zero when the task > gets scheduled on the

[PATCH v3 0/8] powerpc: Disable DAWR on POWER9

2018-03-26 Thread Michael Neuling
Using the DAWR on POWER9 can cause xstops, hence we need to disable it. The current CPU_FTR for DAWR is a bit messy. Despite having CPU_FTR_DAWR, currently we assume DAWR exists in the KVM code based on CPU_FTR_ARCH_207. In other places we assume DAWR exists if CPU_FTR_DAWR is set. This attempts

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Linus Torvalds
On Sun, Mar 25, 2018 at 8:44 PM, John Paul Adrian Glaubitz wrote: < > FWIW, we are maintaining an x32 port in Debian and there are some people > actually using it [1]. There is one build instance running on VMWare that > I am hosting [2] and around 10800 out of 12900

Re: [PATCH v9 21/24] perf tools: Add support for the SPF perf event

2018-03-26 Thread Andi Kleen
On Mon, Mar 26, 2018 at 02:44:48PM -0700, David Rientjes wrote: > On Tue, 13 Mar 2018, Laurent Dufour wrote: > > > Add support for the new speculative faults event. > > > > Signed-off-by: Laurent Dufour > > Acked-by: David Rientjes > > Aside:

Re: [PATCH v4] mm, pkey: treat pkey-0 special

2018-03-26 Thread Balbir Singh
On Tue, Mar 27, 2018 at 2:48 PM, Michael Ellerman wrote: > Ram Pai writes: > >> On Fri, Mar 16, 2018 at 10:02:22PM +1100, Balbir Singh wrote: >>> On Fri, Mar 16, 2018 at 9:33 PM, Ram Pai wrote: >>> > Applications need the ability to

[PATCH] powerpc: Only support DYNAMIC_FTRACE not static

2018-03-26 Thread Michael Ellerman
We've had dynamic ftrace support for over 9 years since Steve first wrote it, all the distros use dynamic, and static is basically untested these days, so drop support for static ftrace. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 1

[PATCH v3 3/8] powerpc: Update xmon to use ppc_breakpoint_available()

2018-03-26 Thread Michael Neuling
The 'bd' command will now print an error and not set the breakpoint on P9. Signed-off-by: Michael Neuling --- arch/powerpc/xmon/xmon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index a06cf6e389..047a682c6d

[PATCH v3 2/8] powerpc: Update ptrace to use ppc_breakpoint_available()

2018-03-26 Thread Michael Neuling
This updates the ptrace code to use ppc_breakpoint_available(). We now advertise via PPC_PTRACE_GETHWDBGINFO zero breakpoints when the DAWR is missing (ie. POWER9). This results in GDB falling back to software emulation of the breakpoint (which is slow). For the features advertised by

[PATCH v3 6/8] KVM: PPC: Book3S HV: Handle migration with POWER9 disabled DAWR

2018-03-26 Thread Michael Neuling
POWER9 with the DAWR disabled causes problems for partition migration. Either we have to fail the migration (since we lose the DAWR) or we silently drop the DAWR and allow the migration to pass. This patch does the latter and allows the migration to pass (at the cost of silently losing the DAWR).

[PATCH v3 8/8] powerpc: Disable DAWR in the base POWER9 CPU features

2018-03-26 Thread Michael Neuling
Using the DAWR on POWER9 can cause xstops, hence we need to disable it. Signed-off-by: Michael Neuling --- arch/powerpc/include/asm/cputable.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/cputable.h

[PATCH v3 7/8] powerpc: Disable DAWR on POWER9 via CPU feature quirk

2018-03-26 Thread Michael Neuling
This disables the DAWR on all POWER9 CPUs via cpu feature quirk. Using the DAWR on POWER9 can cause xstops, hence we need to disable it. Signed-off-by: Michael Neuling --- arch/powerpc/kernel/dt_cpu_ftrs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread John Paul Adrian Glaubitz
On 03/27/2018 12:40 PM, Linus Torvalds wrote: > On Mon, Mar 26, 2018 at 4:37 PM, John Paul Adrian Glaubitz > wrote: >> >> What about a tarball with a minimal Debian x32 chroot? Then you can >> install interesting packages you would like to test yourself. > > That

[PATCH v2] powerpc, pkey: make protection key 0 less special

2018-03-26 Thread Ram Pai
Applications need the ability to associate an address-range with some key and latter revert to its initial default key. Pkey-0 comes close to providing this function but falls short, because the current implementation disallows applications to explicitly associate pkey-0 to the address range.

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread John Paul Adrian Glaubitz
On 03/27/2018 10:03 AM, Linus Torvalds wrote: > Hmm. Do you have a few statically built binaries that could be tested > without installing a whole distribution? Something real and meaningful > enough that it actually exercised a few real system calls, but not > something that needs to bring in 50

Re: [PATCH v4] mm, pkey: treat pkey-0 special

2018-03-26 Thread Michael Ellerman
Ram Pai writes: > On Fri, Mar 16, 2018 at 10:02:22PM +1100, Balbir Singh wrote: >> On Fri, Mar 16, 2018 at 9:33 PM, Ram Pai wrote: >> > Applications need the ability to associate an address-range with some >> > key and latter revert to its initial

[PATCH v3 5/8] KVM: PPC: Book3S HV: Return error from h_set_dabr() on POWER9

2018-03-26 Thread Michael Neuling
POWER7 compat mode guests can use h_set_dabr on POWER9. POWER9 should use the DAWR but since it's disabled there we can't. This returns H_UNSUPPORTED on a h_set_dabr() on POWER9 where the DAWR is disabled. Current Linux guests ignore this error, so they will silently not get the DAWR (sigh). The

Re: [PATCH v2] powerpc/eeh: Fix race with driver un/bind

2018-03-26 Thread Benjamin Herrenschmidt
On Mon, 2018-03-26 at 15:17 +1100, Michael Neuling wrote: > The current EEH callbacks can race with a driver unbind. This > can result in a backtraces like this: > > [7.573055] EEH: Frozen PHB#0-PE#1fc detected > [7.573063] EEH: PE location: S09, PHB location: N/A > [7.573069]

[PATCH 04/10] powerpc/powernv: Set or clear security feature flags

2018-03-26 Thread Michael Ellerman
Now that we have feature flags for security related things, set or clear them based on what we see in the device tree provided by firmware. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/setup.c | 56 ++ 1 file changed, 56

[PATCH V6 2/4] powerpc/mm: Add support for handling > 512TB address in SLB miss

2018-03-26 Thread Aneesh Kumar K.V
For addresses above 512TB we allocate additional mmu contexts. To make it all easy, addresses above 512TB are handled with IR/DR=1 and with stack frame setup. The mmu_context_t is also updated to track the new extended_ids. To support upto 4PB we need a total 8 contexts. Signed-off-by: Aneesh

Re: [PATCH 2/2] smp: introduce kick_active_cpus_sync()

2018-03-26 Thread Andrea Parri
Hi Yury, On Sun, Mar 25, 2018 at 08:50:04PM +0300, Yury Norov wrote: > kick_all_cpus_sync() forces all CPUs to sync caches by sending broadcast IPI. > If CPU is in extended quiescent state (idle task or nohz_full userspace), this > work may be done at the exit of this state. Delaying

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Dominik Brodowski
On Mon, Mar 26, 2018 at 04:47:50AM +0100, Al Viro wrote: > * mips n32 and x86 x32 can become an extra source of headache. > That actually applies to any plans of passing struct pt_regs *. As it > is, e.g. syscall 515 on amd64 is compat_sys_readv(). Dispatched via > this: > /* >

[PATCH 03/10] powerpc/pseries: Set or clear security feature flags

2018-03-26 Thread Michael Ellerman
Now that we have feature flags for security related things, set or clear them based on what we receive from the hypercall. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/setup.c | 43 ++ 1 file changed, 43 insertions(+)

[PATCH 10/10] powerpc/64s: Wire up cpu_show_spectre_v2()

2018-03-26 Thread Michael Ellerman
Add a definition for cpu_show_spectre_v2() to override the generic version. This has several permuations, though in practice some may not occur we cater for any combination. The most verbose is: Mitigation: Indirect branch serialisation (kernel only), Indirect branch cache disabled, ori31

[PATCH V6 3/4] powerpc/mm/hash64: Increase the VA range

2018-03-26 Thread Aneesh Kumar K.V
This patch increases the max virtual (effective) address value to 4PB. With 4K page size config we continue to limit ourself to 64TB. Signed-off-by: Aneesh Kumar K.V [mpe: Keep the H_PGTABLE_RANGE test, update it to work] Signed-off-by: Michael Ellerman

Re: [v2, 1/5] powerpc: Add CPU feature bits for TM bug workarounds on POWER9 v2.2

2018-03-26 Thread Michael Ellerman
On Wed, 2018-03-21 at 10:31:59 UTC, Paul Mackerras wrote: > This adds a CPU feature bit which is set for POWER9 "Nimbus" DD2.2 > processors which will be used to enable the hypervisor to assist > hardware with the handling of checkpointed register values while the > CPU is in suspend state, in

[PATCH 05/10] powerpc/64s: Move cpu_show_meltdown()

2018-03-26 Thread Michael Ellerman
This landed in setup_64.c for no good reason other than we had nowhere else to put it. Now that we have a security-related file, that is a better place for it so move it. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/security.c | 12

[PATCH 06/10] powerpc/64s: Enhance the information in cpu_show_meltdown()

2018-03-26 Thread Michael Ellerman
Now that we have the security feature flags we can make the information displayed in the "meltdown" file more informative. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/security_features.h | 1 + arch/powerpc/kernel/security.c | 30

Re: [RFC PATCH v2 0/2] Randomization of address chosen by mmap.

2018-03-26 Thread Michal Hocko
On Fri 23-03-18 20:55:49, Ilya Smith wrote: > > > On 23 Mar 2018, at 15:48, Matthew Wilcox wrote: > > > > On Thu, Mar 22, 2018 at 07:36:36PM +0300, Ilya Smith wrote: > >> Current implementation doesn't randomize address returned by mmap. > >> All the entropy ends with

[PATCH V6 1/4] powerpc/mm/slice: Consolidate return path in slice_get_unmapped_area()

2018-03-26 Thread Aneesh Kumar K.V
In a following patch, on finding a free area we will need to do allocatinon of extra contexts as needed. Consolidating the return path for slice_get_unmapped_area() will make that easier. Split into a separate patch to make review easy. Signed-off-by: Aneesh Kumar K.V

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Linus Torvalds
On Sun, Mar 25, 2018 at 5:47 PM, Al Viro wrote: > > Linus, Dominik - how do you plan dealing with that fun? Secretly, I was hoping to kill x32, because it's not being used afaik. More realistically, I was thinking we'd just use a separate table or system calls, and

[PATCH 01/10] powerpc: Add security feature flags for Spectre/Meltdown

2018-03-26 Thread Michael Ellerman
This commit adds security feature flags to reflect the settings we receive from firmware regarding Spectre/Meltdown mitigations. The feature names reflect the names we are given by firmware on bare metal machines. See the hostboot source for details. Arguably these could be firmware features,

[PATCH 09/10] powerpc/64s: Wire up cpu_show_spectre_v1()

2018-03-26 Thread Michael Ellerman
Add a definition for cpu_show_spectre_v1() to override the generic version. Currently this just prints "Not affected" or "Vulnerable" based on the firmware flag. Although the kernel does have array_index_nospec() in a few places, we haven't yet audited all the powerpc code to see where it's

[PATCH V6 4/4] powerpc/mm/hash: Don't memset pgd table if not needed

2018-03-26 Thread Aneesh Kumar K.V
We need to zero-out pgd table only if we share the slab cache with pud/pmd level caches. With the support of 4PB, we don't share the slab cache anymore. Instead of removing the code completely hide it within an #ifdef. We don't need to do this with any other page table level, because they all

Re: [1/3] powerpc: Use feature bit for RTC presence rather than timebase presence

2018-03-26 Thread Michael Ellerman
On Mon, 2018-03-19 at 21:46:11 UTC, Paul Mackerras wrote: > All PowerPC CPUs other than the original PPC601 have a timebase > register rather than the "real-time clock" (RTC) register that the > PPC601 (and the original POWER and POWER2 CPUs) had. Currently > we have a CPU feature bit to indicate

[PATCH 02/10] powerpc/pseries: Add new H_GET_CPU_CHARACTERISTICS flags

2018-03-26 Thread Michael Ellerman
Add some additional values which have been defined for the H_GET_CPU_CHARACTERISTICS hypercall. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/hvcall.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/include/asm/hvcall.h

[PATCH 08/10] powerpc/pseries: Use the security flags in pseries_setup_rfi_flush()

2018-03-26 Thread Michael Ellerman
Now that we have the security flags we can simplify the code in pseries_setup_rfi_flush() because the security flags have pessimistic defaults. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/setup.c | 39 ++ 1 file

Re: [PATCH] powerpc: Implement cross-endian emulation of larx and stcx instructions

2018-03-26 Thread Michael Ellerman
Paul Mackerras writes: > diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c > index fb9f58b..0590417 100644 > --- a/arch/powerpc/lib/sstep.c > +++ b/arch/powerpc/lib/sstep.c > @@ -2755,8 +2761,11 @@ int emulate_loadstore(struct pt_regs *regs, struct >

[PATCH V6 0/4] Add support for 4PB virtual address space on hash

2018-03-26 Thread Aneesh Kumar K.V
This patch series extended the max virtual address space value from 512TB to 4PB with 64K page size. We do that by allocating one vsid context for each 512TB range. More details of that is explained in patch 3. Changes from V5: * Fix for loop segmentation fault. * updates from Michael Changes

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread Linus Torvalds
On Sun, Mar 25, 2018 at 8:15 PM, Linus Torvalds wrote: > > HOWEVER. > > I didn't actually test any of the compat or x32 ones, and the way I > did it there also was no type-checking or other automated catching of > getting it wrong. So it's almost certainly

Re: [RFC] new SYSCALL_DEFINE/COMPAT_SYSCALL_DEFINE wrappers

2018-03-26 Thread John Paul Adrian Glaubitz
Hi Linus! On 03/26/2018 03:15 PM, Linus Torvalds wrote: > Secretly, I was hoping to kill x32, because it's not being used afaik. FWIW, we are maintaining an x32 port in Debian and there are some people actually using it [1]. There is one build instance running on VMWare that I am hosting [2] and

[PATCH 07/10] powerpc/powernv: Use the security flags in pnv_setup_rfi_flush()

2018-03-26 Thread Michael Ellerman
Now that we have the security flags we can significantly simplify the code in pnv_setup_rfi_flush(), because we can use the flags instead of checking device tree properties and because the security flags have pessimistic defaults. Signed-off-by: Michael Ellerman ---

Re: [PATCH v6 11/12] ima: Implement support for module-style appended signatures

2018-03-26 Thread Mimi Zohar
On Fri, 2018-03-16 at 17:38 -0300, Thiago Jung Bauermann wrote: > This patch actually implements the appraise_type=imasig|modsig option, > allowing IMA to read and verify modsig signatures. > > In case both are present in the same file, IMA will first check whether the > key used by the xattr

Re: DMA Mapping Error in ppc64

2018-03-26 Thread Jared Bents
Hi Ben On Sat, Mar 24, 2018 at 3:19 AM, Benjamin Herrenschmidt wrote: > On Fri, 2018-03-23 at 07:41 -0500, Jared Bents wrote: >> Thank you for the advice. Looks like I get to try to rewrite the ath9k and >> ath10k drivers to use dma_alloc_coherent() instead of

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Arnd Bergmann
On Wed, Mar 21, 2018 at 2:58 PM, Sinan Kaya wrote: > On 3/21/2018 8:53 AM, Sinan Kaya wrote: >> BTW, I have no idea what compiler barrier does on PPC and if >> >> wrltel() == compiler barrier() + wrltel_relaxed() >> >> can be said. > > this should have been > >

RE: RFC on writel and writel_relaxed

2018-03-26 Thread David Laight
> > This is a super performance critical operation for most drivers and > > directly impacts network performance. Perhaps there ought to be writel_nobarrier() (etc) that never contain any barriers at all. This might mean that they are always just the memory operation, but it would make it more

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Will Deacon
Hi Ben, I don't seem to have the beginning of this thread, so please bounce it over if you'd like me to look at it! On Fri, Mar 23, 2018 at 11:16:08AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-03-22 at 12:51 -0500, Sinan Kaya wrote: > > On 3/22/2018 8:52 AM, Benjamin Herrenschmidt

Re: RFC on writel and writel_relaxed

2018-03-26 Thread okaya
On 2018-03-26 07:44, Will Deacon wrote: Hi Ben, I don't seem to have the beginning of this thread, so please bounce it over if you'd like me to look at it! https://www.spinics.net/lists/linux-rdma/msg62570.html https://www.spinics.net/lists/linux-rdma/index.html#62666 On Fri, Mar 23,

Re: [PATCH v6 12/12] ima: Write modsig to the measurement list

2018-03-26 Thread Mimi Zohar
On Fri, 2018-03-16 at 17:38 -0300, Thiago Jung Bauermann wrote: > Define new "d-sig" template field which holds the digest that is expected > to match the one contained in the modsig. > > Also add modsig support to the "sig" template field, allowing the the > contents of the modsig to be included

Re: [PATCH 2/2] smp: introduce kick_active_cpus_sync()

2018-03-26 Thread Paul E. McKenney
On Sun, Mar 25, 2018 at 11:11:54PM +0300, Yury Norov wrote: > On Sun, Mar 25, 2018 at 12:23:28PM -0700, Paul E. McKenney wrote: > > On Sun, Mar 25, 2018 at 08:50:04PM +0300, Yury Norov wrote: > > > kick_all_cpus_sync() forces all CPUs to sync caches by sending broadcast > > > IPI. > > > If CPU is

[PATCH v3 01/41] cxlflash: Preserve number of interrupts for master contexts

2018-03-26 Thread Uma Krishnan
The number of interrupts requested for user contexts are stored in the context specific structures and utilized to manage the interrupts. For the master contexts, this number is only used once and therefore not saved. To prepare for future commits where the number of interrupts will be required

[PATCH v3 13/41] cxlflash: Support adapter file descriptors for OCXL

2018-03-26 Thread Uma Krishnan
Allocate a file descriptor for an adapter context when requested. In order to allocate inodes for the file descriptors, a pseudo filesystem is created and used. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs ---

[PATCH v3 27/41] cxlflash: Support adapter context polling

2018-03-26 Thread Uma Krishnan
The cxlflash userspace API requires that users be able to poll the adapter context for any pending events or interrupts from the AFU. Support polling on various events by implementing the AFU poll fop using a waitqueue. Signed-off-by: Uma Krishnan Acked-by: Matthew R.

[PATCH v3 33/41] cxlflash: Setup LISNs for master contexts

2018-03-26 Thread Uma Krishnan
Similar to user contexts, master contexts also require that the per-context LISN registers be programmed for certain AFUs. The mapped trigger page is obtained from underlying transport and registered with AFU for each master context. Signed-off-by: Uma Krishnan

[PATCH v3 40/41] cxlflash: Remove commmands from pending list on timeout

2018-03-26 Thread Uma Krishnan
The following Oops can occur if an internal command sent to the AFU does not complete within the timeout: [c00ff101b810] c00816020d94 term_mc+0xfc/0x1b0 [cxlflash] [c00ff101b8a0] c00816020fb0 term_afu+0x168/0x280 [cxlflash] [c00ff101b930] c008160232ec

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Jason Gunthorpe
On Mon, Mar 26, 2018 at 11:08:45AM +, David Laight wrote: > > > This is a super performance critical operation for most drivers and > > > directly impacts network performance. > > Perhaps there ought to be writel_nobarrier() (etc) that never contain > any barriers at all. > This might mean

Re: RFC on writel and writel_relaxed

2018-03-26 Thread Sinan Kaya
On 3/26/2018 8:11 AM, ok...@codeaurora.org wrote: > On 2018-03-26 07:44, Will Deacon wrote: >> Hi Ben, >> >> I don't seem to have the beginning of this thread, so please bounce it over >> if you'd like me to look at it! >> > > https://www.spinics.net/lists/linux-rdma/msg62570.html > >

[PATCH v3 02/41] cxlflash: Avoid clobbering context control register value

2018-03-26 Thread Uma Krishnan
From: "Matthew R. Ochs" The SISLite specification originally defined the context control register with a single field of bits to represent the LISN and also stipulated that the register reset value be 0. The cxlflash driver took advantage of this when programming the

[PATCH v3 05/41] cxlflash: Hardware AFU for OCXL

2018-03-26 Thread Uma Krishnan
When an adapter is initialized, transport specific configuration and MMIO mapping details need to be saved. For CXL, this data is managed by the underlying kernel module. To maintain a separation between the cxlflash core and underlying transports, introduce a new structure to store data specific

[PATCH v3 08/41] cxlflash: Read host AFU configuration

2018-03-26 Thread Uma Krishnan
The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 10/41] cxlflash: Setup AFU PASID

2018-03-26 Thread Uma Krishnan
Per the OCXL specification, the maximum PASID supported by the AFU is indicated by a field within the configuration space. Similar to acTags, implementations can choose to use any sub-range of PASID within their assigned range. For cxlflash, the entire range is used. Signed-off-by: Uma Krishnan

[PATCH v3 14/41] cxlflash: Support adapter context discovery

2018-03-26 Thread Uma Krishnan
Provide means to obtain the process element of an adapter context as well as locate an adapter context by file. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 26 ++ 1

[PATCH v3 16/41] cxlflash: MMIO map the AFU

2018-03-26 Thread Uma Krishnan
When the AFU is configured, the global and per process MMIO regions are presented by the configuration space. Save these regions and map the global MMIO region that is used to access all of the control and provisioning data in the AFU. Signed-off-by: Uma Krishnan

[PATCH v3 22/41] cxlflash: Setup OCXL transaction layer

2018-03-26 Thread Uma Krishnan
The first function of the link needs to configure the transaction layer between the host and device. This is accomplished by a call to the OCXL provider services. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs ---

[PATCH v3 24/41] cxlflash: Support AFU interrupt management

2018-03-26 Thread Uma Krishnan
Add support to allocate and free AFU interrupts using the OCXL provider services. The trigger page returned upon successful allocation will be mapped and exposed to the cxlflash core in a future commit. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 32/41] cxlflash: Setup LISNs for user contexts

2018-03-26 Thread Uma Krishnan
The SISLite specification has been updated for OCXL to support communicating data to generate AFU interrupts to the AFU. This includes a new capability bit that is advertised for OCXL AFUs and new registers to hold the object handle and translation PASID of each interrupt. For Power, the object

[PATCH v3 35/41] cxlflash: Introduce OCXL context state machine

2018-03-26 Thread Uma Krishnan
In order to protect the OCXL hardware contexts from getting clobbered, a simple state machine is added to indicate when a context is in open, close or start state. The expected states are validated throughout the code to prevent illegal operations on a context. A mutex is added to protect writes

[PATCH v3 00/41] cxlflash: OCXL transport support and miscellaneous fixes

2018-03-26 Thread Uma Krishnan
This patch series adds OCXL support to the cxlflash driver. With this support, new devices using the OCXL transport will be supported by the cxlflash driver along with the existing CXL devices. An effort is made to keep this transport specific function independent of the existing core driver that

[PATCH v3 04/41] cxlflash: Introduce OCXL backend

2018-03-26 Thread Uma Krishnan
Add initial infrastructure to support a new cxlflash transport, OCXL. Claim a dependency on OCXL and add a new file, ocxl_hw.c, which will host the backend routines that are specific to OCXL. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 06/41] cxlflash: Read host function configuration

2018-03-26 Thread Uma Krishnan
Per the OCXL specification, the underlying host can have multiple AFUs per function with each function supporting its own configuration. The host function configuration is read on the initialization path to evaluate the number of functions present and identify the features and configuration of the

[PATCH v3 12/41] cxlflash: Use IDR to manage adapter contexts

2018-03-26 Thread Uma Krishnan
A range of PASIDs are used as identifiers for the adapter contexts. These contexts may be destroyed and created randomly. Use an IDR to keep track of contexts that are in use and assign a unique identifier to new ones. Signed-off-by: Uma Krishnan Acked-by: Matthew R.

[PATCH v3 15/41] cxlflash: Support image reload policy modification

2018-03-26 Thread Uma Krishnan
On a PERST, the AFU image can be reloaded or left intact. Provide means to set this image reload policy. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 13 +

[PATCH v3 17/41] cxlflash: Support starting an adapter context

2018-03-26 Thread Uma Krishnan
Once the adapter context is created, it needs to be started by assigning the MMIO space for the context and by enabling the process element in the link. This commit adds the skeleton for starting the context and assigns the context specific MMIO space. Master contexts have access to the global

[PATCH v3 18/41] cxlflash: Support process specific mappings

2018-03-26 Thread Uma Krishnan
Once the context is started, the assigned MMIO space can be mapped and unmapped. Provide means to map and unmap the context MMIO space. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 24

[PATCH v3 26/41] cxlflash: Support starting user contexts

2018-03-26 Thread Uma Krishnan
User contexts request interrupts and are started using the "start work" interface. Populate the start_work() fop to allocate and map interrupts before starting the user context. As part of starting the context, update the user process identification logic to properly derive the data required by

[PATCH v3 30/41] cxlflash: Support file descriptor mapping

2018-03-26 Thread Uma Krishnan
The cxlflash core fop API requires a way to invoke the fault and release handlers of underlying transports using their native file-based APIs. This provides the core with the ability to insert selectively itself into the processing stream of these operations for cleanup. Implement these two fops

[PATCH v3 34/41] cxlflash: Update synchronous interrupt status bits

2018-03-26 Thread Uma Krishnan
The SISLite specification has been updated to define new synchronous interrupt status bits. These bits are set by the AFU when a given PASID or EA is bad and a synchronous interrupt is triggered. The SISLite header file is updated to support these new bits. Note that there are also some

[PATCH v3 36/41] cxlflash: Register for translation errors

2018-03-26 Thread Uma Krishnan
While enabling a context on the link, a predefined callback can be registered with the OCXL provider services to be notified on translation errors. These errors can in turn be passed back to the user on a read operation. Signed-off-by: Uma Krishnan Acked-by: Matthew

[PATCH v3 39/41] cxlflash: Synchronize reset and remove ops

2018-03-26 Thread Uma Krishnan
The following Oops can be encountered if a device removal or system shutdown is initiated while an EEH recovery is in process: [c00ff2f479c0] c00815256f18 cxlflash_pci_slot_reset+0xa0/0x100 [cxlflash] [c00ff2f47a30] c0080dae22e0

[PATCH v3 41/41] cxlflash: Handle spurious interrupts

2018-03-26 Thread Uma Krishnan
The following Oops can occur when there is heavy I/O traffic and the host is reset by a tool such as sg_reset. [c000200fff3fbc90] c0081690117c process_cmd_doneq+0x104/0x500 [cxlflash] (unreliable) [c000200fff3fbd80] c00816901648

[PATCH v3 07/41] cxlflash: Setup function acTag range

2018-03-26 Thread Uma Krishnan
The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. The platform-specific acTag range for the link is obtained using the OCXL provider services and then assigned to the host function based on implementation. Signed-off-by: Uma Krishnan

[PATCH v3 09/41] cxlflash: Setup AFU acTag range

2018-03-26 Thread Uma Krishnan
The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. As cxlflash devices are expected to only support a single AFU per function, the entire range that was assigned to the function is also assigned to the AFU. Signed-off-by: Uma Krishnan

[PATCH v3 11/41] cxlflash: Adapter context support for OCXL

2018-03-26 Thread Uma Krishnan
Add support to create and release the adapter contexts for OCXL and provide means to specify certain contexts as a master. The existing cxlflash core has a design requirement that each host will have a single host context available by default. To satisfy this requirement, one host adapter context

[PATCH v3 19/41] cxlflash: Support AFU state toggling

2018-03-26 Thread Uma Krishnan
The AFU should be enabled following a successful configuration and disabled near the end of the cleanup path. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Frederic Barrat ---

[PATCH v3 23/41] cxlflash: Support process element lifecycle

2018-03-26 Thread Uma Krishnan
As part of the context lifecycle, the associated process element within the Shared Process Area (SPA) of the link must be updated. Each process is defined by various parameters (pid, tid, PASID mm) that are stored in the SPA upon starting a context and invalidated when a context is stopped. Use

[PATCH v3 25/41] cxlflash: Support AFU interrupt mapping and registration

2018-03-26 Thread Uma Krishnan
Add support to map and unmap the irq space and manage irq registrations with the kernel for each allocated AFU interrupt. Also support mapping the physical trigger page to obtain an effective address that will be provided to the cxlflash core in a future commit. Signed-off-by: Uma Krishnan

[PATCH v3 28/41] cxlflash: Support adapter context reading

2018-03-26 Thread Uma Krishnan
The cxlflash userspace API requires that users be able to read the adapter context for any pending events or interrupts from the AFU. Support reading various events by implementing the AFU read fop to copy out event data. Signed-off-by: Uma Krishnan Acked-by: Matthew

[PATCH v3 31/41] cxlflash: Introduce object handle fop

2018-03-26 Thread Uma Krishnan
OCXL requires that AFUs use an opaque object handle to represent an AFU interrupt. The specification does not provide a common means to communicate the object handle to the AFU - each AFU must define this within the AFU specification. To support this model, the object handle must be passed back to

[PATCH v3 37/41] cxlflash: Support AFU reset

2018-03-26 Thread Uma Krishnan
The cxlflash core driver resets the AFU when the master contexts are created in the initialization or recovery paths. Today, the OCXL provider service to perform this operation is pending implementation. To avoid a crash due to a missing fop, log an error once and return success to continue with

[PATCH v3 03/41] cxlflash: Add argument identifier names

2018-03-26 Thread Uma Krishnan
Checkpatch throws a warning when the argument identifier names are not included in the function definitions. To avoid these warnings, argument identifiers are added in the existing function definitions. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 20/41] cxlflash: Support reading adapter VPD data

2018-03-26 Thread Uma Krishnan
Use the PCI VPD services to support reading the VPD data of the underlying adapter. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v3 21/41] cxlflash: Setup function OCXL link

2018-03-26 Thread Uma Krishnan
After reading and modifying the function configuration, setup the OCXL link using the OCXL provider services. The link is released when the adapter is unconfigured. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Frederic

[PATCH v3 29/41] cxlflash: Support adapter context mmap and release

2018-03-26 Thread Uma Krishnan
The cxlflash userspace API requires that users be able to mmap and release the adapter context. Support mapping by implementing the AFU mmap fop to map the context MMIO space and install the corresponding page table entry upon page fault. Similarly, implement the AFU release fop to terminate and

  1   2   >