Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Andrew Donnellan
On 23/08/18 21:56, Michael Ellerman wrote: Christophe LEROY writes: Le 23/08/2018 à 12:36, Segher Boessenkool a écrit : On Thu, Aug 23, 2018 at 11:40:22AM +0200, Christophe LEROY wrote: The only small problème I have is that some version of GCC seems to complain about big memset() (132k and

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Segher Boessenkool
On Thu, Aug 23, 2018 at 11:32:16PM +1000, Andrew Donnellan wrote: > On 23/08/18 21:56, Michael Ellerman wrote: > >Christophe LEROY writes: > > > >>Le 23/08/2018 à 12:36, Segher Boessenkool a écrit : > >>>On Thu, Aug 23, 2018 at 11:40:22AM +0200, Christophe LEROY wrote: > The only small

Re: KVM: PPC: Book3S: Fix guest DMA when guest partially backed by THP pages

2018-08-23 Thread Michael Ellerman
On Thu, 2018-08-23 at 00:08:58 UTC, Paul Mackerras wrote: > Commit 76fa4975f3ed ("KVM: PPC: Check if IOMMU page is contained in the > pinned physical page", 2018-07-17) added some checks to ensure that guest > DMA mappings don't attempt to map more than the guest is entitled to > access. However,

Re: [1/2] powerpc/mm/books3s: Add new pte bit to mark pte temporarily invalid.

2018-08-23 Thread Michael Ellerman
On Wed, 2018-08-22 at 17:16:04 UTC, "Aneesh Kumar K.V" wrote: > When splitting a huge pmd pte, we need to mark the pmd entry invalid. We > can do that by clearing _PAGE_PRESENT bit. But then that will be taken as a > swap pte. In order to differentiate between the two use a software pte bit > when

Re: [v2] poewrpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Michael Ellerman
On Thu, 2018-08-23 at 04:56:08 UTC, Mahesh J Salgaonkar wrote: > From: Mahesh Salgaonkar > > With the powrpc next commit e7e81847478 (poewrpc/mce: Fix SLB rebolting > during MCE recovery path.), the SLB error recovery is broken. The new > change now does not add index value to RB[52-63] that

RE: [PATCH 5/5] arm64: dts: add LX2160ARDB board support

2018-08-23 Thread Vabhav Sharma
> -Original Message- > From: Rob Herring > Sent: Wednesday, August 22, 2018 2:15 AM > To: Vabhav Sharma > Cc: linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; Mark Rutland > ; linuxppc-dev ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Christophe LEROY
Le 23/08/2018 à 16:41, Segher Boessenkool a écrit : On Thu, Aug 23, 2018 at 11:32:16PM +1000, Andrew Donnellan wrote: On 23/08/18 21:56, Michael Ellerman wrote: Christophe LEROY writes: Le 23/08/2018 à 12:36, Segher Boessenkool a écrit : On Thu, Aug 23, 2018 at 11:40:22AM +0200,

Re: powerpc/nohash: fix pte_access_permitted()

2018-08-23 Thread Michael Ellerman
On Tue, 2018-08-21 at 13:03:23 UTC, Christophe Leroy wrote: > Commit 5769beaf180a8 ("powerpc/mm: Add proper pte access check helper > for other platforms") replaced generic pte_access_permitted() by an > arch specific one. > > The generic one is defined as > (pte_present(pte) && (!(write) ||

RE: [PATCH 4/5] arm64: dts: add QorIQ LX2160A SoC support

2018-08-23 Thread Vabhav Sharma
> -Original Message- > From: Sudeep Holla > Sent: Tuesday, August 21, 2018 3:47 PM > To: Vabhav Sharma > Cc: linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; > robh...@kernel.org; mark.rutl...@arm.com; linuxppc-dev@lists.ozlabs.org; > linux-arm-ker...@lists.infradead.org;

Re: [RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Mahesh Jagannath Salgaonkar
On 08/23/2018 05:35 PM, Michael Ellerman wrote: > Mahesh Jagannath Salgaonkar writes: > >> On 08/23/2018 12:14 PM, Michael Ellerman wrote: >>> Mahesh J Salgaonkar writes: >>> From: Mahesh Salgaonkar With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting

Re: DT case sensitivity

2018-08-23 Thread Grant Likely
On 23/08/2018 12:47, Benjamin Herrenschmidt wrote: On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: What problem are you trying to solve? I'm looking at removing device_node.name and using full_name instead (which now is only the

[RFC PATCH 00/11] Secure Virtual Machine Enablement

2018-08-23 Thread Thiago Jung Bauermann
This series contains preliminary work to enable Secure Virtual Machines (SVM) on powerpc. SVMs request to be migrated to secure memory very early in the boot process (in prom_init()), so by default all of their memory is inaccessible to the hypervisor. There is an ultravisor call that the VM can

[RFC PATCH 09/11] powerpc/svm: Use shared memory for LPPACA structures

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual LPPACA structures need to be shared with the host. Hence they need to be on shared memory. Instead of allocating individual chunks of memory for given structure from memblock, a contiguous chunk of memory is allocated and then converted into shared memory. Subsequent

[RFC PATCH 08/11] powerpc: Add and use LPPACA_SIZE constant

2018-08-23 Thread Thiago Jung Bauermann
Helps document what the hard-coded number means. Suggested-by: Alexey Kardashevskiy Signed-off-by: Thiago Jung Bauermann --- arch/powerpc/kernel/paca.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/paca.c b/arch/powerpc/kernel/paca.c index

Re: DT case sensitivity

2018-08-23 Thread Grant Likely
On 23/08/2018 13:08, Rob Herring wrote: On Thu, Aug 23, 2018 at 6:48 AM Benjamin Herrenschmidt wrote: On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: What problem are you trying to solve? I'm looking at removing device_node.name

[RFC PATCH 02/11] powerpc/svm: Select CONFIG_DMA_DIRECT_OPS and CONFIG_SWIOTLB

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual Ultravisor based secure guest platforms will use generic SWIOTLB DMA API (i.e swiotlb_dma_ops structure) available under the CONFIG_DMA_DIRECT_OPS config. Also base CONFIG_SWIOTLB needs to be explicitly selected as well. Select both these config options on powerpc server

[RFC PATCH 03/11] powerpc/svm: Add memory conversion (shared/secure) helper functions

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual Add the following helper functions to convert PAGE_SIZE aligned memory buffers as shared or secure (i.e., accessible to the hypervisor or not) via Ultravisor calls. 1. mem_convert_shared(unsigned long pfn, unsigned long npages) 2. mem_convert_secure(unsigned long pfn,

[RFC PATCH 04/11] powerpc/svm: Convert SWIOTLB buffers to shared memory

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual Hook the shared memory conversion functions into the ARCH_HAS_MEM_ENCRYPT framework and call swiotlb_update_mem_attributes() to convert SWIOTLB's buffers to shared memory. Signed-off-by: Anshuman Khandual Signed-off-by: Thiago Jung Bauermann --- arch/powerpc/Kconfig

Re: [PATCH kernel RFC 0/3] powerpc/pseries/iommu: GPU coherent memory pass through

2018-08-23 Thread Alexey Kardashevskiy
On 09/08/2018 14:41, Alexey Kardashevskiy wrote: > > > On 25/07/2018 19:50, Alexey Kardashevskiy wrote: >> I am trying to pass through a 3D controller: >> [0302]: NVIDIA Corporation GV100GL [Tesla V100 SXM2] [10de:1db1] (rev a1) >> >> which has a quite unique feature as coherent memory

[RFC PATCH 11/11] powerpc/svm: Increase SWIOTLB buffer size

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual SWIOTLB buffer default size (64MB) is not enough for large sequential write operations which eventually leads to kernel crash like here. virtio-pci :00:05.0: swiotlb buffer is full (sz: 327680 bytes) virtio-pci :00:05.0: DMA: Out of SW-IOMMU space for 327680

Re: DT case sensitivity

2018-08-23 Thread Grant Likely
On 23/08/2018 02:29, Benjamin Herrenschmidt wrote: On Wed, 2018-08-22 at 20:26 -0500, Rob Herring wrote: On Wed, Aug 22, 2018 at 8:14 PM Benjamin Herrenschmidt wrote: On Wed, 2018-08-22 at 19:47 -0500, Rob Herring wrote: The default DT string handling in the kernel is node names and

[RFC PATCH 01/11] powerpc/svm: Detect Secure Virtual Machine (SVM) platform

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual A guest requests to be moved to secure memory early at the kernel startup (in prom_init). Define a flag that can be easily checked by other parts of the kernel so that they can set things up accordingly. This is done by checking the MSR(S) bit, which is always set for

[RFC PATCH 05/11] powerpc/svm: Don't release SWIOTLB buffers on secure guests

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual Even though SWIOTLB slab gets allocated and initialized on each powerpc platform with swiotlb_init(), it gets released away again on all server platforms because ppc_swiotlb_enable variable never gets set. Secure guests would require SWIOTLB DMA API support for virtio

[RFC PATCH 06/11] powerpc/svm: Use SWIOTLB DMA API for all virtio devices

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual Secure guest memory (GPA range) is isolated and inaccessible from the host. But virtio ring transactions require the back end drivers to process incoming scatter gather buffers which require their access in host. Hence a portion of guest memory can be converted to shared

[RFC PATCH 07/11] powerpc/svm: Use shared memory for Debug Trace Log (DTL)

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual On Ultravisor platform kmem_cache for DTL buffers must use a constructor function which converts the underlying buddy allocated SLUB cache pages into shared memory so that they are accessible to the hypervisor. Signed-off-by: Anshuman Khandual Signed-off-by: Thiago Jung

[RFC PATCH 10/11] powerpc/svm: Force the use of bounce buffers

2018-08-23 Thread Thiago Jung Bauermann
From: Anshuman Khandual SWIOTLB checks range of incoming CPU addresses to be bounced and see if the device can access it through it's DMA window without requiring bouncing. In such cases it just chooses to skip bouncing. But for cases like secure guests on powerpc platform all addresses need to

Re: [PATCH v2] crypto: vmx - Fix sleep-in-atomic bugs

2018-08-23 Thread Paulo Flabiano Smorigo
On 2018-08-22 21:04, Marcelo Henrique Cerri wrote: That looks good to me. Maybe Paulo can help testing it. -- Regards, Marcelo On Wed, Aug 22, 2018 at 08:26:31AM +0200, Ondrej Mosnacek wrote: This patch fixes sleep-in-atomic bugs in AES-CBC and AES-XTS VMX implementations. The problem is that

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Michael Ellerman
Segher Boessenkool writes: > On Thu, Aug 23, 2018 at 11:32:16PM +1000, Andrew Donnellan wrote: >> On 23/08/18 21:56, Michael Ellerman wrote: >> >Christophe LEROY writes: >> > >> >>Le 23/08/2018 à 12:36, Segher Boessenkool a écrit : >> >>>On Thu, Aug 23, 2018 at 11:40:22AM +0200, Christophe

Re: DT case sensitivity

2018-08-23 Thread Michael Ellerman
Rob Herring writes: > The default DT string handling in the kernel is node names and > compatibles are case insensitive and property names are case sensitive > (Sparc is the the only variation and is opposite). It seems only PPC > (and perhaps only Power Macs?) needs to support case insensitive

Re: [RFC PATCH 00/11] Secure Virtual Machine Enablement

2018-08-23 Thread Christoph Hellwig
It seems like you only sent out 6 our of the actual 11 patches according to the numbering, please resend the full series.

[PATCH 2/2] soc: fsl: qbman: qman: avoid allocating from non existing gen_pool

2018-08-23 Thread Alexandre Belloni
If the qman driver didn't probe, calling qman_alloc_fqid_range, qman_alloc_pool_range or qman_alloc_cgrid_range (as done in dpaa_eth) will pass a NULL pointer to gen_pool_alloc, leading to a NULL pointer dereference. Signed-off-by: Alexandre Belloni --- drivers/soc/fsl/qbman/qman.c | 3 +++ 1

Re: DT case sensitivity

2018-08-23 Thread Benjamin Herrenschmidt
On Thu, 2018-08-23 at 07:19 -0500, Segher Boessenkool wrote: > If one implementation does case insensitive, it will most likely just work, > because people do not make insane names differing only in case on purpose. Apple did :-) ide, vs IDE, ata vs ATA, I've seen all sort of crap there, esp. on

[PATCH v2] powerpc/xive: Avoid unitialized variable

2018-08-23 Thread Breno Leitao
From: Breno Leitao Function xive_native_get_ipi() might uses chip_id without it being initialized. This gives the following error on 'smatch' tool: error: uninitialized symbol 'chip_id' The suggestion is using xc->chip_id instead of consulting the OF for chip id, which is safe since

[PATCH 1/2] soc: fsl: qbman: qman_portal: defer probing when qman is not available

2018-08-23 Thread Alexandre Belloni
If the qman driver (qman_ccsr) doesn't probe or fail to probe before qman_portal, qm_ccsr_start will be either NULL or a stale pointer to an unmapped page. This leads to a crash when probing qman_portal as the init_pcfg function calls qman_liodn_fixup that tries to read qman registers. Assume

[RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting during MCE recovery path.), the SLB error recovery is broken. The new change now does not add index value to RB[52-63] that selects the SLB entry while rebolting, instead it assumes that the shadow

Re: [RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Nicholas Piggin
On Thu, 23 Aug 2018 12:06:53 +0530 Mahesh J Salgaonkar wrote: > From: Mahesh Salgaonkar > > With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting > during MCE recovery path.), the SLB error recovery is broken. The new > change now does not add index value to RB[52-63] that

Re: [RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Michael Ellerman
Mahesh J Salgaonkar writes: > From: Mahesh Salgaonkar > > With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting > during MCE recovery path.), That commit description is wrong, I'll fix it up. cheers > the SLB error recovery is broken. The new > change now does not add

Re: Infinite looping observed in __offline_pages

2018-08-23 Thread Michal Hocko
On Wed 22-08-18 11:58:02, Mike Kravetz wrote: > On 08/22/2018 02:30 AM, Aneesh Kumar K.V wrote: [...] > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index 4eb6e824a80c..f9bdea685cf4 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1338,7 +1338,8 @@ static

[PATCH 4.4 60/79] net/ethernet/freescale/fman: fix cross-build error

2018-08-23 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap [ Upstream commit c133459765fae249ba482f62e12f987aec4376f0 ] CC [M] drivers/net/ethernet/freescale/fman/fman.o In file included from

Re: [PATCH v2] poewrpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Mahesh Jagannath Salgaonkar
On 08/23/2018 10:26 AM, Mahesh J Salgaonkar wrote: > From: Mahesh Salgaonkar > > With the powrpc next commit e7e81847478 (poewrpc/mce: Fix SLB rebolting > during MCE recovery path.), the SLB error recovery is broken. The new > change now does not add index value to RB[52-63] that selects the SLB

[PATCH 4.9 110/130] net/ethernet/freescale/fman: fix cross-build error

2018-08-23 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap [ Upstream commit c133459765fae249ba482f62e12f987aec4376f0 ] CC [M] drivers/net/ethernet/freescale/fman/fman.o In file included from

Re: [RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Mahesh Jagannath Salgaonkar
On 08/23/2018 12:14 PM, Michael Ellerman wrote: > Mahesh J Salgaonkar writes: > >> From: Mahesh Salgaonkar >> >> With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting >> during MCE recovery path.), > > That commit description is wrong, I'll fix it up. Ouch.. My bad.. :-( >

[PATCH 4.17 271/324] net/ethernet/freescale/fman: fix cross-build error

2018-08-23 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap [ Upstream commit c133459765fae249ba482f62e12f987aec4376f0 ] CC [M] drivers/net/ethernet/freescale/fman/fman.o In file included from

Re: [PATCH v8 5/5] powernv/pseries: consolidate code for mce early handling.

2018-08-23 Thread Nicholas Piggin
On Thu, 23 Aug 2018 14:13:13 +0530 Mahesh Jagannath Salgaonkar wrote: > On 08/20/2018 05:04 PM, Nicholas Piggin wrote: > > On Sun, 19 Aug 2018 22:38:39 +0530 > > Mahesh J Salgaonkar wrote: > > > >> From: Mahesh Salgaonkar > >> > >> Now that other platforms also implements real mode mce

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Christophe LEROY
Le 22/08/2018 à 16:20, Aneesh Kumar K.V a écrit : On 08/17/2018 04:14 PM, Christophe LEROY wrote: Le 17/08/2018 à 05:32, Aneesh Kumar K.V a écrit : On 08/14/2018 08:24 PM, Christophe Leroy wrote: While implementing TLB miss HW assistance on the 8xx, the following warning was encountered:

Re: [PATCH 2/2] powerpc/mm/hash: Only need the Nest MMU workaround for R -> RW transition

2018-08-23 Thread Nicholas Piggin
On Wed, 22 Aug 2018 22:46:05 +0530 "Aneesh Kumar K.V" wrote: > The Nest MMU workaround is only needed for RW upgrades. Avoid doing that > for other pte updates. > > We also avoid clearing the pte while marking it invalid. This is because other > page table walk will find this pte none and can

[PATCH 4.14 186/217] net/ethernet/freescale/fman: fix cross-build error

2018-08-23 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Randy Dunlap [ Upstream commit c133459765fae249ba482f62e12f987aec4376f0 ] CC [M] drivers/net/ethernet/freescale/fman/fman.o In file included from

Re: [PATCH v8 5/5] powernv/pseries: consolidate code for mce early handling.

2018-08-23 Thread Mahesh Jagannath Salgaonkar
On 08/20/2018 05:04 PM, Nicholas Piggin wrote: > On Sun, 19 Aug 2018 22:38:39 +0530 > Mahesh J Salgaonkar wrote: > >> From: Mahesh Salgaonkar >> >> Now that other platforms also implements real mode mce handler, >> lets consolidate the code by sharing existing powernv machine check >> early

Re: DT case sensitivity

2018-08-23 Thread Rob Herring
On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: > > On 23/08/2018 02:29, Benjamin Herrenschmidt wrote: > > On Wed, 2018-08-22 at 20:26 -0500, Rob Herring wrote: > >> On Wed, Aug 22, 2018 at 8:14 PM Benjamin Herrenschmidt > >> wrote: > >>> > >>> On Wed, 2018-08-22 at 19:47 -0500, Rob Herring

Re: DT case sensitivity

2018-08-23 Thread Benjamin Herrenschmidt
On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: > On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: > > > > > > What problem are you trying to solve? > > I'm looking at removing device_node.name and using full_name instead > (which now is only the local node name plus unit-address).

Re: [PATCH 2/2] powerpc/mm/hash: Only need the Nest MMU workaround for R -> RW transition

2018-08-23 Thread Benjamin Herrenschmidt
On Thu, 2018-08-23 at 19:23 +1000, Nicholas Piggin wrote: > On Wed, 22 Aug 2018 22:46:05 +0530 > "Aneesh Kumar K.V" wrote: > > > The Nest MMU workaround is only needed for RW upgrades. Avoid doing that > > for other pte updates. > > > > We also avoid clearing the pte while marking it invalid.

Re: [PATCH 2/2] powerpc/mm/hash: Only need the Nest MMU workaround for R -> RW transition

2018-08-23 Thread Michael Ellerman
Nicholas Piggin writes: > On Wed, 22 Aug 2018 22:46:05 +0530 > "Aneesh Kumar K.V" wrote: > >> The Nest MMU workaround is only needed for RW upgrades. Avoid doing that >> for other pte updates. >> >> We also avoid clearing the pte while marking it invalid. This is because >> other >> page table

Re: DT case sensitivity

2018-08-23 Thread Rob Herring
On Thu, Aug 23, 2018 at 6:48 AM Benjamin Herrenschmidt wrote: > > On Thu, 2018-08-23 at 06:43 -0500, Rob Herring wrote: > > On Thu, Aug 23, 2018 at 4:02 AM Grant Likely wrote: > > > > > > > > > What problem are you trying to solve? > > > > I'm looking at removing device_node.name and using

Re: DT case sensitivity

2018-08-23 Thread Segher Boessenkool
On Thu, Aug 23, 2018 at 11:03:28AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2018-08-22 at 19:47 -0500, Rob Herring wrote: > > The default DT string handling in the kernel is node names and > > compatibles are case insensitive and property names are case sensitive > > (Sparc is the the only

Re: [PATCH] powerpc/xive: Initialize symbol before usage

2018-08-23 Thread Michael Ellerman
Cédric Le Goater writes: > On 08/23/2018 05:24 AM, Michael Ellerman wrote: >> Breno Leitao writes: >>> diff --git a/arch/powerpc/sysdev/xive/native.c >>> b/arch/powerpc/sysdev/xive/native.c >>> index 311185b9960a..fc56673a3c0f 100644 >>> --- a/arch/powerpc/sysdev/xive/native.c >>> +++

Re: [PATCH] powerpc/xive: Initialize symbol before usage

2018-08-23 Thread Cédric Le Goater
On 08/23/2018 05:24 AM, Michael Ellerman wrote: > Hi Breno, > > Breno Leitao writes: >> Function xive_native_get_ipi() might uses chip_id without it being >> initialized. This gives the following error on 'smatch' tool: >> >> error: uninitialized symbol 'chip_id' > > Which is correct, it

Re: DT case sensitivity

2018-08-23 Thread Segher Boessenkool
On Thu, Aug 23, 2018 at 11:29:01AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2018-08-22 at 20:26 -0500, Rob Herring wrote: > > On Wed, Aug 22, 2018 at 8:14 PM Benjamin Herrenschmidt > > wrote: > > > > > > On Wed, 2018-08-22 at 19:47 -0500, Rob Herring wrote: > > > > The default DT string

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Segher Boessenkool
On Thu, Aug 23, 2018 at 11:40:22AM +0200, Christophe LEROY wrote: > The only small problème I have is that some version of GCC seems to > complain about big memset() (132k and 256k ones). Is there a way to tell > GCC we really want to do it ? I'm not sure what you mean. Complain, is that a

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Michael Ellerman
Christophe LEROY writes: > Le 23/08/2018 à 12:36, Segher Boessenkool a écrit : >> On Thu, Aug 23, 2018 at 11:40:22AM +0200, Christophe LEROY wrote: >>> The only small problème I have is that some version of GCC seems to >>> complain about big memset() (132k and 256k ones). Is there a way to tell

Re: [RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Michael Ellerman
Mahesh Jagannath Salgaonkar writes: > On 08/23/2018 12:14 PM, Michael Ellerman wrote: >> Mahesh J Salgaonkar writes: >> >>> From: Mahesh Salgaonkar >>> >>> With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting >>> during MCE recovery path.), >> >> That commit description

Re: [PATCH v2 3/4] powerpc/mm: fix a warning when a cache is common to PGD and hugepages

2018-08-23 Thread Christophe LEROY
Le 23/08/2018 à 12:36, Segher Boessenkool a écrit : On Thu, Aug 23, 2018 at 11:40:22AM +0200, Christophe LEROY wrote: The only small problème I have is that some version of GCC seems to complain about big memset() (132k and 256k ones). Is there a way to tell GCC we really want to do it ?

Re: [RESEND PATCH v2] powerpc/mce: Fix SLB rebolting during MCE recovery path.

2018-08-23 Thread Michael Ellerman
Nicholas Piggin writes: > On Thu, 23 Aug 2018 12:06:53 +0530 > Mahesh J Salgaonkar wrote: >> From: Mahesh Salgaonkar >> >> With the powerpc next commit e7e81847478 (powerpc/mce: Fix SLB rebolting >> during MCE recovery path.), the SLB error recovery is broken. The new >> change now does not