Re: [1/1] Fix NULL pointer access in PowerPC MSI teardown code

2018-12-02 Thread Michael Ellerman
On Wed, 2018-11-28 at 03:20:48 UTC, Radu Rendec wrote: > The arch_teardown_msi_irqs() function assumes that controller ops > pointers were already checked in arch_setup_msi_irqs(), but this > assumption is wrong: arch_teardown_msi_irqs() can be called even when > arch_setup_msi_irqs() returns an

[RFC PATCH] soc: fsl: guts: handle devm_kstrdup() failure

2018-12-02 Thread Nicholas Mc Guire
devm_kstrdup() may return NULL if internal allocation failed. soc_dev_attr.machine should be checked (although its only use in pr_info() would be safe even with a NULL). Therefor in the unlikely case of allocation failure, fsl_guts_probe() returns -ENOMEM as this allocating failing is an

Re: powerpc: Look for "stdout-path" when setting up legacy consoles

2018-12-02 Thread Michael Ellerman
On Fri, 2018-11-30 at 03:54:09 UTC, Benjamin Herrenschmidt wrote: > Commit 78e5dfea8 "powerpc: dts: replace 'linux,stdout-path' with > 'stdout-path'" > broke the default console on a number of embedded PowerPC systems, because it > failed to also update the code in

Re: [PATCH] KVM: PPC: Book3S HV: NULL check before some freeing functions is not needed.

2018-12-02 Thread Suraj Jitindar Singh
On Sun, 2018-12-02 at 21:52 +0100, Thomas Meyer wrote: > NULL check before some freeing functions is not needed. Technically true, however I think a comment should be added then to make it clearer to someone reading the code why this is ok. See below. Suraj. > > Signed-off-by: Thomas Meyer >

Re: pkeys: Reserve PKEY_DISABLE_READ

2018-12-02 Thread Ram Pai
On Thu, Nov 29, 2018 at 12:37:15PM +0100, Florian Weimer wrote: > * Dave Hansen: > > > On 11/27/18 3:57 AM, Florian Weimer wrote: > >> I would have expected something that translates PKEY_DISABLE_WRITE | > >> PKEY_DISABLE_READ into PKEY_DISABLE_ACCESS, and also accepts > >> PKEY_DISABLE_ACCESS |

RE: [PATCHv2 5/6] pci: layerscape: Add the EP mode support.

2018-12-02 Thread Xiaowei Bao
Hi Lorenzo, -Original Message- From: Lorenzo Pieralisi Sent: 2018年12月1日 0:22 To: Xiaowei Bao Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo Li ; kis...@ti.com; a...@arndb.de; gre...@linuxfoundation.org; M.h. Lian ; Mingkai Hu ; Roy Zang ;

RE: [PATCHv2 3/6] PCI: layerscape: Add the EP mode support

2018-12-02 Thread Xiaowei Bao
Hi Lorenzo, -Original Message- From: Lorenzo Pieralisi Sent: 2018年11月30日 18:55 To: Xiaowei Bao Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo Li ; kis...@ti.com; a...@arndb.de; gre...@linuxfoundation.org; M.h. Lian ; Mingkai Hu ; Roy Zang

[PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-02 Thread Dmitry V. Levin
From: Elvira Khabirova Arch code should use tracehook_*() helpers, as documented in include/linux/tracehook.h, ptrace_report_syscall() is not expected to be used outside that file. Co-authored-by: Dmitry V. Levin Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU")

[PATCH] KVM: PPC: Book3S HV: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/arch/powerpc/kvm/book3s_hv_nested.c b/arch/powerpc/kvm/book3s_hv_nested.c --- a/arch/powerpc/kvm/book3s_hv_nested.c +++ b/arch/powerpc/kvm/book3s_hv_nested.c @@ -1252,8 +1252,7 @@ static long