Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-11 Thread Michael Bringmann
On 12/11/2018 07:29 AM, Michael Ellerman wrote: > Hi Michael, > > Please Cc the device tree folks on device tree patches, and also the > original author of the patch that added the code you're modifying. > > So I've added: > robh...@kernel.org > frowand.l...@gmail.com >

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
On Wed, Dec 12, 2018 at 12:13 AM Rob Herring wrote: > > > > +$(obj)/%.example.dts: $(src)/%.yaml FORCE > > > + $(call if_changed,chk_binding) > > > + > > > +DT_TMP_SCHEMA := .schema.yaml.tmp > > > > > > BTW, why does this file start with a period? > > What is the meaning of '.tmp'

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Rob Herring
On Mon, Dec 10, 2018 at 10:39 PM Masahiro Yamada wrote: > > Hi Rob, > > On Tue, Dec 11, 2018 at 5:50 AM Rob Herring wrote: > > > > This adds the build infrastructure for checking DT binding schema > > documents and validating dts files using the binding schema. > > > > Check DT binding schema

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-11 Thread Michael Bringmann
--- Snip --- >> >> The mobility.c code continues on during the second migration, accepts >> the definitions of the new nodes from the PHYP and ends up renaming >> the new properties e.g. >> >> [ 4565.827296] Duplicate name in base, renamed to "ibm,platform-facilities#1" >> >> There is no check

Re: [PATCH v2.2 24/34] dt-bindings: arm: Convert Rockchip board/soc bindings to json-schema

2018-12-11 Thread Rob Herring
On Mon, Dec 10, 2018 at 4:45 PM Heiko Stuebner wrote: > > From: Rob Herring > > Convert Rockchip SoC bindings to DT schema format using json-schema. > > Cc: Mark Rutland > Cc: Heiko Stuebner > Cc: devicet...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc:

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-11 Thread Rob Herring
On Tue, Dec 11, 2018 at 7:29 AM Michael Ellerman wrote: > > Hi Michael, > > Please Cc the device tree folks on device tree patches, and also the > original author of the patch that added the code you're modifying. > > So I've added: > robh...@kernel.org > frowand.l...@gmail.com >

[powerpc:next-test 70/71] arch/powerpc/include/asm/io.h:835:22: note: in expansion of macro 'page_to_pfn'

2018-12-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 13fd174be1903cc069bb73b0d53a0420b8f6d778 commit: 3a0f466ce2402cc090c97ccc1285508f688d8a8e [70/71] powerpc: Implement CONFIG_DEBUG_VIRTUAL config: powerpc-ps3_petitboot_nfs_defconfig (attached as .config)

[RFC 1/3] powerpc/numa: Conditionally online new nodes

2018-12-11 Thread Michael Bringmann
Add argument to allow caller to determine whether the node identified for a cpu after an associativity / affinity change should be inited. Signed-off-by: Michael Bringmann --- arch/powerpc/include/asm/topology.h |2 +- arch/powerpc/mm/numa.c |6 +++---

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2018-12-11 Thread David Gibson
On Tue, Dec 11, 2018 at 08:01:43AM -0600, Bjorn Helgaas wrote: > Hi David, > > I see you're still working on this, but if you do end up going this > direction eventually, would you mind splitting this into two patches: > 1) rename the quirk to make it more generic (but not changing any >

[RFC 0/3] powerpc/pseries: Remap hw to kernel cpu indexes

2018-12-11 Thread Michael Bringmann
Define and apply new interface to map hardware-specific powerpc cpu ids to a kernel specific range of cpu values. Mapping is intended to prevent confusion within the kernel about the cpu+node mapping, and the changes in configuration that may happen due to powerpc LPAR migration or other

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-11 Thread Michael Bringmann
Note from Scott Mayes on latest crash: Michael, Since the partition crashed, I was able to get the last .2 seconds worth of RTAS call trace leading up to the crash. Best I could tell from that bit of trace was that the removal of a processor involved the following steps: -- Call to stop-self

Re: [RFC PATCH v2 11/11] powerpc/book3s32: Implement Kernel Userspace Access Protection

2018-12-11 Thread Christophe Leroy
On 12/11/2018 05:25 AM, Russell Currey wrote: On Wed, 2018-11-28 at 09:27 +, Christophe Leroy wrote: This patch implements Kernel Userspace Access Protection for book3s/32. Due to limitations of the processor page protection capabilities, the protection is only against writing. read

Re: Snowpatch

2018-12-11 Thread Russell Currey
On Wed, Dec 12, 2018, at 8:41 AM, Christophe Leroy wrote: > snowpatch is pretty surprising on > https://patchwork.ozlabs.org/patch/1003954/ > > How can such a trivial patch for 8xx alter compilation of all other > targets that much (ie add or remove sparse warnings) ? It was a bug I fixed as

Re: [PATCH v3] powerpc: implement CONFIG_DEBUG_VIRTUAL

2018-12-11 Thread Michael Ellerman
Christophe Leroy writes: > This patch implements CONFIG_DEBUG_VIRTUAL to warn about > incorrect use of virt_to_phys() and page_to_phys() > > Below is the result of test_debug_virtual: > > [1.438746] WARNING: CPU: 0 PID: 1 at ./arch/powerpc/include/asm/io.h:808 >

Re: use generic DMA mapping code in powerpc V4

2018-12-11 Thread Benjamin Herrenschmidt
On Tue, 2018-12-11 at 19:17 +0100, Christian Zigotzky wrote: > X5000 (P5020 board): U-Boot loads the kernel and the dtb file. Then the > kernel starts but it doesn't find any hard disks (partitions). That > means this is also the bad commit for the P5020 board. What are the disks hanging off ?

[RFC 3/3] powerpc/numa: Apply mapping between HW and kernel cpus

2018-12-11 Thread Michael Bringmann
Apply new interface to map external powerpc cpus across multiple nodes to a range of kernel cpu values. Mapping is intended to prevent confusion within the kernel about the cpu+node mapping, and the changes in configuration that may happen due to powerpc LPAR migration or other associativity

Re: [powerpc:next-test 70/71] arch/powerpc/include/asm/io.h:835:22: note: in expansion of macro 'page_to_pfn'

2018-12-11 Thread Christophe Leroy
Missing linux/mm.h Will fix it in the coming patch. Christophe Le 11/12/2018 à 22:55, kbuild test robot a écrit : tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 13fd174be1903cc069bb73b0d53a0420b8f6d778 commit:

[PATCH v3] powerpc: implement CONFIG_DEBUG_VIRTUAL

2018-12-11 Thread Christophe Leroy
This patch implements CONFIG_DEBUG_VIRTUAL to warn about incorrect use of virt_to_phys() and page_to_phys() Below is the result of test_debug_virtual: [1.438746] WARNING: CPU: 0 PID: 1 at ./arch/powerpc/include/asm/io.h:808 test_debug_virtual_init+0x3c/0xd4 [1.448156] CPU: 0 PID: 1

[RFC 2/3] powerpc/numa: Define mapping between HW and kernel cpus

2018-12-11 Thread Michael Bringmann
Define interface to map external powerpc cpus across multiple nodes to a range of kernel cpu values. Mapping is intended to prevent confusion within the kernel about the cpu+node mapping, and the changes in configuration that may happen due to powerpc LPAR migration or other associativity changes

Snowpatch

2018-12-11 Thread Christophe Leroy
snowpatch is pretty surprising on https://patchwork.ozlabs.org/patch/1003954/ How can such a trivial patch for 8xx alter compilation of all other targets that much (ie add or remove sparse warnings) ? Christophe

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Rob Herring
On Tue, Dec 11, 2018 at 10:03 AM Masahiro Yamada wrote: > > On Wed, Dec 12, 2018 at 12:13 AM Rob Herring wrote: > > > > > > > +$(obj)/%.example.dts: $(src)/%.yaml FORCE > > > > + $(call if_changed,chk_binding) > > > > + > > > > +DT_TMP_SCHEMA := .schema.yaml.tmp > > > > > > > > > BTW, why

Re: use generic DMA mapping code in powerpc V4

2018-12-11 Thread Christian Zigotzky
Next step: 7decbcfc656805603ab97206b3f816f26cd2cf7d (powerpc/dma: use generic direct and swiotlb ops) git checkout 7decbcfc656805603ab97206b3f816f26cd2cf7d We have the bad commit! :-) The PASEMI onboard ethernet doesn't work with this commit anymore. Error messages: [  367.627623] pci

Re: [PATCH] i2c: powermac: Use of_node_name_eq for node name comparisons

2018-12-11 Thread Wolfram Sang
On Wed, Dec 05, 2018 at 01:50:24PM -0600, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc:

[PATCH v4] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Rob Herring
This adds the build infrastructure for checking DT binding schema documents and validating dts files using the binding schema. Check DT binding schema documents: make dt_binding_check Build dts files and check using DT binding schema: make dtbs_check Optionally, DT_SCHEMA_FILES can be passed in

Re: [PATCH v2] ocxl: Fix endiannes bug in read_afu_name()

2018-12-11 Thread Andrew Donnellan
On 12/12/18 4:58 am, Greg Kurz wrote: The AFU Descriptor Template in the PCI config space has a Name Space field which is a 24 Byte ASCII character string of descriptive name space for the AFU. The OCXL driver read the string four characters at a time with pci_read_config_dword(). This

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2018-12-11 Thread Bjorn Helgaas
On Tue, Dec 11, 2018 at 6:38 PM David Gibson wrote: > > On Tue, Dec 11, 2018 at 08:01:43AM -0600, Bjorn Helgaas wrote: > > Hi David, > > > > I see you're still working on this, but if you do end up going this > > direction eventually, would you mind splitting this into two patches: > > 1) rename

Re: [PATCH v3] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
On Wed, Dec 12, 2018 at 3:36 AM Rob Herring wrote: > > On Tue, Dec 11, 2018 at 10:03 AM Masahiro Yamada > wrote: > > > > On Wed, Dec 12, 2018 at 12:13 AM Rob Herring wrote: > > > > > > > > > > +$(obj)/%.example.dts: $(src)/%.yaml FORCE > > > > > + $(call if_changed,chk_binding) > > > > >

RE: [PATCH 1/2 v3] powerpc/fsl: Use new clockgen binding

2018-12-11 Thread Andy Tang
> -Original Message- > From: Scott Wood > Sent: 2018年11月26日 9:19 > To: Andy Tang > Cc: mturque...@baylibre.com; sb...@kernel.org; robh...@kernel.org; > mark.rutl...@arm.com; b...@kernel.crashing.org; pau...@samba.org; > m...@ellerman.id.au; linux-...@vger.kernel.org; >

[powerpc:next-test 70/71] include/asm-generic/memory_model.h:55:54: error: 'vmemmap' undeclared; did you mean 'mem_map'?

2018-12-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 13fd174be1903cc069bb73b0d53a0420b8f6d778 commit: 3a0f466ce2402cc090c97ccc1285508f688d8a8e [70/71] powerpc: Implement CONFIG_DEBUG_VIRTUAL config: powerpc-ppc64e_defconfig (attached as .config) compiler:

Re: [PATCH v4] kbuild: Add support for DT binding schema checks

2018-12-11 Thread Masahiro Yamada
On Wed, Dec 12, 2018 at 5:24 AM Rob Herring wrote: > > This adds the build infrastructure for checking DT binding schema > documents and validating dts files using the binding schema. > > Check DT binding schema documents: > make dt_binding_check > > Build dts files and check using DT binding

Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags

2018-12-11 Thread Michael Ellerman
Andrew Murray writes: > On Tue, Dec 11, 2018 at 10:06:53PM +1100, Michael Ellerman wrote: >> [ Reviving old thread. ] >> >> Andrew Murray writes: >> > On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote: >> >> Andrew Murray writes: >> >> >> >> > Update design.txt to reflect the

Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int

2018-12-11 Thread Paul Mackerras
On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1...@gmail.com wrote: > From: Lan Tianyu > > The patch is to make kvm_set_spte_hva() return int and caller can > check return value to determine flush tlb or not. It would be helpful if the patch description told the reader which return

Re: [PATCH] ocxl: Simplify free_spa()

2018-12-11 Thread Greg Kurz
On Tue, 11 Dec 2018 20:13:21 +1100 Andrew Donnellan wrote: > On 11/12/18 7:57 pm, Greg Kurz wrote: > > I now realize that I should have mentioned the real motivation for this > > change. I'm working on refactoring the code so that we can use ocxl in a > > KVM guest. The concept of link can be

Re: [PATCH v2] cpufreq: pmac64: add of_node_put()

2018-12-11 Thread Rafael J. Wysocki
On Monday, November 26, 2018 7:02:26 AM CET Viresh Kumar wrote: > On 23-11-18, 08:33, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > g5_neo2_cpufreq_init() doesn't do that, so fix it. > > >

Re: use generic DMA mapping code in powerpc V4

2018-12-11 Thread Rui Salvaterra
On Mon, 10 Dec 2018 at 20:49, Benjamin Herrenschmidt wrote: > [snip] > > AGP is a gigantic nightmare :-) It's not just cache coherency issues > (some implementations are coherent, some aren't, Apple's is ... weird). > > Apple has all sort of bugs, and Darwin source code only sheds light on >

Re: [PATCH v2] cpufreq: powernv: add of_node_put()

2018-12-11 Thread Rafael J. Wysocki
On Wednesday, November 21, 2018 5:02:04 AM CET Viresh Kumar wrote: > On 20-11-18, 11:05, Yangtao Li wrote: > > The of_find_node_by_path() returns a node pointer with refcount > > incremented,but there is the lack of use of the of_node_put() when > > done.Add the missing of_node_put() to release

Re: [powerpc:next-test 70/71] include/asm-generic/memory_model.h:55:54: error: 'vmemmap' undeclared; did you mean 'mem_map'?

2018-12-11 Thread Christophe Leroy
This one is already fixed in v2 and v3 by the addition of asm/pgtable.h Christophe Le 12/12/2018 à 06:36, kbuild test robot a écrit : tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 13fd174be1903cc069bb73b0d53a0420b8f6d778 commit:

Re: use generic DMA mapping code in powerpc V4

2018-12-11 Thread Christian Zigotzky
> On 12. Dec 2018, at 01:47, Benjamin Herrenschmidt > wrote: > >> On Tue, 2018-12-11 at 19:17 +0100, Christian Zigotzky wrote: >> X5000 (P5020 board): U-Boot loads the kernel and the dtb file. Then the >> kernel starts but it doesn't find any hard disks (partitions). That >> means this is

Re: [PATCH v3] powerpc: implement CONFIG_DEBUG_VIRTUAL

2018-12-11 Thread Christophe Leroy
Le 12/12/2018 à 01:23, Michael Ellerman a écrit : Christophe Leroy writes: This patch implements CONFIG_DEBUG_VIRTUAL to warn about incorrect use of virt_to_phys() and page_to_phys() Below is the result of test_debug_virtual: [1.438746] WARNING: CPU: 0 PID: 1 at

Re: [PATCH] crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK

2018-12-11 Thread Herbert Xu
On Tue, Dec 11, 2018 at 07:29:40AM +, Christophe Leroy wrote: > > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c > index 6988012deca4..385ec970b639 100644 > --- a/drivers/crypto/talitos.c > +++ b/drivers/crypto/talitos.c > @@ -1668,8 +1668,11 @@ static struct talitos_edesc >

Re: [PATCH] ocxl: Simplify free_spa()

2018-12-11 Thread Andrew Donnellan
On 11/12/18 7:57 pm, Greg Kurz wrote: I now realize that I should have mentioned the real motivation for this change. I'm working on refactoring the code so that we can use ocxl in a KVM guest. The concept of link can be shared by both powernv and pseries variants but the SPA is definitely a

Re: [PATCH] ocxl: Fix endiannes bug in read_afu_name()

2018-12-11 Thread Greg Kurz
On Tue, 11 Dec 2018 11:24:08 +1100 Andrew Donnellan wrote: > On 11/12/18 11:05 am, Andrew Donnellan wrote: > > On 11/12/18 2:10 am, Greg Kurz wrote: > >> The double word returned by read_afu_info(OCXL_DVSEC_TEMPL_NAME) contains > >> four characters of the AFU name, read from the PCI config

Re: [PATCH] ocxl: Simplify free_spa()

2018-12-11 Thread Greg Kurz
On Tue, 11 Dec 2018 12:05:49 +1100 Andrew Donnellan wrote: > On 11/12/18 2:15 am, Greg Kurz wrote: > > The only users of free_spa() are alloc_link() and free_link(), and > > in both cases: > > > > - link->spa != NULL > > > > - free_spa(link) is immediatly followed by kfree(link) > > > > The

[PATCH v2] ocxl: Fix endiannes bug in read_afu_name()

2018-12-11 Thread Greg Kurz
The AFU Descriptor Template in the PCI config space has a Name Space field which is a 24 Byte ASCII character string of descriptive name space for the AFU. The OCXL driver read the string four characters at a time with pci_read_config_dword(). This optimization is valid on a little-endian system

Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags

2018-12-11 Thread Michael Ellerman
[ Reviving old thread. ] Andrew Murray writes: > On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote: >> Andrew Murray writes: >> >> > Update design.txt to reflect the presence of the exclude_host >> > and exclude_guest perf flags. >> > >> > Signed-off-by: Andrew Murray >> > ---

[RFC PATCH v1 3/3] powerpc/8xx: Enable CONFIG_VMAP_STACK

2018-12-11 Thread Christophe Leroy
This patch enables CONFIG_VMAP_STACK. For that, a few changes are done in head_8xx.S to re-activation DATA MMU Translation before accessing to the stack. Due to the growing of exception prolog, a few rearrangement is also done in a few exception handlers. Signed-off-by: Christophe Leroy ---

[RFC PATCH v1 1/3] powerpc/32: prepare for CONFIG_VMAP_STACK

2018-12-11 Thread Christophe Leroy
To support CONFIG_VMAP_STACK, the kernel must be able to activate Data MMU Translation for accessing the stack. Before doing that it must save SRR0, SRR1 and DAR in order to not loose them in case there is a Data TLB Miss once the translation is reactivated. This patch defines fields in the

[RFC PATCH v1 2/3] powerpc/8xx: Use alternative scratch registers in DTLB miss handler

2018-12-11 Thread Christophe Leroy
In preparation of handling CONFIG_VMAP_STACK, we need DTLB miss handler to use different scratch registers than other exception handlers in order to not jeopardise exception entry on stack DTLB misses. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_8xx.S | 27

Re: [PATCH] powerpc: Fix bogus usage of MSR_RI on BookE and 40x

2018-12-11 Thread Christophe Leroy
Le 11/12/2018 à 02:57, Benjamin Herrenschmidt a écrit : BookE and 40x processors lack the MSR:RI bit. However, we have a few common code places that rely on it. This fixes it by not defining MSR_RI on those processor types and using the appropriate ifdef's in those locations. Signed-off-by:

[RFC PATCH v1 0/3] Enable CONFIG_VMAP_STACK on the 8xx

2018-12-11 Thread Christophe Leroy
The purpose of this serie is to enable CONFIG_VMAP_STACK on the 8xx. I'm sending it now to get early feedback if any. For the time being, there is no proper handling of stack overflow. This serie applies on the top of the serie "powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK" Christophe Leroy

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-11 Thread Michael Ellerman
Daniel Borkmann writes: < snip > > > I would actually just like to get rid of the BPF_JIT_LIMIT_DEFAULT > define also given for 4.21 arm64 will have its own dedicated area for > JIT allocations where neither the above limit nor the MODULES_END/ > MODULES_VADDR one would fit and I don't want to

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-11 Thread Michael Ellerman
Hi Michael, Please Cc the device tree folks on device tree patches, and also the original author of the patch that added the code you're modifying. So I've added: robh...@kernel.org frowand.l...@gmail.com devicet...@vger.kernel.org linux-ker...@vger.kernel.org Michael Bringmann writes:

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2018-12-11 Thread Bjorn Helgaas
Hi David, I see you're still working on this, but if you do end up going this direction eventually, would you mind splitting this into two patches: 1) rename the quirk to make it more generic (but not changing any behavior), and 2) add the ConnectX devices to the quirk. That way the ConnectX

Re: [v5] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-11 Thread Michael Ellerman
On Fri, 2018-12-07 at 15:56:05 UTC, "Dmitry V. Levin" wrote: > From: Elvira Khabirova > > Arch code should use tracehook_*() helpers, as documented > in include/linux/tracehook.h, > ptrace_report_syscall() is not expected to be used outside that file. > > The patch does not look very nice, but

Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags

2018-12-11 Thread Andrew Murray
On Tue, Dec 11, 2018 at 10:06:53PM +1100, Michael Ellerman wrote: > [ Reviving old thread. ] > > Andrew Murray writes: > > On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote: > >> Andrew Murray writes: > >> > >> > Update design.txt to reflect the presence of the exclude_host > >>

Re: [PATCH] powerpc/ipic: Fix a bounds check in ipic_set_priority()

2018-12-11 Thread Dan Carpenter
On Thu, Dec 06, 2018 at 09:12:12AM +0100, Julia Lawall wrote: > > > On Thu, 6 Dec 2018, Christophe LEROY wrote: > > > > > > > Le 05/12/2018 à 04:26, Michael Ellerman a écrit : > > > Hi Dan, > > > > > > Thanks for the patch. > > > > > > Dan Carpenter writes: > > > > The ipic_info[] array only

Re: use generic DMA mapping code in powerpc V4

2018-12-11 Thread Christian Zigotzky
Next step: 977706f9755d2d697aa6f45b4f9f0e07516efeda (powerpc/dma: remove dma_nommu_mmap_coherent) Result: The P5020 board boots and the PASEMI onboard ethernet works. -- Christian On 10 December 2018 at 4:54PM, Christian Zigotzky wrote: Next step: 64ecd2c160bbef31465c4d34efc0f076a2aad4df