Re: [patch V2 00/15] Lock ordering documentation and annotation for lockdep

2020-03-20 Thread Davidlohr Bueso
On Wed, 18 Mar 2020, Thomas Gleixner wrote: The PS3 one got converted by Peter Zijlstra to rcu_wait(). While at it, I think it makes sense to finally convert the kvm vcpu swait to rcuwait (patch 6/15 starts the necessary api changes). I'm sending some patches on top of this patchset. Thanks

Re: [patch V2 06/15] rcuwait: Add @state argument to rcuwait_wait_event()

2020-03-20 Thread Sebastian Andrzej Siewior
On 2020-03-19 22:36:57 [-0700], Davidlohr Bueso wrote: > On Wed, 18 Mar 2020, Thomas Gleixner wrote: > > Right now I'm not sure what the proper fix should be. I though that v2 has it fixed with the previous commit (acpi: Remove header dependency). The kbot just reported that everything is fine. L

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

2020-03-20 Thread Bharata B Rao
On Fri, Mar 20, 2020 at 09:37:18AM +0100, Vlastimil Babka wrote: > On 3/20/20 4:42 AM, Bharata B Rao wrote: > > On Thu, Mar 19, 2020 at 02:47:58PM +0100, Vlastimil Babka wrote: > >> diff --git a/mm/slub.c b/mm/slub.c > >> index 17dc00e33115..7113b1f9cd77 100644 > >> --- a/mm/slub.c > >> +++ b/mm/sl

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

2020-03-20 Thread Vlastimil Babka
On 3/20/20 8:46 AM, Srikar Dronamraju wrote: > * Vlastimil Babka [2020-03-19 15:10:19]: > >> On 3/19/20 3:05 PM, Srikar Dronamraju wrote: >> > * Vlastimil Babka [2020-03-19 14:47:58]: >> > >> >> No, but AFAICS, such node values are already handled in ___slab_alloc, and >> cannot reach get_part

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

2020-03-20 Thread Vlastimil Babka
On 3/20/20 4:42 AM, Bharata B Rao wrote: > On Thu, Mar 19, 2020 at 02:47:58PM +0100, Vlastimil Babka wrote: >> diff --git a/mm/slub.c b/mm/slub.c >> index 17dc00e33115..7113b1f9cd77 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -1973,8 +1973,6 @@ static void *get_partial(struct kmem_cache *s,

[RFC PATCH 4/4] powerpc kvm_asm: rename PPC_LD and PPC_STD macros to avoid redefinition

2020-03-20 Thread Balamuruhan S
use PPC_KVM_LD and PPC_KVM_STD to fix gcc warnings on redefinition as we consolidate all ppc instruction encoding in ppc-opcode.h Signed-off-by: Balamuruhan S --- arch/powerpc/include/asm/kvm_asm.h| 8 arch/powerpc/kvm/booke_interrupts.S | 8 arch/powerpc/kvm/bookehv_in

[RFC PATCH 3/4] powerpc ppc-opcode: move ppc instuction encoding from test_emulate_step

2020-03-20 Thread Balamuruhan S
Few ppc instructions are encoded in test_emulate_step.c, consolidate them to ppc-opcode.h, fix redefintion errors in bpf_jit caused due to this consolidation. Reuse the macros from ppc-opcode.h Signed-off-by: Balamuruhan S --- arch/powerpc/include/asm/ppc-opcode.h | 34 ++ arch/powerpc/lib

[RFC PATCH 2/4] powerpc selftest: reuse ppc-opcode macros to avoid redundancy

2020-03-20 Thread Balamuruhan S
Avoid redefining macros to encode ppc instructions instead reuse it from ppc-opcode.h, Makefile changes are necessary to compile memcmp_64.S with __ASSEMBLY__ defined from selftests. Signed-off-by: Balamuruhan S --- .../selftests/powerpc/stringloops/Makefile| 15 ++-- .../powerpc/stringl

[RFC PATCH 1/4] powerpc ppc-opcode: introduce PPC_ENCODE_* macros for base instruction encoding

2020-03-20 Thread Balamuruhan S
Introduce PPC_ENCODE* macros to have all the bare encoding of ppc instructions and use it wrapped with stringify_in_c() for raw encoding in ppc-opcode.h. Signed-off-by: Balamuruhan S --- arch/powerpc/include/asm/ppc-opcode.h | 330 +- 1 file changed, 220 insertions(+), 11

[RFC PATCH 0/4] consolidate PowerPC instruction encoding macros

2020-03-20 Thread Balamuruhan S
ppc-opcode.h have base instruction encoding wrapped with stringify_in_c() for raw encoding to have compatibility. But there are redundant macros for base instruction encodings in bpf, instruction emulation test infrastructure and powerpc selftests. Currently PPC_INST_* macros are used for encoding

Re: [RFC 1/2] mm, slub: prevent kmalloc_node crashes and memory leaks

2020-03-20 Thread Srikar Dronamraju
* Vlastimil Babka [2020-03-19 15:10:19]: > On 3/19/20 3:05 PM, Srikar Dronamraju wrote: > > * Vlastimil Babka [2020-03-19 14:47:58]: > > > >> 8< > >> diff --git a/mm/slub.c b/mm/slub.c > >> index 17dc00e33115..7113b1f9cd77 100644 > >> --- a/mm/slub.c > >> +++ b/mm/slub.c > >> @@ -1973,8

Re: [PATCH v3 3/8] drivers/base/memory: store mapping between MMOP_* and string in an array

2020-03-20 Thread Baoquan He
On 03/19/20 at 02:12pm, David Hildenbrand wrote: > Let's use a simple array which we can reuse soon. While at it, move the > string->mmop conversion out of the device hotplug lock. > > Reviewed-by: Wei Yang > Acked-by: Michal Hocko > Cc: Greg Kroah-Hartman > Cc: Andrew Morton > Cc: Michal Hock

Re: [patch V2 11/15] completion: Use simple wait queues

2020-03-20 Thread Christoph Hellwig
On Fri, Mar 20, 2020 at 10:25:41AM +1100, Julian Calaby wrote: > > +++ b/drivers/usb/gadget/function/f_fs.c > > @@ -1703,7 +1703,7 @@ static void ffs_data_put(struct ffs_data > > pr_info("%s(): freeing\n", __func__); > > ffs_data_clear(ffs); > > BUG_O

<    1   2