Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Leonardo Bras
Hello Alexey, thanks for the feedback! On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > On 19/06/2020 15:06, Leonardo Bras wrote: > > On LoPAR "DMA Window Manipulation Calls", it's recommended to remove the > > default DMA window for the device, before attempting to configure a

Re: [PATCH 2/6] powerpc test_emulate_step: fix pr_info() to print 8-byte for prefixed instruction

2020-06-22 Thread Jordan Niethe
On Mon, Jun 22, 2020 at 5:10 PM Balamuruhan S wrote: > > On test failure, `pr_log()` prints 4 bytes instruction > irrespective of word/prefix instruction, fix it by printing > them appropriately. This patch to add a ppc_inst_as_str() function should help with this,

Re: [PATCH 2/4] powerpc/pseries/iommu: Implement ibm,reset-pe-dma-windows rtas call

2020-06-22 Thread Leonardo Bras
Hello Alexey, thanks for the feedback! On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > On 19/06/2020 15:06, Leonardo Bras wrote: > > Platforms supporting the DDW option starting with LoPAR level 2.7 implement > > ibm,ddw-extensions. The first extension available (index 2)

Re: [PATCH 3/4] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window

2020-06-22 Thread Leonardo Bras
Hello Alexey, thanks for the feedback! On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > On 19/06/2020 15:06, Leonardo Bras wrote: > > Move the window-removing part of remove_ddw into a new function > > (remove_dma_window), so it can be used to remove other DMA windows. > > > >

Re: [PATCH] powerpc/pseries: new lparcfg key/value pair: partition_affinity_score

2020-06-22 Thread Tyrel Datwyler
On 6/19/20 5:32 PM, Nathan Lynch wrote: > Hi Tyrel, > > Tyrel Datwyler writes: >> On 6/19/20 8:34 AM, Scott Cheloha wrote: >>> The H_GetPerformanceCounterInfo PHYP hypercall has a subcall, >>> Affinity_Domain_Info_By_Partition, which returns, among other things, >>> a "partition affinity score"

Re: [PATCH 1/6] powerpc test_emulate_step: update nip with patched instruction address

2020-06-22 Thread Jordan Niethe
On Mon, Jun 22, 2020 at 5:10 PM Balamuruhan S wrote: > > pt_regs are initialized to zero in the test infrastructure, R bit > in prefixed instruction form is used to specify whether the effective > address of the storage operand is computed relative to the address > of the instruction. > > If R =

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Leonardo Bras
Hello Alexey, thank you for the feedback! On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > On 19/06/2020 15:06, Leonardo Bras wrote: > > From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of > > outputs from "ibm,query-pe-dma-windows" go from 5 to 6. > > >

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-22 Thread Aneesh Kumar K.V
Vaibhav Jain writes: > Update papr_scm.c to query dimm performance statistics from PHYP via > H_SCM_PERFORMANCE_STATS hcall and export them to user-space as PAPR > specific NVDIMM attribute 'perf_stats' in sysfs. The patch also > provide a sysfs ABI documentation for the stats being reported and

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 04:58, Leonardo Bras wrote: > Hello Alexey, thank you for the feedback! > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: >> >> On 19/06/2020 15:06, Leonardo Bras wrote: >>> From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of >>> outputs

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 11:12 +1000, Alexey Kardashevskiy wrote: [snip] > > > > +static int query_ddw_out_sz(struct device_node *par_dn) > > > > > > Can easily be folded into query_ddw(). > > > > Sure, but it will get inlined by the compiler, and I think it reads > > better this way. > > I mean,

Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()

2020-06-22 Thread Kees Cook
On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote: > Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() > back simply copy_thread(). It's a simpler name, and doesn't imply that only > tls is copied here. This finishes an outstanding chunk of internal process >

Re: [PATCH 3/4] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 04:59, Leonardo Bras wrote: > Hello Alexey, thanks for the feedback! > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: >> >> On 19/06/2020 15:06, Leonardo Bras wrote: >>> Move the window-removing part of remove_ddw into a new function >>> (remove_dma_window), so

Re: [PATCH 2/4] powerpc/pseries/iommu: Implement ibm,reset-pe-dma-windows rtas call

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 11:11 +1000, Alexey Kardashevskiy wrote: > > On 23/06/2020 04:58, Leonardo Bras wrote: > > Hello Alexey, thanks for the feedback! > > > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > > On 19/06/2020 15:06, Leonardo Bras wrote: > > > > Platforms

[PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()

2020-06-22 Thread Christian Brauner
Now that HAVE_COPY_THREAD_TLS has been removed, rename copy_thread_tls() back simply copy_thread(). It's a simpler name, and doesn't imply that only tls is copied here. This finishes an outstanding chunk of internal process creation work since we've added clone3(). Cc: Richard Henderson Cc: Ivan

Re: [PATCH 16/17] arch: remove HAVE_COPY_THREAD_TLS

2020-06-22 Thread Kees Cook
On Tue, Jun 23, 2020 at 01:43:25AM +0200, Christian Brauner wrote: > All architectures support copy_thread_tls() now, so remove the legacy > copy_thread() function and the HAVE_COPY_THREAD_TLS config option. Everyone > uses the same process creation calling convention based on > copy_thread_tls()

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 11:11 +1000, Alexey Kardashevskiy wrote: > > On 23/06/2020 04:59, Leonardo Bras wrote: > > Hello Alexey, thanks for the feedback! > > > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > > On 19/06/2020 15:06, Leonardo Bras wrote: > > > > On LoPAR "DMA

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 12:14, Leonardo Bras wrote: > On Tue, 2020-06-23 at 11:12 +1000, Alexey Kardashevskiy wrote: > [snip] > +static int query_ddw_out_sz(struct device_node *par_dn) Can easily be folded into query_ddw(). >>> >>> Sure, but it will get inlined by the compiler, and I think

Re: [PATCH 2/4] powerpc/pseries/iommu: Implement ibm,reset-pe-dma-windows rtas call

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 04:58, Leonardo Bras wrote: > Hello Alexey, thanks for the feedback! > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: >> >> On 19/06/2020 15:06, Leonardo Bras wrote: >>> Platforms supporting the DDW option starting with LoPAR level 2.7 implement >>>

Re: [PATCH 3/4] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 11:33 +1000, Oliver O'Halloran wrote: > On Tue, Jun 23, 2020 at 11:12 AM Alexey Kardashevskiy wrote: > > On 23/06/2020 04:59, Leonardo Bras wrote: > > > > Also, despite this particular file, the "pdn" name is usually used for > > > > struct pci_dn (not device_node), let's

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 12:35 +1000, Alexey Kardashevskiy wrote: > > I am not sure if this is true in general, but in this device (SR-IOV > > VF) I am testing it will return 0 windows if the default DMA window is > > not deleted, and 1 after it's deleted. > > Since pHyp can only create windows in

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 12:43, Leonardo Bras wrote: > On Tue, 2020-06-23 at 12:35 +1000, Alexey Kardashevskiy wrote: >>> I am not sure if this is true in general, but in this device (SR-IOV >>> VF) I am testing it will return 0 windows if the default DMA window is >>> not deleted, and 1 after it's

Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2020-06-22 Thread Shengjiu Wang
On Tue, Jun 23, 2020 at 12:08 AM Markus Elfring wrote: > > > Fix unchecked return value for clk_prepare_enable. > > > > And because clk_prepare_enable and clk_disable_unprepare should > > check input clock parameter is NULL or not, then we don't need > > to check it before calling the function. >

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 04:59, Leonardo Bras wrote: > Hello Alexey, thanks for the feedback! > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: >> >> On 19/06/2020 15:06, Leonardo Bras wrote: >>> On LoPAR "DMA Window Manipulation Calls", it's recommended to remove the >>> default DMA

Re: [PATCH 3/4] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window

2020-06-22 Thread Oliver O'Halloran
On Tue, Jun 23, 2020 at 11:12 AM Alexey Kardashevskiy wrote: > > On 23/06/2020 04:59, Leonardo Bras wrote: > > > >> Also, despite this particular file, the "pdn" name is usually used for > >> struct pci_dn (not device_node), let's keep it that way. > > > > Sure, I got confused for some time about

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 12:31, Leonardo Bras wrote: > On Tue, 2020-06-23 at 11:11 +1000, Alexey Kardashevskiy wrote: >> >> On 23/06/2020 04:59, Leonardo Bras wrote: >>> Hello Alexey, thanks for the feedback! >>> >>> On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: On 19/06/2020 15:06,

Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

2020-06-22 Thread Aneesh Kumar K.V
Aneesh Kumar K.V writes: > Vaibhav Jain writes: > + */ >> +seq_buf_init(, buf, PAGE_SIZE); >> +for (index = 0, stat = stats->scm_statistic; >> + index < stats->num_statistics; ++index, ++stat) { >> +seq_buf_printf(, "%.8s

[PATCH 16/17] arch: remove HAVE_COPY_THREAD_TLS

2020-06-22 Thread Christian Brauner
All architectures support copy_thread_tls() now, so remove the legacy copy_thread() function and the HAVE_COPY_THREAD_TLS config option. Everyone uses the same process creation calling convention based on copy_thread_tls() and struct kernel_clone_args. This will make it easier to maintain the core

Re: [PATCHv2] tpm: ibmvtpm: Wait for ready buffer before probing for TPM2 attributes

2020-06-22 Thread Jarkko Sakkinen
On Fri, Jun 19, 2020 at 01:30:40PM +1000, David Gibson wrote: > The tpm2_get_cc_attrs_tbl() call will result in TPM commands being issued, > which will need the use of the internal command/response buffer. But, > we're issuing this *before* we've waited to make sure that buffer is > allocated. >

Re: [PATCH 3/4] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window

2020-06-22 Thread Leonardo Bras
On Tue, 2020-06-23 at 11:12 +1000, Alexey Kardashevskiy wrote: > > On 23/06/2020 04:59, Leonardo Bras wrote: > > Hello Alexey, thanks for the feedback! > > > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: > > > On 19/06/2020 15:06, Leonardo Bras wrote: > > > > Move the

Re: [PATCH] ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format

2020-06-22 Thread Nicolin Chen
On Mon, Jun 22, 2020 at 05:03:31PM +0800, Shengjiu Wang wrote: > The "ret" in fsl_easrc_set_ctx_format is not initialized, then > the unknown value maybe returned by this function. > > Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") > Signed-off-by: Shengjiu Wang

Re: [PATCH 3/6] powerpc test_emulate_step: enhancement to test negative scenarios

2020-06-22 Thread Sandipan Das
Hi Bala, On 22/06/20 12:39 pm, Balamuruhan S wrote: > add provision to declare test is a negative scenario, verify > whether emulation fails and avoid executing it. > > Signed-off-by: Balamuruhan S > --- > arch/powerpc/lib/test_emulate_step.c | 46 ++-- > 1 file

Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows

2020-06-22 Thread Alexey Kardashevskiy
On 19/06/2020 15:06, Leonardo Bras wrote: > From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of > outputs from "ibm,query-pe-dma-windows" go from 5 to 6. > > This change of output size is meant to expand the address size of > largest_available_block PE TCE from 32-bit to

Re: [PATCH 2/4] powerpc/pseries/iommu: Implement ibm,reset-pe-dma-windows rtas call

2020-06-22 Thread Alexey Kardashevskiy
On 19/06/2020 15:06, Leonardo Bras wrote: > Platforms supporting the DDW option starting with LoPAR level 2.7 implement > ibm,ddw-extensions. The first extension available (index 2) carries the > token for ibm,reset-pe-dma-windows rtas call, which is used to restore > the default DMA window for

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Alexey Kardashevskiy
On 19/06/2020 15:06, Leonardo Bras wrote: > On LoPAR "DMA Window Manipulation Calls", it's recommended to remove the > default DMA window for the device, before attempting to configure a DDW, > in order to make the maximum resources available for the next DDW to be > created. > > This is a

Re: [PATCH 3/4] powerpc/pseries/iommu: Move window-removing part of remove_ddw into remove_dma_window

2020-06-22 Thread Alexey Kardashevskiy
On 19/06/2020 15:06, Leonardo Bras wrote: > Move the window-removing part of remove_ddw into a new function > (remove_dma_window), so it can be used to remove other DMA windows. > > It's useful for removing DMA windows that don't create DIRECT64_PROPNAME > property, like the default DMA window

[PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2020-06-22 Thread Shengjiu Wang
Fix unchecked return value for clk_prepare_enable. And because clk_prepare_enable and clk_disable_unprepare should check input clock parameter is NULL or not, then we don't need to check it before calling the function. Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver")

[PATCH] powerpc/mm/book3s64: Skip 16G page reservation with radix

2020-06-22 Thread Aneesh Kumar K.V
With hash translation, the hypervisor can hint the LPAR about 16GB contiguous range via ibm,expected#pages. The kernel marks the range specified in the device tree as reserved. Avoid doing this when using radix translation. Radix translation only supports 1G gigantic hugepage and kernel can do

[PATCH 1/6] powerpc test_emulate_step: update nip with patched instruction address

2020-06-22 Thread Balamuruhan S
pt_regs are initialized to zero in the test infrastructure, R bit in prefixed instruction form is used to specify whether the effective address of the storage operand is computed relative to the address of the instruction. If R = 1 and RA = R0|0, the sum of the address of the instruction and the

[PATCH 2/6] powerpc test_emulate_step: fix pr_info() to print 8-byte for prefixed instruction

2020-06-22 Thread Balamuruhan S
On test failure, `pr_log()` prints 4 bytes instruction irrespective of word/prefix instruction, fix it by printing them appropriately. Signed-off-by: Balamuruhan S --- arch/powerpc/lib/test_emulate_step.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH 4/6] powerpc test_emulate_step: add negative tests for prefixed addi

2020-06-22 Thread Balamuruhan S
testcases for `paddi` instruction to cover the negative case, if R is equal to 1 and RA is not equal to 0, the instruction form is invalid. Signed-off-by: Balamuruhan S --- arch/powerpc/lib/test_emulate_step.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 3/6] powerpc test_emulate_step: enhancement to test negative scenarios

2020-06-22 Thread Balamuruhan S
add provision to declare test is a negative scenario, verify whether emulation fails and avoid executing it. Signed-off-by: Balamuruhan S --- arch/powerpc/lib/test_emulate_step.c | 46 ++-- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git

[PATCH] ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format

2020-06-22 Thread Shengjiu Wang
The "ret" in fsl_easrc_set_ctx_format is not initialized, then the unknown value maybe returned by this function. Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_easrc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/6] Prefixed instruction tests to cover negative cases

2020-06-22 Thread Balamuruhan S
This patchset adds support to test negative scenarios and adds testcase for paddi with few fixes. It is based on powerpc/next and on top of Jordan's tests for prefixed instructions patchset, https://lists.ozlabs.org/pipermail/linuxppc-dev/2020-May/211394.html Balamuruhan S (6): powerpc

[PATCH 5/6] powerpc sstep: introduce macros to retrieve Prefix instruction operands

2020-06-22 Thread Balamuruhan S
retrieve prefix instruction operands RA and pc relative bit R values using macros and adopt it in sstep.c and test_emulate_step.c. Signed-off-by: Balamuruhan S --- arch/powerpc/include/asm/sstep.h | 4 arch/powerpc/lib/sstep.c | 12 ++--

[PATCH 6/6] powerpc test_emulate_step: move extern declaration to sstep.h

2020-06-22 Thread Balamuruhan S
fix checkpatch.pl warnings by moving extern declaration from source file to headerfile. Signed-off-by: Balamuruhan S --- arch/powerpc/include/asm/sstep.h | 2 ++ arch/powerpc/lib/test_emulate_step.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH v0 3/5] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2020-06-22 Thread Aneesh Kumar K.V
Bharata B Rao writes: > We can hit the following BUG_ON during memory unplug > > kernel BUG at arch/powerpc/mm/book3s64/pgtable.c:344! > Oops: Exception in kernel mode, sig: 5 [#1] > LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries > NIP [c0097d48] pmd_fragment_free+0x48/0xd0 >

Re: [RFC PATCH v0 4/5] powerpc/mm/radix: Free PUD table when freeing pagetable

2020-06-22 Thread Aneesh Kumar K.V
Bharata B Rao writes: > remove_pagetable() isn't freeing PUD table. This causes memory > leak during memory unplug. Fix this. > We had changes w.r.t p4d (folded 5 level table). You may want to get this updated to recent kernel. Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Bharata B Rao >

Re: [RFC PATCH v0 2/5] powerpc/mm/radix: Create separate mappings for hot-plugged memory

2020-06-22 Thread Aneesh Kumar K.V
Bharata B Rao writes: > Memory that gets hot-plugged _during_ boot (and not the memory > that gets plugged in after boot), is mapped with 1G mappings > and will undergo splitting when it is unplugged. The splitting > code has a few issues: > > 1. Recursive locking > > Memory

Re: [RFC PATCH v0 5/5] powerpc/mm/radix: Remove split_kernel_mapping()

2020-06-22 Thread Aneesh Kumar K.V
Bharata B Rao writes: > With hot-plugged memory getting mapped with 2M mappings always, > there will be no need to split any mappings during unplug. > > Hence remove split_kernel_mapping() and associated code. This > essentially is a revert of > commit 4dd5f8a99e791 ("powerpc/mm/radix: Split

Re: [next-20200621] LTP tests af_alg02/05 failure on POWER9 PowerVM LPAR

2020-06-22 Thread Herbert Xu
On Mon, Jun 22, 2020 at 05:55:29PM +0530, Sachin Sant wrote: > With recent next(next-20200621) af_alg02/05 tests fail while running on POWER9 > PowerVM LPAR. > > Results from 5.8.0-rc1-next-20200622 > # ./af_alg02 > tst_test.c:1096: INFO: Timeout per run is 0h 00m 20s >

[next-20200621] LTP tests af_alg02/05 failure on POWER9 PowerVM LPAR

2020-06-22 Thread Sachin Sant
With recent next(next-20200621) af_alg02/05 tests fail while running on POWER9 PowerVM LPAR. Results from 5.8.0-rc1-next-20200622 # ./af_alg02 tst_test.c:1096: INFO: Timeout per run is 0h 00m 20s af_alg02.c:52: BROK: Timed out while reading from request socket. # 5.8.0-rc1-next-20200618

Re: [RFC PATCH v0 3/5] powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings

2020-06-22 Thread Aneesh Kumar K.V
@@ -71,8 +135,8 @@ static int early_map_kernel_page(unsigned long ea, unsigned long pa, > > pgdp = pgd_offset_k(ea); > if (pgd_none(*pgdp)) { > - pudp = early_alloc_pgtable(PUD_TABLE_SIZE, nid, > - region_start,

[PATCH] hmi: Move hmi irq stat from percpu variable to paca.

2020-06-22 Thread Mahesh Salgaonkar
With the patch series posted at https://lore.kernel.org/linuxppc-dev/20200608070904.387440-1-aneesh.ku...@linux.ibm.com/ the percpu first chunk memory area can come from vmalloc ranges. This makes kernel to crash whenever percpu variable is accessed in real mode. This patch fixes this issue by

Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2020-06-22 Thread Markus Elfring
> Fix unchecked return value for clk_prepare_enable. > > And because clk_prepare_enable and clk_disable_unprepare should > check input clock parameter is NULL or not, then we don't need > to check it before calling the function. I propose to split the adjustment of two function implementations