Re: [PATCH v2 1/4] mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race

2020-09-14 Thread Nicholas Piggin
Excerpts from pet...@infradead.org's message of September 14, 2020 8:56 pm: > On Mon, Sep 14, 2020 at 02:52:16PM +1000, Nicholas Piggin wrote: >> Reading and modifying current->mm and current->active_mm and switching >> mm should be done with irqs off, to prevent races seeing an intermediate >>

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-14 Thread Nicholas Piggin
Excerpts from Anatoly Pugachev's message of September 14, 2020 8:23 pm: > On Mon, Sep 14, 2020 at 10:00 AM Nicholas Piggin wrote: >> >> Excerpts from Nicholas Piggin's message of September 14, 2020 2:52 pm: >> >> [...] >> >> > The basic fix for sparc64 is to remove its mm_cpumask clearing code.

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-14 Thread Nicholas Piggin
Excerpts from David Miller's message of September 15, 2020 5:59 am: > From: Nicholas Piggin > Date: Mon, 14 Sep 2020 14:52:18 +1000 > > ... >> The basic fix for sparc64 is to remove its mm_cpumask clearing code. The >> optimisation could be effectively restored by sending IPIs to mm_cpumask >>

Re: [PATCH v2 1/4] mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race

2020-09-14 Thread peterz
On Mon, Sep 14, 2020 at 02:52:16PM +1000, Nicholas Piggin wrote: > Reading and modifying current->mm and current->active_mm and switching > mm should be done with irqs off, to prevent races seeing an intermediate > state. > > This is similar to commit 38cf307c1f20 ("mm: fix kthread_use_mm() vs

Re: [PATCH] tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()

2020-09-14 Thread Jiri Slaby
On 21. 08. 20, 1:46, Tyrel Datwyler wrote: > The code currently NULLs tty->driver_data in hvcs_close() with the > intent of informing the next call to hvcs_open() that device needs to be > reconfigured. However, when hvcs_cleanup() is called we copy hvcsd from > tty->driver_data which was

Re: [PATCH] serial: ucc_uart: make qe_uart_set_mctrl() static

2020-09-14 Thread Jiri Slaby
On 12. 09. 20, 5:38, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/tty/serial/ucc_uart.c:286:6: warning: symbol 'qe_uart_set_mctrl' > was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Sure: Acked-by: Jiri Slaby > ---

Re: [PATCH] spi: fsl-espi: Only process interrupts for expected events

2020-09-14 Thread Joakim Tjernlund
On Mon, 2020-09-14 at 12:28 +1000, Nicholas Piggin wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Excerpts from Chris Packham's message of September 14,

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-14 Thread Anatoly Pugachev
On Mon, Sep 14, 2020 at 10:00 AM Nicholas Piggin wrote: > > Excerpts from Nicholas Piggin's message of September 14, 2020 2:52 pm: > > [...] > > > The basic fix for sparc64 is to remove its mm_cpumask clearing code. The > > optimisation could be effectively restored by sending IPIs to mm_cpumask

[PATCH -next] drivers/macintosh/smu.c: Fix undeclared symbol warning

2020-09-14 Thread Wang Wensheng
Make kernel with `C=2`: drivers/macintosh/smu.c:1018:30: warning: symbol '__smu_get_sdb_partition' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Wang Wensheng --- drivers/macintosh/smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 00/15] selftests/seccomp: Refactor change_syscall()

2020-09-14 Thread Michael Ellerman
Kees Cook writes: > Hi, > > This refactors the seccomp selftest macros used in change_syscall(), > in an effort to remove special cases for mips, arm, arm64, and xtensa, > which paves the way for powerpc fixes. > > I'm not entirely done testing, but all-arch build tests and x86_64 > selftests

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-14 Thread Michal Suchánek
On Fri, Sep 11, 2020 at 11:23:57PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > does this logic apply to "Unrecoverable System Reset" as well? > > Which logic do you mean? > > We do call die() before checking MSR_RI in system_reset_exception(): > > /* >

Re: [PATCH v2] powerpc/papr_scm: Fix warning triggered by perf_stats_show()

2020-09-14 Thread Ira Weiny
On Sat, Sep 12, 2020 at 01:44:51PM +0530, Vaibhav Jain wrote: > A warning is reported by the kernel in case perf_stats_show() returns > an error code. The warning is of the form below: > > papr_scm ibm,persistent-memory:ibm,pmemory@4411: > Failed to query performance stats, Err:-10 >

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-14 Thread David Miller
From: Nicholas Piggin Date: Mon, 14 Sep 2020 14:52:18 +1000 ... > The basic fix for sparc64 is to remove its mm_cpumask clearing code. The > optimisation could be effectively restored by sending IPIs to mm_cpumask > members and having them remove themselves from mm_cpumask. This is more >

Re: [PATCH 00/15] selftests/seccomp: Refactor change_syscall()

2020-09-14 Thread Kees Cook
On Mon, Sep 14, 2020 at 10:15:18PM +1000, Michael Ellerman wrote: > Kees Cook writes: > > Hi, > > > > This refactors the seccomp selftest macros used in change_syscall(), > > in an effort to remove special cases for mips, arm, arm64, and xtensa, > > which paves the way for powerpc fixes. > > > >

Re: [PATCH 13/15] selftests/seccomp: powerpc: Set syscall return during ptrace syscall exit

2020-09-14 Thread Kees Cook
On Mon, Sep 14, 2020 at 03:47:13PM +1000, Michael Ellerman wrote: > Kees Cook writes: > > Some archs (like ppc) only support changing the return code during > > syscall exit when ptrace is used. As the syscall number might not > > be available anymore during syscall exit, it needs to be saved > >

[PATCH v2 0/7] powerpc: Fix a few W=1 compile warnings

2020-09-14 Thread Cédric Le Goater
Hello, Here is a small contribution improving compile with W=1. Thanks, C. Changes in v2: - Better commit logs - Reworked early_reserve_mem() in prom - Remove if statement in sstep Cédric Le Goater (7): powerpc/sysfs: Remove unused 'err' variable in

[PATCH v2 2/7] powerpc/prom: Introduce early_reserve_mem_old()

2020-09-14 Thread Cédric Le Goater
and condition its call with IS_ENABLED(CONFIG_PPC32). This fixes a compile error with W=1. arch/powerpc/kernel/prom.c: In function ‘early_reserve_mem’: arch/powerpc/kernel/prom.c:625:10: error: variable ‘reserve_map’ set but not used [-Werror=unused-but-set-variable] __be64 *reserve_map;

[PATCH v2 1/7] powerpc/sysfs: Remove unused 'err' variable in sysfs_create_dscr_default()

2020-09-14 Thread Cédric Le Goater
This fixes a compile error with W=1. arch/powerpc/kernel/sysfs.c: In function ‘sysfs_create_dscr_default’: arch/powerpc/kernel/sysfs.c:228:7: error: variable ‘err’ set but not used [-Werror=unused-but-set-variable] int err = 0; ^~~ cc1: all warnings being treated as errors Cc:

[PATCH v2 6/7] powerpc/perf: Remove unused variable 'target' in trace_imc_event_init()

2020-09-14 Thread Cédric Le Goater
This fixes a compile error with W=1. CC arch/powerpc/perf/imc-pmu.o ../arch/powerpc/perf/imc-pmu.c: In function ‘trace_imc_event_init’: ../arch/powerpc/perf/imc-pmu.c:1429:22: error: variable ‘target’ set but not used [-Werror=unused-but-set-variable] struct task_struct *target;

[PATCH] ASoC: fsl_audmix: make clock and output src write only

2020-09-14 Thread Viorel Suman (OSS)
From: Viorel Suman "alsactl -f state.conf store/restore" sequence fails because setting "mixing clock source" and "output source" requires active TDM clock being started for configuration propagation. Make these two controls write only so that their values are not stored at "alsactl store".

[PATCH v2 4/7] powerpc/xive: Make debug routines static

2020-09-14 Thread Cédric Le Goater
This fixes a compile error with W=1. CC arch/powerpc/sysdev/xive/common.o ../arch/powerpc/sysdev/xive/common.c:1568:6: error: no previous prototype for ‘xive_debug_show_cpu’ [-Werror=missing-prototypes] void xive_debug_show_cpu(struct seq_file *m, int cpu) ^~~

[PATCH v2 5/7] powerpc/powernv/pci: Remove unused variable 'parent' in pnv_ioda_configure_pe()

2020-09-14 Thread Cédric Le Goater
This fixes a compile error with W=1. CC arch/powerpc/platforms/powernv/pci-ioda.o ../arch/powerpc/platforms/powernv/pci-ioda.c: In function ‘pnv_ioda_configure_pe’: ../arch/powerpc/platforms/powernv/pci-ioda.c:897:18: error: variable ‘parent’ set but not used

[PATCH v2 7/7] powerpc/32: Declare stack_overflow_exception() prototype

2020-09-14 Thread Cédric Le Goater
This fixes a compile error with W=1. CC arch/powerpc/kernel/traps.o ../arch/powerpc/kernel/traps.c:1663:6: error: no previous prototype for ‘stack_overflow_exception’ [-Werror=missing-prototypes] void stack_overflow_exception(struct pt_regs *regs) ^~~~ Cc:

[PATCH v2 3/7] powerpc/sstep: Remove empty if statement checking for invalid form

2020-09-14 Thread Cédric Le Goater
The check should be performed by the caller. This fixes a compile error with W=1. ../arch/powerpc/lib/sstep.c: In function ‘mlsd_8lsd_ea’: ../arch/powerpc/lib/sstep.c:225:3: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body] ; /* Invalid form. Should already be

[PATCH -next] macintosh: windfarm: use for_each_child_of_node() macro

2020-09-14 Thread Qinglang Miao
Use for_each_child_of_node() macro instead of open coding it. Signed-off-by: Qinglang Miao --- drivers/macintosh/windfarm_smu_sat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c index

Re: [PATCH] KVM: PPC: Book3S HV: Do not allocate HPT for a nested guest

2020-09-14 Thread David Gibson
On Fri, Sep 11, 2020 at 01:16:07AM -0300, Fabiano Rosas wrote: > The current nested KVM code does not support HPT guests. This is > informed/enforced in some ways: > > - Hosts < P9 will not be able to enable the nested HV feature; > > - The nested hypervisor MMU capabilities will not contain >

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-14 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of September 14, 2020 2:52 pm: [...] > The basic fix for sparc64 is to remove its mm_cpumask clearing code. The > optimisation could be effectively restored by sending IPIs to mm_cpumask > members and having them remove themselves from mm_cpumask. This is

Re: [PATCH v3 1/5] dt-bindings: powerpc: define apm,apm82181 binding

2020-09-14 Thread Rob Herring
On Sun, Sep 06, 2020 at 12:06:11AM +0200, Christian Lamparter wrote: > make a binding for the various boards based on the > AppliedMicro/APM APM82181 SoC. > > Signed-off-by: Christian Lamparter > --- > .../bindings/powerpc/4xx/apm,apm82181.yaml| 29 +++ > 1 file changed, 29

Re: [PATCH v3 2/5] powerpc: apm82181: create shared dtsi for APM bluestone

2020-09-14 Thread Rob Herring
On Sun, Sep 06, 2020 at 12:06:12AM +0200, Christian Lamparter wrote: > This patch adds an DTSI-File that can be used by various device-tree > files for APM82181-based devices. > > Some of the nodes (like UART, PCIE, SATA) are used by the uboot and > need to stick with the naming-conventions of

[PATCH net] ibmvnic: update MAINTAINERS

2020-09-14 Thread Dany Madden
Update supporters for IBM Power SRIOV Virtual NIC Device Driver. Thomas Falcon is moving on to other works. Dany Madden, Lijun Pan and Sukadev Bhattiprolu are the current supporters. Signed-off-by: Dany Madden --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff