Re: [PATCH v2 2/3] powerpc/config: Renable MTD_PHYSMAP_OF

2021-08-16 Thread Christophe Leroy
Le 17/08/2021 à 06:54, Joel Stanley a écrit : CONFIG_MTD_PHYSMAP_OF is not longer enabled as it depends on MTD_PHYSMAP which is not enabled. This is a regression from commit 642b1e8dbed7 ("mtd: maps: Merge physmap_of.c into physmap-core.c"), which added the extra dependency. Add

Re: [PATCH v5 06/11] powerpc/pseries/iommu: Add ddw_property_create() and refactor enable_ddw()

2021-08-16 Thread Leonardo Brás
Hello Fred, thanks for this feedback! On Tue, 2021-07-20 at 19:49 +0200, Frederic Barrat wrote: > > > kfree(window); > >   > > -out_clear_window: > > -   remove_ddw(pdn, true); > > +out_del_prop: > > +   of_remove_property(pdn, win64); > >   > >   out_free_prop: > >

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-16 Thread Madhavan Srinivasan
On 8/16/21 12:26 PM, Christophe Leroy wrote: Le 16/08/2021 à 08:44, kajoljain a écrit : On 8/14/21 6:14 PM, Michael Ellerman wrote: Christophe Leroy writes: Le 13/08/2021 à 10:24, Kajol Jain a écrit : Incase of random sampling, there can be scenarios where SIAR is not latching sample

[PATCH v2 0/3] powerpc: mpc855_ads defconfig fixes

2021-08-16 Thread Joel Stanley
v2: fix typos, split out mtd fix from savedefconfig patch The first patch fixes a build warning I noticed when testing something unrelated. The second fixes a regression where the MTD partition support dropped out of the config. I have enabled the dependency so this is still part of the config.

[PATCH v2 1/3] powerpc/config: Fix IPV6 warning in mpc855_ads

2021-08-16 Thread Joel Stanley
When building this config there's a warning: 79:warning: override: reassigning to symbol IPV6 Commit 9a1762a4a4ff ("powerpc/8xx: Update mpc885_ads_defconfig to improve CI") added CONFIG_IPV6=y, but left '# CONFIG_IPV6 is not set' in. IPV6 is default y, so remove both to clean up the build.

[PATCH v2 3/3] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Joel Stanley
Regenerate atop v5.14-rc6 by doing a make savedefconfig. The changes a re-ordering except for the following (which are still set indirectly): - CONFIG_DEBUG_KERNEL=y selected by EXPERT - CONFIG_PPC_EARLY_DEBUG_CPM_ADDR=0xff002008 which is the default setting Signed-off-by: Joel Stanley

[PATCH v2 2/3] powerpc/config: Renable MTD_PHYSMAP_OF

2021-08-16 Thread Joel Stanley
CONFIG_MTD_PHYSMAP_OF is not longer enabled as it depends on MTD_PHYSMAP which is not enabled. This is a regression from commit 642b1e8dbed7 ("mtd: maps: Merge physmap_of.c into physmap-core.c"), which added the extra dependency. Add CONFIG_MTD_PHYSMAP=y so this stays in the config, as Christophe

Re: [PATCH 2/2] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Joel Stanley
On Mon, 16 Aug 2021 at 08:49, Christophe Leroy wrote: > > > > Le 16/08/2021 à 10:31, Joel Stanley a écrit : > > Regenrate atop v5.14-rc6. > > Typos. > > You mean you did redo a "make savedefconfig" ? Yes, I did.

Re: [PATCH v2 3/3] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Christophe Leroy
Le 17/08/2021 à 06:54, Joel Stanley a écrit : Regenerate atop v5.14-rc6 by doing a make savedefconfig. The changes a re-ordering except for the following (which are still set indirectly): - CONFIG_DEBUG_KERNEL=y selected by EXPERT - CONFIG_PPC_EARLY_DEBUG_CPM_ADDR=0xff002008 which is

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-16 Thread kajoljain
On 8/14/21 6:14 PM, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 13/08/2021 à 10:24, Kajol Jain a écrit : >>> Incase of random sampling, there can be scenarios where SIAR is not >>> latching sample address and results in 0 value. Since current code >>> directly returning the siar

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 08:44, kajoljain a écrit : On 8/14/21 6:14 PM, Michael Ellerman wrote: Christophe Leroy writes: Le 13/08/2021 à 10:24, Kajol Jain a écrit : Incase of random sampling, there can be scenarios where SIAR is not latching sample address and results in 0 value. Since current

[PATCH v1 1/4] powerpc/64: handle MSR EE and RI in interrupt entry wrapper

2021-08-16 Thread Nicholas Piggin
Similarly to the system call change in the previous patch, the mtmsrd to enable RI can be combined with the mtmsrd to enable EE for interrupts which enable the latter, which tends to be the important synchronous interrupts (i.e., page faults). Do this by enabling EE and RI together at the

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-16 Thread kajoljain
On 8/13/21 3:04 PM, Christophe Leroy wrote: > > > Le 13/08/2021 à 10:24, Kajol Jain a écrit : >> Incase of random sampling, there can be scenarios where SIAR is not >> latching sample address and results in 0 value. Since current code >> directly returning the siar value, we could see

[PATCH v1 0/4] powerpc/64s: interrupt speedups

2021-08-16 Thread Nicholas Piggin
Here's a few stragglers. The first patch was submitted already but had some bugs with unrecoverable exceptions on HPT (current->blah being accessed before MSR[RI] was enabled). Those should be fixed now. The others are generally for helping asynch interrupts, which are a bit harder to measure

[PATCH v1 2/4] powerpc/64s/perf: add power_pmu_running to query whether perf is being used

2021-08-16 Thread Nicholas Piggin
Interrupt handling code would like to know whether perf is enabled, to know whether it should enable MSR[EE] to improve PMI coverage. Cc: Madhavan Srinivasan Cc: Athira Rajeev Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/hw_irq.h | 2 ++ arch/powerpc/perf/core-book3s.c | 13

Re: [RFC PATCH] powerpc/book3s64/radix: Upgrade va tlbie to PID tlbie if we cross PMD_SIZE

2021-08-16 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > On 8/12/21 6:19 PM, Michael Ellerman wrote: >> "Puvichakravarthy Ramachandran" writes: With shared mapping, even though we are unmapping a large range, the kernel will force a TLB flush with ptl lock held to avoid the race mentioned in commit

[PATCH v1 3/4] powerpc/64s/interrupt: Don't enable MSR[EE] in irq handlers unless perf is in use

2021-08-16 Thread Nicholas Piggin
Enabling MSR[EE] in interrupt handlers while interrupts are still soft masked allows PMIs to profile interrupt handlers to some degree, beyond what SIAR latching allows. When perf is not being used, this is almost useless work. It requires an extra mtmsrd in the irq handler, and it also opens the

[PATCH v1 4/4] powerpc/64s/interrupt: avoid saving CFAR in some asynchronous interrupts

2021-08-16 Thread Nicholas Piggin
Reading the CFAR register is quite costly (~20 cycles on POWER9). It is a good idea to have for most synchronous interrupts, but for async ones it is much less important. Doorbell, external, and decrementer interrupts are the important asynchronous ones. HV interrupts can't skip CFAR if KVM HV is

Re: [PATCH 2/2] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 10:31, Joel Stanley a écrit : Regenrate atop v5.14-rc6. Typos. You mean you did redo a "make savedefconfig" ? The chagnes are mostly re-ordering, except for the following which fall out due to dependenacies: - CONFIG_DEBUG_KERNEL=y selected by EXPERT -

[PATCH linux-next] module: remove duplicate include in interrupt.c

2021-08-16 Thread cgel . zte
From: Lv Ruyi 'asm/interrupt.h' included in 'interrupt.c' is duplicated. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- arch/powerpc/kernel/interrupt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c index

Re: [PATCH linux-next] module: remove duplicate include in interrupt.c

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 13:34, cgel@gmail.com a écrit : From: Lv Ruyi 'asm/interrupt.h' included in 'interrupt.c' is duplicated. This patch has been submitted at least half a dozen of times already. You should maintain alphabetic order in the include list. But please don't post it again, we

Re: [FSL P50x0] lscpu reports wrong values since the RC1 of kernel 5.13

2021-08-16 Thread Christian Zigotzky
Hi All, I tested the RC6 of kernel 5.14 today and unfortunately the issue still exists. We have figured out that only P5040 SoCs are affected. [1] P5020 SoCs display the correct values. Please check the CPU changes in the PowerPC updates 5.13-1 and 5.13-2. Thanks, Christian [1]

[PATCH 1/3] powerpc/64s: Fix build when !PPC_BARRIER_NOSPEC

2021-08-16 Thread Joel Stanley
When disabling PPC_BARRIER_NOSPEC the do_barrier_nospec_fixups_range definition is still included, as well as a stub in asm/setup.h: ../arch/powerpc/lib/feature-fixups.c:502:6: error: redefinition of ‘do_barrier_nospec_fixu> 502 | void do_barrier_nospec_fixups_range(bool enable, void

[PATCH 2/3] powerpc: Fix undefined static key

2021-08-16 Thread Joel Stanley
When CONFIG_PPC_BARRIER_NOSPEC=n, security.c is not built leading to a missing definition of uaccess_flush_key. LD vmlinux.o MODPOST vmlinux.symvers MODINFO modules.builtin.modinfo GEN modules.builtin LD .tmp_vmlinux.kallsyms1 powerpc64le-linux-gnu-ld:

[PATCH 3/3] powerpc/microwatt: CPU doesn't (yet) have speculation bugs

2021-08-16 Thread Joel Stanley
Signed-off-by: Joel Stanley --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 663766fbf505..d5af6667c206 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -279,6 +279,7 @@ config PPC_BARRIER_NOSPEC

Re: [PATCH v2 00/60] KVM: PPC: Book3S HV P9: entry/exit optimisations

2021-08-16 Thread Athira Rajeev
> On 11-Aug-2021, at 9:30 PM, Nicholas Piggin wrote: > > This reduces radix guest full entry/exit latency on POWER9 and POWER10 > by 2x. > > Nested HV guests should see smaller improvements in their L1 entry/exit, > but this is also combined with most L0 speedups also applying to nested >

Re: [PATCH 3/3] powerpc/microwatt: CPU doesn't (yet) have speculation bugs

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 10:24, Joel Stanley a écrit : Signed-off-by: Joel Stanley --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 663766fbf505..d5af6667c206 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig

Re: [PATCH 2/3] powerpc: Fix undefined static key

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 10:24, Joel Stanley a écrit : When CONFIG_PPC_BARRIER_NOSPEC=n, security.c is not built leading to a missing definition of uaccess_flush_key. LD vmlinux.o MODPOST vmlinux.symvers MODINFO modules.builtin.modinfo GEN modules.builtin LD

Re: [PATCH 0/2] powerpc: mpc855_ads defconfig fixes

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 10:31, Joel Stanley a écrit : The first was a build warning I noticed when testing something unrelated. I took a moment to look into it, and came up with the second patch which updates the defconfig to make it easier to maintain in the future It also fixes a regression where

Re: [PATCH 1/2] powerpc/config: Fix IPV6 warning in mpc855_ads

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 10:31, Joel Stanley a écrit : When building this config there's a warning: 79:warning: override: reassigning to symbol IPV6 Commit 9a1762a4a4ff ("powerpc/8xx: Update mpc885_ads_defconfig to improve CI") added CONFIG_IPV6=y, but left '# CONFIG_IPV6 is not set' in. IPV6 is

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-16 Thread Srikar Dronamraju
> > Your version is much much better than mine. > And I have verified that it works as expected. > > Hey Peter/Valentin Are we waiting for any more feedback/testing for this? -- Thanks and Regards Srikar Dronamraju

[PATCH 2/2] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Joel Stanley
Regenrate atop v5.14-rc6. The chagnes are mostly re-ordering, except for the following which fall out due to dependenacies: - CONFIG_DEBUG_KERNEL=y selected by EXPERT - CONFIG_PPC_EARLY_DEBUG_CPM_ADDR=0xff002008 which is the default setting CONFIG_MTD_PHYSMAP_OF is not longer enabled, as

[PATCH 0/3] powerpc/64s: Fix PPC_BARRIER_NOSPEC=n

2021-08-16 Thread Joel Stanley
When disabling PPC_BARRIER_NOSPEC on Microwatt to see if it improved boot time, I discovered the build was broken (first patch). This got worse between when I first tried and now (second patch). The third patch disables PPC_BARRIER_NOSPEC when building for Microwatt. This one is optional, as it

[PATCH 0/2] powerpc: mpc855_ads defconfig fixes

2021-08-16 Thread Joel Stanley
The first was a build warning I noticed when testing something unrelated. I took a moment to look into it, and came up with the second patch which updates the defconfig to make it easier to maintain in the future It also fixes a regression where the MTD partition support dropped out of the

Re: [PATCH 1/3] powerpc/64s: Fix build when !PPC_BARRIER_NOSPEC

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 10:24, Joel Stanley a écrit : When disabling PPC_BARRIER_NOSPEC the do_barrier_nospec_fixups_range definition is still included, as well as a stub in asm/setup.h: ../arch/powerpc/lib/feature-fixups.c:502:6: error: redefinition of ‘do_barrier_nospec_fixu> 502 | void

[PATCH 1/2] powerpc/config: Fix IPV6 warning in mpc855_ads

2021-08-16 Thread Joel Stanley
When building this config there's a warning: 79:warning: override: reassigning to symbol IPV6 Commit 9a1762a4a4ff ("powerpc/8xx: Update mpc885_ads_defconfig to improve CI") added CONFIG_IPV6=y, but left '# CONFIG_IPV6 is not set' in. IPV6 is default y, so remove both to clean up the build.

[PATCH] powerpc/pseries/cpuhp: fix non-NUMA build

2021-08-16 Thread Nathan Lynch
With CONFIG_NUMA unset, direct references to node_to_cpumask_map don't work: arch/powerpc/platforms/pseries/hotplug-cpu.c: In function 'pseries_cpu_hotplug_init': >> arch/powerpc/platforms/pseries/hotplug-cpu.c:1022:8: error: >> 'node_to_cpumask_map' undeclared (first use in this >>

Re: [PATCH] powerpc/pseries/cpuhp: fix non-NUMA build

2021-08-16 Thread Nathan Lynch
Christophe Leroy writes: > Le 16/08/2021 à 17:17, Nathan Lynch a écrit : >> With CONFIG_NUMA unset, direct references to node_to_cpumask_map don't >> work: >> >> arch/powerpc/platforms/pseries/hotplug-cpu.c: In function >> 'pseries_cpu_hotplug_init':

Re: [PATCH] powerpc/pseries/cpuhp: fix non-NUMA build

2021-08-16 Thread Christophe Leroy
Le 16/08/2021 à 17:17, Nathan Lynch a écrit : With CONFIG_NUMA unset, direct references to node_to_cpumask_map don't work: arch/powerpc/platforms/pseries/hotplug-cpu.c: In function 'pseries_cpu_hotplug_init': arch/powerpc/platforms/pseries/hotplug-cpu.c:1022:8: error:

Re: [PATCH v1 2/4] powerpc/64s/perf: add power_pmu_running to query whether perf is being used

2021-08-16 Thread kernel test robot
Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.14-rc6 next-20210816] [cannot apply to scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH] powerpc/xive: Do not mark xive_request_ipi() as __init

2021-08-16 Thread Nathan Chancellor
Compiling ppc64le_defconfig with clang-14 shows a modpost warning: WARNING: modpost: vmlinux.o(.text+0xa74e0): Section mismatch in reference from the function xive_setup_cpu_ipi() to the function .init.text:xive_request_ipi() The function xive_setup_cpu_ipi() references the function __init

Re: [PATCH] powerpc/xive: Do not mark xive_request_ipi() as __init

2021-08-16 Thread Nick Desaulniers
On Mon, Aug 16, 2021 at 12:06 PM Nathan Chancellor wrote: > > Compiling ppc64le_defconfig with clang-14 shows a modpost warning: > > WARNING: modpost: vmlinux.o(.text+0xa74e0): Section mismatch in > reference from the function xive_setup_cpu_ipi() to the function > .init.text:xive_request_ipi() >

Re: [PATCH 3/7] powerpc: replace cc-option-yn uses with cc-option

2021-08-16 Thread Michael Ellerman
Nick Desaulniers writes: > cc-option-yn can be replaced with cc-option. ie. > Checking for support: > ifeq ($(call cc-option-yn,$(FLAG)),y) > becomes: > ifneq ($(call cc-option,$(FLAG)),) > > Checking for lack of support: > ifeq ($(call cc-option-yn,$(FLAG)),n) > becomes: > ifeq ($(call

Re: [PATCH 2/3] powerpc: Fix undefined static key

2021-08-16 Thread Joel Stanley
On Mon, 16 Aug 2021 at 08:39, Christophe Leroy wrote: > > > > Le 16/08/2021 à 10:24, Joel Stanley a écrit : > > When CONFIG_PPC_BARRIER_NOSPEC=n, security.c is not built leading to a > > missing definition of uaccess_flush_key. > > > >LD vmlinux.o > >MODPOST vmlinux.symvers > >

Re: [PATCH 2/3] powerpc: Fix undefined static key

2021-08-16 Thread Michael Ellerman
Joel Stanley writes: > When CONFIG_PPC_BARRIER_NOSPEC=n, security.c is not built leading to a > missing definition of uaccess_flush_key. > > LD vmlinux.o > MODPOST vmlinux.symvers > MODINFO modules.builtin.modinfo > GEN modules.builtin > LD .tmp_vmlinux.kallsyms1 >

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-16 Thread Valentin Schneider
On 16/08/21 16:03, Srikar Dronamraju wrote: >> >> Your version is much much better than mine. >> And I have verified that it works as expected. >> >> > > Hey Peter/Valentin > > Are we waiting for any more feedback/testing for this? > I'm not overly fond of that last one, but AFAICT the only

Re: [PATCH 3/7] powerpc: replace cc-option-yn uses with cc-option

2021-08-16 Thread Nathan Chancellor
On 8/16/2021 5:21 PM, 'Nick Desaulniers' via Clang Built Linux wrote: cc-option-yn can be replaced with cc-option. ie. Checking for support: ifeq ($(call cc-option-yn,$(FLAG)),y) becomes: ifneq ($(call cc-option,$(FLAG)),) Checking for lack of support: ifeq ($(call cc-option-yn,$(FLAG)),n)

Re: [PATCH v8 5/5] powerpc/pseries: Add support for FORM2 associativity

2021-08-16 Thread David Gibson
On Thu, Aug 12, 2021 at 06:52:23PM +0530, Aneesh Kumar K.V wrote: > PAPR interface currently supports two different ways of communicating resource > grouping details to the OS. These are referred to as Form 0 and Form 1 > associativity grouping. Form 0 is the older format and is now considered >

Re: [PATCH v8 3/5] powerpc/pseries: Consolidate different NUMA distance update code paths

2021-08-16 Thread David Gibson
On Thu, Aug 12, 2021 at 06:52:21PM +0530, Aneesh Kumar K.V wrote: > The associativity details of the newly added resourced are collected from > the hypervisor via "ibm,configure-connector" rtas call. Update the numa > distance details of the newly added numa node after the above call. > > Instead

[PATCH 3/7] powerpc: replace cc-option-yn uses with cc-option

2021-08-16 Thread Nick Desaulniers
cc-option-yn can be replaced with cc-option. ie. Checking for support: ifeq ($(call cc-option-yn,$(FLAG)),y) becomes: ifneq ($(call cc-option,$(FLAG)),) Checking for lack of support: ifeq ($(call cc-option-yn,$(FLAG)),n) becomes: ifeq ($(call cc-option,$(FLAG)),) This allows us to pursue