Re: [PATCH] powerpc/purgatory: Omit use of bin2c

2022-07-24 Thread Segher Boessenkool
On Sun, Jun 26, 2022 at 07:40:37AM +0900, Masahiro Yamada wrote: > The .incbin assembler directive is much faster than bin2c + $(CC). And perhaps more importantly it is simpler and less clumsy. > --- /dev/null > +++ b/arch/powerpc/purgatory/kexec-purgatory.S > @@ -0,0 +1,14 @@ > +/*

Re: [PATCH] powerpc/mm: fix repeated words in comments

2022-07-24 Thread Segher Boessenkool
On Sun, Jul 24, 2022 at 02:36:22PM +0800, wangjianli wrote: > Delete the redundant word 'so'. > /* It would be nice if this was a BUILD_BUG_ON(), but at the >* moment, gcc doesn't seem to recognize is_power_of_2 as a > - * constant expression, so so much for that. */ > +

Re: [PATCH] powerpc/purgatory: Omit use of bin2c

2022-07-24 Thread Masahiro Yamada
On Mon, Jul 25, 2022 at 10:42 AM Segher Boessenkool wrote: > > On Sun, Jun 26, 2022 at 07:40:37AM +0900, Masahiro Yamada wrote: > > The .incbin assembler directive is much faster than bin2c + $(CC). > > And perhaps more importantly it is simpler and less clumsy. > > > --- /dev/null > > +++

[PATCH v2] powerpc/purgatory: Omit use of bin2c

2022-07-24 Thread Masahiro Yamada
The .incbin assembler directive is much faster than bin2c + $(CC). Do similar refactoring as in commit 4c0f032d4963 ("s390/purgatory: Omit use of bin2c"). Please note the .quad directive matches to size_t in C (both 8 byte) because the purgatory is compiled only for the 64-bit kernel.

Re: [PATCH] KVM: PPC: Book3S HV:fix repeated words in comments

2022-07-24 Thread Segher Boessenkool
On Sun, Jul 24, 2022 at 01:41:37PM +0800, wangjianli wrote: > From: Jianli Wang > > Delete the redundant word 'do'. > - /* invalidate the entry (what do do on error from the above ?) */ > + /* invalidate the entry (what do on error from the above ?) */ Probably "what to do" was meant

Re: [PATCH] powerpc: Remove the static variable initialisations to 0

2022-07-24 Thread Michael Ellerman
Segher Boessenkool writes: > On Sat, Jul 23, 2022 at 03:34:05PM +0200, Michal Suchánek wrote: >> Hello, >> >> On Sat, Jul 23, 2022 at 05:24:36PM +0800, Jason Wang wrote: >> > Initialise global and static variable to 0 is always unnecessary. >> > Remove the unnecessary initialisations. >> >>

[PATCH] KVM: PPC: Book3S HV:fix repeated words in comments

2022-07-24 Thread wangjianli
From: Jianli Wang Delete the redundant word 'do'. Signed-off-by: Jianli Wang --- arch/powerpc/kvm/book3s_hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index e08fb3124dca..17d79be6077d 100644 ---

[PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.

2022-07-24 Thread wangjianli
Signed-off-by: wangjianli --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 514fd45c1994..73c6db20cd8a 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++

[PATCH] powerpc/mm: fix repeated words in comments

2022-07-24 Thread wangjianli
Delete the redundant word 'so'. Signed-off-by: wangjianli --- arch/powerpc/mm/init-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c index 119ef491f797..acf5d7ba79d1 100644 ---

Re: [PATCH] powerpc/purgatory: Omit use of bin2c

2022-07-24 Thread Masahiro Yamada
On Sun, Jun 26, 2022 at 7:42 AM Masahiro Yamada wrote: > > The .incbin assembler directive is much faster than bin2c + $(CC). > > Do similar refactoring as in commit 4c0f032d4963 ("s390/purgatory: > Omit use of bin2c"). > > Please note the .quad directive matches to size_t in C (both 8 byte) >