Re: [PATCH] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-19 Thread Jens Axboe
On 11/18/23 4:45 PM, Timothy Pearson wrote: > During floating point and vector save to thread data fr0/vs0 are clobbered > by the FPSCR/VSCR store routine. This leads to userspace register corruption > and application data corruption / crash under the following rare condition: > > * A userspace

[PATCH] ASoC: fsl_mqs: Remove duplicate linux/of.h header

2023-11-19 Thread Lucas Tanure
Remove linux/of.h as is included more than once. Reported by make includecheck. Signed-off-by: Lucas Tanure --- sound/soc/fsl/fsl_mqs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index f2d74ec05cdf..86704ba5f6f0 100644 ---

Re: [PATCH v9 23/27] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-11-19 Thread kernel test robot
-CONFIG_FRAMER_PEF2256-0-0 (https://download.01.org/0day-ci/archive/20231119/202311191651.ayfggtmd-...@intel.com/config) reproduce: (https://download.01.org/0day-ci/archive/20231119/202311191651.ayfggtmd-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new

Re: [PATCH] misc: ocxl: link: Remove unnecessary (void*) conversions

2023-11-19 Thread Andrew Donnellan
On Mon, 2023-11-13 at 09:45 +0800, Li zeming wrote: > The link pointer does not need to cast the type. > > Signed-off-by: Li zeming Acked-by: Andrew Donnellan > --- >  drivers/misc/ocxl/link.c | 14 +++--- >  1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH] misc: ocxl: main: Remove unnecessary ‘0’ values from rc

2023-11-19 Thread Andrew Donnellan
On Mon, 2023-11-13 at 09:52 +0800, Li kunyu wrote: > rc is assigned first, so it does not need to initialize the > assignment. > > Signed-off-by: Li kunyu I don't have strong feelings about whether to get rid of unnecessary initialisations, but most of the code doesn't do it, so for

Re: [PATCH v2 1/5] powerpc/rtas: Drop declaration of undefined call_rtas() function

2023-11-19 Thread Andrew Donnellan
On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > The call_rtas() function has never been a part of arch/powerpc, and > its implementation was removed from arch/ppc by commit 0a26b1364f14 > ("ppc: Remove CHRP, POWER3 and POWER4 support from arch/ppc").

Re: [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions

2023-11-19 Thread Andrew Donnellan
On Mon, 2023-11-13 at 09:15 +0800, Li zeming wrote: > The ctx pointer does not need to cast the type. > > Signed-off-by: Li zeming Acked-by: Andrew Donnellan > --- >  drivers/misc/ocxl/context.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] misc: ocxl: afu_irq: Remove unnecessary (void*) conversions

2023-11-19 Thread Andrew Donnellan
On Mon, 2023-11-13 at 09:22 +0800, Li zeming wrote: > The irq pointer does not need to cast the type. > > Signed-off-by: Li zeming Acked-by: Andrew Donnellan > --- >  drivers/misc/ocxl/afu_irq.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v4 4/5] tty: Add SBI debug console support to HVC SBI driver

2023-11-19 Thread Jiri Slaby
On 18. 11. 23, 4:38, Anup Patel wrote: diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c index 31f53fa77e4a..697c981221b5 100644 --- a/drivers/tty/hvc/hvc_riscv_sbi.c +++ b/drivers/tty/hvc/hvc_riscv_sbi.c ... -static int __init hvc_sbi_console_init(void) +static

Re: [PATCH v2 4/5] powerpc/rtas: Remove trailing space

2023-11-19 Thread Andrew Donnellan
On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > Use scripts/cleanfile to remove instances of trailing space in the > core RTAS code and header. > > Signed-off-by: Nathan Lynch Thanks for the cleanup, LGTM. Reviewed-by: Andrew Donnellan > --- >  

Re: [PATCH v2 3/5] powerpc/rtas: Move post_mobility_fixup() declaration to pseries

2023-11-19 Thread Andrew Donnellan
On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > This is a pseries-specific function declaration that doesn't belong > in > rtas.h. Move it to the pseries platform code and adjust > pseries/suspend.c accordingly. > > Signed-off-by: Nathan Lynch This

Re: [PATCH v2 2/5] powerpc/rtas: Remove unused rtas_service_present()

2023-11-19 Thread Andrew Donnellan
On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > rtas_service_present() has no more users. > > rtas_function_implemented() is now the appropriate API for > determining > whether a given RTAS function is available to call. > > Signed-off-by: Nathan

Re: [PATCH] asm/io: remove unnecessary xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()

2023-11-19 Thread Arnd Bergmann
On Mon, Nov 20, 2023, at 01:39, Kefeng Wang wrote: > On 2023/11/20 3:34, Geert Uytterhoeven wrote: >> On Sat, Nov 18, 2023 at 11:09 AM Kefeng Wang >> wrote: >>> >>> -/* >>> - * Convert a physical pointer to a virtual kernel pointer for /dev/mem >>> - * access >>> - */ >>> -#define

Re: [PATCH] asm/io: remove unnecessary xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()

2023-11-19 Thread Kefeng Wang
On 2023/11/20 14:40, Arnd Bergmann wrote: On Mon, Nov 20, 2023, at 01:39, Kefeng Wang wrote: On 2023/11/20 3:34, Geert Uytterhoeven wrote: On Sat, Nov 18, 2023 at 11:09 AM Kefeng Wang wrote: -/* - * Convert a physical pointer to a virtual kernel pointer for /dev/mem - * access - */

[PATCH v2] asm/io: remove unnecessary xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()

2023-11-19 Thread Kefeng Wang
The asm-generic/io.h already has default define, remove unnecessary arch's defination. Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Russell King Cc: Brian Cain Cc: "James E.J. Bottomley" Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Yoshinori Sato Cc: Rich Felker Cc: "David S. Miller"

[linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-19 Thread kernel test robot
Hello, kernel test robot noticed a -2.9% regression of will-it-scale.per_thread_ops on: commit: 0ede61d8589cc2d93aa78230d74ac58b5b8d0244 ("file: convert to SLAB_TYPESAFE_BY_RCU") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master testcase: will-it-scale test machine:

Re: [PATCH v2 5/5] powerpc/rtas: Remove 'extern' from function declarations in rtas.h

2023-11-19 Thread Andrew Donnellan
On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > This header occasionally gains new function declarations without the > leading extern in accordance with current style rules. Leaving the > legacy externs in place is making the header more difficult to

Re: [PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-19 Thread Michael Ellerman
Hi Timothy, Great work debugging this. I think your fix is good, but I want to understand it a bit more to make sure I can explain why we haven't seen it outside of io-uring. If this can be triggered outside of io-uring then I have even more backporting in my future :} Typically save_fpu() is

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-19 Thread Mateusz Guzik
On Mon, Nov 20, 2023 at 03:11:31PM +0800, kernel test robot wrote: > > > Hello, > > kernel test robot noticed a -2.9% regression of will-it-scale.per_thread_ops > on: > > > commit: 0ede61d8589cc2d93aa78230d74ac58b5b8d0244 ("file: convert to > SLAB_TYPESAFE_BY_RCU") >

[PATCH v2] powerpc: Don't clobber fr0/vs0 during fp|altivec register save

2023-11-19 Thread Timothy Pearson
During floating point and vector save to thread data fr0/vs0 are clobbered by the FPSCR/VSCR store routine. This leads to userspace register corruption and application data corruption / crash under the following rare condition: * A userspace thread is executing with VSX/FP mode enabled * The

Re: [PATCH] asm/io: remove unnecessary xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()

2023-11-19 Thread Kefeng Wang
On 2023/11/20 3:34, Geert Uytterhoeven wrote: On Sat, Nov 18, 2023 at 11:09 AM Kefeng Wang wrote: The asm-generic/io.h already has default definition, remove unnecessary arch's defination. Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Russell King Cc: Brian Cain Cc: "James E.J.

Re: [PATCH] asm/io: remove unnecessary xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()

2023-11-19 Thread Geert Uytterhoeven
On Sat, Nov 18, 2023 at 11:09 AM Kefeng Wang wrote: > The asm-generic/io.h already has default definition, remove unnecessary > arch's defination. > > Cc: Richard Henderson > Cc: Ivan Kokshaysky > Cc: Russell King > Cc: Brian Cain > Cc: "James E.J. Bottomley" > Cc: Nicholas Piggin > Cc:

Please backport feea65a338e5 ("powerpc/powernv: Fix fortify source warnings in opal-prd.c")

2023-11-19 Thread Michael Ellerman
Hi, Please backport feea65a338e5 ("powerpc/powernv: Fix fortify source warnings in opal-prd.c") to the 6.5, 6.1, 5.15, 5.10 stable trees. cheers