On 02/21/24 at 11:07pm, Sourabh Jain wrote:
> Hello Baoquan,
>
> On 19/01/24 20:22, Baoquan He wrote:
> > Now move the relevant codes into separate files:
> > kernel/crash_reserve.c, include/linux/crash_reserve.h.
> >
> > And add config item CRASH_RESERVE to control its enabling.
>
> Feels like
Hi Simon,
On 2/22/24 01:56, Simon Horman wrote:
> Fix possible NULL pointer dereference in gelic_card_release_tx_chain()
>
> The cited commit introduced a netdev variable to
> gelic_card_release_tx_chain() which is set unconditionally on each
> iteration of a for loop.
>
> It is set to the
On 02/21/24 at 12:57pm, Andrew Morton wrote:
> On Wed, 21 Feb 2024 11:15:00 +0530 Hari Bathini
> wrote:
>
> > On 04/02/24 8:56 am, Baoquan He wrote:
> > >>> Hope Hari and Pingfan can help have a look, see if
> > >>> it's doable. Now, I make it either have both kexec and crash enabled, or
> >
Hi Simon,
On 2/22/24 02:46, Simon Horman wrote:
> * Update the Kernel Doc for gelic_descr_set_tx_cmdstat()
> and gelic_net_setup_netdev() so that documented name
> and the actual name of the function match.
>
> * Move define of GELIC_ALIGN() so that it is no longer
> between
On 2/22/24 03:32, Dan Carpenter wrote:
> This driver is PPC so I have never looked at the code before. I noticed
> another issue that was introduced last December in commit 3ce4f9c3fbb3
> ("net/ps3_gelic_net: Add gelic_descr structures").
>
> net/ethernet/toshiba/ps3_gelic_net.c
...
>375
Hi Hari,
On Thu, Feb 22, 2024 at 11:30:17AM +0530, Hari Bathini wrote:
> Hi Sachin,
>
> On 22/02/24 10:55 am, Sachin Sant wrote:
> > Kdump fails to save vmcore with recent linux-next builds on IBM Power server
> > with following messages
> >
> > Starting Kdump Vmcore Save Service...
>
Hi Sachin,
On 22/02/24 10:55 am, Sachin Sant wrote:
Kdump fails to save vmcore with recent linux-next builds on IBM Power server
with following messages
Starting Kdump Vmcore Save Service...
[ 17.349599] kdump[367]: Kdump is using the default log level(3).
[ 17.407407] kdump[391]:
Christophe Leroy writes:
> __kernel_map_pages() is almost identical for PPC32 and RADIX.
>
> Refactor it.
>
> On PPC32 it is not needed for KFENCE, but to keep it simple
> just make it similar to PPC64.
>
> Signed-off-by: Christophe Leroy
> ---
> arch/powerpc/include/asm/book3s/64/pgtable.h |
Kdump fails to save vmcore with recent linux-next builds on IBM Power server
with following messages
Starting Kdump Vmcore Save Service...
[ 17.349599] kdump[367]: Kdump is using the default log level(3).
[ 17.407407] kdump[391]: saving to
On 22/02/24 2:27 am, Andrew Morton wrote:
On Wed, 21 Feb 2024 11:15:00 +0530 Hari Bathini wrote:
On 04/02/24 8:56 am, Baoquan He wrote:
Hope Hari and Pingfan can help have a look, see if
it's doable. Now, I make it either have both kexec and crash enabled, or
disable both of them
On 22/02/24 09:28, Baoquan He wrote:
On 02/22/24 at 09:01am, Sourabh Jain wrote:
Hello Baoquan,
There are a lot of code movements introduced by your patch series, 'Split
crash out from kexec and clean up related config items.'
On 02/22/24 at 09:01am, Sourabh Jain wrote:
> Hello Baoquan,
>
> There are a lot of code movements introduced by your patch series, 'Split
> crash out from kexec and clean up related config items.'
>
> https://lore.kernel.org/all/20240221125752.36fbfe9c307496313198b...@linux-foundation.org/
>
>
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
next
branch HEAD: b22ea627225b53ec7ce25c19d6df9fa8217d1643 powerpc/perf: Power11
Performance Monitoring support
elapsed time: 885m
configs tested: 161
configs skipped: 3
The following configs have been built
On Wed, Feb 21, 2024 at 7:10 PM Hans Verkuil wrote:
>
> On 19/02/2024 13:56, Mauro Carvalho Chehab wrote:
> > Em Mon, 19 Feb 2024 12:05:02 +0800
> > Shengjiu Wang escreveu:
> >
> >> Hi Mauro
> >>
> >> On Sat, Feb 17, 2024 at 5:19 PM Mauro Carvalho Chehab
> >> wrote:
> >>>
> >>> Em Thu, 18 Jan
Hello Baoquan,
There are a lot of code movements introduced by your patch series,
'Split crash out from kexec and clean up related config items.'
https://lore.kernel.org/all/20240221125752.36fbfe9c307496313198b...@linux-foundation.org/
Do you want me to rebase this patch series on top of the
On Wed, 2024-02-21 at 10:53 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which
> makes
> many driver authors wrongly assume it's possible to do error handling
> by
> returning an error code. However the value returned is ignored (apart
> from
[+cc Mahesh, Oliver, linuxppc-dev, since I mentioned powerpc below.
Probably not of interest since this is about the ACPI EDR feature, but
just FYI]
On Wed, Feb 21, 2024 at 05:11:04PM -0600, Bjorn Helgaas wrote:
> On Tue, Jan 23, 2024 at 09:59:21AM -0600, Bjorn Helgaas wrote:
> > On Mon, Jan 22,
On Wed, 21 Feb 2024 15:46:22 +1100, Michael Ellerman wrote:
> Add CPU table entries for raw and architected mode. Most fields are
> copied from the Power10 table entries.
>
> CPU, MMU and user (ELF_HWCAP) features are unchanged vs P10. However
> userspace can detect P11 because the AT_PLATFORM
On Fri, 16 Feb 2024 22:58:17 +0900, Masahiro Yamada wrote:
> Commit 2fb857bc9f9e ("powerpc/kcsan: Add exclusions from instrumentation")
> added KCSAN_SANITIZE_early_64.o to arch/powerpc/kernel/Makefile, while
> it does not compile early_64.o.
>
>
Applied to powerpc/next.
[1/1] powerpc: remove
On Fri, 16 Feb 2024 11:00:16 +0530, Shrikanth Hegde wrote:
> When a ifdef is used in the below manner, second one could be considered as
> duplicate.
>
> ifdef DEFINE_A
> ...code block...
> ifdef DEFINE_A <-- This is a duplicate.
> ...code block...
> endif
> else
> ifndef DEFINE_A <--
Christophe Leroy writes:
> Le 21/02/2024 à 13:09, Michael Ellerman a écrit :
>> Christophe Leroy writes:
>>> set_memory_p() and set_memory_np() can fail.
>>>
>>> As mentioned in linux/mm.h:
>>>
>>> /*
>>> * To support DEBUG_PAGEALLOC architecture must ensure that
>>> * __kernel_map_pages()
> On Wednesday, February 21, 2024 at 1:32 AM, Christophe Leroy wrote:
>
> On powerpc (book3s/32) we have more or less the same although it is not
> directly linked to PMDs: the virtual 4G address space is split in
> segments of 256M. On each segment there's a bit called NX to forbit
> execution.
> On Wednesday, February 21, 2024 12:59 AM, Christophe Leroy wrote:
>
> In the code you add __weak for that. But you also add the flags to the
> parameters and I can't understand why when reading the above description.
This change was made to allow most kernel interfaces use vmalloc_node and
> On February 21, 2024 3:27 AM David Hildenbrand wrote
> On 21.02.24 08:13, Christophe Leroy wrote:
> > Le 20/02/2024 à 21:32, Maxwell Bland a écrit :
> >>
> >> While other descriptors (e.g. pud) allow allocations conditional on
> >> which virtual address is allocated, pmd descriptor allocations
> From: Conor Dooley
> FYI:
>
> > mm/vmalloc: allow arch-specific vmalloc_node overrides
> > mm: pgalloc: support address-conditional pmd allocation
>
> With these two arch/riscv/configs/* are broken with calls to undeclared
> functions.
Will fix, thanks! I will also figure out how to make
Hey Maxwell,
FYI:
> mm/vmalloc: allow arch-specific vmalloc_node overrides
> mm: pgalloc: support address-conditional pmd allocation
With these two arch/riscv/configs/* are broken with calls to undeclared
functions.
> arm64: separate code and data virtual memory allocation
> arm64:
snd_soc_card_get_kcontrol() must be holding a read lock on
card->controls_rwsem while walking the controls list.
Compare with snd_ctl_find_numid().
The existing function is renamed snd_soc_card_get_kcontrol_locked()
so that it can be called from contexts that are already holding
On Wed, 21 Feb 2024 11:15:00 +0530 Hari Bathini wrote:
> On 04/02/24 8:56 am, Baoquan He wrote:
> >>> Hope Hari and Pingfan can help have a look, see if
> >>> it's doable. Now, I make it either have both kexec and crash enabled, or
> >>> disable both of them altogether.
> >>
> >> Sure. I will
On Wed, 21 Feb 2024 22:59:47 +0530 Sourabh Jain
wrote:
> > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> > - def_bool CRASH_CORE
> > + def_bool CRASH_RESEERVE
>
> %s/CRASH_RESEERVE/CRASH_RESERVE?
Yes, thanks, this has been addressed in a followon fixup patch
in the mm.git tree.
Hello:
This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt :
On Wed, 14 Feb 2024 07:34:30 -0800 you wrote:
> From: Palmer Dabbelt
>
> The new SBI console has the same problem as the old one: there's only
> one shared backing hardware and no synchronization, so the two drivers
>
This driver is PPC so I have never looked at the code before. I noticed
another issue that was introduced last December in commit 3ce4f9c3fbb3
("net/ps3_gelic_net: Add gelic_descr structures").
net/ethernet/toshiba/ps3_gelic_net.c
375 static int gelic_descr_prepare_rx(struct gelic_card
* Update the Kernel Doc for gelic_descr_set_tx_cmdstat()
and gelic_net_setup_netdev() so that documented name
and the actual name of the function match.
* Move define of GELIC_ALIGN() so that it is no longer
between gelic_alloc_card_net() and it's Kernel Doc.
* Document netdev parameter of
Hello Baoquan,
On 19/01/24 20:22, Baoquan He wrote:
Now move the relevant codes into separate files:
kernel/crash_reserve.c, include/linux/crash_reserve.h.
And add config item CRASH_RESERVE to control its enabling.
Feels like this patch is more about vmcore_info.[c|h] and CONFIG_VMCORE_INFO
Hello Baoquan,
Thank you for reorganizing the kexec and kdump code with a well-defined
configuration structure.
While reviewing the patch series, I noticed a few typos.
On 19/01/24 20:22, Baoquan He wrote:
Both kdump and fa_dump of ppc rely on crashkernel reservation. Move the
relevant codes
Fix possible NULL pointer dereference in gelic_card_release_tx_chain()
The cited commit introduced a netdev variable to
gelic_card_release_tx_chain() which is set unconditionally on each
iteration of a for loop.
It is set to the value of tx_chain->tail->skb->dev. However, in some
cases it is
The per-architecture fbdev code has no dependencies on fbdev and can
be used for any video-related subsystem. Rename the files to 'video'.
Use video-sti.c on parisc as the source file depends on CONFIG_STI_CORE.
Further update all includes statements, includ guards, and Makefiles.
Also update a
Various Kconfig options selected the per-architecture helpers for
fbdev. But none of the contained code depends on fbdev. Standardize
on CONFIG_VIDEO, which will allow to add more general helpers for
video functionality.
CONFIG_VIDEO protects each architecture's video/ directory. This
allows for
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
Make architecture helpers for display functionality depend on general
video functionality instead of fbdev. This avoid the dependency on
fbdev and makes the functionality available for non-fbdev code.
Patch 1 replaces the variety of Kconfig options that control the
Makefiles with CONFIG_VIDEO.
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
Hello,
this series converts all platform drivers below drivers/powerpc to
struct platform_driver::remove_new(). See commit 5c5a7680e67b
("platform: Provide a remove callback that returns no value") for an
extended explanation and the eventual goal.
All conversations are trivial, because their
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
On Wed, Feb 21, 2024 at 02:44:31PM +0100, Herve Codina wrote:
> On Thu, 15 Feb 2024 21:17:23 +0200
> Andy Shevchenko wrote:
[...]
> > > Now what's the plan ?
> > > Andy, do you want to send a v2 of this patch or may I get the patch,
> > > modify it
> > > according to reviews already present in
On Wed, Feb 21, 2024, at 10:53, Uwe Kleine-König wrote:
> Hello,
>
> this series converts all drivers below drivers/misc to struct
> platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> Provide a remove callback that returns no value") for an extended
> explanation and the eventual
Hi Andy, Yury,
On Thu, 15 Feb 2024 21:17:23 +0200
Andy Shevchenko wrote:
[...]
> > Now what's the plan ?
> > Andy, do you want to send a v2 of this patch or may I get the patch, modify
> > it
> > according to reviews already present in v1 and integrate it in my current
> > series ?
>
> I
On 02/21/24 at 11:15am, Hari Bathini wrote:
> Hi Baoquan,
>
> On 04/02/24 8:56 am, Baoquan He wrote:
> > > > Hope Hari and Pingfan can help have a look, see if
> > > > it's doable. Now, I make it either have both kexec and crash enabled, or
> > > > disable both of them altogether.
> > >
> > >
On Wed, Feb 21, 2024 at 05:37:37PM +0800, Peter Xu wrote:
> On Mon, Jan 15, 2024 at 01:55:51PM -0400, Jason Gunthorpe wrote:
> > On Wed, Jan 03, 2024 at 05:14:13PM +0800, pet...@redhat.com wrote:
> > > From: Peter Xu
> > >
> > > ARM defines pmd_thp_or_huge(), detecting either a THP or a huge
Le 21/02/2024 à 13:09, Michael Ellerman a écrit :
> Christophe Leroy writes:
>> set_memory_p() and set_memory_np() can fail.
>>
>> As mentioned in linux/mm.h:
>>
>> /*
>> * To support DEBUG_PAGEALLOC architecture must ensure that
>> * __kernel_map_pages() never fails
>> */
>>
>> So panic
Christophe Leroy writes:
> set_memory_p() and set_memory_np() can fail.
>
> As mentioned in linux/mm.h:
>
> /*
> * To support DEBUG_PAGEALLOC architecture must ensure that
> * __kernel_map_pages() never fails
> */
>
> So panic in case set_memory_p() or set_memory_np() fail
> in
On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote:
> > Drop that check, not only because it'll never be true for hugepd per any
> > known plan, but also it paves way for reusing the function outside
> > fast-gup.
>
> I didn't see any other caller of this function in this series?
On Mon, Jan 15, 2024 at 02:49:00PM -0400, Jason Gunthorpe wrote:
> On Wed, Jan 03, 2024 at 05:14:20PM +0800, pet...@redhat.com wrote:
> > diff --git a/mm/gup.c b/mm/gup.c
> > index 63845b3ec44f..760406180222 100644
> > --- a/mm/gup.c
> > +++ b/mm/gup.c
> > @@ -525,6 +525,70 @@ static struct page
On 21/02/2024 11:11, Shengjiu Wang wrote:
> On Wed, Feb 21, 2024 at 12:30 PM Tomasz Figa wrote:
>>
>> On Sat, Feb 17, 2024 at 6:42 PM Mauro Carvalho Chehab
>> wrote:
>>>
>>> Em Thu, 18 Jan 2024 20:32:00 +0800
>>> Shengjiu Wang escreveu:
>>>
Audio signal processing has the requirement for
On 17/02/2024 10:42, Mauro Carvalho Chehab wrote:
> Em Thu, 18 Jan 2024 20:32:00 +0800
> Shengjiu Wang escreveu:
>
>> Audio signal processing has the requirement for memory to
>> memory similar as Video.
>>
>> This patch is to add this support in v4l2 framework, defined
>> new buffer type
On 19/02/2024 13:56, Mauro Carvalho Chehab wrote:
> Em Mon, 19 Feb 2024 12:05:02 +0800
> Shengjiu Wang escreveu:
>
>> Hi Mauro
>>
>> On Sat, Feb 17, 2024 at 5:19 PM Mauro Carvalho Chehab
>> wrote:
>>>
>>> Em Thu, 18 Jan 2024 20:32:01 +0800
>>> Shengjiu Wang escreveu:
>>>
The audio
On 21.02.24 08:13, Christophe Leroy wrote:
Le 20/02/2024 à 21:32, Maxwell Bland a écrit :
[Vous ne recevez pas souvent de courriers de mbl...@motorola.com. Découvrez
pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
While other descriptors (e.g. pud) allow
Le 21/02/2024 à 06:43, Christoph Hellwig a écrit :
> On Tue, Feb 20, 2024 at 02:32:53PM -0600, Maxwell Bland wrote:
>> Present non-uniform use of __vmalloc_node and __vmalloc_node_range makes
>> enforcing appropriate code and data seperation untenable on certain
>> microarchitectures, as
Le 20/02/2024 à 21:32, Maxwell Bland a écrit :
> [Vous ne recevez pas souvent de courriers de mbl...@motorola.com. Découvrez
> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Reworks ARM's virtual memory allocation infrastructure to support
> dynamic
Le 20/02/2024 à 21:32, Maxwell Bland a écrit :
> [Vous ne recevez pas souvent de courriers de mbl...@motorola.com. Découvrez
> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Current BPF and kprobe instruction allocation interfaces do not match
> the base
Le 20/02/2024 à 21:32, Maxwell Bland a écrit :
> [Vous ne recevez pas souvent de courriers de mbl...@motorola.com. Découvrez
> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> While other descriptors (e.g. pud) allow allocations conditional on
> which virtual
Le 20/02/2024 à 21:32, Maxwell Bland a écrit :
> [Vous ne recevez pas souvent de courriers de mbl...@motorola.com. Découvrez
> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> Present non-uniform use of __vmalloc_node and __vmalloc_node_range makes
> enforcing
On Wed, Feb 21, 2024 at 12:30 PM Tomasz Figa wrote:
>
> On Sat, Feb 17, 2024 at 6:42 PM Mauro Carvalho Chehab
> wrote:
> >
> > Em Thu, 18 Jan 2024 20:32:00 +0800
> > Shengjiu Wang escreveu:
> >
> > > Audio signal processing has the requirement for memory to
> > > memory similar as Video.
> > >
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve
Hello,
this series converts all drivers below drivers/misc to struct
platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
Provide a remove callback that returns no value") for an extended
explanation and the eventual goal.
All conversations are trivial, because their .remove()
On Mon, Jan 15, 2024 at 01:55:51PM -0400, Jason Gunthorpe wrote:
> On Wed, Jan 03, 2024 at 05:14:13PM +0800, pet...@redhat.com wrote:
> > From: Peter Xu
> >
> > ARM defines pmd_thp_or_huge(), detecting either a THP or a huge PMD. It
> > can be a helpful helper if we want to merge more THP and
68 matches
Mail list logo
