Re: OF NDFC

2007-09-06 Thread Segher Boessenkool
Is anybody working on the device-tree-aware ppc 44x NAND flash controller (ndfc) driver? Not to my knowledge. We sort of need a decent binding for NAND flash in general first. Not really. You can put the NAND controller in the device tree without describing the NAND flash itself -- and

Re: OF NDFC

2007-09-06 Thread Josh Boyer
On Thu, 6 Sep 2007 15:06:03 +0200 Segher Boessenkool [EMAIL PROTECTED] wrote: Is anybody working on the device-tree-aware ppc 44x NAND flash controller (ndfc) driver? Not to my knowledge. We sort of need a decent binding for NAND flash in general first. Not really. You can put

Re: atomic 64-bit math on 32-bit ppc's?

2007-09-06 Thread Segher Boessenkool
That's wrong if lock is assigned to r0, you should use a b constraint to avoid this. Same for atomic_dec below. GCC should really have removed r0 from the r class (it isn't truly a general-purpose register), and had a different class meaning r-plus-r0. Nah, GPR0 _is_ a general purpose

Re: Document and implement an improved flash device binding

2007-09-06 Thread Segher Boessenkool
+ - bank-width : Width (in bytes) of the flash bank. Equal to the + device width times the number of interleaved chips. + - device-width : (optional) Width of a single flash chip. If + omitted, assumed to be equal to 'bank-width'. Let's have bank-width optional

Re: OF NDFC

2007-09-06 Thread Valentine Barshak
Josh Boyer wrote: On Thu, 6 Sep 2007 15:06:03 +0200 Segher Boessenkool [EMAIL PROTECTED] wrote: Is anybody working on the device-tree-aware ppc 44x NAND flash controller (ndfc) driver? Not to my knowledge. We sort of need a decent binding for NAND flash in general first. Not really.

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
Hrm.. IIRC, it is permissible under Linux to only include device nodes for those PCI devices where something must be specified which can't be proved via PCI. It is. It isn't clear (to me, at least) which properties are required in a PCI node that exists for e.g. interrupt reasons only; or how

Re: OF NDFC

2007-09-06 Thread Josh Boyer
On Thu, 06 Sep 2007 17:30:08 +0400 Valentine Barshak [EMAIL PROTECTED] wrote: AFAIK, NAND flash is autodetected by reading it's ID at runtime, so there should be no need for flash bindings. Well, I'm not really sure. CFI and JEDEC can both be probed as well, and we're working on a binding

Re: atomic 64-bit math on 32-bit ppc's?

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 03:21:36PM +0200, Segher Boessenkool wrote: That's wrong if lock is assigned to r0, you should use a b constraint to avoid this. Same for atomic_dec below. GCC should really have removed r0 from the r class (it isn't truly a general-purpose register), and had a

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Segher Boessenkool
+/ { + model = Analogue Micro Adder MPC875; This should probably be just MPC875. Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: atomic 64-bit math on 32-bit ppc's?

2007-09-06 Thread Segher Boessenkool
Either way, it's a bit late to change this, no? Sure, I was just whining due to having been bitten by this sort of bug in the past. :-) Write a song about it, it's therapeutical it seems! Segher ___ Linuxppc-dev mailing list

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 04:08:43PM +0200, Segher Boessenkool wrote: +/ { +model = Analogue Micro Adder MPC875; This should probably be just MPC875. There's more than one board with an MPC875 on it. -Scott ___ Linuxppc-dev mailing list

Re: [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1in QE, register mmc_spi stub

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 04:13:56PM +0200, Segher Boessenkool wrote: AFAIK, there is no other standard data structure that could take place of the par_io nodes in the DTS. The device tree is not a dumping ground for all your I need some standard data structure stuff. Use an XML file if

Re: [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1in QE, register mmc_spi stub

2007-09-06 Thread Segher Boessenkool
_and system GPIOs_ :-) Yup, firmware should set up gpios, to make initial kernel boot. After that, kernel can and should manage GPIOs. Sure. But only the GPIOs it _does_ need to toggle, not the ones that have to be fixed to a certain value (like everything that is described in the par_io

Re: [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1in QE, register mmc_spi stub

2007-09-06 Thread Segher Boessenkool
The kernel is of course welcome to do so -- and this may be a valid reason to attach pin information to specific device nodes, if it actually saves a non-negligible amount of power -- but it's not a reason to force the kernel to have to care by not setting things up in the firmware.

Configuring for UPM on MPC82xx using new device binding from Scott

2007-09-06 Thread Esben Haabendal
Hi Is it possible to configure chipselect to use UPM A and UPM B in an MPC8270 chip using the new CPM device bindings patches from Scott? I need to pass in the 3 bits for MS (machine select to the relevant MRx register). Best regards, Esben Haabendal

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
The node should have a compatible property which is sufficient to select the right bridge driver. Yeah, I defined a compatible = mai,articias; property in the pci node. Are there any naming conventions (maybe lower case only)? It's conventional for the part behind the comma to be lower-case

[RFC/PATCH 1/2] Basic generic time/clocksource code for PowerPC

2007-09-06 Thread Paul Mackerras
This changes PowerPC to use the generic time infrastructure for gettimeofday et al. We register a clocksource which uses the timebase register, or the RTC on the 601. It also gets rid of the RTC update stuff. IIRC we discussed removing this some time ago but never actually did it. This is

Re: [PATCH] powerpc: Add workaround for MPICs with broken register reads

2007-09-06 Thread Milton Miller
On Wed Sep 5 12:44:17 EST 2007, Olof Johansson wrote: diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig index 041df77..b9f1efa 100644 --- a/arch/powerpc/platforms/Kconfig +++ b/arch/powerpc/platforms/Kconfig @@ -137,6 +137,10 @@ config MPIC_U3_HT_IRQS

Re: Keep On Debugging You

2007-09-06 Thread Timur Tabi
Zhang Wei-r63237 wrote: Oops! Could you give us a live show version? :D Sorry, I'm booked up for the rest of the year. -- Timur Tabi Linux Kernel Developer @ Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

[NEWBIE] Interrupt-problem mpc5200

2007-09-06 Thread S. Fricke
Hello all. What are the steps to configure an MPC500B-Board to react on an IRQ (2)? I have written a test-driver with this code-snippets, but the prozessor hangs when loading the driver. my __init-function looks like: static int __init mod_init( void ) { volatile static struct

Re: Configuring for UPM on MPC82xx using new device binding from Scott

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 04:23:49PM +0200, Esben Haabendal wrote: Is it possible to configure chipselect to use UPM A and UPM B in an MPC8270 chip using the new CPM device bindings patches from Scott? I need to pass in the 3 bits for MS (machine select to the relevant MRx register). The BRx

[PATCH 2.6.23] PS3: Ignore storage devices that are still being probed

2007-09-06 Thread Geert Uytterhoeven
PS3: A storage device may show up in the repository before the hypervisor has finished probing: - If its type is not yet known, it shows up as PS3_DEV_TYPE_STOR_DUMMY, - If its regions are being probed, it shows up as having zero regions. If any of these happen, consider the device not yet

Re: Keep On Debugging You

2007-09-06 Thread Linas Vepstas
On Thu, Sep 06, 2007 at 10:21:43AM -0500, Timur Tabi wrote: Zhang Wei-r63237 wrote: Oops! Could you give us a live show version? :D Sorry, I'm booked up for the rest of the year. Hmm. Maybe someone could sneak a videocam into one of the venues, and, you know, post a pirated, illegal

Re: Keep On Debugging You

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 11:51:33AM -0500, Linas Vepstas wrote: On Thu, Sep 06, 2007 at 10:21:43AM -0500, Timur Tabi wrote: Zhang Wei-r63237 wrote: Oops! Could you give us a live show version? :D Sorry, I'm booked up for the rest of the year. Hmm. Maybe someone could sneak a

Re: [RFC/PATCH 1/2] Basic generic time/clocksource code for PowerPC

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 06:55:35PM +0200, Gabriel Paubert wrote: On Fri, Sep 07, 2007 at 12:41:38AM +1000, Paul Mackerras wrote: This changes PowerPC to use the generic time infrastructure for gettimeofday et al. We register a clocksource which uses the timebase register, or the RTC on the

[PATCH 0/3] powerpc: whitespace cleanup, grammar corrections

2007-09-06 Thread Linas Vepstas
These popped out at me while I was reading code. Its all janitorial. --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 2/3] powerpc: prom whitespace cleanup

2007-09-06 Thread Linas Vepstas
Whitespace cleanup: badly indented lines. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/prom.c

[PATCH 1/3] powerpc: prom_init whitespace cleanup, typo fix.

2007-09-06 Thread Linas Vepstas
Whitespace cleanup: badly indented lines. Typo in comment. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom_init.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/prom_init.c

[PATCH 3/3] powerpc: setup_64 comment cleanup.

2007-09-06 Thread Linas Vepstas
Gramatical corrections to comments. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom.c |8 +--- arch/powerpc/kernel/setup_64.c |6 +++--- 2 files changed, 8 insertions(+), 6 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/setup_64.c

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 07:50:32PM +0200, Segher Boessenkool wrote: + model = Analogue Micro Adder MPC875; This should probably be just MPC875. There's more than one board with an MPC875 on it. model is the model name the vendor uses. It isn't supposed to be unique globally, nor does

Re: [RFC/PATCH 1/2] Basic generic time/clocksource code for PowerPC

2007-09-06 Thread Paul Mackerras
Gabriel Paubert writes: On Fri, Sep 07, 2007 at 12:41:38AM +1000, Paul Mackerras wrote: This changes PowerPC to use the generic time infrastructure for gettimeofday et al. We register a clocksource which uses the timebase register, or the RTC on the 601. It also gets rid of the RTC

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Segher Boessenkool
+ model = Analogue Micro Adder MPC875; This should probably be just MPC875. There's more than one board with an MPC875 on it. model is the model name the vendor uses. It isn't supposed to be unique globally, nor does it say what CPU is on the board. The name the vendor uses is Adder

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 08:48:12PM +0200, Segher Boessenkool wrote: +model = Analogue Micro Adder MPC875; This should probably be just MPC875. There's more than one board with an MPC875 on it. model is the model name the vendor uses. It isn't supposed to be unique globally,

Re: [RFC/PATCH 2/2] Generic clockevents and no-idle-HZ for PowerPC

2007-09-06 Thread Olof Johansson
Hi, Nice! I've been looking forward to these patches. Should help keep power consumption down on machines with powersavings support for idle. On Fri, Sep 07, 2007 at 12:44:46AM +1000, Paul Mackerras wrote: @@ -749,6 +805,8 @@ void __init clocksource_init(void) printk(KERN_INFO

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 02:12:55PM -0500, Scott Wood wrote: On Thu, Sep 06, 2007 at 08:48:12PM +0200, Segher Boessenkool wrote: So it should be Adder MPC875, then :-) Any particular reason to leave out potentially useful information in a field that is for human consumption? Other than

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Segher Boessenkool
+ model = Analogue Micro Adder MPC875; This should probably be just MPC875. There's more than one board with an MPC875 on it. model is the model name the vendor uses. It isn't supposed to be unique globally, nor does it say what CPU is on the board. The name the vendor uses is

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Segher Boessenkool
BTW, IEEE1275 seems to disagree: No it doesn't. A manufacturer-dependent string that generally specifies the model name and number (including revision level) for this device. The format of the text string is arbitrary, although in conventional usage the string begins with the

Re: [RFC/PATCH 2/2] Generic clockevents and no-idle-HZ for PowerPC

2007-09-06 Thread Olof Johansson
Hi again, On Thu, Sep 06, 2007 at 02:15:16PM -0500, Olof Johansson wrote: I don't think that set_dec() is needed any more. I get a very long delay during Calibrating delay loop... with it there. Looks like decrementer_set_next_event() already sets a reasonable decementer value, it's called

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Segher Boessenkool
BTW, IEEE1275 seems to disagree: No it doesn't. ...in conventional usage the string begins with the name of the device's manufacturer. You cut that sentence short here, it continues: as with the name property. Even if you want to quibble about the manner in which the manufacturer is

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Gerhard Pircher
Original-Nachricht Datum: Thu, 6 Sep 2007 15:36:30 +0200 Von: Segher Boessenkool [EMAIL PROTECTED] An: Gerhard Pircher [EMAIL PROTECTED] CC: linuxppc-dev@ozlabs.org, [EMAIL PROTECTED] Betreff: Re: [RFC] AmigaOne device tree source v2 PCI legacy I/O is not direct mapped:

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Scott Wood
On Thu, Sep 06, 2007 at 10:57:28PM +0200, Segher Boessenkool wrote: BTW, IEEE1275 seems to disagree: No it doesn't. ...in conventional usage the string begins with the name of the device's manufacturer. You cut that sentence short here, it continues: as with the name property. You

Re: [PATCH 04/10] bootwrapper: Add strtoull().

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:10PM -0500, Scott Wood wrote: This will be needed by PlanetCore firmware support. Signed-off-by: Scott Wood [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] -- David Gibson| I'll have my music baroque, and my code david AT

Re: [PATCH 09/10] bootwrapper: Only print MAC addresses when the node is actually present.

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:18PM -0500, Scott Wood wrote: Some firmwares (such as PlanetCore) only provide a base MAC address, and expect the kernel to set certain bits to generate the addresses for the other ports. As such, MAC addresses are generated that may not correspond to actual

Re: [PATCH 06/10] bootwrapper: Move strncmp() from flatdevtree_env.h to string.S/string.h.

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:14PM -0500, Scott Wood wrote: It will be needed for PlanetCore firmware support. Signed-off-by: Scott Wood [EMAIL PROTECTED] I still have a patch that already does this, plus strchr() as well, pending... -- David Gibson| I'll have my music

Re: [PATCH 05/10] bootwrapper: Add get_path().

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:12PM -0500, Scott Wood wrote: This will be used by the PlanetCore firmware support to construct a linux,stdout-path from the serial node that it finds. Signed-off-by: Scott Wood [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] Although I'm planning to

Re: [PATCH 3/3] powerpc: setup_64 comment cleanup.

2007-09-06 Thread Michael Ellerman
On Thu, 2007-09-06 at 12:47 -0500, Linas Vepstas wrote: Gramatical corrections to comments. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom.c |8 +--- arch/powerpc/kernel/setup_64.c |6 +++--- 2 files changed, 8 insertions(+), 6

Re: [PATCH 03/10] bootwrapper: flatdevtree fixes

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:04PM -0500, Scott Wood wrote: 1. ft_create_node was returning the internal pointer rather than a phandle. 2. ft_find_device_rel was treating a top phandle of NULL as an error, rather than as the root of the tree. The old, absolute ft_find_device is removed, and

Re: [patch 3/6] Walnut DTS

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 11:33:17AM -0500, Josh Boyer wrote: Updated DTS below Device tree source file for the PPC405 Walnut evaluation board. Signed-off-by: Josh Boyer [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] -- David Gibson| I'll have my music

Re: [patch 6/6] Walnut zImage wrapper

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 11:36:04AM -0500, Josh Boyer wrote: Updated patch below Add zImage wrapper for walnut board Signed-off-by: Josh Boyer [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] -- David Gibson| I'll have my music baroque, and my code david AT

Re: [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1in QE, register mmc_spi stub

2007-09-06 Thread Timur Tabi
David Gibson wrote: Firmwares are, more often than not, crap, and that's unlikely to change. For a lot of things, having the kernel or bootwrapper cope as a special case with a handful of crap firmwares which don't set things up properly isn't actually any easier than having it set them up

Re: [PATCH 10/10] bootwrapper: Add fsl_get_immr() and 8xx/pq2 clock functions.

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:19PM -0500, Scott Wood wrote: fsl_get_immr() is equivalent to the kernel's get_immrbase() function. mpc885_get_clock() transforms a crystal frequency into a system frequency according to the PLL register settings. pq2_get_clocks() does the same as the above

Re: Document and implement an improved flash device binding

2007-09-06 Thread David Gibson
On Thu, Sep 06, 2007 at 03:28:35PM +0200, Segher Boessenkool wrote: + - bank-width : Width (in bytes) of the flash bank. Equal to the + device width times the number of interleaved chips. + - device-width : (optional) Width of a single flash chip. If + omitted,

Re: [PATCH 8/9] 8xx: Adder 875 support

2007-09-06 Thread Olof Johansson
On Thu, Sep 06, 2007 at 04:30:23PM -0500, Scott Wood wrote: On Thu, Sep 06, 2007 at 10:57:28PM +0200, Segher Boessenkool wrote: BTW, IEEE1275 seems to disagree: No it doesn't. ...in conventional usage the string begins with the name of the device's manufacturer. You cut that

Re: [PATCH 08/10] bootwrapper: Add a firmware-independent raw target.

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:16PM -0500, Scott Wood wrote: This target produces a flat binary rather than an ELF file, fixes the entry point at the beginning of the image, and takes a complete device tree with no fixups needed. The device tree must have labels on /#address-cells, the

Re: [PATCH 07/10] bootwrapper: Add PlanetCore firmware support.

2007-09-06 Thread David Gibson
On Wed, Sep 05, 2007 at 02:21:15PM -0500, Scott Wood wrote: This is a library that board code can use to extract information from the PlanetCore configuration keys. PlanetCore is used on various boards from Embedded Planet. Signed-off-by: Scott Wood [EMAIL PROTECTED] [snip] +void

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread David Gibson
On Thu, Sep 06, 2007 at 03:56:38PM +0200, Segher Boessenkool wrote: That looks totally bogus. Unlike Segher, I think there are a few cases where overlapping reg and ranges can make sense That's not unlike me -- I may have lower tolerance for it though :-) I see. Can't imagine how I got