At present, dtc makes a lot of semantic checks on the device tree by
default, and will refuse to produce output if they fail. This means
people tend to need -f to force output despite failing semantic checks
rather a lot.
This patch splits the device tree checks into structural checks (no
bad or
On Wed, 17 Oct 2007, Kumar Gala wrote:
On Oct 17, 2007, at 1:39 PM, David Woodhouse wrote:
On Mon, 2007-10-15 at 18:07 -0500, Kumar Gala wrote:
I was wondering if you cared about the following boards existing in
arch/powerpc:
* STX GP3
* TQM 85xx
* SBC 8560
I'm told WR doesn't
No response yet, figured I should try here instead.
Jocke
Forwarded Message
From: Joakim Tjernlund [EMAIL PROTECTED]
Reply-To: [EMAIL PROTECTED]
To: Netdev [EMAIL PROTECTED], Li Yang-r58472
[EMAIL PROTECTED]
Subject: [PATCH] Fix ethernet multicast for ucc_geth.
Date: Wed, 17
The check then is to see if a non {}'d block has no statements in it if the
ifdef is null. Hmmm. May be possible. Will think on it.
if (err)
+#ifdef CONFIG_GFAR_NAPI
napi_disable(priv-napi);
+#endif
-apw
___
Linuxppc-dev
Grant Likely wrote:
On 9/30/07, David Gibson [EMAIL PROTECTED] wrote:
On Fri, Sep 28, 2007 at 06:53:28PM +0200, Segher Boessenkool wrote:
I'm working on merging dtc into the kernel tree instead.
I'm kind of late to this party; but I have to say I disagree. Most of
us are doing just fine
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
b/arch/powerpc/boot/dts/mpc8377_mds.dts
new file mode 100644
index 000..8530de6
--- /dev/null
+++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
@@ -0,0 +1,282 @@
+/*
+ * MPC8377E MDS Device Tree Source
+
On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote:
Hello,
The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards.
The applications to be run on the kernel with 256KB PAGE_SIZE have to be
built using the modified version of binutils, where the MAXPAGESIZE
It has turned out that my mailer had corrupted my previous message (thanks
Wolfgang Denk for pointing this). So if you'd like to apply the patch without
the
conflicts please use the version of the patch in this mail.
The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards.
On Thu, 2007-10-18 at 05:44 -0500, Josh Boyer wrote:
On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote:
Hello,
The following patch adds support for 256KB PAGE_SIZE on ppc44x-based
boards.
The applications to be run on the kernel with 256KB PAGE_SIZE have to be
built using
On Thu, 2007-10-18 at 15:00 +0400, Yuri Tikhonov wrote:
It has turned out that my mailer had corrupted my previous message (thanks
Wolfgang Denk for pointing this). So if you'd like to apply the patch without
the
conflicts please use the version of the patch in this mail.
The following
On Thu, 18 Oct 2007 21:45:14 +1000
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
On Thu, 2007-10-18 at 05:44 -0500, Josh Boyer wrote:
On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote:
Hello,
The following patch adds support for 256KB PAGE_SIZE on ppc44x-based
boards.
On Thu, 2007-10-18 at 07:01 -0500, Josh Boyer wrote:
On Thu, 18 Oct 2007 21:45:14 +1000
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
On Thu, 2007-10-18 at 05:44 -0500, Josh Boyer wrote:
On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote:
Hello,
The following
Kamalesh Babulal writes:
The kernel build fails on the power box
INSTALL vdso64.so
INSTALL vdso32.so
BOOTCC arch/powerpc/boot/inflate.o
arch/powerpc/boot/inflate.c:920:19: error: errno.h: No such file or directory
This problem is fixed by
Hello,
I see one more issue.
Marian Balakowicz wrote:
Add device tree source file for Motion-PRO board.
Signed-off-by: Marian Balakowicz [EMAIL PROTECTED]
---
[deletions]
+ [EMAIL PROTECTED] {
+ compatible = mpc5200b-gpio\0mpc5200-gpio;
+
Currently there's no way to enable early boot console on PowerPC 44x
not specifying uart's physical address in kernel config, which is used
for very early debug messages. This patch splits very early debug output
(which needs uart physical address in kernel config) and early boot console
(which
On 10/18/07, Wolfgang Grandegger [EMAIL PROTECTED] wrote:
Hello,
I see one more issue.
Marian Balakowicz wrote:
Add device tree source file for Motion-PRO board.
Signed-off-by: Marian Balakowicz [EMAIL PROTECTED]
---
[deletions]
+ [EMAIL PROTECTED] {
+
On Thursday 18 October 2007 14:44, you wrote:
Sorry, this is against arch/ppc which is bug fix only. New features
should be done against arch/powerpc.
Understood. The situation here is that the boards, which required these
modifications, have no support in the arch/powerpc branch. So this
is it me or are you just posting the patches you're updating? (this
is the only v5 patch I saw in the series)
On Oct 18, 2007, at 5:16 AM, Li Yang wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts b/arch/powerpc/
Paul Mackerras wrote:
Kamalesh Babulal writes:
The kernel build fails on the power box
INSTALL vdso64.so
INSTALL vdso32.so
BOOTCC arch/powerpc/boot/inflate.o
arch/powerpc/boot/inflate.c:920:19: error: errno.h: No such file or directory
This problem is fixed by
On Thursday 18 October 2007 15:47, Benjamin Herrenschmidt wrote:
Signed-off-by: Pavel Kolesnikov [EMAIL PROTECTED]
Acked-by: Yuri Tikhonov [EMAIL PROTECTED]
Small nit...
You are posting the patch, thus you should be signing off, not ack'ing.
Ack'ing means you agree with the patch
On Thursday 18 October 2007 16:12, Benjamin Herrenschmidt wrote:
I always reserve the right to change my mind. If something makes sense
and the code is decent enough then it might very well be acceptable.
Requiring a modified binutils makes me a bit nervous though.
From a kernel point
On Thursday 18 October 2007 17:25, Josh Boyer wrote:
Understood. The situation here is that the boards, which required these
modifications, have no support in the arch/powerpc branch. So this is
why we made this in arch/ppc.
Bit of a dilemma then. What board exactly?
These are the
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 18, 2007 9:17 PM
To: Li Yang-r58472
Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v5 9/9] add MPC837x MDS board default device tree
is it me or are you just posting the
On Thu, 18 Oct 2007 17:18:00 +0400
Yuri Tikhonov [EMAIL PROTECTED] wrote:
On Thursday 18 October 2007 14:44, you wrote:
Sorry, this is against arch/ppc which is bug fix only. New features
should be done against arch/powerpc.
Understood. The situation here is that the boards, which
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 17, 2007 9:59 PM
To: David Gibson
Cc: Li Yang-r58472; [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 9/9] add MPC837x MDS board default device tree
On Oct 14, 2007, at
On Oct 18, 2007, at 8:33 AM, Li Yang-r58472 wrote:
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 18, 2007 9:17 PM
To: Li Yang-r58472
Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v5 9/9] add MPC837x MDS board default
On 10/15/07, Jeff Garzik [EMAIL PROTECTED] wrote:
Domen Puncer wrote:
Hello!
If there are no objections, I would like to get this merged
when bestcomm goes in (any time now?).
It's split into four parts:
1 - device tree
2 - small bestcomm change
3 - the actual driver
4 - phy
Hello, I wrote:
With these functions implemented we cooperate better with the generic
timekeeping code. This obsoletes the need for the timer sysdev as a bonus.
Aha, I'm seeing it's not merged to mainline yet!
Contrarywise, it's been merged first -- looks like this all happened
-Original Message-
From: Joakim Tjernlund [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 17, 2007 5:06 PM
To: Netdev; Li Yang-r58472
Subject: [PATCH] Fix ethernet multicast for ucc_geth.
From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17
00:00:00 2001
From: Joakim
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
Note that some kind of read barrier or compiler barrier should be needed
regardless, or we are just not sync'ing with anything at all (we may
have loaded the value ages ago and thus operate on a totally stale
value). I prefer a full barrier to
On Thu, 18 Oct 2007 17:30:17 +0400
Yuri Tikhonov [EMAIL PROTECTED] wrote:
On Thursday 18 October 2007 17:25, Josh Boyer wrote:
Understood. The situation here is that the boards, which required these
modifications, have no support in the arch/powerpc branch. So this is
why we made this
Paul Mackerras wrote:
BTW, while fixing that for classic PPC, but you've broke it for 40x /
book
E CPU which interrupt at 0. Congratulations. :-)
What problem do you see arising from this?
Timers firing too early.
Paul.
WBR, Sergei
___
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/kernel/cputable.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
index d3fb7d0..03b973f 100644
--- a/arch/powerpc/kernel/cputable.c
+++
These interrupts are introduced by the latest Freescale SoC such as
MPC837x. The patch also adds comment to interrupts.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/sysdev/ipic.c | 224 ++--
arch/powerpc/sysdev/ipic.h |7 +-
We were developing with Linux 2.6.10 and a Planetcore boot loader,
however, recent work has us up and running with 2.6.23+ and U-boot
1.2.0. However, we are now running into a few challenges regarding
the differences.
Our driver writer's code isn't functioning, but it was with 2.6.10 and
planet
On 10/15/07, Kumar Gala [EMAIL PROTECTED] wrote:
Guys,
I was wondering if you cared about the following boards existing in
arch/powerpc:
* STX GP3
* TQM 85xx
* SBC 8560
I'm told WR doesn't care about the SBC 8560, so I'll see if David does.
Sorry for the late reply, this just popped up
The MPC837x MDS is a new member of Freescale MDS reference system.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/platforms/83xx/Kconfig | 12
arch/powerpc/platforms/83xx/Makefile |1 +
arch/powerpc/platforms/83xx/mpc837x_mds.c | 103
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
Documentation/powerpc/booting-without-of.txt | 32 ++
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/Documentation/powerpc/booting-without-of.txt
b/Documentation/powerpc/booting-without-of.txt
index
IPIC controller doesn't support ack operations. The pending registers
are read-only. The patch removes ack operations which are not needed.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/sysdev/ipic.c | 40 ++--
1 files changed, 2 insertions(+),
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 282 +++
arch/powerpc/boot/dts/mpc8378_mds.dts | 264 +
arch/powerpc/boot/dts/mpc8379_mds.dts | 300 +
3 files changed,
On Oct 18, 2007, at 10:04 AM, Li Yang wrote:
These interrupts are introduced by the latest Freescale SoC such as
MPC837x. The patch also adds comment to interrupts.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/sysdev/ipic.c | 224 +
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
Take a real life example:
drivers/message/fusion/mptbase.c
/* Disable interrupts! */
CHIPREG_WRITE32(ioc-chip-IntMask, 0x);
ioc-active = 0;
synchronize_irq(pdev-irq);
And we aren't in a spinlock
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
Fix a typo in previous one.
arch/powerpc/boot/dts/mpc8377_mds.dts | 282 +++
arch/powerpc/boot/dts/mpc8378_mds.dts | 264 +
arch/powerpc/boot/dts/mpc8379_mds.dts | 300
On Oct 18, 2007, at 10:04 AM, Li Yang wrote:
The SerDes(serializer/deserializer) PHY block is a new SoC block used
in Freescale chips to support multiple serial interfaces, such as PCI
Express, SGMII, SATA.
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/platforms/Kconfig |
On Oct 18, 2007, at 10:09 AM, Li Yang wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
Fix a typo in previous one.
arch/powerpc/boot/dts/mpc8377_mds.dts | 282 ++
+
arch/powerpc/boot/dts/mpc8378_mds.dts | 264 ++
+++
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 18, 2007 11:02 PM
To: Li Yang-r58472
Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v6 resend 9/9] add MPC837x MDS board
default device tree
On Oct 18, 2007, at 10:09 AM,
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_microcode() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers.
Signed-off-by: Timur
On Oct 18, 2007, at 10:04 AM, Li Yang wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 282 ++
+
arch/powerpc/boot/dts/mpc8378_mds.dts | 264 ++
+++
arch/powerpc/boot/dts/mpc8379_mds.dts |
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
arch/powerpc/configs/mpc837x_mds_defconfig | 878
1 files changed, 878 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/configs/mpc837x_mds_defconfig
diff --git a/arch/powerpc/configs/mpc837x_mds_defconfig
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
Documentation/powerpc/booting-without-of.txt | 29 ++
1 files changed, 29 insertions(+), 0 deletions(-)
diff --git a/Documentation/powerpc/booting-without-of.txt
b/Documentation/powerpc/booting-without-of.txt
index
Hello.
Paul Mackerras wrote:
Tony started from an earlier patch by John Stultz, not from your
patches.
Well, that I can believe, yet the clockevents patch has traces of my
former work, and looking at read_persisitent_time() it looks suspiciously
close to my version too...
There is
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 18, 2007 10:57 PM
To: Li Yang-r58472
Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v6 2/9] ipic: add new interrupts
introduced by new chip
On Oct 18, 2007, at 10:04 AM,
Timur Tabi wrote:
Define the layout of a binary blob that contains a QE firmware and
instructions
on how to upload it. Add function qe_upload_microcode() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers.
On Oct 18, 2007, at 4:59 AM, Matt Sealey wrote:
Grant Likely wrote:
On 9/30/07, David Gibson [EMAIL PROTECTED] wrote:
On Fri, Sep 28, 2007 at 06:53:28PM +0200, Segher Boessenkool wrote:
I'm working on merging dtc into the kernel tree instead.
I'm kind of late to this party; but I have to say
From: Grant Likely [EMAIL PROTECTED]
Signed-off-by: Grant Likely [EMAIL PROTECTED]
---
Documentation/powerpc/booting-without-of.txt | 264 ++
1 files changed, 264 insertions(+), 0 deletions(-)
diff --git a/Documentation/powerpc/booting-without-of.txt
On 10/18/07, Milton Miller [EMAIL PROTECTED] wrote:
On Oct 18, 2007, at 4:59 AM, Matt Sealey wrote:
Which begs the question; why cloning?
Why can't development be MOVED to in-kernel?
Because we don't put userspace testsuites there for one.
And its a stand alone tool and should have its
On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote:
This very large patch incorporates a copy of dtc into the kernel
source, in arch/powerpc/boot/dtc-src. This means that dtc is no
longer an external dependency to build kernels with configurations
which need a dtb file.
Signed-off-by:
-Original Message-
From: Grant Likely [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 18, 2007 10:23 AM
To: linuxppc-dev@ozlabs.org; Stephen Neuendorffer; Wolfgang
Reissnegger; Leonid; [EMAIL PROTECTED]; Josh
Boyer; Arnd Bergmann
Subject: [PATCH v3] Device tree bindings for
This patch creates localbus node, moves bcsr into it, and adds
localbus to the probe path.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8568mds.dts | 14 +++---
arch/powerpc/platforms/85xx/mpc85xx_mds.c |1 +
2 files changed, 12 insertions(+),
MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8568mds.dts | 34 +-
1 files changed, 33 insertions(+), 1 deletions(-)
diff --git
On 10/18/07, Stephen Neuendorffer [EMAIL PROTECTED] wrote:
-Original Message-
From: Grant Likely [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 18, 2007 10:23 AM
To: linuxppc-dev@ozlabs.org; Stephen Neuendorffer; Wolfgang
Reissnegger; Leonid; [EMAIL PROTECTED]; Josh
Boyer;
Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart().
This patch relies on Sascha Hauer's patch published in:
http://patchwork.ozlabs.org/linuxppc/patch?id=8910.
Signed-off-by: Marian Balakowicz [EMAIL PROTECTED]
Signed-off-by: Sascha Hauer [EMAIL PROTECTED]
---
Add 'fsl,' prefix to 'compatible' property for gpt nodes.
Add 'fsl,' prefix to empty, GPT0 specific 'has-wdt' property.
Signed-off-by: Marian Balakowicz [EMAIL PROTECTED]
---
.../powerpc/mpc52xx-device-tree-bindings.txt |4 ++-
arch/powerpc/boot/dts/lite5200.dts | 26
Here's the second version of MPC5200 patches, please review. Thanks!
[POWERPC] Enable restart support for lite5200 board
[POWERPC] Add restart support for mpc52xx based platforms
[POWERPC] Update device tree binding for mpc5200 gpt
[POWERPC] Add mpc52xx_find_and_map_path(), refactor utility
Add helper routine mpc52xx_find_and_map_path(). Extract common code to
mpc52xx_map_node() and refactor mpc52xx_find_and_map().
Signed-off-by: Jan Wrobel [EMAIL PROTECTED]
Reviewed-by: Grant Likely [EMAIL PROTECTED]
---
arch/powerpc/platforms/52xx/mpc52xx_common.c | 21 +
On Thu, Oct 18, 2007 at 10:08:25AM -0500, Timur Tabi wrote:
Define the layout of a binary blob that contains a QE firmware and
instructions
on how to upload it. Add function qe_upload_microcode() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
Signed-off-by: Marian Balakowicz [EMAIL PROTECTED]
---
arch/powerpc/platforms/52xx/lite5200.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/platforms/52xx/lite5200.c
b/arch/powerpc/platforms/52xx/lite5200.c
index 65b7ae4..25d2bfa 100644
---
Anton Vorontsov wrote:
+if (firmware-length == (length + sizeof(u32))) {
+/* Length is valid, and there's a CRC */
+crc = be32_to_cpu(*((__be32 *) ((void *) firmware + length)));
Spaces are not needed after (__be32 *) and (void *). The whole
construction isn't
Grant Likely wrote:
On 10/18/07, Marian Balakowicz [EMAIL PROTECTED] wrote:
Add common helper routines: mpc52xx_map_wdt() and mpc52xx_restart().
This patch relies on Sascha Hauer's patch published in:
http://patchwork.ozlabs.org/linuxppc/patch?id=8910.
By 'relies', do you mean depends on
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Grant Likely
Sent: Thursday, October 18, 2007 11:13 AM
To: Stephen Neuendorffer
Cc: linuxppc-dev@ozlabs.org; Wolfgang Reissnegger; Leonid;
[EMAIL PROTECTED]; Josh Boyer; Arnd Bergmann
Subject:
On Thu, Oct 18, 2007 at 11:27:23AM +1000, Michael Ellerman wrote:
It does what pci_device_to_OF_node() does, but in the right way.
The plan is to remove pci_device_to_OF_node() once all the callers have
been converted to properly handle the refcounting.
Oh. Yes. well, of course, then.
On Oct 18, 2007, at 1:01 PM, Anton Vorontsov wrote:
MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8568mds.dts | 34 +++
++-
1 files changed, 33
On Oct 18, 2007, at 1:00 PM, Anton Vorontsov wrote:
This patch creates localbus node, moves bcsr into it, and adds
localbus to the probe path.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
why two patches for lbus and flash to lbus?
- k
___
On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote:
On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote:
This very large patch incorporates a copy of dtc into the kernel
source, in arch/powerpc/boot/dtc-src. This means that dtc is no
longer an external dependency to build kernels
On 10/16/07, David Gibson [EMAIL PROTECTED] wrote:
On Tue, Oct 16, 2007 at 03:31:07PM -0600, Grant Likely wrote:
From: Grant Likely [EMAIL PROTECTED]
Add the 'set -e' command to the wrapper script so that if any command
fails then the script will automatically exit
Ah.. this will
From: Randy Dunlap [EMAIL PROTECTED]
Missing MODULE_LICENSE(), loading this module taints the kernel.
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---
drivers/net/phy/mdio-bitbang.c |2 ++
1 file changed, 2 insertions(+)
--- linux-2.6.23-git7.orig/drivers/net/phy/mdio-bitbang.c
+++
On Thu, 2007-10-18 at 22:35 +0800, Herbert Xu wrote:
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
Note that some kind of read barrier or compiler barrier should be needed
regardless, or we are just not sync'ing with anything at all (we may
have loaded the value ages ago and thus
On Thu, 2007-10-18 at 22:56 +0800, Herbert Xu wrote:
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
Take a real life example:
drivers/message/fusion/mptbase.c
/* Disable interrupts! */
CHIPREG_WRITE32(ioc-chip-IntMask, 0x);
ioc-active = 0;
Need help adding new driver to supports a custom FPGA. Is there a
good driver that anyone would recommend I can look at that is fully
functional, works with 2.6.23 (powerpc style) and is described within
a device tree?
Bonus points:
uses freescale interrupts (timers/irq's from mpc 82xx/etc...)
On 10/18/07, Alan Bennett [EMAIL PROTECTED] wrote:
Need help adding new driver to supports a custom FPGA. Is there a
good driver that anyone would recommend I can look at that is fully
functional, works with 2.6.23 (powerpc style) and is described within
a device tree?
Bonus points:
uses
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 19 Oct 2007 13:36:24 +0800
[NET]: Fix possible dev_deactivate race condition
The function dev_deactivate is supposed to only return when
all outstanding transmissions have completed. Unfortunately
it is possible for store operations in the
On Fri, Oct 19, 2007 at 12:20:25PM +0800, Herbert Xu wrote:
In fact this bug exists elsewhere too. For example, the network
stack does this in net/sched/sch_generic.c:
/* Wait for outstanding qdisc_run calls. */
while (test_bit(__LINK_STATE_QDISC_RUNNING, dev-state))
On Fri, 2007-10-19 at 12:48 +0800, Herbert Xu wrote:
[IRQ]: Fix synchronize_irq races with IRQ handler
As it is some callers of synchronize_irq rely on memory barriers
to provide synchronisation against the IRQ handlers. For example,
the tg3 driver does
tp-irq_sync = 1;
What may happen is that action can either float upwards to give
spin_lock
action
set IRQ_INPROGRESS
spin_unlock
spin_lock
clear IRQ_INPROGRESS
spin_unlock
or it can float downwards to give
spin_lock
set IRQ_INPROGRESS
On Fri, 2007-10-19 at 12:20 +0800, Herbert Xu wrote:
That's why I think this patch is in fact the only one that
solves all the races in this thread. The case that it solves
which the lock/unlock patch does not is the one where action
flows downwards past the clearing of IRQ_INPROGRESS. I
The whole lock/set IRQ_INPROGRESS/unlock path can then only happen
before the locked section above, in which case we see and wait nicely
and all is good, or after, in which case the store to foo will be
visible to the IRQ handler as it will be ordered with the unlock in the
code above.
Note
On Thu, Oct 18, 2007 at 08:26:45PM -0700, Linus Torvalds wrote:
On Thu, 18 Oct 2007, Linus Torvalds wrote:
I *think* it should work with something like
for (;;) {
smp_rmb();
if (!spin_is_locked(desc-lock)) {
smp_rmb();
repeat:
/* Optimistic, no-locking loop */
while (desc-status IRQ_INPROGRESS)
cpu_relax();
/* Ok, that indicated we're done: double-check carefully */
spin_lock_irqsave(desc-lock, flags);
-Original Message-
From: Stephen Rothwell [mailto:[EMAIL PROTECTED]
Sent: Friday, October 19, 2007 8:43 AM
To: Li Yang-r58472
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v6 4/9] add platform support for MPC837x MDS board
+static int
all,
hi, when I boot my system, there are no output on the screen.
I choice the framebuffer and my monitor card is ATI PAGE 128 PCI, qt/e GUI.
When i compile the kernel, the boot logo and aty 128fb has be compiled into
kernel patched with videoboot, and x86emu. The video parameters set:
Nick Piggin [EMAIL PROTECTED] wrote:
First of all let's agree on some basic assumptions:
* A pair of spin lock/unlock subsumes the effect of a full mb.
Not unless you mean a pair of spin lock/unlock as in
2 spin lock/unlock pairs (4 operations).
*X = 10;
spin_lock(lock);
/* *Y
On Thu, 18 Oct 2007, Linus Torvalds wrote:
I *think* it should work with something like
for (;;) {
smp_rmb();
if (!spin_is_locked(desc-lock)) {
smp_rmb();
if (!(desc-status IRQ_INPROGRESS)
On Oct 18, 2007, at 6:19 PM, Paul Mackerras wrote:
Kumar Gala writes:
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
Your commit message doesn't give any reason why you are doing this, or
any explanation of what goes wrong without it. In fact, the commit
message is completely empty. :)
On Fri, 19 Oct 2007, Herbert Xu wrote:
In other words I think this patch is great :)
Hey, I appreciate it, but I do think that the spinlock only to
immediately unlock it again is pretty horrid.
I'm convinced that there should be some way to do this without actually
taking the lock. I
On Thu, Oct 18, 2007 at 04:39:59PM -0700, Linus Torvalds wrote:
Basic notion: the only thing that serializes the IRQ_INPROGRESS flag is
the descriptor lock. And we don't have to (or even want to!) hold it while
waiting for the thing, but we want to *have*held*it* in between whatever
we're
[POWERPC] Switch to generic WARN_ON()/BUG_ON()
Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about
4K text on a ppc64_defconfig. The main reason seems to be that prepping
the arguments to the conditional trap instructions is more work than
just doing a compare and branch.
Sergei Shtylyov writes:
And now you have incomplete read_persistent_clock() implementation for
I don't see anything incomplete about it. If you do, feel free to
post a patch.
example, god knows why it was preferred to mine -- well, it also implemented
Your most recent post of your
On Thu, Oct 18, 2007 at 09:59:26PM +0200, Sam Ravnborg wrote:
On Thu, Oct 18, 2007 at 12:49:54PM -0500, Milton Miller wrote:
On Tue Oct 16 15:02:17 EST 2007, David Gibson wrote:
This very large patch incorporates a copy of dtc into the kernel
source, in arch/powerpc/boot/dtc-src. This
On Thu, Oct 18, 2007 at 06:16:20PM +0800, Li Yang wrote:
Signed-off-by: Li Yang [EMAIL PROTECTED]
---
diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
b/arch/powerpc/boot/dts/mpc8377_mds.dts
new file mode 100644
index 000..8530de6
--- /dev/null
+++
Sergei Shtylyov writes:
What problem do you see arising from this?
Timers firing too early.
Only if the minimum interrupt latency is less than 1 decrementer
tick. That seems pretty unlikely to me unless you have a very slow
timebase frequency.
In fact what we should program the
1 - 100 of 120 matches
Mail list logo