Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Benjamin Herrenschmidt
Hi Matt ! The IBM PowerStation is a machine similar in design to our JS21 blades, which uses an HT2000 bridge with it's dual 5780 TG3's. I started investigating recently a problem where with recent kernels, the machine will appear to freeze every second or two for a second or two. The freeze

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Segher Boessenkool
I don't know yet for sure what happens, but a quick look at the commit seems to show that the driver synchronously spin-waits for up to 2.5ms That's what the comment says, but the code says 2.5 _seconds_: + /* Wait for up to 2.5 milliseconds */ + for (i = 0; i 25; i++) { +

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Benjamin Herrenschmidt
On Fri, 2008-08-08 at 10:58 +0200, Segher Boessenkool wrote: I don't know yet for sure what happens, but a quick look at the commit seems to show that the driver synchronously spin-waits for up to 2.5ms That's what the comment says, but the code says 2.5 _seconds_: + /* Wait for up

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Arnd Bergmann
On Friday 08 August 2008, Segher Boessenkool wrote: I don't know yet for sure what happens, but a quick look at the commit seems to show that the driver synchronously spin-waits for up to 2.5ms That's what the comment says, but the code says 2.5 _seconds_: +       /* Wait for up to 2.5

[PATCH] Re: Level IRQ handling on Xilinx INTC with ARCH=powerpc

2008-08-08 Thread Sergey Temerkhanov
I've prepared the patch to fix the problem being discussed. It adds a field flags to struct irq_chip. If IRQ_CHIP_UNMASK_ACK is set in this field, acknowledge is performed before unmasking. The patch is against 2.6.26 diff -r 6b0915754563 arch/powerpc/sysdev/xilinx_intc.c ---

[PATCH] watchdog: delete unused driver mpc8xx_wdt.c

2008-08-08 Thread Jochen Friedrich
The watchdog driver mpc8xx_wdt.c was a device interface to arch/ppc/syslib/m8xx_wdt.c for MPC8xx hardware. Now that ARCH=ppc is gone, this driver is of no more use. For ARCH=powerpc, MPC8xx hardware is supported by mpc8xxx_wdt.c. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: Vitaly

Re: [PATCH 2/2] Cell OProfile: SPU mutex lock fix, version 4

2008-08-08 Thread Arnd Bergmann
On Friday 01 August 2008, Carl Love wrote: If an error occurs on opcontrol start, the event and per cpu buffers are released.  If later opcontrol shutdown is called then the free function will be called again to free buffers that no longer exist.  This results in a kernel oops.  The

[2.6 patch] cleanup powerpc/include/asm/ide.h

2008-08-08 Thread Adrian Bunk
This patch removes code that became unused through IDE changes and the arch/ppc/ removal. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/powerpc/include/asm/ide.h | 43 - 1 file changed, 1 insertion(+), 42 deletions(-)

Re: [PATCH 1/2] Cell OProfile: SPU mutex lock fix, version 4

2008-08-08 Thread Arnd Bergmann
On Friday 01 August 2008, Carl Love wrote: The issue is the SPU code is not holding the kernel mutex lock while adding samples to the kernel buffer. Thanks for your patch, and sorry for not replying earlier. It looks good from a functionality perspective, I just have some style comments left

[PATCH 0/3] Patches to support QE USB Host Controller

2008-08-08 Thread Anton Vorontsov
Hi all, Most patches that were needed to support QE USB Host were merged during 2.6.27 merge window, and only three more patches left over. Here they are. David, could you bear with gpio_to_chip() exported function, just as a stopgap for a proper api? Thanks, -- Anton Vorontsov email: [EMAIL

[PATCH 1/3] gpiolib: make gpio_to_chip() public

2008-08-08 Thread Anton Vorontsov
We'll need this function to write platform-specific hooks to deal with pin's dedicated functions. Quite obviously this will work only for the platforms with 1-to-1 GPIO to PIN mapping. This is stopgap solution till we think out and implement a proper api (pinlib?). Signed-off-by: Anton Vorontsov

[PATCH 2/3] powerpc/qe: new call to revert a gpio to a dedicated function

2008-08-08 Thread Anton Vorontsov
qe_gpio_set_dedicated() is a platform specific function, which is used to revert a pin to a dedicated function. Caller should have already obtained the gpio via gpio_request(). This is needed to support Freescale USB Host Controller. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] ---

Re: [2.6 patch] cleanup powerpc/include/asm/ide.h

2008-08-08 Thread Bartlomiej Zolnierkiewicz
On Friday 08 August 2008, Adrian Bunk wrote: This patch removes code that became unused through IDE changes and the arch/ppc/ removal. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

[12/17] powerpc: use bcd2bin/bin2bcd

2008-08-08 Thread Adrian Bunk
This patch changes powerpc to use the new bcd2bin/bin2bcd functions instead of the obsolete BCD_TO_BIN/BIN_TO_BCD macros. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/powerpc/platforms/chrp/time.c | 24 arch/powerpc/platforms/iseries/mf.c | 26

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Matt Carlson
On Fri, Aug 08, 2008 at 07:18:31PM +1000, Benjamin Herrenschmidt wrote: On Fri, 2008-08-08 at 10:58 +0200, Segher Boessenkool wrote: I don't know yet for sure what happens, but a quick look at the commit seems to show that the driver synchronously spin-waits for up to 2.5ms That's what

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Michael Chan
On Fri, 2008-08-08 at 11:43 -0700, Matthew Carlson wrote: Segher is right. The code should be 2.5 milliseconds but is actually much longer. This fix is actually already in my patch queue and needs to be sent upstream. Matt, I think we can optimize this a little more. The heart beat event

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Nathan Lynch
Benjamin Herrenschmidt wrote: On Fri, 2008-08-08 at 10:58 +0200, Segher Boessenkool wrote: I don't know yet for sure what happens, but a quick look at the commit seems to show that the driver synchronously spin-waits for up to 2.5ms That's what the comment says, but the code says 2.5

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Benjamin Herrenschmidt
On Fri, 2008-08-08 at 11:43 -0700, Matt Carlson wrote: Segher is right. The code should be 2.5 milliseconds but is actually much longer. This fix is actually already in my patch queue and needs to be sent upstream. We really shouldn't be displaying any error messages in the event of a

Re: [PATCH 1/2] Cell OProfile: SPU mutex lock fix, version 4

2008-08-08 Thread Carl Love
On Fri, 2008-08-08 at 18:08 +0200, Arnd Bergmann wrote: On Friday 01 August 2008, Carl Love wrote: The issue is the SPU code is not holding the kernel mutex lock while adding samples to the kernel buffer. Thanks for your patch, and sorry for not replying earlier. It looks good from a

Re: [PATCH 1/2] Repost Cell OProfile: SPU mutex lock fix, version 4

2008-08-08 Thread Carl Love
Version 4 of the SPU mutex lock fix. Updated to address Arnd's comments. The issue is the SPU code is not holding the kernel mutex lock while adding samples to the kernel buffer. This patch creates per SPU buffers to hold the data. Data is added to the buffers from in interrupt context. The

Re: [PATCH 2/2] Repost Cell OProfile: SPU mutex lock fix, version 4

2008-08-08 Thread Carl Love
Updated to address Arnd's comments. If an error occurs on opcontrol start, the event and per cpu buffers are released. If later opcontrol shutdown is called then the free function will be called again to free buffers that no longer exist. This results in a kernel oops. The following changes

Re: [PATCH 0/3] Patches to support QE USB Host Controller

2008-08-08 Thread Greg KH
On Fri, Aug 08, 2008 at 08:17:17PM +0400, Anton Vorontsov wrote: Hi all, Most patches that were needed to support QE USB Host were merged during 2.6.27 merge window, and only three more patches left over. Here they are. David, could you bear with gpio_to_chip() exported function, just as

Re: Strange tg3 regression with UMP fw. link reporting

2008-08-08 Thread Michael Chan
On Fri, 2008-08-08 at 15:05 -0700, Benjamin Herrenschmidt wrote: On Fri, 2008-08-08 at 11:43 -0700, Matt Carlson wrote: We really shouldn't be displaying any error messages in the event of a timeout though. Earlier versions of the UMP firmware did not support the link update interface.