Re: checkpatch nits ...

2008-08-27 Thread Wolfram Sang
On Sat, Aug 23, 2008 at 10:57:21AM +0200, Arnd Bergmann wrote: On Saturday 23 August 2008, Kevin Diggs wrote: WARNING: externs should be avoided in .c files #1137: FILE: powerpc/kernel/cpu/pll_if.c:369: +       __asm__ __volatile__ ( ??? I don't know what this is? The entire

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Kevin Diggs
Arnd Bergmann wrote: On Tuesday 26 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: On Monday 25 August 2008, Kevin Diggs wrote: Most people list their email address here as well For reasons I'd rather not go into, my email address is not likely to remain valid for much longer.

Re: [PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered

2008-08-27 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: We must not call dev_mc_add() from within our HW configure which happens before we initialize and register the netdev. Do it in open() instead. Thanks to Sebastian Siewior for tracking it down. Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- This

[PATCH] cpm1: Fix race condition in CPM1 GPIO library.

2008-08-27 Thread Jochen Friedrich
The CPM1 GPIO library code uses the non thread-safe clrbits32/setbits32 macros. This patch protects them with a spinlock. Based on the CPM2 patch from Laurent Pinchart [EMAIL PROTECTED], commit 639d64456e20cbfc866b18dc03cf9f9babc9c7cd. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] ---

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Kamalesh Babulal
Arjan van de Ven wrote: Kamalesh Babulal wrote: Hi Stephen, Badness warning is seen, while booting up the next-20080825/26 kernels on the powerpc boxes this is fixed in the patch I sent to Ingo earlier today (attached again for reference)

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Arnd Bergmann
On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Ok, thanks for the explanation. I now saw that you also use '_v' for variables (I guess). These should probably go the same way. Actually the _v means global variable. I would prefer to keep it. The reasoning on

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Geert Uytterhoeven
On Wed, 27 Aug 2008, Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Are there even SMP boards based on a 750? I thought only 74xx and 603/604 were SMP capable. Not that I have heard of. I thought it was lacking some hardware that was

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Arjan van de Ven
Kamalesh Babulal wrote: Thanks for reference of the patch, After replacing the patch with the latest one above on the powerpc, the warning still remains Badness at kernel/notifier.c:86 sadly you have something going on that doesn't list the modules loaded etc... is this during boot or way

Re: gdb problems with threads on mpc512x

2008-08-27 Thread Daniele Bosi
I attach the listing of our program, I tried it on ELDK4.2 Freescale (kernel 2.6.24.6 by Freescale, your rootfs) and it's still giving me problems: if I issue br PrintHello then cont-inue for some times, after a while gdb stops responding and is not even getting CTRL-C or CTRL-Z. Of course

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Stephen Rothwell
Hi Arjan, On Wed, 27 Aug 2008 06:48:06 -0700 Arjan van de Ven [EMAIL PROTECTED] wrote: Kamalesh Babulal wrote: Thanks for reference of the patch, After replacing the patch with the latest one above on the powerpc, the warning still remains Badness at kernel/notifier.c:86

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Stephen Rothwell
Hi Arjan, On Thu, 28 Aug 2008 00:33:08 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote: The original reported trace was during setup_system which is very early in the boot. But, of course, that version didn't have the necessary extra dereference of the function address ... And the later debug

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-27 Thread Alan Stern
On Wed, 27 Aug 2008, Vitaly Bordug wrote: A published errata for ppc440epx states, that when running Linux with both EHCI and OHCI modules loaded, the EHCI module experiences a fatal error when a high-speed device is connected to the USB2.0, and functions normally if OHCI module is not

[TTY] driver sriel tty on ppc board

2008-08-27 Thread Sébastien Chrétien
Hello, I am trying to code a tty serial driver (UART link). The initialization is : (model LDD 3) static int __init tiny_tty_init(void) { int i, retval; printk(Initialization of ttyS - \n); tiny_tty_driver=alloc_tty_driver(NB_TTY); if(!tiny_tty_driver) return -ENOMEM;

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Brad Boyer
On Wed, Aug 27, 2008 at 01:40:10PM +0200, Geert Uytterhoeven wrote: On Wed, 27 Aug 2008, Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Are there even SMP boards based on a 750? I thought only 74xx and 603/604 were SMP capable. Not

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Geert Uytterhoeven
On Wed, 27 Aug 2008, Brad Boyer wrote: On Wed, Aug 27, 2008 at 01:40:10PM +0200, Geert Uytterhoeven wrote: On Wed, 27 Aug 2008, Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Are there even SMP boards based on a 750? I thought only 74xx

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Kamalesh Babulal
Arjan van de Ven wrote: Kamalesh Babulal wrote: Thanks for reference of the patch, After replacing the patch with the latest one above on the powerpc, the warning still remains Badness at kernel/notifier.c:86 sadly you have something going on that doesn't list the modules loaded etc...

Re: Efficient memcpy()/memmove() for G2/G3 cores...

2008-08-27 Thread Steven Munroe
On Tue, 2008-08-26 at 08:28 +1000, Benjamin Herrenschmidt wrote: On Mon, 2008-08-25 at 15:06 +0200, David Jander wrote: Hi Matt, On Monday 25 August 2008 13:00:10 Matt Sealey wrote: The focus has definitely been on VMX but that's not to say lower power processors were forgotten :)

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Kevin Diggs
Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Ok, thanks for the explanation. I now saw that you also use '_v' for variables (I guess). These should probably go the same way. Actually the _v means global variable. I would prefer to keep it.

Re: [PATCH 2/4] Add cpufreq driver for the IBM PowerPC 750GX

2008-08-27 Thread Kevin Diggs
Arnd Bergmann wrote: On Wednesday 27 August 2008, Kevin Diggs wrote: Arnd Bergmann wrote: Ok, thanks for the explanation. I now saw that you also use '_v' for variables (I guess). These should probably go the same way. Actually the _v means global variable. I would prefer to keep it.

Re: [PATCH v2] POWERPC: Allow 32-bit pgtable code to support 36-bit physical

2008-08-27 Thread Scott Wood
Becky Bruce wrote: #if _PAGE_HASHPTE != 0 +#ifndef CONFIG_PTE_64BIT pte_update(ptep, ~_PAGE_HASHPTE, pte_val(pte) ~_PAGE_HASHPTE); #else + /* +* We have to do the write of the 64b pte as 2 stores. This +* code assumes that the entry we're storing to is currently

Re: [PATCH] hotplug/rpaphp: remove unused error path code

2008-08-27 Thread Jesse Barnes
On Monday, August 18, 2008 6:45 pm Stephen Rothwell wrote: Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 (PCI: introduce pci_slot) removed the need for this error path. Eliminate this warning: drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':

Re: [PATCH 04/59] CRED: Wrap task credential accesses in the PowerPC arch

2008-08-27 Thread Benjamin Herrenschmidt
On Wed, 2008-08-27 at 14:46 +0100, David Howells wrote: Wrap access to task credentials so that they can be separated more easily from the task_struct during the introduction of COW creds. Change most current-(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id(). Change some task-e?[ug]id to

Re: [PATCH] hotplug/rpaphp: remove unused error path code

2008-08-27 Thread Stephen Rothwell
Hi Jesse, On Wed, 27 Aug 2008 16:34:03 -0700 Jesse Barnes [EMAIL PROTECTED] wrote: On Monday, August 18, 2008 6:45 pm Stephen Rothwell wrote: Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 (PCI: introduce pci_slot) removed the need for this error path. Eliminate this warning: