Re: [BUG] hvc_console WARN() on current upstream

2009-01-08 Thread Christian Borntraeger
Am Donnerstag, 8. Januar 2009 schrieb Benjamin Herrenschmidt: [ cut here ] Badness at /home/benh/kernels/linux-powerpc/kernel/mutex.c:135 NIP: c04fe0dc LR: c04fe0c0 CTR: c02c4304 REGS: cfffb660 TRAP: 0700 Not tainted (2.6.28-test)

Re: [BUG] hvc_console WARN() on current upstream

2009-01-08 Thread Benjamin Herrenschmidt
Also including Alan, he's the current tty guru On Thu, 2009-01-08 at 08:57 +0100, Christian Borntraeger wrote: Am Donnerstag, 8. Januar 2009 schrieb Benjamin Herrenschmidt: [ cut here ] Badness at /home/benh/kernels/linux-powerpc/kernel/mutex.c:135 NIP:

Re: 2.6.28-rc9 panics with crashkernel=256M while booting

2009-01-08 Thread Chandru
On Wednesday 07 January 2009 22:55:25 Dave Hansen wrote: I'm just suggesting making your fix in the ppc code instead of in mm/bootmem.c. Here are the changes that helped to boot the kernel. Please review it. Thanks, Signed-off-by: Chandru S chan...@linux.vnet.ibm.com Cc: Dave Hansen

Re: [patch 0/6] ps3vram driver patches

2009-01-08 Thread Geert Uytterhoeven
On Wed, 7 Jan 2009, Arnd Bergmann wrote: On Wednesday 07 January 2009, Geoff Levand wrote: Geert and I were discussing actually removing the direct write to the XDR memory, and so the need for that ioremap, as the mapping is just used in ps3vram_erase(), which seems could be removed.

[PATCH v6] spi: Add PPC4xx SPI driver

2009-01-08 Thread Stefan Roese
This adds a SPI driver for the SPI controller found in the IBM/AMCC 4xx PowerPC's. Signed-off-by: Stefan Roese s...@denx.de Signed-off-by: Wolfgang Ocker w...@reccoware.de Acked-by: Josh Boyer jwbo...@linux.vnet.ibm.com --- Changes in v6: - Moved comment about high interrupt load to top of file

Re: [PATCH 1/3] radeonfb: Fix 64 bits resources on 32 bits archs

2009-01-08 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: This fixes radeonfb to not truncate 64 bits resources on 32 bits platforms. Unfortunately, there are still issues with addresses returned to userspace via struct fb_fix_screeninfo. This will have to be dealt with separately. Signed-off-by: Benjamin

Re: [PATCH 1/3] radeonfb: Fix 64 bits resources on 32 bits archs

2009-01-08 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: This fixes radeonfb to not truncate 64 bits resources on 32 bits platforms. Unfortunately, there are still issues with addresses returned to userspace via struct fb_fix_screeninfo. This will have to be dealt with separately. Signed-off-by: Benjamin

Re: [PATCH 1/2] watchdog: Basic support for GE Fanuc's FPGA based watchdog timer

2009-01-08 Thread Martyn Welch
Wim Van Sebroeck wrote: Hi All, Any status of acceptance of this? I changed the ioctl to an unlocked ioctl and removed the temperature ioctl call. It's now in my linux-2.6-watchdog-next tree. Can someone verify that it still works?

Re: [BUG] hvc_console WARN() on current upstream

2009-01-08 Thread Alan Cox
Seems that we are in interrupt, doing hvc_poll, which does tty_flip_buffer_push Which means that someone has tty-low_latency set and is calling tty_flip_buffer_push in an IRQ. That has never been allowed or safe, and now it hurts ;) /** * tty_flip_buffer_push- terminal *

Re: Kernel completely crashes after accessing an unmapped area.

2009-01-08 Thread Ricardo
Hello Benjamin Thank you very much for your help. You are completely right, once I have fixed the cputable everything worked like a charm. I have reviewed the last git version and it seems solved there, so I wont publish the patch in git format ( to avoid confusions) Best

[PATCH 0/5] hvc_console updates was Re: [BUG] hvc_console WARN() on current upstream

2009-01-08 Thread Milton Miller
Alan Cox wrote: Benjamin Herrenschmidt wrote: Seems that we are in interrupt, doing hvc_poll, which does tty_flip_buffer_push Which means that someone has tty-low_latency set and is calling tty_flip_buffer_push in an IRQ. That has never been allowed or safe, and now it hurts ;) /** *

[PATCH 3/4] hvc_console: free_irq only if request_irq was successful

2009-01-08 Thread Milton Miller
Only call free_irq if we marked the request_irq has having succeeded instead of whenever the the sub-driver identified the interrupt to use. Signed-off-by: Milton Miller milt...@bga.com --- Appears to be a bugfix but might use a bit of time in -next. This code was created in 2.6.28 to allow s390

[PATCH 2/4] hvc_console: use kzalloc

2009-01-08 Thread Milton Miller
Replace kmalloc + memset with kzalloc. Signed-off-by: Milton Miller milt...@bga.com Index: work.git/drivers/char/hvc_console.c === --- work.git.orig/drivers/char/hvc_console.c2009-01-08 04:24:10.0 -0600 +++

[PATCH 4/4] hvc_console: comment mb and make it an smp_ one

2009-01-08 Thread Milton Miller
I remember some history on this barrier. There was a race between open via /dev/console and the tty being fully setup. Its also why there is a temporary variable and the global is assigned at the end of the function. Signed-off-by: Milton Miller milt...@bga.com Index:

[PATCH 1/4] hvc_console: do not set low_latency

2009-01-08 Thread Milton Miller
hvc_console is setting low_latency unconditionally, but some clients are interrupt driven and will call hvc_poll from irq context. This will cause tty_flip_buffer_push to be called from irq context, and it very clearly states it must not be called from IRQ when low_latency is specified. Looking

[PATCH 4/4] powerpc: numa: avoid possible reference beyond property length in find_min_common_depth

2009-01-08 Thread Milton Miller
find_min_common_depth was checking the property length incorrectly. The value is in bytes not cells, and it is using the second entry. Signed-off-By: Milton Miller milt...@bga.com --- I'm not aware of any trees that are broken in this way, so backport not likely needed but easy to apply. Index:

[PATCH 3/4] powerpc: remove redundant find_cpu_node

2009-01-08 Thread Milton Miller
use of_get_cpu_node, which is a superset of numa.c's find_cpu_node in a less restrictive section (text vs cpuinit). Signed-off-by: Milton Miller milt...@bga.com Index: work.git/arch/powerpc/mm/numa.c === ---

[PATCH 1/4] powerpc: move hose_list and pci_address_to_pio to pci-common

2009-01-08 Thread Milton Miller
move the definition of hose_list next to its hotplug spinlock. create pcibios_io_size to encapsulate ifdef in existing pci-common function pcibios_vaddr_is_ioport move pci_address_to_pio to pci-common, using new pcibios_io_size, and protect this GPL exported function against concurrent hotplug

[PATCH 2/4] powerpc: remove write only variable

2009-01-08 Thread Milton Miller
Since we never hotplug add an isa bus, we never need to set primary. Delete this write-only variable. Signed-off-by: Milton Miller milt...@bga.com --- The reference to primary was removed in during a code move 92eb4602 (v2.6.16) when dlpar for p5ioc was tested. Index:

[PATCH kexec-tools v2] ppc64: always check number of ranges when adding them

2009-01-08 Thread Milton Miller
make the idom always call realloc_memory_ranges when filling a range entry kexec was core dumping after using 5 exclude_range pairs when only 3 were allocated. also delcare realloc_memory_ranges to take void. Signed-off-by: Milton Miller milt...@bga.com --- v2: compare variable j not i in a

[PATCH] powerpc/e500mc: Minor tweaks to init/exception code for e500mc

2009-01-08 Thread Kumar Gala
* PID1/PID2 don't exist on e500mc so we should write them * Doorbell exceptions need to be taken w/EE still disabled since we use them for things like IPIs Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- arch/powerpc/kernel/head_fsl_booke.S |6 +++--- 1 files changed, 3

Re: [PATCH] powerpc/mpc52xx: Properly update irq_desc when set_type() is called.

2009-01-08 Thread Matt Sealey
Grant Likely wrote: On Wed, Jan 7, 2009 at 8:51 PM, Matt Sealey m...@genesi-usa.com wrote: Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca The MPC5200 PIC driver doesn't correctly update the .status field of the irq_desc structure when the set_type hook is called. This patch

Re: [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor

2009-01-08 Thread Robert Richter
On 01.12.08 16:18:26, Carl Love wrote: This is a rework of the previously posted set of patches. Patch 1 is the user level patch to add the SPU events to the user OProfile tool. Patch 2 is a kernel patch to do code clean up and restructuring to make it easier to add the new SPU event

Re: [PATCH 3/4] hvc_console: free_irq only if request_irq was successful

2009-01-08 Thread Christian Borntraeger
Am Donnerstag, 8. Januar 2009 schrieb Milton Miller: Only call free_irq if we marked the request_irq has having succeeded instead of whenever the the sub-driver identified the interrupt to use. Signed-off-by: Milton Miller milt...@bga.com --- Appears to be a bugfix but might use a bit of

Re: [PATCH] gianfar: Fixup use of BUS_ID_SIZE

2009-01-08 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Wed, 7 Jan 2009 09:52:01 -0600 Commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 went back to using BUS_ID_SIZE instead of sizeof() as per the larger patch series that will remove char bus_id[20] from struct device. Signed-off-by: Kumar Gala

Re: [PATCH 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC mode support

2009-01-08 Thread Anton Vorontsov
On Thu, Jan 08, 2009 at 12:50:22AM -0600, Kumar Gala wrote: +struct mpc83xx_pcie_priv { +void __iomem *cfg_map; +u32 dev_base; +}; So was thinking about this and was wondering about doing the following: hose-cfg_addr /* use instead of dev_base to cache pci bus/dev/fn */

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-08 Thread David Miller
From: Ira Snyder i...@ovro.caltech.edu Date: Wed, 7 Jan 2009 11:50:52 -0800 This adds support to Linux for a virtual ethernet interface which uses the PCI bus as its transport mechanism. It creates a simple, familiar, and fast method of communication for two devices connected by a PCI

Re: [PATCH] ucc_geth: use correct UCCE macros

2009-01-08 Thread David Miller
From: Timur Tabi ti...@freescale.com Date: Wed, 7 Jan 2009 14:17:04 -0600 On Wed, Jan 7, 2009 at 2:12 PM, Timur Tabi ti...@freescale.com wrote: This patch will break ucc_geth.c if my other patch, powerpc: add Ethernet UPSMR definitions to QE library isn't also applied. That patch is

Re: [PATCH] ucc_geth: use correct UCCE macros

2009-01-08 Thread Timur Tabi
David Miller wrote: I think I'll wait for Kumar's stuff to hit Linus's tree, then apply this patch. The patch is safely stored in my inbox and patchwork so there is no need to fear it getting lost :-) That's good enough for me. Thanks! -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC mode support

2009-01-08 Thread Kumar Gala
On Jan 8, 2009, at 1:10 PM, Anton Vorontsov wrote: On Thu, Jan 08, 2009 at 12:50:22AM -0600, Kumar Gala wrote: +struct mpc83xx_pcie_priv { + void __iomem *cfg_map; + u32 dev_base; +}; So was thinking about this and was wondering about doing the following: hose-cfg_addr /*

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-08 Thread Ira Snyder
On Thu, Jan 08, 2009 at 11:16:10AM -0800, David Miller wrote: From: Ira Snyder i...@ovro.caltech.edu Date: Wed, 7 Jan 2009 11:50:52 -0800 This adds support to Linux for a virtual ethernet interface which uses the PCI bus as its transport mechanism. It creates a simple, familiar, and fast

Re: 2.6.28-rc9 panics with crashkernel=256M while booting

2009-01-08 Thread Dave Hansen
On Thu, 2009-01-08 at 15:59 +0530, Chandru wrote: @@ -898,9 +899,17 @@ static void mark_reserved_regions_for_ni * if reserved region extends past active region * then trim size to active region */ -

Re: [BUG] hvc_console WARN() on current upstream

2009-01-08 Thread Benjamin Herrenschmidt
On Thu, 2009-01-08 at 11:11 +, Alan Cox wrote: Seems that we are in interrupt, doing hvc_poll, which does tty_flip_buffer_push Which means that someone has tty-low_latency set and is calling tty_flip_buffer_push in an IRQ. That has never been allowed or safe, and now it hurts ;)

Re: [PATCH 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC modesupport

2009-01-08 Thread Anton Vorontsov
On Thu, Jan 08, 2009 at 03:27:10PM +0800, Liu Dave wrote: +static void __iomem *mpc83xx_pcie_remap_cfg(struct pci_bus *bus, + unsigned int devfn, [snip] + if (pcie-dev_base == dev_base) + goto mapped; + + out_le32(hose-cfg_data

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-08 Thread Ira Snyder
On Thu, Jan 08, 2009 at 11:27:16AM -0800, Ira Snyder wrote: On Thu, Jan 08, 2009 at 11:16:10AM -0800, David Miller wrote: From: Ira Snyder i...@ovro.caltech.edu Date: Wed, 7 Jan 2009 11:50:52 -0800 This adds support to Linux for a virtual ethernet interface which uses the PCI bus as

[PATCH v6 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC mode support

2009-01-08 Thread Anton Vorontsov
This patch adds support for PCI-Express controllers as found on the newer MPC83xx chips. The work is loosely based on the Tony Li's patch[1], but unlike the original patch, this patch implements sliding window for the Type 1 transactions using outbound window translations, so we don't have to

[PATCH 1/2] powerpc/fsl-booke: Cleanup init/exception setup to be runtime

2009-01-08 Thread Kumar Gala
We currently have a few variants of fsl-booke processors (e500v1, e500v2, e500mc, and e200). They all have minor differences that we had previously been handling via ifdefs. To move towards having this support the following changes have been made: * PID1, PID2 only exist on e500v1 e500v2 and

[PATCH 2/2] powerpc/e500mc: Doorbells need to be taken w/exceptions disabled

2009-01-08 Thread Kumar Gala
We use Doorbell interrupts for IPIs and thus we need to make sure we aren't interrupted in the process of processing the IPI. Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- arch/powerpc/kernel/head_fsl_booke.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] powerpc/e500mc: Minor tweaks to init/exception code for e500mc

2009-01-08 Thread Kumar Gala
On Jan 8, 2009, at 8:33 AM, Kumar Gala wrote: * PID1/PID2 don't exist on e500mc so we should write them * Doorbell exceptions need to be taken w/EE still disabled since we use them for things like IPIs Signed-off-by: Kumar Gala ga...@kernel.crashing.org ---

Re: [PATCH v6 1/2] powerpc/fsl_pci: Add MPC83xx PCI-E controller RC mode support

2009-01-08 Thread Kumar Gala
On Jan 8, 2009, at 3:55 PM, Anton Vorontsov wrote: This patch adds support for PCI-Express controllers as found on the newer MPC83xx chips. The work is loosely based on the Tony Li's patch[1], but unlike the original patch, this patch implements sliding window for the Type 1 transactions

Re: [PATCH 2/2] powerpc/83xx: Add PCI-E support for all MPC83xx boards with PCI-E

2009-01-08 Thread Kumar Gala
On Jan 7, 2009, at 7:31 PM, Anton Vorontsov wrote: This patch adds pcie nodes to the appropriate dts files, plus adds some probing code for the boards. Also, remove of_device_is_avaliable() check from the mpc837x_mds.c board file, as mpc83xx_add_bridge() has the same check now.

Re: [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor

2009-01-08 Thread Carl Love
On Thu, 2009-01-08 at 16:48 +0100, Robert Richter wrote: On 01.12.08 16:18:26, Carl Love wrote: This is a rework of the previously posted set of patches. Patch 1 is the user level patch to add the SPU events to the user OProfile tool. Patch 2 is a kernel patch to do code clean up

linux-next: manual merge of the rr tree

2009-01-08 Thread Stephen Rothwell
Hi Rusty, Today's linux-next merge of the rr tree got a conflict in arch/powerpc/kernel/sysfs.c between commit 93197a36a9c16a85fb24cf5a8639f7bf9af838a3 (powerpc: Rewrite sysfs processor cache info code) from Linus' tree and commit 013ab448cec493262080ecc47b13e0adbcfaeccd

RE: [PATCH 2/2] powerpc/e500mc: Doorbells need to be taken w/exceptionsdisabled

2009-01-08 Thread Liu Dave
Acked-by: Dave Liu dave...@freescale.com -Original Message- From: linuxppc-dev-bounces+daveliu=freescale@ozlabs.org [mailto:linuxppc-dev-bounces+daveliu=freescale@ozlabs.org] On Behalf Of Kumar Gala Sent: 2009?1?9? 8:15 AM To: linuxppc-dev@ozlabs.org Subject: [PATCH 2/2]