linux-next: upstream tree build failure

2009-04-22 Thread Stephen Rothwell
Hi all, [I am now using gcc version 4.4.0 ...] Today's linux-next build (powerpc ppc44x_defconfig) failed like this: arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression Previous gcc versions didn't notice this because one of the preceding #ifs always evaluated to true. I ha

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 11:06 PM, David Gibson wrote: Well, yes, I guess I agree. How immutable you consider the device tree blob to be is a judgement call based on the specific details of platform/board in question. If it is indeed a reference platform, in the early stages of development where i

Re: [PATCH][BUILD FAILURE 03/12] Re: Next April 21 : PPC64 randconfig [arch/powerpc/kernel/of_platform.o]

2009-04-22 Thread Michael Ellerman
On Wed, 2009-04-22 at 20:15 -0700, Randy Dunlap wrote: > Michael Ellerman wrote: > > On Wed, 2009-04-22 at 21:46 +0530, Subrata Modak wrote: > >> On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: > >>> Reported this earlier on 14th April 2009: > >>> http://lkml.org/lkml/2009/4/14/480, > >>> >

Re: removing get_immrbase()??

2009-04-22 Thread David Gibson
On Wed, Apr 22, 2009 at 10:36:36PM -0500, Kumar Gala wrote: > > On Apr 22, 2009, at 9:26 PM, David Gibson wrote: > >> On Wed, Apr 22, 2009 at 04:55:42PM -0500, Kumar Gala wrote: >>> >>> On Apr 22, 2009, at 4:38 PM, Scott Wood wrote: >>> Kumar Gala wrote: > I disagree. If you update your k

Re: [PATCH] powerpc: adjust oprofile_cpu_type

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 6:40 PM, Mike Wolf wrote: Resending. the patch was munged last time. Oprofile is changing the naming it is using for the compatibility modes. Instead of having compat-power, oprofile will go to family naming convention and use compat-v. Currently only compat-v1 will b

[PATCH] powerpc: Refactor board check for PCI quirks on FSL boards with uli1575

2009-04-22 Thread Kumar Gala
Refactor the check to determine if the quirk is applicable to the boards into one inline function so we only have to change one place to add more boards that the quirks might be applicable to. Also removed a warning related to unused temp variable. Signed-off-by: Kumar Gala --- * With new and im

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 9:26 PM, David Gibson wrote: On Wed, Apr 22, 2009 at 04:55:42PM -0500, Kumar Gala wrote: On Apr 22, 2009, at 4:38 PM, Scott Wood wrote: Kumar Gala wrote: I disagree. If you update your kernel you should update your device tree (thus we have .dts in the kernel tree an

Re: [14/14] net: add Xilinx ll_temac device driver

2009-04-22 Thread Grant Likely
On Wed, Apr 22, 2009 at 9:37 PM, Grant Likely wrote: > On Wed, Apr 22, 2009 at 5:12 PM, Graeme Smecher > wrote: >> Hi Grant, >> >> I'm not sure if you've caught this yet, but there's a typo in >> drivers/net/xilinx_temac.c. The TX and RX ISRs (ll_temac_tx_irq and >> ll_temac_rx_irq) take two argu

Re: [PATCH][BUILD FAILURE 03/12] Re: Next April 21 : PPC64 randconfig [arch/powerpc/kernel/of_platform.o]

2009-04-22 Thread Randy Dunlap
Michael Ellerman wrote: > On Wed, 2009-04-22 at 21:46 +0530, Subrata Modak wrote: >> On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: >>> Reported this earlier on 14th April 2009: >>> http://lkml.org/lkml/2009/4/14/480, >>> >>> Michael, >>> >>> Any fix in sight ? >>> http://lkml.org/lkml/200

Re: removing get_immrbase()??

2009-04-22 Thread David Gibson
On Wed, Apr 22, 2009 at 04:55:42PM -0500, Kumar Gala wrote: > > On Apr 22, 2009, at 4:38 PM, Scott Wood wrote: > >> Kumar Gala wrote: >>> I disagree. If you update your kernel you should update your device >>> tree (thus we have .dts in the kernel tree and not somewhere else). >> >> No. The devi

[PATCH 6/6] powerpc: We don't need __do_IRQ() anymore

2009-04-22 Thread Michael Ellerman
So select GENERIC_HARDIRQS_NO__DO_IRQ to disable it. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 4c78045..3ba167a 100644 --- a/arch/powerpc/Kconfig +++ b/arc

[PATCH 5/6] powerpc/powermac: Use generic_handle_irq() in gatwick_action()

2009-04-22 Thread Michael Ellerman
Don't call __do_IRQ() directly in gatwick_action(), use generic_handle_irq(). Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powermac/pic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powerm

[PATCH 4/6] powerpc: Remove fallback to __do_IRQ()

2009-04-22 Thread Michael Ellerman
We should no longer have any irq code that needs __do_IRQ(), so remove the fallback to __do_IRQ(). Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/irq.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c in

[PATCH 3/6] powerpc: Move get_irq() comment into header

2009-04-22 Thread Michael Ellerman
The guts of do_IRQ() isn't really the right place to be documenting the ppc_md.get_irq() interface. So move the comment into machdep.h Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/machdep.h |4 arch/powerpc/kernel/irq.c |7 --- 2 files changed, 4 inserti

[PATCH 2/6] powerpc: Move stack overflow check into a separate function

2009-04-22 Thread Michael Ellerman
Makes do_IRQ() shorter and clearer. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/irq.c | 31 +-- 1 files changed, 17 insertions(+), 14 deletions(-) diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c index bc08827..f725610 100644 --- a/arc

[PATCH 1/6] powerpc: Move #ifdef'ed body of do_IRQ() into a separate function

2009-04-22 Thread Michael Ellerman
Rather than a giant ifdef in the body of do_IRQ(), including a dangling else, move the irq stack logic into a separate routine and do the ifdef there. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/irq.c | 96 ++--- 1 files changed, 56 insertion

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-04-22 Thread Ben Dooks
On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: > > On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: > > >Recent DMA changes result in a BUG() when NULL is passed to > >dma_alloc_coherent in place of a device. > > > >Signed-off-by: Mark Ware > >--- > > > >This patch fixes the BUG() duri

Re: [PATCH][BUILD FAILURE 03/12] Re: Next April 21 : PPC64 randconfig [arch/powerpc/kernel/of_platform.o]

2009-04-22 Thread Michael Ellerman
On Wed, 2009-04-22 at 21:46 +0530, Subrata Modak wrote: > On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: > > Reported this earlier on 14th April 2009: > > http://lkml.org/lkml/2009/4/14/480, > > > > Michael, > > > > Any fix in sight ? > > http://lkml.org/lkml/2009/4/14/676, > > > > CC

[PATCH] powerpc/cell: CELL_NATIVE should select PCI

2009-04-22 Thread Michael Ellerman
Because it selects PPC_OF_PLATFORM_PCI which depends on PCI, so if we don't select PCI we can end up with PCI=n and PPC_OF_PLATFORM_PCI=y which doesn't build. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/cell/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) For

Re: [OT] Lite5200B w/ nfs root hangs after some time

2009-04-22 Thread Grant Likely
On Wed, Apr 22, 2009 at 12:10 PM, Wolfgang Denk wrote: > In message <1240422181.549...@antares> you wrote: >> Any idea what goes wrong here, and how I could fix it? > > Apply this patch: > > http://patchwork.ozlabs.org/patch/24487/ No, that's not the problem in this case. 2.6.29 networking is br

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
On Wed, Apr 22, 2009 at 5:33 PM, Scott Wood wrote: > All I'm asking is that we treat a mandatory dts upgrade as seriously as a > mandatory firmware upgrade. I agree with this statement 100%. -- Timur Tabi Linux kernel developer at Freescale ___ Linux

Re: [PATCH v2] powerpc: Refactor board check for quirk

2009-04-22 Thread Stephen Rothwell
Hi Kumar, On Wed, 22 Apr 2009 11:56:10 -0500 Kumar Gala wrote: > > Refactor the check to determine if the quirk is applicable to the boards > into one inline function so we only have to change one place to add more > boards that the quirks might be applicable to. > > Also removed a warning relat

Re: [OT] Lite5200B w/ nfs root hangs after some time

2009-04-22 Thread Roy Siu
good try for the expr., platform. 在 2009年4月23日 上午2:10 時, Wolfgang Denk 寫到: Dear Albrecht =?iso-8859-1?b?RHJl3w==?=, In message <1240422181.549...@antares> you wrote: this question is maybe off-topic on this list... This is not off topic (actually, if you had bothered to check the mailing i

[PATCH] powerpc: adjust oprofile_cpu_type

2009-04-22 Thread Mike Wolf
Resending. the patch was munged last time. Oprofile is changing the naming it is using for the compatibility modes. Instead of having compat-power, oprofile will go to family naming convention and use compat-v. Currently only compat-v1 will be defined. Signed-off-by: Mike Wolf --- mainl

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Kumar Gala wrote: On Apr 22, 2009, at 4:38 PM, Scott Wood wrote: Kumar Gala wrote: I disagree. If you update your kernel you should update your device tree (thus we have .dts in the kernel tree and not somewhere else). No. The device tree is a means to pass information from the firmware to

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 4:57 PM, Timur Tabi wrote: Kumar Gala wrote: New nodes. For example I've proposed a "local access window" node. Once I add it I plan on changing code to use it. This will break an old device tree booting with the new kernel and I'm completely ok with that. Are we ha

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
Scott Wood wrote: > That is indeed the case. A "demonstration" of that for the tree you > quote is that the "reg" address changed -- if you tried feeding the old > tree into the new kernel, it would not find the CPM command register. > There is no code in the kernel that looks for the command-

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Timur Tabi wrote: Kumar Gala wrote: The specific issue I'm talking about is the addition of new nodes that might break old device trees. New nodes or new properties? The CPM nodes are not new. On some device trees, the original versions did not have a compatible property for the CPM nodes

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
Kumar Gala wrote: > New nodes. For example I've proposed a "local access window" node. > Once I add it I plan on changing code to use it. This will break an > old device tree booting with the new kernel and I'm completely ok with > that. Are we having two different conversations? I was

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 4:38 PM, Scott Wood wrote: Kumar Gala wrote: I disagree. If you update your kernel you should update your device tree (thus we have .dts in the kernel tree and not somewhere else). No. The device tree is a means to pass information from the firmware to the kernel.

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 4:46 PM, Timur Tabi wrote: Kumar Gala wrote: The specific issue I'm talking about is the addition of new nodes that might break old device trees. New nodes or new properties? The CPM nodes are not new. On some device trees, the original versions did not have a comp

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
Kumar Gala wrote: > The specific issue I'm talking about is the addition of new nodes that > might break old device trees. New nodes or new properties? The CPM nodes are not new. On some device trees, the original versions did not have a compatible property for the CPM nodes (e.g. commit 0b5

[Question] PPC440EPx SMII ethernet

2009-04-22 Thread Steven A. Falco
We have built a new board based on the PPC440EPx. We are using an SMII-mode phy for the ethernet. The .dts file started as the one for Sequoia, and I have changed the phy specifier to phy-mode = "smii" - I've also removed the has-mdio property from RGMII0. The ethernet is working in U-Boot, but

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 4:33 PM, Timur Tabi wrote: Kumar Gala wrote: I disagree. If you update your kernel you should update your device tree (thus we have .dts in the kernel tree and not somewhere else). Is this a new policy? I was under the impression that supporting older device trees,

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Kumar Gala wrote: I disagree. If you update your kernel you should update your device tree (thus we have .dts in the kernel tree and not somewhere else). No. The device tree is a means to pass information from the firmware to the kernel. It is part of the firmware. That the repository of t

[PATCH v2] fs_enet: Remove dead code

2009-04-22 Thread Kumar Gala
CONFIG_DUET doesn't exist anymore, remove all the code that exists to support it. Signed-off-by: Kumar Gala --- * Removed stale comment that went along w/DUET support drivers/net/fs_enet/fs_enet-main.c | 35 +-- drivers/net/fs_enet/fs_enet.h |5 -

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
Kumar Gala wrote: > I disagree. If you update your kernel you should update your device > tree (thus we have .dts in the kernel tree and not somewhere else). Is this a new policy? I was under the impression that supporting older device trees, if not too inconvenient, is desirable. I've nack'

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 3:16 PM, Timur Tabi wrote: Scott Wood wrote: Timur Tabi wrote: these two are related and seem like we could look for "fsl,cpm2" That's okay, as long as you don't break compatibility with older device trees that don't have that property, unless you can demonstrate

Re: [PATCH] fs_enet: Remove dead code

2009-04-22 Thread Scott Wood
Kumar Gala wrote: @@ -318,32 +314,6 @@ static void restart(struct net_device *dev) /* * adjust to speed (only for DUET & RMII) */ -#ifdef CONFIG_DUET - if (fpi->use_rmii) { Please remove the comment that goes with the code being removed. Otherwise, ACK. -Scott

[PATCH] fs_enet: Remove dead code

2009-04-22 Thread Kumar Gala
CONFIG_DUET doesn't exist anymore, remove all the code that exists to support it. Signed-off-by: Kumar Gala --- drivers/net/fs_enet/fs_enet-main.c | 35 +-- drivers/net/fs_enet/fs_enet.h |5 - drivers/net/fs_enet/mac-fec.c | 30 --

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Scott Wood wrote: arch/powerpc/include/asm/cpm2.h:#define CPM_MAP_ADDR (get_immrbase() + 0x8) arch/powerpc/sysdev/cpm2.c:cpm2_immr = ioremap(get_immrbase(), CPM_MAP_SIZE); these two are related and seem like we could look for "fsl,cpm2" And do what with it that wouldn't be a reimp

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Timur Tabi wrote: Scott Wood wrote: Timur Tabi wrote: these two are related and seem like we could look for "fsl,cpm2" That's okay, as long as you don't break compatibility with older device trees that don't have that property, unless you can demonstrate that these trees would never wor

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
Scott Wood wrote: > Timur Tabi wrote: >>>these two are related and seem like we could look for "fsl,cpm2" >> That's okay, as long as you don't break compatibility with older >> device trees that don't have that property, unless you can demonstrate >> that these trees would never work with t

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Timur Tabi wrote: these two are related and seem like we could look for "fsl,cpm2" That's okay, as long as you don't break compatibility with older device trees that don't have that property, unless you can demonstrate that these trees would never work with the current kernel anyway. A

Re: [PATCH v6] spi: Add PPC4xx SPI driver

2009-04-22 Thread David Brownell
On Thursday 08 January 2009, Stefan Roese wrote: > This adds a SPI driver for the SPI controller found in the IBM/AMCC > 4xx PowerPC's. > +/* > + * The PPC4xx SPI controller has no FIFO so each sent/received byte will > + * generate an interrupt to the CPU. This can cause high CPU utilization. >

Re: removing get_immrbase()??

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 2:44 PM, Scott Wood wrote: CPM/QE related users. arch/powerpc/include/asm/cpm1.h:#define IMAP_ADDR (get_immrbase()) only used drivers/net/fs_enet/fs_enet-main.c which seems evil. That driver *is* evil. :-) It looks like the only remaining user of fs_enet_imma

Re: removing get_immrbase()??

2009-04-22 Thread Scott Wood
Kumar Gala wrote: I'm not sure if we can actually get away with completely removing get_immrbase() but I figured I'd give everyone something to flame me about. The current users are: I think we want to keep it for an eventual re-introduction of a large TLB entry to cover IMMR (but no longer

Re: removing get_immrbase()??

2009-04-22 Thread Timur Tabi
On Wed, Apr 22, 2009 at 1:38 PM, Kumar Gala wrote: > I'm not sure if we can actually get away with completely removing > get_immrbase() but I figured I'd give everyone something to flame me about. >  The current users are: > > CPM/QE related users. I'm okay with doing this for QE, but I don't see

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Ricardo Ribalda Delgado
Hello Scott It is definitively more elegant... Let me send tomorrow a patch On Wed, Apr 22, 2009 at 20:11, Scott Wood wrote: > Ricardo Ribalda Delgado wrote: >> >> Hi Scott >> >>> Perhaps "compatible" should be used instead? >> >> What do you mean? >> >> if (strcmp(partname, "partition") || s

[PATCH] powerpc/cpm: Remove some cruft code and defines

2009-04-22 Thread Kumar Gala
Kill of some old defines and macros that we no longer use like CPM_MAP_ADDR and CPM_IRQ_OFFSET. Signed-off-by: Kumar Gala --- arch/powerpc/include/asm/cpm2.h|4 arch/powerpc/platforms/82xx/pq2ads.h | 13 - arch/powerpc/platforms/8xx/mpc885ads.h |4 arch/

removing get_immrbase()??

2009-04-22 Thread Kumar Gala
I'm not sure if we can actually get away with completely removing get_immrbase() but I figured I'd give everyone something to flame me about. The current users are: CPM/QE related users. arch/powerpc/include/asm/cpm1.h:#define IMAP_ADDR (get_immrbase()) only used driv

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Benjamin Krill
* Ricardo Ribalda Delgado | 2009-04-22 19:59:08 [+0200]: >> >>                if (strcmp(partname, "partition") <= 0) { > >Anything alfabetically higher than partition (like "z" will pass >the test :S) You are totally right! cheers ben ___ Linuxppc

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 1:16 PM, Scott Wood wrote: Kumar Gala wrote: What "we care about" at this point is irrelevant, given the PITA it would be to change the device trees (or u-boot) that are already in use once we do begin to care. Which is exactly why I didn't put it in the .dts right now.

[PATCH] powerpc/fsl: use of_iomap() for rstcr mapping

2009-04-22 Thread Kumar Gala
The rstcr register mapping code was written sometime ago before of_iomap() existed. We can use it and clean up the code a bit and get rid of one user of get_immrbase() in the process. Signed-off-by: Kumar Gala --- arch/powerpc/sysdev/fsl_soc.c | 14 -- 1 files changed, 4 insertion

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Scott Wood
Kumar Gala wrote: What "we care about" at this point is irrelevant, given the PITA it would be to change the device trees (or u-boot) that are already in use once we do begin to care. Which is exactly why I didn't put it in the .dts right now. ??? Today we know NO code exists that cares abo

[RFC][PATCH] powerpc/86xx: Add binding for LAWs and MCM

2009-04-22 Thread Kumar Gala
The first 4k region of CCSR space is well defined for local access windows, CCSRBAR, etc. The second 4k region is well defined as register for configuring and getting errors for the MPX coherency module. Signed-off-by: Kumar Gala --- Please review. Once we close on this I intend to mimic this f

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 12:38 PM, Scott Wood wrote: Kumar Gala wrote: On Apr 22, 2009, at 12:16 PM, Scott Wood wrote: Kumar Gala wrote: On Apr 22, 2009, at 12:04 PM, Scott Wood wrote: Kumar Gala wrote: If this has an elbc more recent than 1.0 (looks like it), we should indicate that here. t

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Scott Wood
Ricardo Ribalda Delgado wrote: Hi Scott Perhaps "compatible" should be used instead? What do you mean? if (strcmp(partname, "partition") || strcmp(partname, "compatible") ) I can't see the advantages. No, I mean: foo { compatible = "partition"; ... }; -Scott

Re: [OT] Lite5200B w/ nfs root hangs after some time

2009-04-22 Thread Wolfgang Denk
Dear Albrecht =?iso-8859-1?b?RHJl3w==?=, In message <1240422181.549...@antares> you wrote: > > this question is maybe off-topic on this list... This is not off topic (actually, if you had bothered to check the mailing ist archives before posting, you would have known - because you would have foun

Re: FPGA IRQ design question

2009-04-22 Thread Wolfgang Grandegger
Eddie Dawydiuk wrote: > Grant, > >> However, if you're writing one-off custom drivers and there is no >> common coded needed for acking irqs, then I would probably just use >> the external IRQ. > > Thanks for the suggestions I think going to just use the external IRQ. > As a result I've been read

Re: FPGA IRQ design question

2009-04-22 Thread Eddie Dawydiuk
Grant, However, if you're writing one-off custom drivers and there is no common coded needed for acking irqs, then I would probably just use the external IRQ. Thanks for the suggestions I think going to just use the external IRQ. As a result I've been reading through a few different dts files

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Ricardo Ribalda Delgado
Hello Benjamin > Hi Recardo, > > I would suggest to do: > >                if (strcmp(partname, "partition") <= 0) { Anything alfabetically higher than partition (like "z" will pass the test :S) Regards > > cheers >  ben > > -- Ricardo Ribalda http://www.eps.uam.es/~rribalda/

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Ricardo Ribalda Delgado
Hi Scott > Perhaps "compatible" should be used instead? What do you mean? if (strcmp(partname, "partition") || strcmp(partname, "compatible") ) I can't see the advantages. > >> Hi Recardo, >> >> I would suggest to do: >> >>                if (strcmp(partname, "partition") <= 0) { > > Check wh

[OT] Lite5200B w/ nfs root hangs after some time

2009-04-22 Thread Albrecht Dreß
Hi, this question is maybe off-topic on this list... I use the Lite5200B board with stock kernel 2.6.29, and boot with the root fs on nfs on an Ubuntu 8.10 PC. Both the Lite5200B and the Ubuntu PC are part of a corporate network. On the root fs, I have busybox and everything else needed.

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Scott Wood
Kumar Gala wrote: On Apr 22, 2009, at 12:16 PM, Scott Wood wrote: Kumar Gala wrote: On Apr 22, 2009, at 12:04 PM, Scott Wood wrote: Kumar Gala wrote: If this has an elbc more recent than 1.0 (looks like it), we should indicate that here. that might be the case, but I leave it to u-boot to

[PATCH] powerpc/86xx: clean up smp init code

2009-04-22 Thread Kumar Gala
Removed the need for asm/mpc86xx.h as it was only used in mpc86xx_smp.c and just moved the defines it cared about into there. Also fixed up the ioremap to only map the one 4k page we need access to and to iounmap when we are done. Signed-off-by: Kumar Gala --- arch/powerpc/include/asm/mpc86xx.h

Re: [BUILD FAILURE 02/12] Next April 21 : PPC64 randconfig [drivers/net/ni65.c]

2009-04-22 Thread Andreas Mohr
Hi, On Wed, Apr 22, 2009 at 09:45:47PM +0530, Subrata Modak wrote: > On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: > > I am observing this for the first time: > > > > CC drivers/net/ni65.o > > drivers/net/ni65.c: In function ‘ni65_init_lance’: > > drivers/net/ni65.c:585: error: im

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Scott Wood
Benjamin Krill wrote: --- a/drivers/mtd/ofpart.c +++ b/drivers/mtd/ofpart.c @@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev, /* check if this is a partition node */ partname = of_get_property(pp, "name", &len); - if (strcmp

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 12:16 PM, Scott Wood wrote: Kumar Gala wrote: On Apr 22, 2009, at 12:04 PM, Scott Wood wrote: Kumar Gala wrote: If this has an elbc more recent than 1.0 (looks like it), we should indicate that here. that might be the case, but I leave it to u-boot to do that. Why?

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Scott Wood
Kumar Gala wrote: On Apr 22, 2009, at 12:04 PM, Scott Wood wrote: Kumar Gala wrote: If this has an elbc more recent than 1.0 (looks like it), we should indicate that here. that might be the case, but I leave it to u-boot to do that. Why? There's no p2020 with an older eLBC, and there's no

Re: ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Benjamin Krill
>--- a/drivers/mtd/ofpart.c >+++ b/drivers/mtd/ofpart.c >@@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev, > > /* check if this is a partition node */ > partname = of_get_property(pp, "name", &len); >- if (strcmp(partname, "partiti

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 12:04 PM, Scott Wood wrote: Kumar Gala wrote: If this has an elbc more recent than 1.0 (looks like it), we should indicate that here. that might be the case, but I leave it to u-boot to do that. Why? There's no p2020 with an older eLBC, and there's no block version re

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Scott Wood
Kumar Gala wrote: If this has an elbc more recent than 1.0 (looks like it), we should indicate that here. that might be the case, but I leave it to u-boot to do that. Why? There's no p2020 with an older eLBC, and there's no block version register. -Scott __

[PATCH v5] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Kumar Gala
The P2020 is a dual e500v2 core based SOC with: * 3 PCIe controllers * 2 General purpose DMA controllers * 2 sRIO controllers * 3 eTSECS * USB 2.0 * SDHC * SPI, I2C, DUART * enhanced localbus * and optional Security (P2020E) security w/XOR acceleration The p2020 DS reference board is pretty simila

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Kumar Gala
On Apr 22, 2009, at 11:44 AM, Scott Wood wrote: On Tue, Apr 21, 2009 at 10:31:45PM -0500, Kumar Gala wrote: + local...@ffe05000 { + #address-cells = <2>; + #size-cells = <1>; + compatible = "fsl,elbc", "simple-bus"; If this has an elbc more rec

[PATCH v2] powerpc: Refactor board check for quirk

2009-04-22 Thread Kumar Gala
Refactor the check to determine if the quirk is applicable to the boards into one inline function so we only have to change one place to add more boards that the quirks might be applicable to. Also removed a warning related to unused temp variable. Signed-off-by: Kumar Gala --- * Fixed compile i

Re: [PATCH v3] powerpc/85xx: Add P2020DS board support

2009-04-22 Thread Scott Wood
On Tue, Apr 21, 2009 at 10:31:45PM -0500, Kumar Gala wrote: > + local...@ffe05000 { > + #address-cells = <2>; > + #size-cells = <1>; > + compatible = "fsl,elbc", "simple-bus"; If this has an elbc more recent than 1.0 (looks like it), we should indicate that

Re: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc

2009-04-22 Thread michael
Hi, Stefan Roscher wrote: On Wednesday 22 April 2009 04:10:18 pm michael wrote: Hi, I don't take the point, if it is not import use the vmalloc. Why you try with a kmalloc alloc first? and why do not use kzalloc? Because kmalloc() is faster than vmalloc() causing a huge p

[PATCH][BUILD FAILURE 03/12] Re: Next April 21 : PPC64 randconfig [arch/powerpc/kernel/of_platform.o]

2009-04-22 Thread Subrata Modak
On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: > Reported this earlier on 14th April 2009: > http://lkml.org/lkml/2009/4/14/480, > > Michael, > > Any fix in sight ? > http://lkml.org/lkml/2009/4/14/676, > > CC arch/powerpc/kernel/of_platform.o > arch/powerpc/kernel/of_platform.c: I

Re: [BUILD FAILURE 02/12] Next April 21 : PPC64 randconfig [drivers/net/ni65.c]

2009-04-22 Thread Subrata Modak
On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: > I am observing this for the first time: > > CC drivers/net/ni65.o > drivers/net/ni65.c: In function ‘ni65_init_lance’: > drivers/net/ni65.c:585: error: implicit declaration of function > ‘isa_virt_to_bus’ > drivers/net/ni65.c: In func

Re: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc

2009-04-22 Thread michael
Hi, Stefan Roscher wrote: In case of large queue pairs there is the possibillity of allocation failures due to memory fragmentationo with kmalloc().To ensure the memory is allocated even if kmalloc() can not find chunks which are big enough, we try to allocate the memory with vmalloc(). Signe

Re: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc

2009-04-22 Thread Stefan Roscher
On Wednesday 22 April 2009 04:10:18 pm michael wrote: > Hi, > > I don't take the point, if it is not import use the vmalloc. Why you try > with a kmalloc > alloc first? and why do not use kzalloc? Because kmalloc() is faster than vmalloc() causing a huge performance win when someone allocates a

Re: [MTD] ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Ricardo Ribalda Delgado
Hello You are right, remove the -1. I thought that strlen gives the #of chars + 1 ('\0'). Thanks On Wed, Apr 22, 2009 at 11:24, Peter Korsgaard wrote: >> "Ricardo" == Ricardo Ribalda Delgado writes: > > Hi, > >  Ricardo> Sometimes, an special partition is included in the device >  Ric

ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Ricardo Ribalda Delgado
Sometimes, an special partition is included in the device tree including all the partitions. Like in: partit...@ff00 { reg = < 0x00 0x80 >; label = "Root File System"; }; partit...@ff80 { reg = < 0x80 0x1a >; label = "Bitstream"; }; ... partition

Re: [BUILD FAILURE 09/12] Next April 21 : PPC64 randconfig [drivers/staging/comedi/drivers.o]

2009-04-22 Thread Randy Dunlap
Geert Uytterhoeven wrote: > On Wed, 22 Apr 2009, Michael Ellerman wrote: >> On Wed, 2009-04-22 at 00:23 +0530, Subrata Modak wrote: >>> Reported this error on 14th April: >>> http://lkml.org/lkml/2009/4/14/488, >>> >>> CC [M] drivers/staging/comedi/drivers.o >>> drivers/staging/comedi/drivers.c:

Re: FPGA IRQ design question

2009-04-22 Thread Grant Likely
On Wed, Apr 22, 2009 at 8:49 AM, Eddie Dawydiuk wrote: > Hello, > > I'm working on a board based on the Yosemite AMCC 440EP. We have an FPGA > connected via the PCI bus, and has an IRQ line connected directly to the > 440EP. The FPGA implements two registers to indicate which core generated > the

Re: freeze when reading a PCI bridge register

2009-04-22 Thread Nicolas Lavocat
Tests done... -I use ioremap for the mapping of the memory, so it should be uncacheable -I inserted a eieio() before the read and there is no change. In addition, I use outbe_32 and inbe_32, which make a sync or isync ... And these functions are used for the serial port and perfectly work abou

FPGA IRQ design question

2009-04-22 Thread Eddie Dawydiuk
Hello, I'm working on a board based on the Yosemite AMCC 440EP. We have an FPGA connected via the PCI bus, and has an IRQ line connected directly to the 440EP. The FPGA implements two registers to indicate which core generated the interrupt. So now the question is from a design standpoint is i

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-22 Thread Takashi Iwai
At Wed, 22 Apr 2009 22:56:52 +1000, Paul Mackerras wrote: > > Jean Delvare writes: > > > > I sympathize, but throwing disruptive changes into Linus' tree when > > > we're past -rc3 is not the way to solve the problem. > > > > We're past -rc3 because people discuss instead of testing my patches.

Re: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc

2009-04-22 Thread Stefan Roscher
In case of large queue pairs there is the possibillity of allocation failures due to memory fragmentationo with kmalloc().To ensure the memory is allocated even if kmalloc() can not find chunks which are big enough, we try to allocate the memory with vmalloc(). Signed-off-by: Stefan Roscher --

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-22 Thread Paul Mackerras
Jean Delvare writes: > > I sympathize, but throwing disruptive changes into Linus' tree when > > we're past -rc3 is not the way to solve the problem. > > We're past -rc3 because people discuss instead of testing my patches. > Otherwise everything would be merged already. Well, no. The first con

Re: freeze when reading a PCI bridge register

2009-04-22 Thread Nicolas Lavocat
Thank you for your advices! I try it as soon as possible! (the board is not often available...) Nicolas Lavocat Gabriel Paubert a écrit : On Wed, Apr 22, 2009 at 10:04:29AM +0200, Nicolas Lavocat wrote: Hi everybody! I' am trying to configure a PCI bridge on a private board, with a powe

Re: [PATCH] therm_windtunnel: Convert to a new-style i2c driver

2009-04-22 Thread Jean Delvare
On Thu, 16 Apr 2009 23:01:01 +0200, Jean Delvare wrote: > The legacy i2c binding model is going away soon, so convert the ppc > therm_windtunnel driver to the new model or it will break. > > Signed-off-by: Jean Delvare > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > --- > Can someone please

Re: [PATCH] therm_adt746x: Convert to a new-style i2c driver

2009-04-22 Thread Jean Delvare
On Thu, 16 Apr 2009 22:59:27 +0200, Jean Delvare wrote: > The legacy i2c binding model is going away soon, so convert the ppc > therm_adt746x driver to the new model or it will break. > > Signed-off-by: Jean Delvare > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > --- > Can someone please te

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-22 Thread Jean Delvare
Hi Paul, On Wed, 22 Apr 2009 19:34:40 +1000, Paul Mackerras wrote: > Jean Delvare writes: > > > Not removing it now has a high risk of developers continuing to ignore > > the deprecation warnings and adding new legacy drivers, which I then > > must convert to the new model. This never ends. > >

Re: freeze when reading a PCI bridge register

2009-04-22 Thread Gabriel Paubert
On Wed, Apr 22, 2009 at 10:04:29AM +0200, Nicolas Lavocat wrote: > Hi everybody! > > I' am trying to configure a PCI bridge on a private board, with a > powerpc . In a first time, I tried to get informations about PCI > devices, in order to be sure that my read and write methods work ( > u

Re: freeze when reading a PCI bridge register

2009-04-22 Thread Nicolas Lavocat
In fact, because system froze, I wanted to know where was the problem, so, step by step, I removed operations, until try to  read this register, basic operation when a PCI device is used. This register can be read with JTAG, and under uboot, so I think that it is not a PCI problem.. Nicolas La

Re: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc

2009-04-22 Thread Stefan Roscher
Hi Roland, thanks for the quick review. I was hoping you could apply these changes for 2.6.30 because this will be the codebase for the next OFED release. The patch is well tested in HPC environment and we haven't seen any issues. Regarding Antons patch you are right. If a user allocates an unr

Re: freeze when reading a PCI bridge register

2009-04-22 Thread Nicolas Lavocat
Hum... It is a proprietary bridge... I don't know how works the marvel, but it is not like tundra (TSI108)... But  it seems that this bridge works like X86 bridges.  I 'm goigng to read documentations about Marvel bridges! Nicolas Lavocat Liu Dave-R63238 a écrit : So the host bridg

RE: freeze when reading a PCI bridge register

2009-04-22 Thread Liu Dave-R63238
So the host bridge is important, what is the bridge? Marvell or Tundra chipset? From: Nicolas Lavocat [mailto:nicolas.lavo...@fr.thalesgroup.com] Sent: Wednesday, April 22, 2009 4:32 PM To: Liu Dave-R63238 Cc: linuxppc-dev

  1   2   >