Benjamin Herrenschmidt b...@kernel.crashing.org wrote on 2010/01/14 09:57:11:
Seen it now as it is in Linus tree:
1) IMHO it would have been nicer to use #ifdef __KERNEL__
instead of CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
as then arches that don't define
This patch series adds support for the MPC512x from Freescale to the
i2c-mpc driver. At that occasion, issues with __devinit[data] have
been fixed and the doc of the FSL I2C dts bindings updated. It has
been tested on a MPC5121ADS, TQM5200 and TQM8560 board
Wolfgang
Wolfgang Grandegger (3):
From: Wolfgang Grandegger w...@denx.de
__devinit[data] has not yet been used for all initialization functions
and data. To avoid truncating lines, the struct mpc_i2c_match_data has
been renamed to mpc_i2c_data, which is even the better name.
Signed-off-by: Wolfgang Grandegger w...@denx.de
---
From: Wolfgang Grandegger w...@denx.de
The setclock initialization functions have been renamed to setup
because I2C interrupts must be enabled for the MPC512x. This requires
to handle fsl,preserve-clocking in a slighly different way. Also,
the old settings are now reported calling dev_dbg(). For
From: Wolfgang Grandegger w...@denx.de
This patch adds the MPC5121 to the list of supported devices,
enhances the doc of the clock-frequency property and removes
the obsolete cell-index property from the example nodes.
Signed-off-by: Wolfgang Grandegger w...@denx.de
---
2010/1/25 Chris Simmonds ch...@2net.co.uk:
Johnny Hung wrote:
2010/1/22 Marco Stornelli marco.storne...@gmail.com:
2010/1/22 Johnny Hung johnny.hack...@gmail.com:
2010/1/20 Marco Stornelli marco.storne...@gmail.com:
2010/1/20 Johnny Hung johnny.hack...@gmail.com:
2010/1/19 Matthias
Johnny Hung wrote:
2010/1/22 Marco Stornelli marco.storne...@gmail.com:
2010/1/22 Johnny Hung johnny.hack...@gmail.com:
2010/1/20 Marco Stornelli marco.storne...@gmail.com:
2010/1/20 Johnny Hung johnny.hack...@gmail.com:
2010/1/19 Matthias Kaehlcke matth...@kaehlcke.net:
El Tue, Jan 19,
Hi Wolfgang,
On Mon, Jan 25, 2010 at 09:27:08AM +0100, Wolfgang Grandegger wrote:
From: Wolfgang Grandegger w...@denx.de
The setclock initialization functions have been renamed to setup
because I2C interrupts must be enabled for the MPC512x. This requires
to handle fsl,preserve-clocking in
On Mon, Jan 25, 2010 at 09:27:09AM +0100, Wolfgang Grandegger wrote:
From: Wolfgang Grandegger w...@denx.de
This patch adds the MPC5121 to the list of supported devices,
enhances the doc of the clock-frequency property and removes
the obsolete cell-index property from the example nodes.
I
Wolfram Sang wrote:
On Mon, Jan 25, 2010 at 09:27:09AM +0100, Wolfgang Grandegger wrote:
From: Wolfgang Grandegger w...@denx.de
This patch adds the MPC5121 to the list of supported devices,
enhances the doc of the clock-frequency property and removes
the obsolete cell-index property from the
On Mon, Jan 25, 2010 at 09:27:06AM +0100, Wolfgang Grandegger wrote:
This patch series adds support for the MPC512x from Freescale to the
i2c-mpc driver. At that occasion, issues with __devinit[data] have
been fixed and the doc of the FSL I2C dts bindings updated. It has
been tested on a
Hi Wolfram,
Wolfram Sang wrote:
Hi Wolfgang,
On Mon, Jan 25, 2010 at 09:27:08AM +0100, Wolfgang Grandegger wrote:
From: Wolfgang Grandegger w...@denx.de
The setclock initialization functions have been renamed to setup
because I2C interrupts must be enabled for the MPC512x. This requires
Hello,
I found that qlge is broken on PPC, and it got broken after commit
06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev-pcie
is not set on PPC, because the function set_pcie_port_type(), who sets
dev-pcie, is not being called on PPC PCI code.
So, I have two ideas to fix it,
-static void __devinit mpc_i2c_setclock_52xx(struct device_node *node,
- struct mpc_i2c *i2c,
- u32 clock, u32 prescaler)
+static void __devinit mpc_i2c_setup_52xx(struct device_node *node,
+
Hi Wolfram,
Wolfram Sang w.s...@pengutronix.de wrote:
Please include a logfile with changes since the last version. This really
helps.
Ok.
+static int __init mpc5121_nfc_probe(struct of_device *op,
+ const struct of_device_id *match)
[...]
+{
+
On Jan 22, 2010, at 12:27 AM, Aaron Pace wrote:
Its possible that we've broken module/vmalloc support with
Large physical addressing.? Its not something I've
tried in a while.? What kernel/git SHA are you using.
I'm just pulling in from the main kernel tree git.
My current version is
On Jan 21, 2010, at 4:28 PM, Peter Tyser wrote:
On Fri, 2009-12-18 at 16:50 -0600, Peter Tyser wrote:
Recent U-Boot commit 5ccd29c3679b3669b0bde5c501c1aa0f325a7acb caused
the cpu-release-addr device tree property to contain the physical RAM
location that secondary cores were spinning at.
On Dec 15, 2009, at 4:58 PM, Anton Vorontsov wrote:
MPC85xx chips report the wrong value in feature reporting register,
and that causes the following oops:
Unable to handle kernel paging request for data at address 0x0c00
Faulting instruction address: 0xc0019294
Oops: Kernel access of
On Dec 18, 2009, at 4:50 PM, Peter Tyser wrote:
Recent U-Boot commit 5ccd29c3679b3669b0bde5c501c1aa0f325a7acb caused
the cpu-release-addr device tree property to contain the physical RAM
location that secondary cores were spinning at. Previously, the
cpu-release-addr property contained a
On Thu, 21 Jan 2010 10:43:34 -0700
Grant Likely grant.lik...@secretlab.ca wrote:
diff --git a/Documentation/powerpc/dts-bindings/fsl/usb.txt
b/Documentation/powerpc/dts-bindings/fsl/usb.txt
index b001524..9050154 100644
--- a/Documentation/powerpc/dts-bindings/fsl/usb.txt
+++
Is a simple hello world module sufficient to show the issue? I'll look
into it this week.
- k
It wasn't in my situation, unfortunately. To duplicate this, I had
one relatively large kernel module, and then one simple 'hello world'
module that did nothing more than call an exported
On Thu, 2009-11-19 at 18:42 -0600, Peter Tyser wrote:
Some unused, unsupported debug code existed in the mpc85xx EDAC driver
that resulted in a build failure when CONFIG_EDAC_DEBUG was defined:
drivers/edac/mpc85xx_edac.c: In function 'mpc85xx_mc_err_probe':
On Jan 25, 2010, at 11:06 AM, Aaron Pace wrote:
Is a simple hello world module sufficient to show the issue? I'll look
into it this week.
- k
It wasn't in my situation, unfortunately. To duplicate this, I had
one relatively large kernel module, and then one simple 'hello world'
Benjamin Herrenschmidt wrote:
On Wed, 2010-01-20 at 16:09 -0600, Joel Schopp wrote:
I can turn that into a conditional branch (case statement) with a shift
for the common 1,2,4 cases which should cover all procs available today
falling back to a divide for any theoretical future processors
Hi all,
Currently it's a burden to make I2C or SPI GPIO chips work with the
OF GPIO infrastructure. I've posted several approaches to solve the
issue before, and others have tried too. Here is another try.
This patch set is used to make things much easier, and completely
seamless for GPIO chips
Some platforms (e.g. OpenFirmware) want to know when a particular chip
added or removed, so that the platforms could add their specifics for
non-platform devices, like I2C or SPI GPIO chips.
This patch implements the notifier for chip addition and removal events.
Signed-off-by: Anton Vorontsov
With this patch there are two ways to register OF GPIO controllers:
1. Allocating the of_gpio_chip structure and passing the
of_gc-gc pointer to the gpiochip_add. (Can use container_of
to convert the gpio_chip to the of_gpio_chip.)
2. Allocating and registering the gpio_chip structure
This patch implements GPIOLIB notifier hooks, and thus makes device-enabled
GPIO chips (i.e. the ones that have gpio_chip-dev specified) automatically
attached to the OpenFirmware subsystem. Which means that now we can handle
I2C and SPI GPIO chips almost* transparently.
* Almost because some
With the new OF GPIO infrastructure it's much easier to handle I2C
GPIO controllers, i.e. now drivers don't have to deal with the
OF-specific bits.
Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com
---
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 68 +---
1 files
Wolfram Sang wrote:
-static void __devinit mpc_i2c_setclock_52xx(struct device_node *node,
- struct mpc_i2c *i2c,
- u32 clock, u32 prescaler)
+static void __devinit mpc_i2c_setup_52xx(struct device_node *node,
+
Thanks for the information.
Based on your input, I could successfully update the dts file and gpio
controller configuration. I verified from the GPIO chip intialized and added
properly. But, still Iam getting the message as
No NAND device found!!!.
In our system we have two flash NOR
As stated in spi.h (at struct spi_transfer) the driver can keep the chip
select of the last device active if cs_change is set at the last transfer of a
message.
The spi_mpc8xxx driver always deactivates the chip select after completing the
message regardless of cs_change is set or not.
I'd
Am 25.01.10 05:06 schrieb(en) Ben Dooks:
On Fri, Jan 22, 2010 at 09:17:55PM +0100, Albrecht Dreß wrote:
Improve the recovery of the MPC5200B's I2C bus from errors like bus hangs.
This is very sparse comapred to the large comment below the --- line, maybe
some more description should be
Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger:
Albrecht Dreß wrote:
Make the I2C adapter timeout configurable through a Device Tree property which
gives the timeout in microseconds.
My understanding is that software properties should not be defined via the
device tree. I think a sysfs
On Mon, 25 Jan 2010 11:42:29 -0200
Breno Leitao lei...@linux.vnet.ibm.com wrote:
Hello,
I found that qlge is broken on PPC, and it got broken after commit
06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because
dev-pcie is not set on PPC, because the function
set_pcie_port_type(),
overkill to me. I will have a closer look, though. At a minimum I will
replace -1 with MPC_I2C_PRESERVE_CLOCK.
Might be also an idea to define it with ~0 (clock is still unsigned). If
possible, the code checking for those two cases (0 and -1) should be close
together. That could be a compromise
From: Wolfgang Grandegger w...@denx.de
This patch series adds support for the MPC512x from Freescale to the
i2c-mpc driver. At that occasion, issues with __devinit[data] have
been fixed and the doc of the FSL I2C dts bindings updated. It has
been tested on a MPC5121ADS, TQM5200 and TQM8560 board
From: Wolfgang Grandegger w...@denx.de
This patch adds the MPC5121 to the list of supported devices,
enhances the doc of the clock-frequency property and removes
the obsolete cell-index property from the example nodes.
Furthermore and example for the MPC5121 has been added.
Signed-off-by:
From: Wolfgang Grandegger w...@denx.de
__devinit[data] has not yet been used for all initialization functions
and data. To avoid truncating lines, the struct mpc_i2c_match_data has
been renamed to mpc_i2c_data, which is even the better name.
Signed-off-by: Wolfgang Grandegger w...@denx.de
---
From: Wolfgang Grandegger w...@denx.de
The setclock initialization functions have been renamed to setup
because I2C interrupts must be enabled for the MPC512x. This requires
to handle fsl,preserve-clocking in a slighly different way. Also,
the old settings are now reported calling dev_dbg(). For
Wolfram Sang wrote:
overkill to me. I will have a closer look, though. At a minimum I will
replace -1 with MPC_I2C_PRESERVE_CLOCK.
Might be also an idea to define it with ~0 (clock is still unsigned). If
possible, the code checking for those two cases (0 and -1) should be close
together.
I just sent v2. Hope it's OK now.
Thanks, will check tomorrow.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Mon, 25 Jan 2010 12:38:49 -0800
Jesse Barnes jbar...@virtuousgeek.org wrote:
On Mon, 25 Jan 2010 11:42:29 -0200
Breno Leitao lei...@linux.vnet.ibm.com wrote:
Hello,
I found that qlge is broken on PPC, and it got broken after commit
06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It
On Mon, 2010-01-25 at 17:50 -0800, Jesse Barnes wrote:
You mean dev-is_pcie?
Why isn't pci_scan_device calling pci_setup_device for you? That
should do the proper PCIe init depending on the device, along with
extracting other device info...
Cc'ing Ben for PPC. Ben, should PPC use
On Mon, 2010-01-25 at 11:50 -0600, Joel Schopp wrote:
Look at the cputhreads.h implementation ... Today we only support
power-of-two numbers of threads.
I've run 3 threads using cpu hotplug to offline 1 of the 4. It's
certainly a stupid idea, but there you go.
Oh, you mean you need
On Monday 25 January 2010, Anton Vorontsov wrote:
With this patch there are two ways to register OF GPIO controllers:
1. Allocating the of_gpio_chip structure and passing the
of_gc-gc pointer to the gpiochip_add. (Can use container_of
to convert the gpio_chip to the of_gpio_chip.)
On Monday 25 January 2010, Anton Vorontsov wrote:
+config GPIOLIB_NOTIFIER
+ bool
+ help
+ This symbol is selected by subsystems that need to handle GPIO
+ chips addition and removal. E.g., this is used for the
+ OpenFirmware bindings.
+
I'm no huge
On Monday 25 January 2010, Anton Vorontsov wrote:
With the new OF GPIO infrastructure it's much easier to handle I2C
GPIO controllers, i.e. now drivers don't have to deal with the
OF-specific bits.
Good, that's how it should have been done in the first place. :)
Of course, there's still the
Albrecht Dreß wrote:
Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger:
Albrecht Dreß wrote:
Make the I2C adapter timeout configurable through a Device Tree
property which gives the timeout in microseconds.
My understanding is that software properties should not be defined via
the device
On Wed, 20 Jan 2010 12:28:43 +0100
Wolfram Sang w.s...@pengutronix.de wrote:
+static void __iomem *reset_module_base;
type here also?
Ok.
+
+static int __init mpc512x_restart_init(void)
+{
+ struct device_node *np;
+
+ np = of_find_compatible_node(NULL, NULL,
Breno Leitao wrote:
Hello,
I found that qlge is broken on PPC, and it got broken after commit
06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev-pcie
is not set on PPC, because the function set_pcie_port_type(), who sets
dev-pcie, is not being called on PPC PCI code.
Hi
Jesse Barnes wrote:
On Mon, 25 Jan 2010 12:38:49 -0800
Jesse Barnes jbar...@virtuousgeek.org wrote:
On Mon, 25 Jan 2010 11:42:29 -0200
Breno Leitao lei...@linux.vnet.ibm.com wrote:
Hello,
I found that qlge is broken on PPC, and it got broken after commit
52 matches
Mail list logo
