Re: [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag

2010-02-07 Thread Albert Herranz
Alan Stern wrote: On a 64-bit processor, some of the accesses will be 64 bits wide instead of 32. Does that matter for your purposes? The wii uses a 32-bit processor, so this is safe in this case. What about ohci-hcd and uhci-hcd? They both use non-32-bit accesses to structures in coherent

Re: [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag

2010-02-07 Thread Alan Stern
On Sun, 7 Feb 2010, Albert Herranz wrote: The wii has no uhci, but has 2 ohci controllers. For ohci we need a similar approach as done for ehci. So you'll need to write a patch splitting up the OHCI data structures in the same way the EHCI qh was split up. If you do it as described above

powerpc: Reduce differences between pseries and ppc64 defconfigs

2010-02-07 Thread Anton Blanchard
The pseries and ppc64 defconfigs have drifted apart over the years. Reduce some of the differences while still keeping the idea that the ppc64 defconfig is cross platform but enables fewer features than pseries, eg NR_CPUS is lower. Also enable a number of common adapters as modules.

[PATCH] powerpc: Convert mmu context allocator from idr to ida

2010-02-07 Thread Anton Blanchard
We can use the much more lightweight ida allocator since we don't need the pointer storage idr provides. Signed-off-by: Anton Blanchard an...@samba.org --- Index: powerpc.git/arch/powerpc/mm/mmu_context_hash64.c === ---

[PATCH] powerpc: Only print clockevent settings once

2010-02-07 Thread Anton Blanchard
The clockevent multiplier and shift is useful information, but we only need to print it once. Signed-off-by: Anton Blanchard an...@samba.org --- Index: powerpc.git/arch/powerpc/kernel/time.c === ---

powerpc: Make powerpc_firmware_features __read_mostly

2010-02-07 Thread Anton Blanchard
We use firmware_has_feature quite a lot these days, so it's worth putting powerpc_firmware_features into __read_mostly. Signed-off-by: Anton Blanchard an...@samba.org --- Index: powerpc.git/arch/powerpc/kernel/firmware.c === ---

[PATCH] powerpc: reformat SD_NODE_INIT to match x86

2010-02-07 Thread Anton Blanchard
Clean up SD_NODE_INITS so we can easily compare it to x86. Similar to the work in 47734f89be0614b5acbd6a532390f9c72f019648 (sched: Clean up topology.h) Signed-off-by: Anton Blanchard an...@samba.org --- Index: linux.trees.git/arch/powerpc/include/asm/topology.h

Re: [RFC PATCH 1/2] USB: add HCD_BOUNCE_BUFFERS host controller driver flag

2010-02-07 Thread Albert Herranz
Alan Stern wrote: On Sun, 7 Feb 2010, Albert Herranz wrote: The wii has no uhci, but has 2 ohci controllers. For ohci we need a similar approach as done for ehci. So you'll need to write a patch splitting up the OHCI data structures in the same way the EHCI qh was split up. Yes. It

[PATCH] powerpc: Quieten cede latency printk

2010-02-07 Thread Anton Blanchard
The cede latency stuff is relatively new and we don't need to complain about it not working on older firmware. Signed-off-by: Anton Blanchard an...@samba.org --- Index: powerpc.git/arch/powerpc/platforms/pseries/hotplug-cpu.c ===

[PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread Michael Neuling
apkm, linus: this or something like it needs to go into 2.6.33 ( 32) to fix 'ulimit -s'. Mikey [PATCH] Restrict stack space reservation to rlimit When reserving stack space for a new process, make sure we're not attempting to allocate more than rlimit allows. Also, reserve the same stack

Re: Stack size protection broken on ppc64

2010-02-07 Thread Anton Blanchard
Hi, Cool, thanks. The following is based on this and fixes the problem for me on PPC64 ie. the !CONFIG_STACK_GROWSUP case. Thanks! Seeing the original setting of EXTRA_STACK_VM_PAGES is more or less random, I wonder if we should round EXTRA_STACK_VM_SIZE up to 128kB (or even down to 64kB)

[PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread Michael Neuling
When reserving stack space for a new process, make sure we're not attempting to allocate more than rlimit allows. Also, reserve the same stack size independent of page size. This fixes a bug cause by b6a2fea39318e43fee84fa7b0b90d68bed92d2ba mm: variable length argument support and unmasked by

[PATCH] powerpc: Add last sysfs file and dump of ftrace buffer to oops printout

2010-02-07 Thread Anton Blanchard
Add printout of last accessed sysfs file, added to x86 in ae87221d3ce49d9de1e43756da834fd0bf05a2ad (sysfs: crash debugging) Also add the notify_die hook that allows us to print out the ftrace buffer on oops. This is useful in conjunction with ftrace function_graph: Oops: Kernel access of bad

powerpc/pseries: Fix kexec regression caused by CPPR tracking

2010-02-07 Thread Mark Nelson
The code to track the CPPR values added by commit 49bd3647134ea47420067aea8d1401e722bf2aac (powerpc/pseries: Track previous CPPR values to correctly EOI interrupts) broke kexec on pseries because the kexec code in xics.c calls xics_set_cpu_priority() before the IPI has been EOI'ed. This wasn't a

Re: [PATCH 01/10] arch/powerpc: Fix continuation line formats

2010-02-07 Thread Benjamin Herrenschmidt
On Mon, 2010-02-01 at 10:30 -0800, Joe Perches wrote: On Mon, 2010-02-01 at 13:16 +1100, Benjamin Herrenschmidt wrote: On Sun, 2010-01-31 at 12:02 -0800, Joe Perches wrote: String constants that are continued on subsequent lines with \ are not good. Signed-off-by: Joe Perches

Re: [PATCH] powerpc: fix ioremap_flags() with book3e pte definition

2010-02-07 Thread Benjamin Herrenschmidt
On Fri, 2010-02-05 at 00:53 +0800, Li Yang wrote: We can't just clear the user read permission in book3e pte, because that will also clear supervisor read permission. This surely isn't desired. Fix the problem by adding the supervisor read back. Signed-off-by: Li Yang le...@freescale.com

Re: [PATCH] powerpc: Only print clockevent settings once

2010-02-07 Thread Wolfram Sang
On Mon, Feb 08, 2010 at 09:28:01AM +1100, Anton Blanchard wrote: The clockevent multiplier and shift is useful information, but we only need to print it once. Signed-off-by: Anton Blanchard an...@samba.org --- Index: powerpc.git/arch/powerpc/kernel/time.c

Re: [PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread Anton Blanchard
Hi, Why do we need page size independent stack size? It seems to have compatibility breaking risk. I don't think so. The current behaviour is clearly wrong, we dont need a 16x larger stack just because you went from a 4kB to a 64kB base page size. The user application stack usage is the same

Re: [PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread KOSAKI Motohiro
Hi, Why do we need page size independent stack size? It seems to have compatibility breaking risk. I don't think so. The current behaviour is clearly wrong, we dont need a 16x larger stack just because you went from a 4kB to a 64kB base page size. The user application stack usage is

Re: [PATCH] powerpc: Only print clockevent settings once

2010-02-07 Thread Anton Blanchard
Hi Wolfram, What about printk_once from kernel.h? Thanks for the suggestion! Anton -- The clockevent multiplier and shift is useful information, but we only need to print it once. Signed-off-by: Anton Blanchard an...@samba.org --- Index: powerpc.git/arch/powerpc/kernel/time.c

Re: [PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread Anton Blanchard
Hi, I didn't discuss which behavior is better. Michael said he want to apply his patch to 2.6.32 2.6.33. stable tree never accept the breaking compatibility patch. Your answer doesn't explain why can't we wait it until next merge window. btw, personally, I like page size indepent

Re: [PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread KOSAKI Motohiro
Hi apkm, linus: this or something like it needs to go into 2.6.33 ( 32) to fix 'ulimit -s'. fix ulimit -s is too cool explanation ;-) we are not ESPer. please consider to provide what bug is exist. Mikey [PATCH] Restrict stack space reservation to rlimit When reserving stack space

[PATCH] Clear MSR_RI during RTAS calls

2010-02-07 Thread Anton Blanchard
RTAS should never cause an exception but if it does (for example accessing outside our RMO) then we might go a long way through the kernel before oopsing. If we unset MSR_RI we should at least stop things on exception exit. Signed-off-by: Anton Blanchard an...@samba.org --- The setting of

[PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread Michael Neuling
Hi, Why do we need page size independent stack size? It seems to have compatibility breaking risk. I don't think so. The current behaviour is clearly wrong, we dont need a 16x larger stack just because you went from a 4kB to a 64kB base page size. The user application stack

Re: [PATCH] Clear MSR_RI during RTAS calls

2010-02-07 Thread Anton Blanchard
The setting of MSR_RI during RTAS calls went in ages ago (2003), and I'm not sure why. Clearly an exception inside RTAS is fatal since we most likely have a bad r13. I wrote the r13 comment without thinking :) Regardless I think we want to catch any RTAS exception ASAP. Anton

Re: [PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread KOSAKI Motohiro
Hi, Why do we need page size independent stack size? It seems to have compatibility breaking risk. I don't think so. The current behaviour is clearly wrong, we dont need a 16x larger stack just because you went from a 4kB to a 64kB base page size. The user

Re: [PATCH] Restrict stack space reservation to rlimit

2010-02-07 Thread KOSAKI Motohiro
Hi, I didn't discuss which behavior is better. Michael said he want to apply his patch to 2.6.32 2.6.33. stable tree never accept the breaking compatibility patch. Your answer doesn't explain why can't we wait it until next merge window. btw, personally, I like page size

[git pull] Please pull powerpc.git merge branch

2010-02-07 Thread Benjamin Herrenschmidt
Hi Linus ! Here's a small regression fix that should still make it into .33 Cheers, Ben. The following changes since commit 6339204ecc2aa2067a99595522de0403f0854bb8: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kernel.org/.../viro/vfs-2.6 are available in the git